[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
tianxiaoliang commented on a change in pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#discussion_r444677764 ## File path: server/service/rbac/rbac.go ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [servicecomb-pack] zhfeng commented on issue #669: 怎么设置跑出异常的分支事务不补偿通通过本地事务回滚?

2020-06-23 Thread GitBox
zhfeng commented on issue #669: URL: https://github.com/apache/servicecomb-pack/issues/669#issuecomment-648607422 能提供一个完整的例子吗?b服务的本地事务rollback后,omega应该发出TxAbortedEvent。alpha server收到这个消息后,应该是触发补偿操作,发送TxCompensatedEvent给需要做补偿的服务,按说b服务是不会收到这个消息的啊? --

[GitHub] [servicecomb-java-chassis] jiangqiushi closed issue #1808: servicecomb集群场景,新服务上线瞬间,集群处理能力显著下降

2020-06-23 Thread GitBox
jiangqiushi closed issue #1808: URL: https://github.com/apache/servicecomb-java-chassis/issues/1808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [servicecomb-pack] cmonkey commented on issue #669: 怎么设置跑出异常的分支事务不补偿通通过本地事务回滚?

2020-06-23 Thread GitBox
cmonkey commented on issue #669: URL: https://github.com/apache/servicecomb-pack/issues/669#issuecomment-648561176 > b方法不跑出异常,a拿到b的结果是失败的要回滚a的本地事务跑出异常回滚a本地事务,结果还是会走b的补偿方法,但b方法实际上已经是失败的,不需要回滚的,还是会走了一次补偿 明白你意思了,需要你在b 这个服务的补偿里面做一次校验, 看看传递的globalTxId 是否需要补偿 ---

[GitHub] [servicecomb-pack] ywdkfz commented on issue #669: 怎么设置跑出异常的分支事务不补偿通通过本地事务回滚?

2020-06-23 Thread GitBox
ywdkfz commented on issue #669: URL: https://github.com/apache/servicecomb-pack/issues/669#issuecomment-648560273 b方法不跑出异常,a拿到b的结果是失败的要回滚a的本地事务跑出异常回滚a本地事务,结果还是会走b的补偿方法,但b方法实际上已经是失败的,不需要回滚的,还是会走了一次补偿 This is an automated mes

[GitHub] [servicecomb-pack] cmonkey commented on issue #669: 怎么设置跑出异常的分支事务不补偿通通过本地事务回滚?

2020-06-23 Thread GitBox
cmonkey commented on issue #669: URL: https://github.com/apache/servicecomb-pack/issues/669#issuecomment-648559018 > b方法的补偿方法不需要被调用,实际上调用了,怎么可以让b的补偿方法不调用呢 b方法不抛出异常就可以 This is an automated message from the Apache Git S

[GitHub] [servicecomb-java-chassis] jiangqiushi commented on issue #1855: [Bug Report]vert.x-worker-thread处理PipedInputStream发生死锁

2020-06-23 Thread GitBox
jiangqiushi commented on issue #1855: URL: https://github.com/apache/servicecomb-java-chassis/issues/1855#issuecomment-648558398 通过线程堆栈发现,PipedInputStream发生了死锁。 1)所有的业务线程(tts-threadpool-1-thread-xx)都阻塞在write上。 2)所有的vert.x-worker-thread都阻塞在read上。 3)通过连续堆栈,间隔5秒,一个奇怪的现象,包装PipedInputS

[GitHub] [servicecomb-java-chassis] jiangqiushi commented on issue #1855: [Bug Report]vert.x-worker-thread处理PipedInputStream发生死锁

2020-06-23 Thread GitBox
jiangqiushi commented on issue #1855: URL: https://github.com/apache/servicecomb-java-chassis/issues/1855#issuecomment-648558290 **线程堆栈** ```xml 2020-06-24 10:18:59 Full thread dump Java HotSpot(TM) 64-Bit Server VM (25.191-b12 mixed mode): "Attach Listener" #175 daemon

[GitHub] [servicecomb-java-chassis] jiangqiushi opened a new issue #1855: [Bug Report]vert.x-worker-thread处理PipedInputStream发生死锁

2020-06-23 Thread GitBox
jiangqiushi opened a new issue #1855: URL: https://github.com/apache/servicecomb-java-chassis/issues/1855 **版本:** 1.2.0.B006 **背景:** 服务端需要流式返回语音数据,代码如下 ```java // 服务端入口 public ResponseEntity doServerLogic(...) { PipedOutputStream out = new PipedOutputStream(

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1497: 业务如果想在发生熔断的时候,在业务日志打个error日志,这个怎么做呢?

2020-06-23 Thread GitBox
liubao68 commented on issue #1497: URL: https://github.com/apache/servicecomb-java-chassis/issues/1497#issuecomment-648528120 > 没有触发熔断有两种情况: > > 1. 没有达到触发熔断的条件。 > 2. 没有注册成功。我遇到的情况是,使用Subscribe注解时,底层是通过反射获取配置了这个注解的方法。在对比注解类是否相等时,由于类加载器不同,导致无法获取到配置了注解的方法。导致没有注册成功。 class load

[GitHub] [servicecomb-pack] ywdkfz commented on issue #669: 怎么设置跑出异常的分支事务不补偿通通过本地事务回滚?

2020-06-23 Thread GitBox
ywdkfz commented on issue #669: URL: https://github.com/apache/servicecomb-pack/issues/669#issuecomment-648526752 b方法的补偿方法不需要被调用,实际上调用了,怎么可以让b的补偿方法不调用呢 This is an automated message from the Apache Git Service. To respond to

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1854: [SCB-2024]support not resolve place holder when running in spring boot

2020-06-23 Thread GitBox
liubao68 merged pull request #1854: URL: https://github.com/apache/servicecomb-java-chassis/pull/1854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[servicecomb-java-chassis] branch master updated: [SCB-2024]support not resolve place holder when running in spring boot

2020-06-23 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git The following commit(s) were added to refs/heads/master by this push: new e622d17 [SCB-2024]support not

[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1133: IllegalArgumentException at ConfigurationSpringInitializer#getProperties

2020-06-23 Thread GitBox
liubao68 closed issue #1133: URL: https://github.com/apache/servicecomb-java-chassis/issues/1133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1133: IllegalArgumentException at ConfigurationSpringInitializer#getProperties

2020-06-23 Thread GitBox
liubao68 edited a comment on issue #1133: URL: https://github.com/apache/servicecomb-java-chassis/issues/1133#issuecomment-648522209 I created a PR to fix this: https://github.com/apache/servicecomb-java-chassis/pull/1854/files Users can add a configuration in `microservice.yaml`

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1133: IllegalArgumentException at ConfigurationSpringInitializer#getProperties

2020-06-23 Thread GitBox
liubao68 commented on issue #1133: URL: https://github.com/apache/servicecomb-java-chassis/issues/1133#issuecomment-648522209 I created a PR to fix this: https://github.com/apache/servicecomb-java-chassis/pull/1854/files Users can add a configuration in `microservice.yaml` ``

[GitHub] [servicecomb-service-center] aseTo2016 commented on a change in pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
aseTo2016 commented on a change in pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#discussion_r444214464 ## File path: server/service/kv/store.go ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [servicecomb-pack] WillemJiang commented on issue #669: 怎么设置跑出异常的分支事务不补偿通通过本地事务回滚?

2020-06-23 Thread GitBox
WillemJiang commented on issue #669: URL: https://github.com/apache/servicecomb-pack/issues/669#issuecomment-648483694 使用spring transaction提供的 @transactional 来进行设置。 This is an automated message from the Apache Git Service. T

[servicecomb-pack] branch master updated (b476b8b -> fd07b17)

2020-06-23 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git. from b476b8b Merge pull request #661 from apache/SCB-1928 new c2d52e9 SCB-2004 In Omega, if CallbackCo

[servicecomb-pack] 02/04: SCB-2004 Use message-driven compensation retry instead of recursive compensation

2020-06-23 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git commit 8e0afb719be61701f358a31bd841a5a1e4c09da6 Author: Lei Zhang AuthorDate: Mon Jun 22 23:55:21 2020 +0800

[servicecomb-pack] 03/04: SCB-2004 Fix await for Travis CI

2020-06-23 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git commit 41b27fa6a5baded07c6d437fa59da95dfb4902b5 Author: Lei Zhang AuthorDate: Tue Jun 23 12:04:48 2020 +0800

[servicecomb-pack] 01/04: SCB-2004 In Omega, if CallbackContenxt does not contain callbackMethod, send TxCompensateAckFailedEvent to Alpha instead of throwing NPE

2020-06-23 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git commit c2d52e9c3cd2203e193bb5154d637fc6f7cb5203 Author: Lei Zhang AuthorDate: Mon Jun 22 19:35:54 2020 +0800

[servicecomb-pack] 04/04: SCB-2004 Rename preState to preComponsitedState

2020-06-23 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git commit fd07b173b934947516096aaa2be7a441368c7b3f Author: Lei Zhang AuthorDate: Wed Jun 24 02:53:32 2020 +0800

[GitHub] [servicecomb-pack] WillemJiang merged pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

2020-06-23 Thread GitBox
WillemJiang merged pull request #667: URL: https://github.com/apache/servicecomb-pack/pull/667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

2020-06-23 Thread GitBox
coveralls edited a comment on pull request #667: URL: https://github.com/apache/servicecomb-pack/pull/667#issuecomment-647654794 [![Coverage Status](https://coveralls.io/builds/31640580/badge)](https://coveralls.io/builds/31640580) Coverage increased (+0.03%) to 80.698% when pull

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

2020-06-23 Thread GitBox
coolbeevip commented on a change in pull request #667: URL: https://github.com/apache/servicecomb-pack/pull/667#discussion_r40343 ## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/fsm/event/internal/ComponsitedCheckEvent.java ## @@ -17,10

[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1854: [SCB-2024]support not resolve place holder when running in spring boot

2020-06-23 Thread GitBox
coveralls commented on pull request #1854: URL: https://github.com/apache/servicecomb-java-chassis/pull/1854#issuecomment-648154159 [![Coverage Status](https://coveralls.io/builds/31632055/badge)](https://coveralls.io/builds/31632055) Coverage increased (+0.01%) to 86.313% when

[GitHub] [servicecomb-service-center] coveralls edited a comment on pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
coveralls edited a comment on pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#issuecomment-647985232 [![Coverage Status](https://coveralls.io/builds/31631622/badge)](https://coveralls.io/builds/31631622) Coverage decreased (-0.03%) to 61.12%

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1854: [SCB-2024]support not resolve place holder when running in spring boot

2020-06-23 Thread GitBox
liubao68 opened a new pull request #1854: URL: https://github.com/apache/servicecomb-java-chassis/pull/1854 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed fo

[servicecomb-service-center] branch master updated: use sphinx to manage docs (#651)

2020-06-23 Thread tianxiaoliang
This is an automated email from the ASF dual-hosted git repository. tianxiaoliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-service-center.git The following commit(s) were added to refs/heads/master by this push: new 78325fb use sphinx t

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #651: [SCB-2022] Migrate service-center documents to sphinx

2020-06-23 Thread GitBox
tianxiaoliang merged pull request #651: URL: https://github.com/apache/servicecomb-service-center/pull/651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #651: [SCB-2022] Migrate service-center documents to sphinx

2020-06-23 Thread GitBox
tianxiaoliang commented on pull request #651: URL: https://github.com/apache/servicecomb-service-center/pull/651#issuecomment-648114036 基础设施我已经提单了,会有人和RTD网站集成 This is an automated message from the Apache Git Service. To resp

[GitHub] [servicecomb-service-center] coveralls edited a comment on pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
coveralls edited a comment on pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#issuecomment-647985232 [![Coverage Status](https://coveralls.io/builds/31630320/badge)](https://coveralls.io/builds/31630320) Coverage increased (+0.008%) to 61.17

[GitHub] [servicecomb-service-center] coveralls commented on pull request #651: [SCB-2022] Migrate service-center documents to sphinx

2020-06-23 Thread GitBox
coveralls commented on pull request #651: URL: https://github.com/apache/servicecomb-service-center/pull/651#issuecomment-648054401 [![Coverage Status](https://coveralls.io/builds/31628198/badge)](https://coveralls.io/builds/31628198) Coverage increased (+0.06%) to 61.222% when

[GitHub] [servicecomb-service-center] hityc2019 opened a new pull request #651: [SCB-2022] Migrate service-center documents to sphinx

2020-06-23 Thread GitBox
hityc2019 opened a new pull request #651: URL: https://github.com/apache/servicecomb-service-center/pull/651 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed f

[GitHub] [servicecomb-service-center] coveralls edited a comment on pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
coveralls edited a comment on pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#issuecomment-647985232 [![Coverage Status](https://coveralls.io/builds/31627053/badge)](https://coveralls.io/builds/31627053) Coverage increased (+0.03%) to 61.196

[GitHub] [servicecomb-service-center] coveralls edited a comment on pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
coveralls edited a comment on pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#issuecomment-647985232 [![Coverage Status](https://coveralls.io/builds/31626795/badge)](https://coveralls.io/builds/31626795) Coverage decreased (-0.1%) to 61.061%

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1322: controller 层无法使用@Validated注解,而只能使用@Valid注解,导致无法进行group分类,请问怎么解决?

2020-06-23 Thread GitBox
liubao68 edited a comment on issue #1322: URL: https://github.com/apache/servicecomb-java-chassis/issues/1322#issuecomment-648022943 java-chassis 使用的是 hibernate validation, 上述机制是 spring validation 提供的扩展功能,并不是协议标准的组成部分。 需要分析下是否在 java-chassis 中替换为 spring validation. --

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1322: controller 层无法使用@Validated注解,而只能使用@Valid注解,导致无法进行group分类,请问怎么解决?

2020-06-23 Thread GitBox
liubao68 commented on issue #1322: URL: https://github.com/apache/servicecomb-java-chassis/issues/1322#issuecomment-648022943 java-chassis 使用的是 hibernate validation, 上述机制是 spring validation 提供的功能。 需要分析下是否在 java-chassis 中替换. ---

[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1573: 默认线程池没有指定线程名称

2020-06-23 Thread GitBox
liubao68 closed issue #1573: URL: https://github.com/apache/servicecomb-java-chassis/issues/1573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1573: 默认线程池没有指定线程名称

2020-06-23 Thread GitBox
liubao68 commented on issue #1573: URL: https://github.com/apache/servicecomb-java-chassis/issues/1573#issuecomment-648017441 I looked ThreadPoolExecutorEx, and find that the thread name is given to 'group{num}-{num}-thread-{num}', and this is a special pattern.

[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1690: 接口使用swagger注解,@ApiResponse里面@Example解析不出来

2020-06-23 Thread GitBox
liubao68 closed issue #1690: URL: https://github.com/apache/servicecomb-java-chassis/issues/1690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1690: 接口使用swagger注解,@ApiResponse里面@Example解析不出来

2020-06-23 Thread GitBox
liubao68 commented on issue #1690: URL: https://github.com/apache/servicecomb-java-chassis/issues/1690#issuecomment-648014123 fixed in https://github.com/apache/servicecomb-java-chassis/pull/1853 and will be available in 2.1.0 -

[GitHub] [servicecomb-docs] liubao68 merged pull request #184: [SCB-2003]add documents for supported context parameters in consumer …

2020-06-23 Thread GitBox
liubao68 merged pull request #184: URL: https://github.com/apache/servicecomb-docs/pull/184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[servicecomb-docs] branch master updated: [SCB-2003]add documents for supported context parameters in consumer / provider

2020-06-23 Thread liubao
This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-docs.git The following commit(s) were added to refs/heads/master by this push: new 2dcc49a [SCB-2003]add documents for s

[GitHub] [servicecomb-service-center] coveralls edited a comment on pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
coveralls edited a comment on pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#issuecomment-647985232 [![Coverage Status](https://coveralls.io/builds/31625983/badge)](https://coveralls.io/builds/31625983) Coverage decreased (-0.2%) to 60.991%

[GitHub] [servicecomb-service-center] humingcheng commented on a change in pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
humingcheng commented on a change in pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#discussion_r444047987 ## File path: server/rest/controller/v4/auth_resource.go ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [servicecomb-service-center] coveralls commented on pull request #649: [WIP]RBAC prototype

2020-06-23 Thread GitBox
coveralls commented on pull request #649: URL: https://github.com/apache/servicecomb-service-center/pull/649#issuecomment-647985232 [![Coverage Status](https://coveralls.io/builds/31625398/badge)](https://coveralls.io/builds/31625398) Coverage decreased (-0.1%) to 61.027% when p

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

2020-06-23 Thread GitBox
WillemJiang commented on a change in pull request #667: URL: https://github.com/apache/servicecomb-pack/pull/667#discussion_r444039232 ## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/fsm/event/internal/ComponsitedCheckEvent.java ## @@ -17,10

[GitHub] [servicecomb-docs] liubao68 opened a new pull request #184: [SCB-2003]add documents for supported context parameters in consumer …

2020-06-23 Thread GitBox
liubao68 opened a new pull request #184: URL: https://github.com/apache/servicecomb-docs/pull/184 …/ provider This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us