[GitHub] WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect

2018-10-22 Thread GitBox
WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-431846676 @minlywang Can you check the code and build it yourself? I guess there are some jars are out of

[GitHub] WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect

2018-10-21 Thread GitBox
WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-431745396 @minlywang The code was merged into master branch, you can build it yourself or just using the

[GitHub] WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect

2018-10-17 Thread GitBox
WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-430850129 @cherry|zhao,Thanks for your time. Could you fill a JIRA for it?

[GitHub] WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect

2018-10-14 Thread GitBox
WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-429716060 Yeah, it should work that way. Let's find out what's wrong in your demo first. Could you provide a

[GitHub] WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect

2018-10-14 Thread GitBox
WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-429680219 We just need to make sure the @Transactional is the last one to take effect. I have the same

[GitHub] WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect

2018-10-14 Thread GitBox
WillemJiang commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-429603687 @minlywang Normally we cannot put the SagaStart and Compensable on the same method. SagaStart should