[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2414: CSE升级后,如何使用ParameterMessageInterpolator

2021-06-15 Thread GitBox


liubao68 commented on issue #2414:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2414#issuecomment-861933076


   java chassis的修改参考: 
https://github.com/apache/servicecomb-java-chassis/pull/1838/files 
   相关的RN: 
http://servicecomb.gitee.io/servicecomb-java-chassis-doc/java-chassis/zh_CN/featured-topics/upgrading/2_0_1T2_1_0.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 closed issue #2398: 实例变更的可靠性测试问题

2021-06-15 Thread GitBox


liubao68 closed issue #2398:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2398


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] fuziye01 opened a new issue #1052: go mongo driver连接池占满

2021-06-15 Thread GitBox


fuziye01 opened a new issue #1052:
URL: https://github.com/apache/servicecomb-service-center/issues/1052


   问题描述:
   在并发量高的情况下,会报如下错误
   create service failed {"error": "timed out while checking out a connection 
from connection pool}
   
   问题原因:
   原因是go mongo driver的默认最大连接数量为100
   
   解决方法:
   新增配置项registry.mongo.cluster.maxPoolSize,把该参数设置为可以配置的,默认设置为1000
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] G-Jay-R commented on issue #2396: CSE升级后,自定义的错误处理机制方法失效,类继承AbstractEdgeDispatcher

2021-06-15 Thread GitBox


G-Jay-R commented on issue #2396:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2396#issuecomment-861940233


   edgeservice后的服务返回了405的响应码,属于异常么?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] DFSOrange closed pull request #1047: fix cache bugs

2021-06-15 Thread GitBox


DFSOrange closed pull request #1047:
URL: https://github.com/apache/servicecomb-service-center/pull/1047


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] DFSOrange commented on a change in pull request #1047: fix cache bugs

2021-06-15 Thread GitBox


DFSOrange commented on a change in pull request #1047:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1047#discussion_r652289446



##
File path: datasource/mongo/sd/instancec_test.go
##
@@ -83,3 +84,72 @@ func TestInstCacheBasicFunc(t *testing.T) {
assert.Len(t, instanceCache.cache.GetValue("svcid"), 0)
})
 }
+
+func TestInstValueUpdate(t *testing.T) {
+   inst1 := model.Instance{
+   Domain:  "d1",
+   Project: "p1",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.0",
+   },
+   }
+   inst2 := model.Instance{
+   Domain:  "d1",
+   Project: "p1",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.0",
+   },
+   }
+   inst3 := model.Instance{
+   Domain:  "d2",
+   Project: "p2",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.0",
+   },
+   }
+   inst4 := model.Instance{
+   Domain:  "d2",
+   Project: "p2",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.1",
+   },
+   }
+   inst5 := model.Instance{
+   Domain:  "d2",
+   Project: "p2",
+   RefreshTime: time.Now(),
+   Instance: {
+   InstanceId: "123",
+   Version:"1.1",
+   },
+   }
+   var InstTests = []struct {
+   in   []interface{}
+   expected bool
+   }{
+   {in: []interface{}{inst1, inst2},

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] fuziye01 commented on a change in pull request #1050: bugfix: GetAllConsumerIds with no version filter

2021-06-15 Thread GitBox


fuziye01 commented on a change in pull request #1050:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1050#discussion_r652301150



##
File path: datasource/mongo/event/instance_event_handler.go
##
@@ -157,3 +166,170 @@ func NotifySyncerInstanceEvent(event sd.MongoEvent, 
microService *discovery.Micr
 
log.Debug(fmt.Sprintf("success to add instance change event action 
[%s], instanceKey : %s to event queue", instEvent.Action, instanceKey))
 }
+
+func getAllConsumerIDs(ctx context.Context, provider *discovery.MicroService) 
(allow []string, deny []string, err error) {
+   if provider == nil || len(provider.ServiceId) == 0 {
+   return nil, nil, fmt.Errorf("invalid provider")
+   }
+
+   //todo 删除服务,最后实例推送有误差
+   providerRules, ok := cache.GetRulesByServiceID(provider.ServiceId)

Review comment:
   缓存的版本过滤也应该做




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2416: servicecomb升级到2.1.5报javax.el.ExpressionFactory错误

2021-06-15 Thread GitBox


liubao68 commented on issue #2416:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2416#issuecomment-861930557


   看看: https://github.com/apache/servicecomb-java-chassis/issues/2414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2415: servicecomb从2.0.1升级到2.1.5,无法读取CSE全局配置,导致无法注册公有云

2021-06-15 Thread GitBox


liubao68 commented on issue #2415:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2415#issuecomment-861931067


   日志WARN部分和你描述的问题看起来没什么关系。 无法读取配置, 可以看看注册中心是否正常连接上,以及是否正常拉取配置。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1930: netty版本升级至4.1.50之后,form表单中文件如果大于8M,会造成form表单参数解析乱码

2021-06-15 Thread GitBox


liubao68 closed issue #1930:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1930


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] tianxiaoliang edited a comment on issue #1051: instance_event_handler中GetAllConsumerIds未做版本规则过滤

2021-06-15 Thread GitBox


tianxiaoliang edited a comment on issue #1051:
URL: 
https://github.com/apache/servicecomb-service-center/issues/1051#issuecomment-861940531


   补充复现方法,实际结果,预期结果,有bug report 
模板https://github.com/apache/servicecomb-service-center/issues/new?assignees===bug_report.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] tianxiaoliang commented on issue #1051: instance_event_handler中GetAllConsumerIds未做版本规则过滤

2021-06-15 Thread GitBox


tianxiaoliang commented on issue #1051:
URL: 
https://github.com/apache/servicecomb-service-center/issues/1051#issuecomment-861940531


   补充复现方法,实际结果,预期结果


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2398: 实例变更的可靠性测试问题

2021-06-15 Thread GitBox


liubao68 commented on issue #2398:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2398#issuecomment-861935988


   这个问题是safemode机制处理导致的问题, 
[PR](https://github.com/apache/servicecomb-java-chassis/pull/2412) 优化了实例查询的机制。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1050: bugfix: GetAllConsumerIds with no version filter

2021-06-15 Thread GitBox


tianxiaoliang commented on pull request #1050:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1050#issuecomment-861940811


   使用bug report模板记录bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1261: trust-sample在指定场景出现java.lang.NullPointerException: null

2021-06-15 Thread GitBox


liubao68 closed issue #1261:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1261


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1261: trust-sample在指定场景出现java.lang.NullPointerException: null

2021-06-15 Thread GitBox


liubao68 commented on issue #1261:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1261#issuecomment-861933963


   samples changed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] holdyou01 commented on issue #2415: servicecomb从2.0.1升级到2.1.5,无法读取CSE全局配置,导致无法注册公有云

2021-06-15 Thread GitBox


holdyou01 commented on issue #2415:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2415#issuecomment-861984362


   注册中心肯定是没连上才没注册,配置也没有拉取,就是想问为什么没有注册?现在看到的是对比后的日志,多的就是这个None 
EnumerablePropertySource ignored.。能给出相对具体的解决办法吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[servicecomb-java-chassis] branch master updated: upgrade cache plugin (#2413)

2021-06-15 Thread liubao
This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
 new 51c25a8  upgrade cache plugin (#2413)
51c25a8 is described below

commit 51c25a8325a108b67dd3a3b15228e51bcb179ccd
Author: liubao68 
AuthorDate: Tue Jun 15 14:11:55 2021 +0800

upgrade cache plugin (#2413)
---
 .github/workflows/maven.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 933e7a1..b86bfb6 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -20,12 +20,12 @@ jobs:
   uses: actions/setup-java@v1
   with:
 java-version: 1.8
-- uses: actions/cache@v1
+- uses: actions/cache@v2
   with:
 path: ~/.m2/repository
 key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
 restore-keys: |
-  ${{ runner.os }}-maven
+  ${{ runner.os }}-maven-
 - name: Compilation and Installation
   run: bash scripts/build.sh install
 - name: publish coverage report


[GitHub] [servicecomb-kie] tianxiaoliang commented on pull request #185: add upload interface

2021-06-15 Thread GitBox


tianxiaoliang commented on pull request #185:
URL: https://github.com/apache/servicecomb-kie/pull/185#issuecomment-861206302


   对于工作中的PR,前缀加WIP,这样别人有空会给你建议,且表示无需合入


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2411: 微服务之间调用逻辑 当http返回状态码为异常码时 代码直接进入了异常

2021-06-15 Thread GitBox


liubao68 commented on issue #2411:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2411#issuecomment-861211733


   
可以参考下[异常处理](http://servicecomb.gitee.io/servicecomb-java-chassis-doc/java-chassis/zh_CN/general-development/error-handling.html)
 的描述 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2377: There is a vulnerability in httpcomponents 4.5.7 ,upgrade recommended

2021-06-15 Thread GitBox


liubao68 commented on issue #2377:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2377#issuecomment-861213523


   fixed, will be available in 2.3.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 closed issue #2377: There is a vulnerability in httpcomponents 4.5.7 ,upgrade recommended

2021-06-15 Thread GitBox


liubao68 closed issue #2377:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2377


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2382: servicecomb在SC故障恢复后有可能不刷新实例缓存

2021-06-15 Thread GitBox


liubao68 commented on issue #2382:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2382#issuecomment-861214222


   修复方案参考:https://github.com/apache/servicecomb-java-chassis/pull/2412。 
方案性变化,在2.3.0修复, 老版本不提供修复。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2413: upgrade cache plugin

2021-06-15 Thread GitBox


liubao68 merged pull request #2413:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2413


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #2382: servicecomb在SC故障恢复后有可能不刷新实例缓存

2021-06-15 Thread GitBox


liubao68 edited a comment on issue #2382:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2382#issuecomment-861214222


   修复方案参考:https://github.com/apache/servicecomb-java-chassis/pull/2412 。 
方案性变化,在2.3.0修复, 老版本不提供修复。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 closed issue #2382: servicecomb在SC故障恢复后有可能不刷新实例缓存

2021-06-15 Thread GitBox


liubao68 closed issue #2382:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2382


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] holdyou01 opened a new issue #2415: servicecomb从2.0.1升级到2.1.5,无法读取CSE全局配置,导致无法注册公有云

2021-06-15 Thread GitBox


holdyou01 opened a new issue #2415:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2415


   日志报错
   
   
   1. 
   
![20210615-194448(WeLinkPC)](https://user-images.githubusercontent.com/72956826/122047110-52ded300-ce12-11eb-960c-56653ba573fc.png)
   
   相应日志出现在servicecomb-governance的jar包里
   
![2](https://user-images.githubusercontent.com/72956826/122047359-a3563080-ce12-11eb-96d4-4016c12da144.png)
   想问下这种版本升级还有什么地方缺少适配吗?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] IcyZhang commented on issue #2414: CSE升级后,如何使用ParameterMessageInterpolator

2021-06-15 Thread GitBox


IcyZhang commented on issue #2414:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2414#issuecomment-861441146


   我们再升级CSE版本,然后看到CSE整改删除了对于jakarta.el的依赖。 
当前我们产品使用对于消息校验的,也依赖到了jakarta.el。想确定下,你们的修改经验,能否支撑我们也同步修改下,删除对于jakarta.el的依赖


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-kie] Sphairis commented on pull request #185: add upload interface

2021-06-15 Thread GitBox


Sphairis commented on pull request #185:
URL: https://github.com/apache/servicecomb-kie/pull/185#issuecomment-861443481


   > 对于工作中的PR,前缀加WIP,这样别人有空会给你建议,且表示无需合入
   
   好的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #1050: bugfix: GetAllConsumerIds with no version filter

2021-06-15 Thread GitBox


robotLJW opened a new pull request #1050:
URL: https://github.com/apache/servicecomb-service-center/pull/1050


   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case 
name, when you call t.Run().
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2414: CSE升级后,如何使用ParameterMessageInterpolator

2021-06-15 Thread GitBox


liubao68 commented on issue #2414:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2414#issuecomment-861395497


   这个异常看起来和java chassis没有关系。 在不能选择 jakarta.el 的场景, 只能使用 
ParameterMessageInterpolator, 无法使用 jakarta.el的功能。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2299: Netty漏洞 CVE-2021-21295

2021-06-15 Thread GitBox


liubao68 commented on issue #2299:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2299#issuecomment-861360693


   目前netty 4.1.60+版本都有影响重要功能的bug,不能使用。 需要等待 4.1.66 及以上版本


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] IcyZhang commented on issue #2414: CSE升级后,如何使用ParameterMessageInterpolator

2021-06-15 Thread GitBox


IcyZhang commented on issue #2414:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2414#issuecomment-861423696


   如何切换ParameterMessageInterpolator?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] IcyZhang opened a new issue #2414: CSE升级后,如何使用ParameterMessageInterpolator

2021-06-15 Thread GitBox


IcyZhang opened a new issue #2414:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2414


   
   
![问题](https://user-images.githubusercontent.com/21097832/12204-017b1780-ce03-11eb-9069-3512bceec204.png)
   
   现状:项目不允许引入jakarta.el,如何使用ParameterMessageInterpolator 来生成错误消息
   报错:
   
   
![报错](https://user-images.githubusercontent.com/21097832/122033644-4bfc9400-ce03-11eb-86b8-785e23357ce8.png)
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1047: fix cache bugs

2021-06-15 Thread GitBox


tianxiaoliang commented on a change in pull request #1047:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1047#discussion_r651704722



##
File path: datasource/mongo/sd/instancec_test.go
##
@@ -83,3 +84,72 @@ func TestInstCacheBasicFunc(t *testing.T) {
assert.Len(t, instanceCache.cache.GetValue("svcid"), 0)
})
 }
+
+func TestInstValueUpdate(t *testing.T) {
+   inst1 := model.Instance{
+   Domain:  "d1",
+   Project: "p1",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.0",
+   },
+   }
+   inst2 := model.Instance{
+   Domain:  "d1",
+   Project: "p1",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.0",
+   },
+   }
+   inst3 := model.Instance{
+   Domain:  "d2",
+   Project: "p2",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.0",
+   },
+   }
+   inst4 := model.Instance{
+   Domain:  "d2",
+   Project: "p2",
+   RefreshTime: time.Time{},
+   Instance: {
+   InstanceId: "123",
+   Version:"1.1",
+   },
+   }
+   inst5 := model.Instance{
+   Domain:  "d2",
+   Project: "p2",
+   RefreshTime: time.Now(),
+   Instance: {
+   InstanceId: "123",
+   Version:"1.1",
+   },
+   }
+   var InstTests = []struct {
+   in   []interface{}
+   expected bool
+   }{
+   {in: []interface{}{inst1, inst2},

Review comment:
   可能gotests工具版本和别人不同?没有test case 名字




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2414: CSE升级后,如何使用ParameterMessageInterpolator

2021-06-15 Thread GitBox


liubao68 commented on issue #2414:
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/2414#issuecomment-861425013


   java chassis默认就是的。 你报告的问题, 应该和java-chassis没有关系。 堆栈显示的不是java chassis功能。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [servicecomb-java-chassis] xudonghua opened a new issue #2416: servicecomb升级到2.1.5报javax.el.ExpressionFactory错误

2021-06-15 Thread GitBox


xudonghua opened a new issue #2416:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2416


   1、首先报错:
   
[/opt/huawei/release/speaker/SCThirdSkillService/20210615152956/config/META-INF/spring/provider.bean.xml]:
 Invocation of init method failed; nested exception is 
javax.validation.ValidationException: HV000183: Unable to initialize 
'javax.el.ExpressionFactory'. Check that you have the EL dependencies on the 
classpath, or use ParameterMessageInterpolator instead
   删除如下行:
   
![image](https://user-images.githubusercontent.com/85955436/122089767-ae708700-ce39-11eb-9051-2ec87abb4128.png)
   2、上面这行是干嘛用的?删了之后又报错
   Exception in thread "main" 
org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'filterChainsManager': Unsatisfied dependency expressed 
through method 'addFilters' parameter 0; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'parameterValidatorFilter' defined in URL 
[jar:file:/opt/huawei/release/speaker/SCThirdSkillService/20210615152956/lib/java-chassis-core-2.1.5.jar!/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilter.class]:
 Invocation of init method failed; nested exception is 
javax.validation.ValidationException: HV000183: Unable to initialize 
'javax.el.ExpressionFactory'. Check that you have the EL dependencies on the 
classpath, or use ParameterMessageInterpolator instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org