[GitHub] coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics
coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#issuecomment-427647235 [](https://coveralls.io/builds/19417071) Coverage decreased (-0.1%) to 86.08% when pulling **17e729ad3962a7dfe06dcb32954fd5e65945b10b on heyile:metrics_apm** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics
coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#issuecomment-427647235 [](https://coveralls.io/builds/19417054) Coverage decreased (-0.1%) to 86.084% when pulling **17e729ad3962a7dfe06dcb32954fd5e65945b10b on heyile:metrics_apm** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui closed pull request #454: SCB-951 Wrong help information in scctl
little-cui closed pull request #454: SCB-951 Wrong help information in scctl
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/454
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/scctl/pkg/plugin/README.md b/scctl/pkg/plugin/README.md
index 979cdeaa..39096e86 100644
--- a/scctl/pkg/plugin/README.md
+++ b/scctl/pkg/plugin/README.md
@@ -20,9 +20,9 @@ Get the microservices list from ServiceCenter. `service`
command can be instead
Options
-- `domain`(d) domain name, return `default` domain microservices list by
default.
-- `output`(o) support mode `wide`, return the complete microservices
information(e.g., framework, endpoints).
-- `all-domains` return all domains microservices information.
+- `domain`(d) print the information under the specified domain in service
center, print under the `default` domain by default.
+- `output`(o) support mode `wide`, output the complete microservices
information(e.g., framework, endpoints).
+- `all-domains` print the information under all domains in service center.
Examples
diff --git a/scctl/pkg/plugin/get/cmd.go b/scctl/pkg/plugin/get/cmd.go
index 05fa3ad7..ba86983c 100644
--- a/scctl/pkg/plugin/get/cmd.go
+++ b/scctl/pkg/plugin/get/cmd.go
@@ -37,9 +37,9 @@ func NewGetCommand(parent *cobra.Command) *cobra.Command {
Short: "Output the resources information of service center",
}
parent.AddCommand(cmd)
- cmd.PersistentFlags().StringVarP(, "domain", "d", "default",
"the info of the service center")
- cmd.PersistentFlags().StringVarP(, "output", "o", "", "print the
info of the service center")
- cmd.PersistentFlags().BoolVar(, "all-domains", false, "print
the info of the service center")
+ cmd.PersistentFlags().StringVarP(, "domain", "d", "default",
"print the information under the specified domain in service center")
+ cmd.PersistentFlags().StringVarP(, "output", "o", "", "output
the complete microservice information(e.g., framework, endpoints)")
+ cmd.PersistentFlags().BoolVar(, "all-domains", false, "print
the information under all domains in service center")
return cmd
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-servicecomb-service-center] branch master updated: SCB-951 Wrong help information in scctl (#454)
This is an automated email from the ASF dual-hosted git repository.
littlecui pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-servicecomb-service-center.git
The following commit(s) were added to refs/heads/master by this push:
new 500b64f SCB-951 Wrong help information in scctl (#454)
500b64f is described below
commit 500b64f106732688e79bde736a6b6aaceb95fdab
Author: little-cui
AuthorDate: Tue Oct 9 08:59:48 2018 +0800
SCB-951 Wrong help information in scctl (#454)
---
scctl/pkg/plugin/README.md | 6 +++---
scctl/pkg/plugin/get/cmd.go | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/scctl/pkg/plugin/README.md b/scctl/pkg/plugin/README.md
index 979cdea..39096e8 100644
--- a/scctl/pkg/plugin/README.md
+++ b/scctl/pkg/plugin/README.md
@@ -20,9 +20,9 @@ Get the microservices list from ServiceCenter. `service`
command can be instead
Options
-- `domain`(d) domain name, return `default` domain microservices list by
default.
-- `output`(o) support mode `wide`, return the complete microservices
information(e.g., framework, endpoints).
-- `all-domains` return all domains microservices information.
+- `domain`(d) print the information under the specified domain in service
center, print under the `default` domain by default.
+- `output`(o) support mode `wide`, output the complete microservices
information(e.g., framework, endpoints).
+- `all-domains` print the information under all domains in service center.
Examples
diff --git a/scctl/pkg/plugin/get/cmd.go b/scctl/pkg/plugin/get/cmd.go
index 05fa3ad..ba86983 100644
--- a/scctl/pkg/plugin/get/cmd.go
+++ b/scctl/pkg/plugin/get/cmd.go
@@ -37,9 +37,9 @@ func NewGetCommand(parent *cobra.Command) *cobra.Command {
Short: "Output the resources information of service center",
}
parent.AddCommand(cmd)
- cmd.PersistentFlags().StringVarP(, "domain", "d", "default",
"the info of the service center")
- cmd.PersistentFlags().StringVarP(, "output", "o", "", "print the
info of the service center")
- cmd.PersistentFlags().BoolVar(, "all-domains", false, "print
the info of the service center")
+ cmd.PersistentFlags().StringVarP(, "domain", "d", "default",
"print the information under the specified domain in service center")
+ cmd.PersistentFlags().StringVarP(, "output", "o", "", "output
the complete microservice information(e.g., framework, endpoints)")
+ cmd.PersistentFlags().BoolVar(, "all-domains", false, "print
the information under all domains in service center")
return cmd
}
[incubator-servicecomb-website] branch asf-site updated (e27a531 -> cf9cc34)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-website.git. from e27a531 Publish the website add 4e62e80 fix date issue add 6453a46 fix date issue add cbea09f add online live link add a342af3 Merge pull request #142 from imlidian/master new 64721ec Merge branch 'master' into asf-site new cf9cc34 Publish the web site The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md | 4 +++- .../cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md | 4 +++- .../cn/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html | 4 +++- .../docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html| 4 +++- content/feed.xml | 10 +++--- 5 files changed, 19 insertions(+), 7 deletions(-)
[incubator-servicecomb-website] 02/02: Publish the web site
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a commit to branch asf-site
in repository
https://gitbox.apache.org/repos/asf/incubator-servicecomb-website.git
commit cf9cc348039f6b0d70c218a667e1afaa9fddbd0a
Author: Willem Jiang
AuthorDate: Tue Oct 9 07:33:06 2018 +0800
Publish the web site
---
.../cn/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html | 4 +++-
.../docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html| 4 +++-
content/feed.xml | 10 +++---
3 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/content/cn/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
b/content/cn/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
index 82ee2aa..447d364 100644
--- a/content/cn/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
+++ b/content/cn/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
@@ -393,7 +393,9 @@
会议日期/时间：2018 年 10 月 12 日，星期五，13:30–16:50
-会议地址：上海世博展览馆416-417会议厅，上海, Room
416-417
+会议地址：上海世博展览馆416-417会议厅
+
+在线直播: http://www.itdks.com/eventlist/detail/2709;>链接
diff --git a/content/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
b/content/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
index 346cb17..284c2a8 100644
--- a/content/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
+++ b/content/docs/Apache-ServiceComb-Meetup-2018-Shanghai/index.html
@@ -386,7 +386,9 @@
Meeting Date/time: Friday, October 12, 2018, 13:30-16:50
PM
-Meeting address:Shanghai World Expo Exhibition
Convention Center, Room 416-417
+Meeting Address:Shanghai World Expo Exhibition
Convention Center, Room 416-417
+
+Live Online: http://www.itdks.com/eventlist/detail/2709;>Link
diff --git a/content/feed.xml b/content/feed.xml
index ab8221e..7a529c6 100644
--- a/content/feed.xml
+++ b/content/feed.xml
@@ -1,10 +1,12 @@
-http://www.w3.org/2005/Atom; >https://jekyllrb.com/;
version="3.4.3">Jekyll2018-10-08T11:38:25+08:00/Apache ServiceComb (incubating)The homepage of
ServiceComb{name=nil,
avatar= [...]
+http://www.w3.org/2005/Atom; >https://jekyllrb.com/;
version="3.4.3">Jekyll2018-10-09T07:32:15+08:00/Apache ServiceComb (incubating)The homepage of
ServiceComb{name=nil,
avatar= [...]
pstrongApache ServiceComb Meetup/strong/p
pstrong会议日期/时间/strong：2018 年 10 月 12
日，星期五，13:30–16:50/p
-pstrong会议地址/strong：上海世博展览馆416-417会议厅，上海,
strongRoom 416-417/strong/p
+pstrong会议地址/strong：上海世博展览馆416-417会议厅/p
+
+pstrong在线直播:/strong a
href=http://www.itdks.com/eventlist/detail/2709链接/a/p;
hr /
@@ -78,7 +80,9 @@
pstrongMeeting Date/time:/strong Friday, October 12,
2018, 13:30-16:50 PM/p
-pstrongMeeting address:/strongShanghai World Expo
Exhibition amp; Convention Center, strongRoom
416-417/strong/p
+pstrongMeeting Address:/strongShanghai World Expo
Exhibition amp; Convention Center, strongRoom
416-417/strong/p
+
+pstrongLive Online:/strong a
href=http://www.itdks.com/eventlist/detail/2709Link/a/p;
hr /
[incubator-servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-website.git commit 64721eca31da40460b5de6f699c1c3b04a836adb Merge: e27a531 a342af3 Author: Willem Jiang AuthorDate: Tue Oct 9 07:32:07 2018 +0800 Merge branch 'master' into asf-site _posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md| 4 +++- _posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
[GitHub] wujimin commented on a change in pull request #936: [SCB-737]Avoid null point exception
wujimin commented on a change in pull request #936: [SCB-737]Avoid null point
exception
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/936#discussion_r223366629
##
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
##
@@ -63,6 +63,9 @@ protected void processProvider(String beanName, Object bean)
{
// aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
// 所以，需要先取出原class，再取标注
Class beanCls = BeanUtils.getImplClassFromBean(bean);
+if(beanCls == null) {
Review comment:
if got null, maybe will cause to lost schema definition
so need to print a warn log at least.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics
coveralls edited a comment on issue #944: [SCB-950] modify consumer producer metrics and add edge metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/944#issuecomment-427647235 [](https://coveralls.io/builds/19399479) Coverage decreased (-0.1%) to 86.088% when pulling **512636f6e926218c0540d1b43746e17194aeb5da on heyile:metrics_apm** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #454: SCB-951 Wrong help information in scctl
codecov-io commented on issue #454: SCB-951 Wrong help information in scctl URL: https://github.com/apache/incubator-servicecomb-service-center/pull/454#issuecomment-427756909 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@4e2344f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=tree) ```diff @@Coverage Diff@@ ## master #454 +/- ## = Coverage ? 60.17% = Files ? 156 Lines ?13404 Branches ?0 = Hits ? 8066 Misses? 4759 Partials ? 579 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=footer). Last update [4e2344f...c2711d7](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/454?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui opened a new pull request #454: SCB-951 Wrong help information in scctl
little-cui opened a new pull request #454: SCB-951 Wrong help information in scctl URL: https://github.com/apache/incubator-servicecomb-service-center/pull/454 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-servicecomb-website] branch master updated (f7523f2 -> a342af3)
This is an automated email from the ASF dual-hosted git repository. zhengyangyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-website.git. from f7523f2 fix date issue add 4e62e80 fix date issue add 6453a46 fix date issue add cbea09f add online live link new a342af3 Merge pull request #142 from imlidian/master The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md| 4 +++- _posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
[incubator-servicecomb-website] 01/01: Merge pull request #142 from imlidian/master
This is an automated email from the ASF dual-hosted git repository. zhengyangyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-website.git commit a342af3f42a705113fb85a587f903adf0a2053c0 Merge: f7523f2 cbea09f Author: zhengyangyong AuthorDate: Mon Oct 8 16:03:55 2018 +0800 Merge pull request #142 from imlidian/master add online live link _posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md| 4 +++- _posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
[GitHub] zhengyangyong closed pull request #142: add online live link
zhengyangyong closed pull request #142: add online live link URL: https://github.com/apache/incubator-servicecomb-website/pull/142 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/_posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md b/_posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md index 77df712e..948a1e98 100644 --- a/_posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md +++ b/_posts/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md @@ -14,7 +14,9 @@ redirect_from: **Meeting Date/time:** Friday, October 12, 2018, 13:30-16:50 PM -**Meeting address:**Shanghai World Expo Exhibition & Convention Center, **Room 416-417** +**Meeting Address:**Shanghai World Expo Exhibition & Convention Center, **Room 416-417** + +**Live Online:** [Link](http://www.itdks.com/eventlist/detail/2709) diff --git a/_posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md b/_posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md index 2835c4c4..c782edf6 100644 --- a/_posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md +++ b/_posts/cn/2018-09-28-Apache-ServiceComb-Meetup-2018-Shanghai.md @@ -15,9 +15,11 @@ redirect_from: **Apache ServiceComb Meetup** -**会议日期/时间**：2018 年 10 月 12 日，星期三，1:30 – 16:50 +**会议日期/时间**：2018 年 10 月 12 日，星期五，13:30–16:50 -**会议地址**：上海世博展览馆416-417会议厅，上海, **Room 416-417** +**会议地址**：上海世博展览馆416-417会议厅 + +**在线直播:** [链接](http://www.itdks.com/eventlist/detail/2709) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] imlidian opened a new pull request #142: add online live link
imlidian opened a new pull request #142: add online live link URL: https://github.com/apache/incubator-servicecomb-website/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] laijianbin commented on a change in pull request #936: [SCB-737]Avoid null point exception
laijianbin commented on a change in pull request #936: [SCB-737]Avoid null
point exception
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/936#discussion_r223254374
##
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
##
@@ -63,6 +63,9 @@ protected void processProvider(String beanName, Object bean)
{
// aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
// 所以，需要先取出原class，再取标注
Class beanCls = BeanUtils.getImplClassFromBean(bean);
+if(beanCls == null) {
Review comment:
org.springframework.aop.TargetClassAware.getTargetClass(),this method return
the target Class, or null if not known. more detail, reference
https://issues.apache.org/jira/browse/SCB-737?filter=-1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
