[GitHub] [servicecomb-service-center] codecov-io commented on issue #548: Add Syncer

2019-05-20 Thread GitBox 
codecov-io commented on issue #548: Add Syncer 
URL: 
https://github.com/apache/servicecomb-service-center/pull/548#issuecomment-494245933
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=h1)
 Report
   > Merging 
[#548](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/3eb06e429e5de2bb398b3df0db29a5e454fb49f4?src=pr=desc)
 will **increase** coverage by `0.64%`.
   > The diff coverage is `76.74%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#548  +/-   ##
   =
   + Coverage   57.86%   58.5%   +0.64% 
   =
 Files 185 202  +17 
 Lines   14823   15309 +486 
   =
   + Hits 85778957 +380 
   - Misses   56445726  +82 
   - Partials  602 626  +24
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[syncer/plugins/servicecenter/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci9zZXJ2aWNlLmdv)
 | `100% <100%> (ø)` | |
   | 
[syncer/plugins/servicecenter/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci9pbnN0YW5jZS5nbw==)
 | `100% <100%> (ø)` | |
   | 
[syncer/plugins/export.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3BsdWdpbnMvZXhwb3J0Lmdv)
 | `100% <100%> (ø)` | |
   | 
[syncer/datacenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL2RhdGFjZW50ZXIvc3luYy5nbw==)
 | `54.83% <54.83%> (ø)` | |
   | 
[syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv)
 | `57.69% <57.69%> (ø)` | |
   | 
[syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv)
 | `63.63% <63.63%> (ø)` | |
   | 
[syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv)
 | `67.74% <67.74%> (ø)` | |
   | 
[syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=)
 | `74% <74%> (ø)` | |
   | 
[syncer/plugins/plugin.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3BsdWdpbnMvcGx1Z2luLmdv)
 | `77.33% <77.33%> (ø)` | |
   | 
[syncer/storage/storage.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree#diff-c3luY2VyL3N0b3JhZ2Uvc3RvcmFnZS5nbw==)
 | `79.31% <79.31%> (ø)` | |
   | ... and [31 
more](https://codecov.io/gh/apache/servicecomb-service-center/pull/548/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=footer).
 Last update 
[3eb06e4...3b097d7](https://codecov.io/gh/apache/servicecomb-service-center/pull/548?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls commented on issue #548: Add Syncer

2019-05-20 Thread GitBox 
coveralls commented on issue #548: Add Syncer 
URL: 
https://github.com/apache/servicecomb-service-center/pull/548#issuecomment-494245995
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23507229/badge)](https://coveralls.io/builds/23507229)
   
   Coverage increased (+0.7%) to 60.929% when pulling 
**3b097d7fcb8777486766b4461abc3e2dfcbcebc7 on zenlint:master** into 
**3eb06e429e5de2bb398b3df0db29a5e454fb49f4 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] zenlint commented on issue #548: Add Syncer

2019-05-20 Thread GitBox 
zenlint commented on issue #548: Add Syncer 
URL: 
https://github.com/apache/servicecomb-service-center/pull/548#issuecomment-494245285
 
 
   @little-cui @tianxiaoliang , please help to review the PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] zenlint opened a new pull request #548: Add Syncer

2019-05-20 Thread GitBox 
zenlint opened a new pull request #548: Add Syncer 
URL: https://github.com/apache/servicecomb-service-center/pull/548
 
 
   Add basic minimal runnable version of Syncer, reference to 
[README.md](https://github.com/zenlint/servicecomb-service-center/blob/master/syncer/README.md)
 to get what is Service-center Syncer.
   
   The current Syner has a P2P network to ensure that different Service-centers 
can perform peer-to-peer data synchronization when needed. When data needs to 
be synchronized between Service-centers, Syner establishs a point-to-point 
channel through GRPC to ensure that the less impact on network load.
   
   I am going to make syncer to support the following capabilities in the 
coming PR,
   - Support for other service registration and discovery centers, such as 
SpringCloud Eureka, Istio, etc.
   - Enhance the reliability of the Syner itself, Syner lifecycle management.
   
   Reference to 
[TODO.md](https://github.com/zenlint/servicecomb-service-center/blob/master/syncer/TODO.md)
 to get future plans for Syncer.
   
   It is worth noting that both Syncer and Service-center are loosely coupled 
in the code and there runtime, therefore,  Syncer will not affect the current 
Service-center.
   
   Signed-off-by: Zen Lin 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls edited a comment on issue #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
coveralls edited a comment on issue #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470#issuecomment-493862531
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23506379/badge)](https://coveralls.io/builds/23506379)
   
   Coverage decreased (-0.2%) to 90.031% when pulling 
**fefc2f8fd0324a5cd467a5eea205539e7427f096 on 
cmonkey:feature/acceptance-pack-spring-demo-with-zookeeper** into 
**d7125d3cf3ce6c8fc5d172073ee34190f03f81ed on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] cmonkey opened a new pull request #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
cmonkey opened a new pull request #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] cmonkey closed pull request #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
cmonkey closed pull request #470: Feature/acceptance pack spring demo with 
zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #1216: [SCB-1290][WIP][WEAK] add swagger generator unit test case for List>

2019-05-20 Thread GitBox 
wujimin opened a new pull request #1216: [SCB-1290][WIP][WEAK] add swagger 
generator unit test case for List>
URL: https://github.com/apache/servicecomb-java-chassis/pull/1216
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1209: [SCB-1278] Not send x-cse* header to third party service by default

2019-05-20 Thread GitBox 
wujimin commented on a change in pull request #1209: [SCB-1278] Not send x-cse* 
header to third party service by default
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1209#discussion_r285719208
 
 

 ##
 File path: 
core/src/main/java/org/apache/servicecomb/core/definition/OperationConfig.java
 ##
 @@ -61,6 +61,20 @@
   @InjectProperty(keys = {"request.${op-any-priority}.timeout", 
"request.timeout"}, defaultValue = "3")
   private long msRequestTimeout;
 
+  /**
+   * whether to remove certain headers from the 3rd party invocations
+   */
+  @InjectProperty(keys = 
{"request.${op-any-priority}.clientRequestHeaderFilterEnabled",
+  "request.clientRequestHeaderFilterEnabled"}, defaultValue = "true")
+  private boolean clientRequestHeaderFilterEnabled = true;
+
+  /**
+   * the matched headers should be removed, in invocations to 3rd party 
services
+   */
+  @InjectProperty(keys = 
{"request.${op-any-priority}.clientRequestHeaderFilterPattern",
+  "request.clientRequestHeaderFilterPattern"}, defaultValue = "^x-cse.*")
+  private String clientRequestHeaderFilterPattern = "^x-cse.*";
 
 Review comment:
   if need to compile pattern, then we can do that in setter method
   that can avoid check changes during main business logic.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1209: [SCB-1278] Not send x-cse* header to third party service by default

2019-05-20 Thread GitBox 
wujimin commented on a change in pull request #1209: [SCB-1278] Not send x-cse* 
header to third party service by default
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1209#discussion_r285718301
 
 

 ##
 File path: core/src/main/java/org/apache/servicecomb/core/Endpoint.java
 ##
 @@ -61,6 +61,13 @@ public Object getAddress() {
 return address;
   }
 
+  public boolean isThirdPartyEndpoint() {
+if (null == this.instance) {
 
 Review comment:
   seems not so good.
   we also need to support register 3rd services to SC, sometimes maybe also 
not allow send context header to that target.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-java-chassis] branch master updated: [SCB-1287]refactor edge dispatcher to make them more extensible

2019-05-20 Thread wujimin 
This is an automated email from the ASF dual-hosted git repository.

wujimin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
 new 7d01439  [SCB-1287]refactor edge dispatcher to make them more 
extensible
7d01439 is described below

commit 7d0143984e1013684a368ce38baf89a9765d7ad1
Author: liubao 
AuthorDate: Fri May 17 12:03:42 2019 +0800

[SCB-1287]refactor edge dispatcher to make them more extensible
---
 .../java/org/apache/servicecomb/edge/core/AbstractEdgeDispatcher.java | 4 
 .../java/org/apache/servicecomb/edge/core/DefaultEdgeDispatcher.java  | 2 +-
 .../org/apache/servicecomb/edge/core/URLMappedEdgeDispatcher.java | 2 +-
 .../apache/servicecomb/transport/rest/vertx/VertxRestDispatcher.java  | 4 ++--
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git 
a/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/AbstractEdgeDispatcher.java
 
b/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/AbstractEdgeDispatcher.java
index 689da10..7cdc43e 100644
--- 
a/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/AbstractEdgeDispatcher.java
+++ 
b/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/AbstractEdgeDispatcher.java
@@ -34,6 +34,10 @@ import io.vertx.ext.web.RoutingContext;
 public abstract class AbstractEdgeDispatcher extends 
AbstractVertxHttpDispatcher {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(AbstractEdgeDispatcher.class);
 
+  protected EdgeInvocation createEdgeInvocation() {
+return new EdgeInvocation();
+  }
+
   protected void onFailure(RoutingContext context) {
 LOGGER.error("edge server failed.", context.failure());
 HttpServerResponse response = context.response();
diff --git 
a/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/DefaultEdgeDispatcher.java
 
b/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/DefaultEdgeDispatcher.java
index 20ecb21..b6eadfe 100644
--- 
a/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/DefaultEdgeDispatcher.java
+++ 
b/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/DefaultEdgeDispatcher.java
@@ -76,7 +76,7 @@ public class DefaultEdgeDispatcher extends 
AbstractEdgeDispatcher {
 String microserviceName = pathParams.get("param0");
 String path = Utils.findActualPath(context.request().path(), 
prefixSegmentCount);
 
-EdgeInvocation edgeInvocation = new EdgeInvocation();
+EdgeInvocation edgeInvocation =  createEdgeInvocation();
 if (withVersion) {
   String pathVersion = pathParams.get("param1");
   
edgeInvocation.setVersionRule(versionMapper.getOrCreate(pathVersion).getVersionRule());
diff --git 
a/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/URLMappedEdgeDispatcher.java
 
b/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/URLMappedEdgeDispatcher.java
index f8c1695..5f9cfb7 100644
--- 
a/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/URLMappedEdgeDispatcher.java
+++ 
b/edge/edge-core/src/main/java/org/apache/servicecomb/edge/core/URLMappedEdgeDispatcher.java
@@ -151,7 +151,7 @@ public class URLMappedEdgeDispatcher extends 
AbstractEdgeDispatcher {
 
 String path = Utils.findActualPath(context.request().path(), 
configurationItem.prefixSegmentCount);
 
-EdgeInvocation edgeInvocation = new EdgeInvocation();
+EdgeInvocation edgeInvocation = createEdgeInvocation();
 if (configurationItem.versionRule != null) {
   edgeInvocation.setVersionRule(configurationItem.versionRule);
 }
diff --git 
a/transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/VertxRestDispatcher.java
 
b/transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/VertxRestDispatcher.java
index 20f70bd..b90bc78 100644
--- 
a/transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/VertxRestDispatcher.java
+++ 
b/transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/VertxRestDispatcher.java
@@ -68,7 +68,7 @@ public class VertxRestDispatcher extends 
AbstractVertxHttpDispatcher {
 
router.route().failureHandler(this::failureHandler).handler(this::onRequest);
   }
 
-  private void failureHandler(RoutingContext context) {
+  protected void failureHandler(RoutingContext context) {
 LOGGER.error("http server failed.", context.failure());
 
 AbstractRestInvocation restProducerInvocation = 
context.get(RestConst.REST_PRODUCER_INVOCATION);
@@ -182,7 +182,7 @@ public class VertxRestDispatcher extends 
AbstractVertxHttpDispatcher {
 context.response().close();
   }
 
-  private void onRequest(RoutingContext context) {
+  protected void onRequest(RoutingContext context) {
 if (transport == null) {
   transport =

[GitHub] [servicecomb-java-chassis] wujimin merged pull request #1210: [SCB-1287]refactor edge dispatcher to make them more extensible

2019-05-20 Thread GitBox 
wujimin merged pull request #1210: [SCB-1287]refactor edge dispatcher to make 
them more extensible
URL: https://github.com/apache/servicecomb-java-chassis/pull/1210
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-java-chassis] branch weak-contract-type updated (4a3e3c0 -> 938f8d8)

2019-05-20 Thread wujimin 
This is an automated email from the ASF dual-hosted git repository.

wujimin pushed a change to branch weak-contract-type
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git.


 discard 4a3e3c0  [SCB-1286][WIP][WEAK] support only generate response for a 
operation
 discard a86db3e  [SCB-1285][WIP][WEAK] enhance ResponseTypeProcessor to 
support extractResponseType
 discard 72dbb7e  [SCB-1284][WIP][WEAK] operationId should not be empty
 discard f37f882  [SCB-1283][WIP][WEAK] avoid generate empty property by 
SwaggerDefinition
omit 6516edb  [SCB-1269][WIP][WEAK] update UT
omit 69bf689  [SCB-1269][WIP][WEAK] delete useless files
omit 8bc9ed5  [SCB-1269][WIP][WEAK] swaggerProducer arguments not depend on 
swagger interface
omit d0bafd8  [SCB-1268][WIP][WEAK] update UT
omit 3511995  [SCB-1268][WIP][WEAK] publish Microservice life event
omit ea259f9  [SCB-1268][WIP][WEAK] delete metas from AppManager, will 
manage them by VendorExtensions
omit ba0d8bb  [SCB-1268][WIP][WEAK] MicroserviceNameParser not depend on 
static variable
omit 60d1fc7  [SCB-1268][WIP][WEAK] format code
omit 45dc098  [SCB-1117][WIP][WEAK] UT for Springmvc mode
omit d4c2a56  [SCB-1117][WIP][WEAK] UT for Jaxrs mode
omit c18e234  [SCB-1117][WIP][WEAK] UT for Pojo mode
omit 6059851  [SCB-1117][WIP][WEAK] prepare UT model and consumer interfaces
omit a18b482  [SCB-1117][WIP][WEAK] delete useless UT files
omit 9e78c06  [SCB-1117][WIP][WEAK] delete useless files
omit 21c9bdc  [SCB-1117][WIP][WEAK] SwaggerConsumer arguments not depend on 
swagger interface
omit 6f04624  [SCB-1256][WIP][WEAK] rename ConcreteInterfaceRegister to 
ConcreteTypeRegister
omit 8af4ccf  [SCB-1252][WIP][WEAK] change element of HttpParameterType to 
uppercase
omit 3b2468b  [SCB-1248][WIP][WEAK] update unit test
omit 97ec4d9  [SCB-1248][WIP][WEAK] reduce EventBus subscribers
omit cc2d5e3  [SCB-1248][WIP][WEAK] add MicroserviceMeta
omit 2656a76  [SCB-1248][WIP][WEAK] add SwaggerLoader
omit 05601da  [SCB-1248][WIP][WEAK] remove MicroserviceVersionFactory
omit 78613da  [SCB-1248][WIP][WEAK] improve config log
omit 1b610f0  [SCB-1248][WIP][WEAK] make local registry easier to use
omit bbb748c  [SCB-1228][WIP][WEAK] update chassis pom.xml to present 
interface argument name
omit e214252  [SCB-1228][WIP][WEAK] update unit test
omit e660206  [SCB-1228][WIP][WEAK] update SPI definition
omit 4e8f299  [SCB-1228][WIP][WEAK] springmvc processors switch to new 
mechanism
omit 3e06938  [SCB-1228][WIP][WEAK] swagger springmvc generator switch to 
new mechanism
omit 65e6004  [SCB-1228][WIP][WEAK] delete swagger to class logic
omit a02b2aa  [SCB-1227][WIP][WEAK] update unit test
omit 6b5f0a8  [SCB-1227][WIP][WEAK] update SPI definition
omit 90dc849  [SCB-1227][WIP][WEAK] jaxrs processors switch to new mechanism
omit 8734d71  [SCB-1227][WIP][WEAK] swagger jaxrs generator switch to new 
mechanism
omit 00e53a3  [SCB-1242] add spring data plugin project
omit dd7e3d2  [SCB-1242] swagger generator and json deserializer prepare to 
support spring data
omit 3a2559a  [SCB-1225][WIP][WEAK] fix by review comments
omit 0b9463b  [SCB-1225][WIP][WEAK] remove unnecessary dependency of spring
omit 81c8d87  [SCB-1225][WIP][WEAK] update unit test cases
omit b8a5880  [SCB-1225][WIP][WEAK] SPI definition switch to new mechanism
omit 627f4a1  [SCB-1225][WIP][WEAK] delete useless files
omit 81b1faf  [SCB-1225][WIP][WEAK] create abstract rest mode generator
omit 84bb73a  [SCB-1225][WIP][WEAK] create pojo mode generator
omit 225925b  [SCB-1225][WIP][WEAK] unit test utils switch to new mechanism
omit 3476385  [SCB-1225][WIP][WEAK] response generator switch to new 
mechanism
omit d0ed73d  [SCB-1225][WIP][WEAK] parameter generator switch to new 
mechanism
omit ee06599  [SCB-1225][WIP][WEAK] class and method annotation switch to 
new mechanism
omit a56bb81  [SCB-1225][WIP][WEAK] create basic generator implementation
omit 6a93b14  [SCB-1225][WIP][WEAK] define new generator interfaces
omit 4be28c2  [SCB-1225][WIP][WEAK] delete swagger to class logic
omit 2536b5b  [SCB-1213][WIP][WEAK] swagger generator placeholder resolver 
not depend on spring
omit c994fb4  [SC-1214][WIP][WEAK] change weak-contract-type branch version 
to weak-contract-type-SNAPSHOT
 add cfd26b9  SCB-1275 Fixed the starting error of bmi example
 add 8ef4ca9  [SCB-1277]make sure demo and samples are normal
 add b5c1bba  [SCB-1280] remove unnecessary class cast
 add 622297b  [SCB-1280] add IT for nested List params
 new 10f2ae5  [SC-1214][WIP][WEAK] change weak-contract-type branch version 
to weak-contract-type-SNAPSHOT
 new 4eb6aba  [SCB-1213][WIP][WEAK] swagger generator placeholder resolver 
not depend on spring
 new f73c165  [SCB-1225][WIP][WEAK] delete swagger to class logic
 new 7b46cfe

[servicecomb-samples] 01/03: refract project structures

2019-05-20 Thread liubao 
This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-samples.git

commit 161f7960091dd8ef486707882d872d90d861f7be
Author: liubao 
AuthorDate: Fri May 17 10:51:09 2019 +0800

refract project structures
---
 .../main/resources/META-INF/spring/user.bean.xml   |  24 ---
 .../resources/META-INF/spring/resource.bean.xml|  30 ---
 .../endpoint/pom.xml   |   0
 .../authentication/api/AuthenticationEndpoint.java |   0
 .../pom.xml|   0
 .../service/pom.xml|   0
 .../authentication/api/AuthenticationService.java  |   0
 .../servicecomb/authentication/api/Token.java  |   0
 .../samples/porter/file/api/InspectorEndpoint.java | 206 -
 .../samples/porter/file/api/LogEndpoint.java   |  72 ---
 .../samples/porter/common/api/LogService.java  |  26 ---
 authentication/api/edge-service/endpoint/pom.xml   |  38 
 .../edge}/AuthenticationEndpoint.java  |   2 +-
 .../cse.bean.xml => api/edge-service/pom.xml}  |  25 ++-
 authentication/api/edge-service/service/pom.xml|  42 +
 .../authentication/edge}/AuthHandler.java  |   2 +-
 .../authentication/edge}/AuthenticationFilter.java |   2 +-
 .../edge}/CustomVertxRestDispatcher.java   |   2 +-
 .../edge}/InternalAccessHandler.java   |   2 +-
 ...servicecomb.common.rest.filter.HttpServerFilter |   2 +-
 ...ecomb.transport.rest.vertx.VertxHttpDispatcher} |   2 +-
 .../src/main/resources/config/cse.handler.xml  |   4 +-
 authentication/api/pom.xml |   4 +-
 .../endpoint/pom.xml   |   6 +-
 .../pom.xml|   2 +-
 authentication/api/resource-server/service/pom.xml |  42 +
 .../resource/AccessConfiguration.java  |   0
 .../resource/AccessConfigurationManager.java   |   0
 ...eptionExceptionToProducerResponseConverter.java |   0
 .../resource/ResourceAuthHandler.java  |   0
 .../resource/SimpleAuthentication.java |   0
 exception.ExceptionToProducerResponseConverter |   0
 .../src/main/resources/config/cse.handler.xml  |   0
 .../{ => samples}/AuthenticationServer/pom.xml |   8 +-
 .../AuthenticationConfiguration.java   |   0
 .../authentication/AuthenticationServerMain.java   |   0
 .../service/AuthenticationServiceImpl.java |   0
 .../src/main/resources/log4j2.xml  |   0
 .../src/main/resources/microservice.yaml   |   0
 authentication/{ => samples}/Client/pom.xml|   9 +-
 .../authentication/AuthenticationClientMain.java   |   0
 .../authentication/AuthenticationTestCase.java |   0
 .../authentication/BootEventListener.java  |   0
 .../authentication/GateRestTemplate.java   |   0
 .../authentication/ITUriTemplateHandler.java   |   0
 .../servicecomb/authentication/TestCase.java   |   0
 .../servicecomb/authentication/TestEndpoint.java   |   0
 .../apache/servicecomb/authentication/TestMgr.java |   0
 .../Client/src/main/resources/log4j2.xml   |   0
 .../Client/src/main/resources/microservice.yaml|   0
 .../{Gateway => samples/EdgeService}/pom.xml   |  15 +-
 .../authentication/gateway/ApiDispatcher.java  |   0
 .../gateway/AuthenticationConfiguration.java   |   0
 .../gateway/AuthenticationEdgeMain.java}   |   2 +-
 .../authentication/gateway/EdgeSSLCustom.java  |   0
 .../gateway/StaticWebpageDispatcher.java   |   0
 ...cecomb.transport.rest.vertx.VertxHttpDispatcher |   3 +-
 .../EdgeService}/src/main/resources/log4j2.xml |   0
 .../src/main/resources/microservice.yaml   |   0
 .../src/main/resources/ui/css/style.css|   0
 .../src/main/resources/ui/js/jquery-1.11.1.min.js  |   0
 .../EdgeService}/src/main/resources/ui/js/login.js |   0
 .../src/main/resources/ui/js/upload.js |   0
 .../EdgeService}/src/main/resources/ui/login.html  |   0
 .../EdgeService}/src/main/resources/ui/upload.html |   0
 .../authentication/test/PatternTest.java   |   0
 .../{ => samples}/ResourceServer/pom.xml   |  22 +--
 .../resource/AuthenticationConfiguration.java  |   0
 .../authentication/resource/FileEndpoint.java  |   0
 .../authentication/resource/FileStoreService.java  |   0
 .../resource/HandlerAuthEndpoint.java  |   0
 .../resource/LocalFileStoreService.java|   0
 .../resource/MethodSecurityConfiguration.java  |   0
 .../resource/PreMethodAuthEndpoint.java|   0
 .../resource}/ResourceServerMain.java  |   2 +-
 .../ResourceServer}/src/main/resources/log4j2.xml  |   0
 .../src/main/resources/microservice.yaml   |   0
 authentication/{api => samples}/pom.xml|   6 +-
 78 files changed, 194

[servicecomb-samples] 03/03: using oauth 2 password mode to grant tokens

2019-05-20 Thread liubao 
This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-samples.git

commit db8821565eb92ad727d0cc0076d231fa7c87d4ce
Author: liubao 
AuthorDate: Fri May 17 17:12:32 2019 +0800

using oauth 2 password mode to grant tokens
---
 authentication/README.md   |  4 +-
 .../TokenEndpoint.java}| 68 +-
 .../authentication/{api => server}/Token.java  |  2 +-
 .../TokenConst.java}   | 23 +++-
 .../TokenService.java} | 19 ++
 .../edge/AuthenticationEndpoint.java   | 44 --
 .../edge/CustomVertxRestDispatcher.java|  1 +
 ...cecomb.transport.rest.vertx.VertxHttpDispatcher |  2 +-
 .../authentication/AuthenticationTestCase.java | 12 ++--
 .../authentication/BootEventListener.java  | 12 ++--
 .../authentication/gateway/ApiDispatcher.java  |  1 +
 .../src/main/resources/microservice.yaml   |  2 +-
 12 files changed, 74 insertions(+), 116 deletions(-)

diff --git a/authentication/README.md b/authentication/README.md
index 2274bb4..6d477bb 100644
--- a/authentication/README.md
+++ b/authentication/README.md
@@ -87,4 +87,6 @@ http://localhost:9093/v1/test/start
 
 测试项目同时展示了这个项目的功能，比如： AuthenticationTestCase 的测试逻辑展示了基本的认证功能，从登陆，到接口的权限检查。 
 
-
+# TODO LIST
+1. provide TLS for authentication server & edge service
+2. grant scope for INTERNAL access & EXTERNAL access 
diff --git 
a/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
 
b/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/TokenEndpoint.java
similarity index 51%
rename from 
authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
rename to 
authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/TokenEndpoint.java
index c777bc5..67c7ba4 100644
--- 
a/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
+++ 
b/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/TokenEndpoint.java
@@ -15,26 +15,32 @@
  * limitations under the License.
  */
 
-package org.apache.servicecomb.authentication.api;
+package org.apache.servicecomb.authentication.server;
+
+import java.util.Map;
+
+import javax.ws.rs.core.MediaType;
 
 import org.apache.servicecomb.authentication.jwt.JWTClaims;
 import org.apache.servicecomb.authentication.jwt.JsonParser;
 import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.security.core.userdetails.UserDetails;
 import org.springframework.security.core.userdetails.UserDetailsService;
+import org.springframework.security.core.userdetails.UsernameNotFoundException;
 import org.springframework.security.crypto.password.PasswordEncoder;
 import org.springframework.security.jwt.Jwt;
 import org.springframework.security.jwt.JwtHelper;
 import org.springframework.security.jwt.crypto.sign.Signer;
 import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestParam;
 
-@RestSchema(schemaId = "AuthenticationEndpoint")
-@RequestMapping(path = "/v1/auth")
-public class AuthenticationEndpoint implements AuthenticationService {
+@RestSchema(schemaId = "TokenEndpoint")
+@RequestMapping(path = "/v1/oauth/token")
+public class TokenEndpoint implements TokenService {
   @Autowired
   @Qualifier("authUserDetailsService")
   private UserDetailsService userDetailsService;
@@ -48,33 +54,41 @@ public class AuthenticationEndpoint implements 
AuthenticationService {
   private Signer signer;
 
   @Override
-  @PostMapping(path = "login")
-  public Token login(@RequestParam(name = "userName") String userName,
-  @RequestParam(name = "password") String password) {
-UserDetails userDetails = userDetailsService.loadUserByUsername(userName);
-if (passwordEncoder.matches(password, userDetails.getPassword())) {
-  JWTClaims claims = new JWTClaims();
-  if (userDetails.getAuthorities() != null) {
-userDetails.getAuthorities().forEach(authority -> 
claims.addAuthority(authority.getAuthority()));
-  }
-  String content = JsonParser.unparse(claims);
-  Jwt accessToken = JwtHelper.encode(content, signer);
+  @PostMapping(path

[servicecomb-samples] branch master updated (8e5bdc9 -> db88215)

2019-05-20 Thread liubao 
This is an automated email from the ASF dual-hosted git repository.

liubao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-samples.git.


from 8e5bdc9  add project index
 new 161f796  refract project structures
 new ab23af1  provide default authentication service implementation
 new db88215  using oauth 2 password mode to grant tokens

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../service/AuthenticationServiceImpl.java |  75 
 .../main/resources/META-INF/spring/user.bean.xml   |  24 ---
 .../gateway/AuthenticationEndpoint.java|  44 -
 .../main/resources/META-INF/spring/cse.bean.xml|  27 ---
 authentication/README.md   |   4 +-
 .../resources/META-INF/spring/resource.bean.xml|  30 ---
 .../authentication/api/AuthenticationEndpoint.java |  42 -
 .../authentication/api/AuthenticationService.java  |  35 
 .../endpoint/pom.xml   |   5 +
 .../authentication/server/TokenEndpoint.java   |  94 ++
 .../pom.xml|   0
 .../service/pom.xml|   0
 .../servicecomb/authentication/server}/Token.java  |   2 +-
 .../authentication/server/TokenConst.java} |  12 +-
 .../authentication/server/TokenService.java}   |  10 +-
 .../samples/porter/file/api/InspectorEndpoint.java | 206 -
 .../samples/porter/file/api/LogEndpoint.java   |  72 ---
 authentication/api/edge-service/endpoint/pom.xml   |  38 
 .../{AuthenticationServer => edge-service}/pom.xml |   2 +-
 authentication/api/edge-service/service/pom.xml|  42 +
 .../authentication/edge}/AuthHandler.java  |   2 +-
 .../authentication/edge}/AuthenticationFilter.java |   2 +-
 .../edge}/CustomVertxRestDispatcher.java   |   3 +-
 .../edge}/InternalAccessHandler.java   |   2 +-
 ...servicecomb.common.rest.filter.HttpServerFilter |   2 +-
 ...ecomb.transport.rest.vertx.VertxHttpDispatcher} |   2 +-
 .../src/main/resources/config/cse.handler.xml  |   4 +-
 authentication/api/pom.xml |   4 +-
 .../endpoint/pom.xml   |   6 +-
 .../pom.xml|   2 +-
 authentication/api/resource-server/service/pom.xml |  42 +
 .../resource/AccessConfiguration.java  |   0
 .../resource/AccessConfigurationManager.java   |   0
 ...eptionExceptionToProducerResponseConverter.java |   0
 .../resource/ResourceAuthHandler.java  |   0
 .../resource/SimpleAuthentication.java |   0
 exception.ExceptionToProducerResponseConverter |   0
 .../src/main/resources/config/cse.handler.xml  |   0
 .../{ => samples}/AuthenticationServer/pom.xml |   8 +-
 .../AuthenticationConfiguration.java   |   0
 .../authentication/AuthenticationServerMain.java   |   0
 .../src/main/resources/log4j2.xml  |   0
 .../src/main/resources/microservice.yaml   |   0
 authentication/{ => samples}/Client/pom.xml|   9 +-
 .../authentication/AuthenticationClientMain.java   |   0
 .../authentication/AuthenticationTestCase.java |  12 +-
 .../authentication/BootEventListener.java  |  12 +-
 .../authentication/GateRestTemplate.java   |   0
 .../authentication/ITUriTemplateHandler.java   |   0
 .../servicecomb/authentication/TestCase.java   |   0
 .../servicecomb/authentication/TestEndpoint.java   |   0
 .../apache/servicecomb/authentication/TestMgr.java |   0
 .../Client/src/main/resources/log4j2.xml   |   0
 .../Client/src/main/resources/microservice.yaml|   0
 .../{Gateway => samples/EdgeService}/pom.xml   |  15 +-
 .../authentication/gateway/ApiDispatcher.java  |   1 +
 .../gateway/AuthenticationConfiguration.java   |   0
 .../gateway/AuthenticationEdgeMain.java}   |   2 +-
 .../authentication/gateway/EdgeSSLCustom.java  |   0
 .../gateway/StaticWebpageDispatcher.java   |   0
 ...cecomb.transport.rest.vertx.VertxHttpDispatcher |   3 +-
 .../EdgeService}/src/main/resources/log4j2.xml |   0
 .../src/main/resources/microservice.yaml   |   2 +-
 .../src/main/resources/ui/css/style.css|   0
 .../src/main/resources/ui/js/jquery-1.11.1.min.js  |   0
 .../EdgeService}/src/main/resources/ui/js/login.js |   0
 .../src/main/resources/ui/js/upload.js |   0
 .../EdgeService}/src/main/resources/ui/login.html  |   0
 .../EdgeService}/src/main/resources/ui/upload.html |   0
 .../authentication/test/PatternTest.java   |   0
 .../{ => samples}/ResourceServer/pom.xml   |  22 +--
 .../resource/AuthenticationConfiguration.java  |

[servicecomb-samples] 02/03: provide default authentication service implementation

2019-05-20 Thread liubao 
This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-samples.git

commit ab23af153a31eca1daa4406797caa80d89250c26
Author: liubao 
AuthorDate: Fri May 17 11:35:41 2019 +0800

provide default authentication service implementation
---
 .../api/authentication-server/endpoint/pom.xml |  5 ++
 .../authentication/api/AuthenticationEndpoint.java | 46 +++--
 .../service/AuthenticationServiceImpl.java | 75 --
 3 files changed, 47 insertions(+), 79 deletions(-)

diff --git a/authentication/api/authentication-server/endpoint/pom.xml 
b/authentication/api/authentication-server/endpoint/pom.xml
index 5eebece..a653462 100644
--- a/authentication/api/authentication-server/endpoint/pom.xml
+++ b/authentication/api/authentication-server/endpoint/pom.xml
@@ -34,5 +34,10 @@
   authentication-server-api-service
   ${project.parent.version}
 
+
+  org.apache.servicecomb.authentication
+  authentication-common-api-service
+  ${project.parent.version}
+
   
 
diff --git 
a/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
 
b/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
index 5177aeb..c777bc5 100644
--- 
a/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
+++ 
b/authentication/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/api/AuthenticationEndpoint.java
@@ -17,26 +17,64 @@
 
 package org.apache.servicecomb.authentication.api;
 
+import org.apache.servicecomb.authentication.jwt.JWTClaims;
+import org.apache.servicecomb.authentication.jwt.JsonParser;
 import org.apache.servicecomb.provider.rest.common.RestSchema;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Qualifier;
+import org.springframework.security.core.userdetails.UserDetails;
+import org.springframework.security.core.userdetails.UserDetailsService;
+import org.springframework.security.crypto.password.PasswordEncoder;
+import org.springframework.security.jwt.Jwt;
+import org.springframework.security.jwt.JwtHelper;
+import org.springframework.security.jwt.crypto.sign.Signer;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestParam;
 
 @RestSchema(schemaId = "AuthenticationEndpoint")
 @RequestMapping(path = "/v1/auth")
-public class AuthenticationEndpoint {
+public class AuthenticationEndpoint implements AuthenticationService {
   @Autowired
-  private AuthenticationService authenticationService;
+  @Qualifier("authUserDetailsService")
+  private UserDetailsService userDetailsService;
 
+  @Autowired
+  @Qualifier("authPasswordEncoder")
+  private PasswordEncoder passwordEncoder;
+
+  @Autowired
+  @Qualifier("authSigner")
+  private Signer signer;
+
+  @Override
   @PostMapping(path = "login")
   public Token login(@RequestParam(name = "userName") String userName,
   @RequestParam(name = "password") String password) {
-return authenticationService.login(userName, password);
+UserDetails userDetails = userDetailsService.loadUserByUsername(userName);
+if (passwordEncoder.matches(password, userDetails.getPassword())) {
+  JWTClaims claims = new JWTClaims();
+  if (userDetails.getAuthorities() != null) {
+userDetails.getAuthorities().forEach(authority -> 
claims.addAuthority(authority.getAuthority()));
+  }
+  String content = JsonParser.unparse(claims);
+  Jwt accessToken = JwtHelper.encode(content, signer);
+
+  Token token = new Token();
+  token.setScope(claims.getScope());
+  token.setExpires_in(10 * 60);
+  token.setToken_type("bearer");
+  token.setAccess_token(accessToken.getEncoded());
+  return token;
+} else {
+  return null;
+}
   }
 
+  @Override
   @PostMapping(path = "refresh")
   public Token refresh(@RequestParam(name = "refreshToken") String 
refreshToken) {
-return authenticationService.refresh(refreshToken);
+return null;
   }
+
 }
diff --git 
a/authentication/samples/AuthenticationServer/src/main/java/org/apache/servicecomb/authentication/service/AuthenticationServiceImpl.java
 
b/authentication/samples/AuthenticationServer/src/main/java/org/apache/servicecomb/authentication/service/AuthenticationServiceImpl.java
deleted file mode 100644
index cfbe22b..000
--- 
a/authentication/samples/AuthenticationServer/src/main/java/org/apache/servicecomb/authentication/service/AuthenticationServiceImpl.java
+++ /dev/null
@@ -1,75 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [servicecomb-samples] liubao68 merged pull request #8: refract project structures

2019-05-20 Thread GitBox 
liubao68 merged pull request #8: refract project structures
URL: https://github.com/apache/servicecomb-samples/pull/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-website] branch asf-site updated (f521976 -> 50f8e28)

2019-05-20 Thread ningjiang 
This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git.


from f521976  Publish the website
 add b473d45  Update release information for Java-Chassis 1.2.1
 new 9bfc3e6  Merge branch 'master' into asf-site
 new 50f8e28  Publish the website

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 _pages/cn/home.md  |  2 +-
 _pages/home.md |  2 +-
 _release/cn/java_chassis_downloads.md  |  3 +-
 _release/cn/java_chassis_releaseNotes.md   | 44 
 _release/cn/release.md |  3 +-
 _release/java_chassis_downloads.md |  3 +-
 _release/java_chassis_releaseNotes.md  | 45 +
 _release/release.md|  3 +-
 content/cn/index.html  |  2 +-
 content/cn/release/index.html  |  3 +-
 .../cn/release/java-chassis-downloads/index.html   |  8 +++-
 .../release/java-chassis-release-notes/index.html  | 47 +-
 content/feed.xml   |  2 +-
 content/index.html |  2 +-
 content/release/index.html |  3 +-
 content/release/java-chassis-downloads/index.html  |  8 +++-
 .../release/java-chassis-release-notes/index.html  | 47 +-
 17 files changed, 212 insertions(+), 15 deletions(-)

[servicecomb-website] 02/02: Publish the website

2019-05-20 Thread ningjiang 
This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git

commit 50f8e28d572351b77a40405363519e40395c7b8f
Author: Willem Jiang 
AuthorDate: Mon May 20 19:38:35 2019 +0800

Publish the website
---
 content/cn/index.html  |  2 +-
 content/cn/release/index.html  |  3 +-
 .../cn/release/java-chassis-downloads/index.html   |  8 +++-
 .../release/java-chassis-release-notes/index.html  | 47 +-
 content/feed.xml   |  2 +-
 content/index.html |  2 +-
 content/release/index.html |  3 +-
 content/release/java-chassis-downloads/index.html  |  8 +++-
 .../release/java-chassis-release-notes/index.html  | 47 +-
 9 files changed, 113 insertions(+), 9 deletions(-)

diff --git a/content/cn/index.html b/content/cn/index.html
index 6fbda0a..16fcf04 100644
--- a/content/cn/index.html
+++ b/content/cn/index.html
@@ -293,7 +293,7 @@
   
 
   最新新闻
-  Apache ServiceComb Pack 发布式版 
0.4.0   Apache ServiceComb 
Saga 发布最新版 0.2.1   Apache ServiceComb Saga Actuator 
发布最新版 0.3.0   Apache ServiceComb 
荣获中国开源云联盟组织的中国优秀开源项目一等奖  
+  Apache ServiceComb Java-Chassis 1.2.1 is 
released   Apache 
ServiceComb Saga 发布最新版 0.2.1   Apache ServiceComb Saga Actuator 
发布最新版 0.3.0   Apache ServiceComb 
荣获中国开源云联盟组织的中国优秀开源项目一等奖  
   Apache ServiceComb 发布正式版 1.2.0   
https://gitter.im/ServiceCombUsers/Lobby;>欢迎加入 Apache ServiceComb 
社区Gitter即时聊天室   Apache ServiceComb 
社区开发团队   Apache ServiceComb 
社区联合传智播客的黑马程序员、博学谷、传智汇子品牌发布微服务化教程  
 
 
diff --git a/content/cn/release/index.html b/content/cn/release/index.html
index b013c7f..ae5a539 100644
--- a/content/cn/release/index.html
+++ b/content/cn/release/index.html
@@ -431,7 +431,7 @@
 
 
   
-https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.0/;
 target="_blank">ServiceComb Java-Chassis 1.2.0 (released on 2019-04-12)
+https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.1/;
 target="_blank">ServiceComb Java-Chassis 1.2.1 (released on 2019-05-19)
   
   
 https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/;
 target="_blank">ServiceComb Service-Center 1.2.0 (released on 
2019-04-06)
@@ -456,6 +456,7 @@
   
 http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/;
 target="_blank">ServiceComb Service-Center 1.0.0-m1 (released on 
2018-03-27)
   
+  https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.0/;
 target="_blank">ServiceComb Java-Chassis 1.2.0 (released on 
2019-04-12)
   https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.1.0/;
 target="_blank">ServiceComb Java-Chassis 1.1.0 (released on 
2018-11-30)
   http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/;
 target="_blank">ServiceComb Java-Chassis 1.0.0 (released on 
2018-08-02)
   http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/;
 target="_blank">ServiceComb Java-Chassis 1.0.0-m2 (released on 
2018-06-21)
diff --git a/content/cn/release/java-chassis-downloads/index.html 
b/content/cn/release/java-chassis-downloads/index.html
index 22bc215..dbca19c 100644
--- a/content/cn/release/java-chassis-downloads/index.html
+++ b/content/cn/release/java-chassis-downloads/index.html
@@ -436,7 +436,13 @@
   
   
 
-  Apache ServiceComb Java-Chassis 1.2.0 (Latest)
+  Apache ServiceComb Java-Chassis 1.2.1 (Latest)
+  https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-src.zip;>[src]
 https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-src.zip.asc;>[asc]
 https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-src.zip.sha512;>[sha512]
+  https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-bin.zip;>[Binary]
 https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-bin.zip.asc;>[asc]
 https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-bin.zip.sha512;>[sha512]
+  Service-Center 1.0.0 or above
+
+
+  Apache ServiceComb Java-Chassis 1.2.0
   https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip;>[src]

[servicecomb-website] 01/02: Merge branch 'master' into asf-site

2019-05-20 Thread ningjiang 
This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git

commit 9bfc3e6b74a5f7d787acb4a1e735428ff1e8fc28
Merge: f521976 b473d45
Author: Willem Jiang 
AuthorDate: Mon May 20 19:37:39 2019 +0800

Merge branch 'master' into asf-site

 _pages/cn/home.md|  2 +-
 _pages/home.md   |  2 +-
 _release/cn/java_chassis_downloads.md|  3 ++-
 _release/cn/java_chassis_releaseNotes.md | 44 +++
 _release/cn/release.md   |  3 ++-
 _release/java_chassis_downloads.md   |  3 ++-
 _release/java_chassis_releaseNotes.md| 45 
 _release/release.md  |  3 ++-
 8 files changed, 99 insertions(+), 6 deletions(-)

[servicecomb-website] branch master updated: Update release information for Java-Chassis 1.2.1

2019-05-20 Thread ningjiang 
This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git


The following commit(s) were added to refs/heads/master by this push:
 new b473d45  Update release information for Java-Chassis 1.2.1
b473d45 is described below

commit b473d45cb0b0af54acb490ab548f96d92e4c4f68
Author: asifdxtreme 
AuthorDate: Mon May 20 14:55:17 2019 +0530

Update release information for Java-Chassis 1.2.1
---
 _pages/cn/home.md|  2 +-
 _pages/home.md   |  2 +-
 _release/cn/java_chassis_downloads.md|  3 ++-
 _release/cn/java_chassis_releaseNotes.md | 44 +++
 _release/cn/release.md   |  3 ++-
 _release/java_chassis_downloads.md   |  3 ++-
 _release/java_chassis_releaseNotes.md| 45 
 _release/release.md  |  3 ++-
 8 files changed, 99 insertions(+), 6 deletions(-)

diff --git a/_pages/cn/home.md b/_pages/cn/home.md
index c36defc..8e7fe5a 100755
--- a/_pages/cn/home.md
+++ b/_pages/cn/home.md
@@ -20,7 +20,7 @@ intro:
 
 
   
-Apache ServiceComb Pack 发布式版 
0.4.0
+Apache ServiceComb Java-Chassis 1.2.1 is 
released
   
   
 Apache ServiceComb Saga 发布最新版 
0.2.1
diff --git a/_pages/home.md b/_pages/home.md
index b6f2508..ccabdb8 100755
--- a/_pages/home.md
+++ b/_pages/home.md
@@ -19,7 +19,7 @@ intro:
 
 
   
-Apache ServiceComb Release Pack 
0.4.0
+Apache ServiceComb Java-Chassis 1.2.1 is released
   
   
 Apache ServiceComb Saga 
Actuator releases a new version 0.3.0
diff --git a/_release/cn/java_chassis_downloads.md 
b/_release/cn/java_chassis_downloads.md
index e22fc59..28bf83d 100644
--- a/_release/cn/java_chassis_downloads.md
+++ b/_release/cn/java_chassis_downloads.md
@@ -11,7 +11,8 @@ last_modified_at: 2019-04-12T00:50:43-55:00
 
 | Release   | 源码|   发布包 |  
 Recommended Version of Service-Center |
 | -- | - | 
- | - |
-|**Apache ServiceComb Java-Chassis 1.2.0 
(Latest)**|[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip)
 
[[asc]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip.asc)
 
[[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip.sha512)|[[B
 [...]
+|**Apache ServiceComb Java-Chassis 1.2.1 
(Latest)**|[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-src.zip)
 
[[asc]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-src.zip.asc)
 
[[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.1/apache-servicecomb-java-chassis-distribution-1.2.1-src.zip.sha512)|[[B
 [...]
+|Apache ServiceComb Java-Chassis 
1.2.0|[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip)
 
[[asc]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip.asc)
 
[[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.2.0/apache-servicecomb-java-chassis-distribution-1.2.0-src.zip.sha512)|[[Binary]](https
 [...]
 |Apache ServiceComb Java-Chassis 
1.1.0|[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.1.0/apache-servicecomb-java-chassis-distribution-1.1.0-src.zip)
 
[[asc]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.1.0/apache-servicecomb-java-chassis-distribution-1.1.0-src.zip.asc)
 
[[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-java-chassis/1.1.0/apache-servicecomb-java-chassis-distribution-1.1.0-src.zip.sha512)|[[Binary]](https
 [...]
 |Apache ServiceComb (incubating) Java-Chassis 
1.0.0|[[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-src.zip)
 
[[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-src.zip.asc)
 
[[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java
 [...]
 |Apache ServiceComb (incubating) Java-Chassis 
1.0.0-m2|[[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-src.zip)

[GitHub] [servicecomb-website] WillemJiang merged pull request #179: Update release information for Java-Chassis 1.2.1

2019-05-20 Thread GitBox 
WillemJiang merged pull request #179: Update release information for 
Java-Chassis 1.2.1
URL: https://github.com/apache/servicecomb-website/pull/179
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls edited a comment on issue #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
coveralls edited a comment on issue #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470#issuecomment-493862531
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23487413/badge)](https://coveralls.io/builds/23487413)
   
   Coverage decreased (-0.08%) to 90.149% when pulling 
**fefc2f8fd0324a5cd467a5eea205539e7427f096 on 
cmonkey:feature/acceptance-pack-spring-demo-with-zookeeper** into 
**d7125d3cf3ce6c8fc5d172073ee34190f03f81ed on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-website] asifdxtreme opened a new pull request #179: Update release information for Java-Chassis 1.2.1

2019-05-20 Thread GitBox 
asifdxtreme opened a new pull request #179: Update release information for 
Java-Chassis 1.2.1
URL: https://github.com/apache/servicecomb-website/pull/179
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls edited a comment on issue #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
coveralls edited a comment on issue #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470#issuecomment-493862531
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23486514/badge)](https://coveralls.io/builds/23486514)
   
   Coverage decreased (-0.08%) to 90.149% when pulling 
**f1fbf267b5566e5c2fa0bfcf279a417e9f80faba on 
cmonkey:feature/acceptance-pack-spring-demo-with-zookeeper** into 
**d7125d3cf3ce6c8fc5d172073ee34190f03f81ed on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls edited a comment on issue #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
coveralls edited a comment on issue #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470#issuecomment-493862531
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23486491/badge)](https://coveralls.io/builds/23486491)
   
   Coverage decreased (-0.08%) to 90.149% when pulling 
**f1fbf267b5566e5c2fa0bfcf279a417e9f80faba on 
cmonkey:feature/acceptance-pack-spring-demo-with-zookeeper** into 
**d7125d3cf3ce6c8fc5d172073ee34190f03f81ed on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] cmonkey opened a new pull request #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
cmonkey opened a new pull request #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] cmonkey closed pull request #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
cmonkey closed pull request #470: Feature/acceptance pack spring demo with 
zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] yhs0092 commented on issue #1215: The CseClientHttpRequest automatically adds the path variable named ‘null’.

2019-05-20 Thread GitBox 
yhs0092 commented on issue #1215: The CseClientHttpRequest automatically adds 
the path variable named ‘null’.
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1215#issuecomment-493883918
 
 
   An Apache jira issue is created to track it 
[SCB-1289](https://issues.apache.org/jira/browse/SCB-1289)
   Could you please provide a PR to fix it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liangrongjie commented on issue #1215: The CseClientHttpRequest automatically adds the path variable named ‘null’.

2019-05-20 Thread GitBox 
liangrongjie commented on issue #1215: The CseClientHttpRequest automatically 
adds the path variable named ‘null’.
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1215#issuecomment-493883874
 
 
   https://issues.apache.org/jira/browse/SCB-1289


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liangrongjie opened a new issue #1215: The CseClientHttpRequest automatically adds the path variable named ‘null’.

2019-05-20 Thread GitBox 
liangrongjie opened a new issue #1215: The CseClientHttpRequest automatically 
adds the path variable named ‘null’.
URL: https://github.com/apache/servicecomb-java-chassis/issues/1215
 
 
   When the Cse is used as the client to send a request without the path 
variable to other microservices, the cse automatically adds a redundant 
variable named "null".
   
   The original path`/v1/countries` is changed to `/v1/countries?null`.
   
   The code is in the 
`org.apache.servicecomb.provider.springmvc.reference.CseClientHttpRequest#prepareInvocation(Object[])`
   ```java
   invocation.getHandlerContext().put(RestConst.REST_CLIENT_REQUEST_PATH,
   path + "?" + this.uri.getRawQuery());
   ```
   
   when request path  without the path variable, the ` this.uri.getRawQuery()` 
return null (*not string ""*)；executes the request at the 
`org.apache.servicecomb.transport.rest.client.http.RestClientInvocation#createRequestPath(RestOperationMeta)`
   obtained incorrect path from invocation.handlerContext.
   
   ```java
   String path = (String) 
invocation.getHandlerContext().get(RestConst.REST_CLIENT_REQUEST_PATH);
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] solomoni0999 opened a new issue #1214: Customer无法获取Provider的服务地址

2019-05-20 Thread GitBox 
solomoni0999 opened a new issue #1214: Customer无法获取Provider的服务地址
URL: https://github.com/apache/servicecomb-java-chassis/issues/1214
 
 
   
   消费者无法获取生产者地址，消费者和生产者都成功注册到服务中心，且都已经配置env模式
   
   Caused by: org.apache.servicecomb.core.exception.CseException: No available 
address found. microserviceName=agentmanager, version=0.0.0+, 
discoveryGroupName=0.0.0+/0.0.1+/instancesNoMatch/
   at 
org.apache.servicecomb.core.exception.ExceptionUtils.createCseException(ExceptionUtils.java:57)
 ~[java-chassis-core-1.1.0.jar:1.1.0]
   at 
org.apache.servicecomb.core.exception.ExceptionUtils.lbAddressNotFound(ExceptionUtils.java:88)
 ~[java-chassis-core-1.1.0.jar:1.1.0]
   ... 91 common frames omitted
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls edited a comment on issue #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
coveralls edited a comment on issue #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470#issuecomment-493862531
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23484218/badge)](https://coveralls.io/builds/23484218)
   
   Coverage decreased (-0.2%) to 90.031% when pulling 
**a2d6aa4c3e41bd4e7aaec0f8899836d0273cccab on 
cmonkey:feature/acceptance-pack-spring-demo-with-zookeeper** into 
**d7125d3cf3ce6c8fc5d172073ee34190f03f81ed on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls commented on issue #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
coveralls commented on issue #470: Feature/acceptance pack spring demo with 
zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470#issuecomment-493862531
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/23484176/badge)](https://coveralls.io/builds/23484176)
   
   Coverage decreased (-0.08%) to 90.149% when pulling 
**a2d6aa4c3e41bd4e7aaec0f8899836d0273cccab on 
cmonkey:feature/acceptance-pack-spring-demo-with-zookeeper** into 
**d7125d3cf3ce6c8fc5d172073ee34190f03f81ed on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] cmonkey opened a new pull request #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
cmonkey opened a new pull request #470: Feature/acceptance pack spring demo 
with zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] cmonkey closed pull request #470: Feature/acceptance pack spring demo with zookeeper

2019-05-20 Thread GitBox 
cmonkey closed pull request #470: Feature/acceptance pack spring demo with 
zookeeper
URL: https://github.com/apache/servicecomb-pack/pull/470
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services