[GitHub] [servicecomb-website] kakulisen opened a new pull request #193: Update the home page
kakulisen opened a new pull request #193: Update the home page URL: https://github.com/apache/servicecomb-website/pull/193 Add the toolkit release 0.1.0 information and reorganize Latest News This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] 02/02: Publish the website
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit 7327b9f55aa4c13ca05b0cdc94903c0b1a96a633 Author: Willem Jiang AuthorDate: Tue Sep 3 10:10:13 2019 +0800 Publish the website --- content/cn/developers/index.html | 2 +- content/cn/release/compatibleversion.html | 28 content/cn/release/index.html | 31 + .../cn/release/java-chassis-downloads/index.html | 28 .../release/java-chassis-release-notes/index.html | 28 content/cn/release/pack-downloads/index.html | 28 content/cn/release/pack-release-notes/index.html | 28 .../cn/release/saga-actuator-downloads/index.html | 28 .../release/saga-actuator-release-notes/index.html | 28 content/cn/release/saga-downloads/index.html | 28 content/cn/release/saga-release-notes/index.html | 28 .../cn/release/service-center-downloads/index.html | 28 .../service-center-release-notes/index.html| 28 .../index.html | 103 +-- .../index.html | 133 ++- content/feed.xml | 2 +- content/release/compatibleversion.html | 28 content/release/index.html | 28 content/release/java-chassis-downloads/index.html | 28 .../release/java-chassis-release-notes/index.html | 28 content/release/pack-downloads/index.html | 28 content/release/pack-release-notes/index.html | 28 content/release/saga-actuator-downloads/index.html | 28 .../release/saga-actuator-release-notes/index.html | 28 content/release/saga-downloads/index.html | 28 content/release/saga-release-notes/index.html | 28 .../release/service-center-downloads/index.html| 28 .../service-center-release-notes/index.html| 28 .../index.html | 74 +++ .../index.html | 133 ++- content/sitemap.xml| 146 - 31 files changed, 1073 insertions(+), 195 deletions(-) diff --git a/content/cn/developers/index.html b/content/cn/developers/index.html index 71d06b1..6a6ee3b 100644 --- a/content/cn/developers/index.html +++ b/content/cn/developers/index.html @@ -470,7 +470,7 @@ Golang - https://github.com/apache/servicecomb-tool-kit;>servicecomb-tool-kit + https://github.com/apache/servicecomb-toolkit;>servicecomb-toolkit 基于契约的微服务开发工具 Java diff --git a/content/cn/release/compatibleversion.html b/content/cn/release/compatibleversion.html index 051670a..184ba44 100644 --- a/content/cn/release/compatibleversion.html +++ b/content/cn/release/compatibleversion.html @@ -341,6 +341,34 @@ + Toolkit + + + + + + + + + + + +Release Notes + + + + + + + +Downloads + + + + + + + Saga Actuator diff --git a/content/cn/release/index.html b/content/cn/release/index.html index a2324d0..4c4b5b0 100644 --- a/content/cn/release/index.html +++ b/content/cn/release/index.html @@ -342,6 +342,34 @@ + Toolkit + + + + + + + + + + + +发布说明 + + + + + + + +发布包 + + + + + + + Saga Actuator @@ -431,6 +459,9 @@ +https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-toolkit/0.1.0/; target="_blank">ServiceComb Toolkit 0.1.0 (released on 2019-08-31) + + https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-pack/0.5.0/; target="_blank">ServiceComb Pack 0.5.0 (released on 2019-08-26) diff --git a/content/cn/release/java-chassis-downloads/index.html b/content/cn/release/java-chassis-downloads/index.html index b376e8c..17c6981 100644 --- a/content/cn/release/java-chassis-downloads/index.html +++ b/content/cn/release/java-chassis-downloads/index.html @@ -342,6 +342,34 @@ + Toolkit + + + + + + + + + + + +发布说明 + + + + + + + +发布包 + + + + + + + Saga Actuator diff --git
[servicecomb-website] branch asf-site updated (64be702 -> 7327b9f)
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git.
from 64be702 Publish the website
add 0a0597f Update ServiceComb Toolkit 0.1.0 Release information
add a94b04b Merge pull request #192 from kakulisen/master
new cb7cf0a Merge branch 'master' into asf-site
new 7327b9f Publish the website
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
_data/navigation.yml | 12 ++
_developers/cn/developer-guide.md | 2 +-
_release/cn/release.md | 2 +
_release/cn/toolkit_downloads.md | 49 +++
_release/cn/toolkit_releaseNotes.md| 89 +
_release/toolkit_downloads.md | 50 +++
_release/toolkit_releaseNotes.md | 89 +
content/cn/developers/index.html | 2 +-
content/cn/release/compatibleversion.html | 28
content/cn/release/index.html | 31 +
.../cn/release/java-chassis-downloads/index.html | 28
.../release/java-chassis-release-notes/index.html | 28
content/cn/release/pack-downloads/index.html | 28
content/cn/release/pack-release-notes/index.html | 28
.../cn/release/saga-actuator-downloads/index.html | 28
.../release/saga-actuator-release-notes/index.html | 28
content/cn/release/saga-downloads/index.html | 28
content/cn/release/saga-release-notes/index.html | 28
.../cn/release/service-center-downloads/index.html | 28
.../service-center-release-notes/index.html| 28
.../index.html | 103 +--
.../index.html | 133 ++-
content/feed.xml | 2 +-
content/release/compatibleversion.html | 28
content/release/index.html | 28
content/release/java-chassis-downloads/index.html | 28
.../release/java-chassis-release-notes/index.html | 28
content/release/pack-downloads/index.html | 28
content/release/pack-release-notes/index.html | 28
content/release/saga-actuator-downloads/index.html | 28
.../release/saga-actuator-release-notes/index.html | 28
content/release/saga-downloads/index.html | 28
content/release/saga-release-notes/index.html | 28
.../release/service-center-downloads/index.html| 28
.../service-center-release-notes/index.html| 28
.../index.html | 74 +++
.../index.html | 133 ++-
content/sitemap.xml| 146 -
38 files changed, 1365 insertions(+), 196 deletions(-)
create mode 100644 _release/cn/toolkit_downloads.md
create mode 100644 _release/cn/toolkit_releaseNotes.md
create mode 100644 _release/toolkit_downloads.md
create mode 100644 _release/toolkit_releaseNotes.md
copy content/cn/release/{saga-actuator-downloads =>
toolkit-downloads}/index.html (80%)
copy content/cn/release/{saga-actuator-release-notes =>
toolkit-release-notes}/index.html (69%)
copy content/release/{saga-actuator-downloads => toolkit-downloads}/index.html
(84%)
copy content/release/{saga-actuator-release-notes =>
toolkit-release-notes}/index.html (68%)
[servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit cb7cf0a79ab932ffc5c3ba5864a3e6eb6869df21 Merge: 64be702 a94b04b Author: Willem Jiang AuthorDate: Tue Sep 3 10:08:58 2019 +0800 Merge branch 'master' into asf-site _data/navigation.yml| 12 + _developers/cn/developer-guide.md | 2 +- _release/cn/release.md | 2 + _release/cn/toolkit_downloads.md| 49 _release/cn/toolkit_releaseNotes.md | 89 + _release/toolkit_downloads.md | 50 + _release/toolkit_releaseNotes.md| 89 + 7 files changed, 292 insertions(+), 1 deletion(-)
[servicecomb-website] branch master updated: Update ServiceComb Toolkit 0.1.0 Release information
This is an automated email from the ASF dual-hosted git repository.
mabin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git
The following commit(s) were added to refs/heads/master by this push:
new 0a0597f Update ServiceComb Toolkit 0.1.0 Release information
new a94b04b Merge pull request #192 from kakulisen/master
0a0597f is described below
commit 0a0597fd00123a3957cb144063f9d35d10987f30
Author: kakulisen <18813972...@163.com>
AuthorDate: Mon Sep 2 16:26:32 2019 +0800
Update ServiceComb Toolkit 0.1.0 Release information
Signed-off-by: kakulisen <18813972...@163.com>
---
_data/navigation.yml| 12 +
_developers/cn/developer-guide.md | 2 +-
_release/cn/release.md | 2 +
_release/cn/toolkit_downloads.md| 49
_release/cn/toolkit_releaseNotes.md | 89 +
_release/toolkit_downloads.md | 50 +
_release/toolkit_releaseNotes.md| 89 +
7 files changed, 292 insertions(+), 1 deletion(-)
diff --git a/_data/navigation.yml b/_data/navigation.yml
index eeb1dfa..0403923 100755
--- a/_data/navigation.yml
+++ b/_data/navigation.yml
@@ -108,6 +108,12 @@ t:
url: /release/pack-release-notes/
- title: "Downloads"
url: /release/pack-downloads/
+ - title: "Toolkit"
+children:
+ - title: "Release Notes"
+url: /release/toolkit-release-notes/
+ - title: "Downloads"
+url: /release/toolkit-downloads/
- title: "Saga Actuator"
children:
- title: "Release Notes"
@@ -237,6 +243,12 @@ t:
url: /cn/release/pack-release-notes/
- title: "发布包"
url: /cn/release/pack-downloads/
+ - title: "Toolkit"
+children:
+ - title: "发布说明"
+url: /cn/release/toolkit-release-notes/
+ - title: "发布包"
+url: /cn/release/toolkit-downloads/
- title: "Saga Actuator"
children:
- title: "发布说明"
diff --git a/_developers/cn/developer-guide.md
b/_developers/cn/developer-guide.md
index f57a8df..20c60f4 100755
--- a/_developers/cn/developer-guide.md
+++ b/_developers/cn/developer-guide.md
@@ -17,7 +17,7 @@ last_modified_at: 2017-06-24T19:18:43+08:00
| [servicecomb-pack](https://github.com/apache/servicecomb-pack)
| 支持Saga/TCC等多协议的分布式事务方案 | Java |
| [servicecomb-mesher](https://github.com/apache/servicecomb-Mesher) |
微服务网格 | Golang|
| [servicecomb-kie](https://github.com/apache/servicecomb-kie)
| 微服务配置管理中心 | Golang|
-| [servicecomb-tool-kit](https://github.com/apache/servicecomb-tool-kit)
| 基于契约的微服务开发工具 | Java |
+| [servicecomb-toolkit](https://github.com/apache/servicecomb-toolkit)
| 基于契约的微服务开发工具 | Java |
| [servicecomb-samples](https://github.com/apache/servicecomb-samples)
| 提供了微服务示例 | Java |
| [servicecomb-fence](https://github.com/apache/servicecomb-fence)
| ServiceComb Java-chassis安全认证解决方案 | Java |
| [servicecomb-docs](https://github.com/apache/servicecomb-docs) |
ServiceComb用户手册| CSS |
diff --git a/_release/cn/release.md b/_release/cn/release.md
index ba754c3..d4c4d85 100755
--- a/_release/cn/release.md
+++ b/_release/cn/release.md
@@ -14,6 +14,8 @@ last_modified_at: 2019-04-06T00:50:43-55:00
**稳定发布版 - 最新版本:**
+* [ServiceComb Toolkit
0.1.0](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-toolkit/0.1.0/){:target="_blank"}
(released on 2019-08-31)
+
* [ServiceComb Pack
0.5.0](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-pack/0.5.0/){:target="_blank"}
(released on 2019-08-26)
* [ServiceComb Java-Chassis
1.2.1](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.1/){:target="_blank"}
(released on 2019-05-19)
diff --git a/_release/cn/toolkit_downloads.md b/_release/cn/toolkit_downloads.md
new file mode 100644
index 000..7ccb379
--- /dev/null
+++ b/_release/cn/toolkit_downloads.md
@@ -0,0 +1,49 @@
+---
+title: "ServiceComb Toolkit Downloads"
+lang: cn
+ref: release
+permalink: /cn/release/toolkit-downloads/
+excerpt: "ServiceComb Toolkit Downloads"
+last_modified_at: 2019-09-02T14:06:43-55:00
+---
+
+## 发布包
+
+| 版本号 | 源码|
+| -- | - |
- |
+|**Apache ServiceComb Toolkit
0.1.0(LATEST)**|[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-toolkit/0.1.0/apache-servicecomb-toolkit-distribution-0.1.0-src.zip)
[[asc]](https://www.apache.org/dist/servicecomb/servicecomb-toolkit/0.1.0/apache-servicecomb-toolkit-distribution-0.1.0-src.zip.asc)
[GitHub] [servicecomb-website] MabinGo merged pull request #192: Update ServiceComb Toolkit 0.1.0 Release information
MabinGo merged pull request #192: Update ServiceComb Toolkit 0.1.0 Release information URL: https://github.com/apache/servicecomb-website/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on issue #551: SagaStartAnnotationProcessorTimeoutWrapper NOT handle sagaStart.autoClose()
WillemJiang commented on issue #551: SagaStartAnnotationProcessorTimeoutWrapper NOT handle sagaStart.autoClose() URL: https://github.com/apache/servicecomb-pack/issues/551#issuecomment-527165542 Yes, We need to check the autoClose attribute to see if we need to send the SagaEnded Event to Alpha. I just created JIRA [SCB-1476](https://issues.apache.org/jira/browse/SCB-1476) to track this issue. Please feel free to submit a PR for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] jeremyxu2010 opened a new issue #551: SagaStartAnnotationProcessorTimeoutWrapper NOT handle sagaStart.autoClose()
jeremyxu2010 opened a new issue #551:
SagaStartAnnotationProcessorTimeoutWrapper NOT handle sagaStart.autoClose()
URL: https://github.com/apache/servicecomb-pack/issues/551
```java
public Object apply(ProceedingJoinPoint joinPoint, SagaStart sagaStart,
OmegaContext context)
throws Throwable {
final TimeoutProb timeoutProb = TimeoutProbManager.getInstance()
.addTimeoutProb(sagaStart.timeout());
Object output;
try {
Method method = ((MethodSignature)
joinPoint.getSignature()).getMethod();
sagaStartAnnotationProcessor.preIntercept(sagaStart.timeout());
if (LOG.isDebugEnabled()) {
LOG.debug("Initialized context {} before execution of method {}",
context,
method.toString());
}
try {
output = joinPoint.proceed();
if (timeoutProb.getInterruptFailureException() != null) {
throw new
OmegaException(timeoutProb.getInterruptFailureException());
}
sagaStartAnnotationProcessor.postIntercept(context.globalTxId());
if (LOG.isDebugEnabled()) {
LOG.debug("Transaction with context {} has finished.", context);
}
return output;
} catch (Throwable throwable) {
// TODO We still need to intercept some exceptions that we can't
judge the state of the child transaction.
// At this point, we don't need to send SagaAbortEvent, just need
to throw a TransactionTimeoutException
// For example, java.net.SocketTimeoutException, etc.
if (LOG.isDebugEnabled()) {
LOG.debug("TimeoutWrapper exception {}",
throwable.getClass().getName());
}
if (timeoutProb.getInterruptFailureException() != null) {
LOG.info("TimeoutProb interrupt fail");
throw timeoutProb.getInterruptFailureException();
} else if (isThreadInterruptException(throwable)) {
// We don't have to send an SagaAbortEvent
// Because the SagaActor state automatically change to suspended
when timeout.
throw new TransactionTimeoutException("Timeout interrupt",
throwable);
} else {
// We don't need to handle the OmegaException here
if (!(throwable instanceof OmegaException)) {
LOG.info("TimeoutWrapper Exception {}",
throwable.getClass().getName());
sagaStartAnnotationProcessor.onError(method.toString(),
throwable);
LOG.error("Transaction {} failed.", context.globalTxId());
}
}
throw throwable;
}
} finally {
context.clear();
TimeoutProbManager.getInstance().removeTimeoutProb(timeoutProb);
}
}
```
Should check `sagaStart.autoClose()`, decide to call
`sagaStartAnnotationProcessor.postIntercept(context.globalTxId());` or not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on issue #547: PackDubboConsumerFilter get null omegaContext
WillemJiang commented on issue #547: PackDubboConsumerFilter get null omegaContext URL: https://github.com/apache/servicecomb-pack/issues/547#issuecomment-527100783 是的OmegaContext可以通过SpringApplicationContext获得，如果Dubbo服务不是由Spring创建的话，需要自己显示完成OmegaContext注入的工作。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #28: [SCB-1474] Fix issue problem in client/client.go.
tianxiaoliang commented on a change in pull request #28: [SCB-1474] Fix issue
problem in client/client.go.
URL: https://github.com/apache/servicecomb-kie/pull/28#discussion_r319903560
##
File path: client/client.go
##
@@ -165,15 +167,12 @@ func (c *Client) SearchByLabels(ctx context.Context,
opts ...GetOption) ([]*mode
if options.Project == "" {
options.Project = defaultProject
}
- lableReq := "q="
- i := 1
+ lableReq := ByLabelsPrefix
Review comment:
ByLabelsPrefix -> QueryParamQ
the convention is use http param "query param","header" as const prefix
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] liulzz commented on issue #550: akka.actor.ActorNotFound: Actor not found for
liulzz commented on issue #550: akka.actor.ActorNotFound: Actor not found for URL: https://github.com/apache/servicecomb-pack/issues/550#issuecomment-527078383 > saga状态机模式 这个异常是什么原因？ 0.5.0版本中actor获取是同步阻塞的模式，一旦超时，就会throw一个ActorNotFound的runtimexception，需要调整actor获取的超时时间或者等下一个版本采用异步的方式 ``` private static final Timeout lookupTimeout = new Timeout(Duration.create(1, TimeUnit.SECONDS)); ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1316: [SCB-1475] ServiceCombServerStats.getFailedRate and getSuccessRate m…
coveralls commented on issue #1316: [SCB-1475] ServiceCombServerStats.getFailedRate and getSuccessRate m… URL: https://github.com/apache/servicecomb-java-chassis/pull/1316#issuecomment-527077800 [](https://coveralls.io/builds/25477872) Coverage remained the same at 85.869% when pulling **16f1fe0643818b36d26f123acaeff4fbe9f791fa on HuaiJoe:master** into **1b90a7b6368c8395c1fdc4101dca429bcf78586e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] MabinGo commented on issue #192: Update ServiceComb Toolkit 0.1.0 Release information
MabinGo commented on issue #192: Update ServiceComb Toolkit 0.1.0 Release information URL: https://github.com/apache/servicecomb-website/pull/192#issuecomment-527068546 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] HuaiJoe opened a new pull request #1316: [SCB-1475] ServiceCombServerStats.getFailedRate and getSuccessRate m…
HuaiJoe opened a new pull request #1316: [SCB-1475] ServiceCombServerStats.getFailedRate and getSuccessRate m… URL: https://github.com/apache/servicecomb-java-chassis/pull/1316 …ay arise an exception of java.lang.ArithmeticException: / by zero under concurrency scenarios Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] kakulisen opened a new pull request #192: Update ServiceComb Toolkit 0.1.0 Release information
kakulisen opened a new pull request #192: Update ServiceComb Toolkit 0.1.0 Release information URL: https://github.com/apache/servicecomb-website/pull/192 Update ServiceComb Toolkit 0.1.0 Release information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] Fxdemon commented on issue #550: akka.actor.ActorNotFound: Actor not found for
Fxdemon commented on issue #550: akka.actor.ActorNotFound: Actor not found for URL: https://github.com/apache/servicecomb-pack/issues/550#issuecomment-527036454 saga状态机模式 这个异常是什么原因？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] Fxdemon opened a new issue #550: akka.actor.ActorNotFound: Actor not found for
Fxdemon opened a new issue #550: akka.actor.ActorNotFound: Actor not found for URL: https://github.com/apache/servicecomb-pack/issues/550 Caused by: akka.actor.ActorNotFound: Actor not found for: ActorSelection[Anchor(akka://alpha-akka/), Path(/user/9cb2c448-09e7-4896-9a72-629a6a91539c)] at akka.actor.ActorSelection.$anonfun$resolveOne$1(ActorSelection.scala:70) at scala.concurrent.impl.CallbackRunnable.run$$$capture(Promise.scala:60) at scala.concurrent.impl.CallbackRunnable.run(Promise.scala) at akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:55) at akka.dispatch.BatchingExecutor$Batch.run(BatchingExecutor.scala:73) at akka.dispatch.ExecutionContexts$sameThreadExecutionContext$.unbatchedExecute(Future.scala:77) at akka.dispatch.BatchingExecutor.execute(BatchingExecutor.scala:120) at akka.dispatch.BatchingExecutor.execute$(BatchingExecutor.scala:114) at akka.dispatch.ExecutionContexts$sameThreadExecutionContext$.execute(Future.scala:76) at scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:68) at scala.concurrent.impl.Promise$DefaultPromise.dispatchOrAddCallback(Promise.scala:312) at scala.concurrent.impl.Promise$DefaultPromise.onComplete(Promise.scala:303) at akka.actor.ActorSelection.resolveOne(ActorSelection.scala:68) at org.apache.servicecomb.pack.alpha.fsm.sink.SagaActorEventSender.send(SagaActorEventSender.java:70) ... 2 more 2019-09-02 15:30:44.505 ERROR Fxdemon --- [torEventChannel] o.a.s.p.a.f.c.MemoryActorEventChannel: akka.actor.ActorNotFound: Actor not found for: ActorSelection[Anchor(akka://alpha-akka/), Path(/user/9cb2c448-09e7-4896-9a72-629a6a91539c)] java.lang.RuntimeException: akka.actor.ActorNotFound: Actor not found for: ActorSelection[Anchor(akka://alpha-akka/), Path(/user/9cb2c448-09e7-4896-9a72-629a6a91539c)] at org.apache.servicecomb.pack.alpha.fsm.sink.SagaActorEventSender.send(SagaActorEventSender.java:79) at org.apache.servicecomb.pack.alpha.fsm.channel.MemoryActorEventChannel$EventConsumer.run(MemoryActorEventChannel.java:60) at java.lang.Thread.run(Thread.java:748) Caused by: akka.actor.ActorNotFound: Actor not found for: ActorSelection[Anchor(akka://alpha-akka/), Path(/user/9cb2c448-09e7-4896-9a72-629a6a91539c)] at akka.actor.ActorSelection.$anonfun$resolveOne$1(ActorSelection.scala:70) at scala.concurrent.impl.CallbackRunnable.run$$$capture(Promise.scala:60) at scala.concurrent.impl.CallbackRunnable.run(Promise.scala) at akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:55) at akka.dispatch.BatchingExecutor$Batch.run(BatchingExecutor.scala:73) at akka.dispatch.ExecutionContexts$sameThreadExecutionContext$.unbatchedExecute(Future.scala:77) at akka.dispatch.BatchingExecutor.execute(BatchingExecutor.scala:120) at akka.dispatch.BatchingExecutor.execute$(BatchingExecutor.scala:114) at akka.dispatch.ExecutionContexts$sameThreadExecutionContext$.execute(Future.scala:76) at scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:68) at scala.concurrent.impl.Promise$DefaultPromise.dispatchOrAddCallback(Promise.scala:312) at scala.concurrent.impl.Promise$DefaultPromise.onComplete(Promise.scala:303) at akka.actor.ActorSelection.resolveOne(ActorSelection.scala:68) at org.apache.servicecomb.pack.alpha.fsm.sink.SagaActorEventSender.send(SagaActorEventSender.java:70) ... 2 more 2019-09-02 15:30:44.507 ERROR Fxdemon --- [torEventChannel] o.a.s.p.a.f.c.MemoryActorEventChannel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #28: [SCB-1474] Fix issue problem in client/client.go.
tianxiaoliang commented on a change in pull request #28: [SCB-1474] Fix issue
problem in client/client.go.
URL: https://github.com/apache/servicecomb-kie/pull/28#discussion_r319815705
##
File path: client/client.go
##
@@ -147,18 +147,58 @@ func (c *Client) Get(ctx context.Context, key string,
opts ...GetOption) ([]*mod
}))
return nil, fmt.Errorf("get %s failed,http status [%s], body
[%s]", key, resp.Status, b)
}
- var kvRes []*model.KVResponse
- err = json.Unmarshal(b, )
+ var kvs []*model.KVResponse
+ err = json.Unmarshal(b, )
if err != nil {
openlogging.Error("unmarshal kv failed:" + err.Error())
return nil, err
}
- var kvs []*model.KVDoc
- for _, kvR := range kvRes {
- kvD := *kvR.Data[0]
- kvD.LabelID = kvR.LabelDoc.LabelID
- kvD.Labels = kvR.LabelDoc.Labels
- kvs = append(kvs, )
+ return kvs, nil
+}
+
+//Get get value
+func (c *Client) SearchByLabels(ctx context.Context, opts ...GetOption)
([]*model.KVResponse, error) {
+ options := GetOptions{}
+ for _, o := range opts {
+ o()
+ }
+ if options.Project == "" {
+ options.Project = defaultProject
+ }
+ lableReq := "q="
Review comment:
const
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #28: [SCB-1474] Fix issue problem in client/client.go.
tianxiaoliang commented on a change in pull request #28: [SCB-1474] Fix issue
problem in client/client.go.
URL: https://github.com/apache/servicecomb-kie/pull/28#discussion_r319815900
##
File path: client/client.go
##
@@ -147,18 +147,58 @@ func (c *Client) Get(ctx context.Context, key string,
opts ...GetOption) ([]*mod
}))
return nil, fmt.Errorf("get %s failed,http status [%s], body
[%s]", key, resp.Status, b)
}
- var kvRes []*model.KVResponse
- err = json.Unmarshal(b, )
+ var kvs []*model.KVResponse
+ err = json.Unmarshal(b, )
if err != nil {
openlogging.Error("unmarshal kv failed:" + err.Error())
return nil, err
}
- var kvs []*model.KVDoc
- for _, kvR := range kvRes {
- kvD := *kvR.Data[0]
- kvD.LabelID = kvR.LabelDoc.LabelID
- kvD.Labels = kvR.LabelDoc.Labels
- kvs = append(kvs, )
+ return kvs, nil
+}
+
+//Get get value
+func (c *Client) SearchByLabels(ctx context.Context, opts ...GetOption)
([]*model.KVResponse, error) {
+ options := GetOptions{}
+ for _, o := range opts {
+ o()
+ }
+ if options.Project == "" {
+ options.Project = defaultProject
+ }
+ lableReq := "q="
+ i := 1
Review comment:
that is that mean? it is like a magic number, give it a meanful name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
