[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1319: 请教华为的CSE架构与Apache的Servicecomb 架构，内部有什么区别吗？配置文件以及服务治理那些是通用的吗？
liubao68 commented on issue #1319: 请教华为的CSE架构与Apache的Servicecomb 架构，内部有什么区别吗？配置文件以及服务治理那些是通用的吗？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1319#issuecomment-543005777 For java SDK java-chassis, they almost the same. See https://bbs.huaweicloud.com/blogs/107286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1354: 对接 Nacos 配置中心
liubao68 commented on issue #1354: 对接 Nacos 配置中心 URL: https://github.com/apache/servicecomb-java-chassis/issues/1354#issuecomment-543004906 we do not have this yet. Do you mind contribute the client code ? ServiceComb use archorius API to add dynamic support and examles are https://github.com/apache/servicecomb-java-chassis/tree/master/dynamic-config which already impements support for config-center, servicecomb-kie and Appollo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571
xiangyuQi commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335805870
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
好的 :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571
coolbeevip commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335805392
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
使用 Ordered. LOWEST_PRECEDENCE 可以控制尽量最后一个加载
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571
coolbeevip commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335799406
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
目前看来我也没有太好的建议，因为我们无法控制还有哪些组件扩展了这个接口，不过我建议在日志中打印这个组件注册成功或者注册失败的日志，这样再出现类似问题的时候我们可以通过日志看到我们的这个组件是否成功注册，如果已经成功注册，但是还有问题，我们就可以怀疑这个项目还用了其他类似的组件，可以缩小问题排查范围
关于 @order 我觉得如果我们已知一些组件的加载顺序需要控制，那么可以采用此方式。另外我印象中 @AutoconfigureOrder
是专门为已知自动配置类提供排序，用这个可能性能会好一点吧。
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] pengyu0929 opened a new issue #573: Failed to get reconnected sender, all alpha server is down
pengyu0929 opened a new issue #573: Failed to get reconnected sender, all alpha server is down URL: https://github.com/apache/servicecomb-pack/issues/573 我现在有两个问题： 1. 我发现有人在之前提出了和我现在一样的问题， #326 ，不知道你们是否修复？ 2.有两个服务 A 、B，在A中有两个接口 A1、A2，B中有两个接口 B1、B2，在A1上没有添加@SagaStart注解，A2添加，B1、B2都添加了@Compensable注解； 请求三次，第一次请求A2-->B2，没有问题； 第二次请求A1-->B1，就出现了 `Failed to get reconnected sender, all alpha server is down`，此时omega将sender的value值设置成了 Long 的最大值； 第三次请求 A2-->B2，这时也出现了 `Failed to get reconnected sender, all alpha server is down`， 这时我发现 sender 的 value 值为 Long 的最大值，使用的是默认的sender； 以上情况，我认为 A1 没有添加 @SagaStart 注解出现问题是正常的，但是在之后调用 A2 时不应该出现 `Failed to get reconnected sender, all alpha server is down`; 之后我测试了一种情况，就是在请求A2-->B2，在B2向alpha发送事件时，我手动将alpha关闭，此时会抛出 `Failed to get reconnected sender, all alpha server is down` ，同时将sender的value值设置为Long的最大值。之后我重启alpha，再次请求A2-->B2，请求正常（sender的value值为0L）。 这种情况是为什么呢？是在omega重连alpha时将sender的value值重置了吗？可是我翻看源码并没找到相关的代码。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571
xiangyuQi commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335796055
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
事实上我这个实现参考了spring-cloud-netflix-hystrix的HystrixSecurityAutoConfiguration,我是想通过@Order
保证HystrixServiceCombAutoConfiguration在HystrixSecurityAutoConfiguration生效的情况下,在其之后加载,否则,ServiceCombConcurrencyStrategy将会被
HystrixSecurityAutoConfiguration的strategy覆盖,不知道你有更好的建议吗
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571
xiangyuQi commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335796055
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
事实上我这个实现参考了spring-cloud-netflix-hystrix的HystrixSecurityAutoConfiguration,我是想通过@Order
保证HystrixServiceCombAutoConfiguration在HystrixSecurityAutoConfiguration生效的情况下,在其之后加载,否则,ServiceCombConcurrencyStrategy将会被
HystrixSecurityAutoConfiguration覆盖,不知道你有更好的建议吗
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] xiangyuQi commented on a change in pull request #572: fix issue #571
xiangyuQi commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335794446
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
嗯,有必要加这个判断,如果有实现类直接继承了ServiceCombConcurrencyStrategy,并且在之前注册了,那应该会有问题.谢谢你的建议
:)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571
coolbeevip commented on a change in pull request #572: fix issue #571
URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335791654
##
File path:
omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java
##
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2013-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.pack.omega.transport.feign.hystrix;
+
+import javax.annotation.PostConstruct;
+import java.util.List;
+import java.util.Optional;
+
+import com.netflix.hystrix.Hystrix;
+import com.netflix.hystrix.strategy.HystrixPlugins;
+import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
+import com.netflix.hystrix.strategy.eventnotifier.HystrixEventNotifier;
+import com.netflix.hystrix.strategy.executionhook.HystrixCommandExecutionHook;
+import com.netflix.hystrix.strategy.metrics.HystrixMetricsPublisher;
+import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.core.annotation.Order;
+
+/**
+ * 使用hystrix情况下，自动注册ServiceCombConcurrencyStrategy
+ * @author : qixiangy...@163.com
+ */
+@Configuration
+@Order
+@ConditionalOnClass({Hystrix.class})
+public class HystrixServiceCombAutoConfiguration {
+
+ @Autowired
+ Optional> hystrixCallableWrappers;
+
+ @PostConstruct
+ public void init() {
Review comment:
当有多个 HystrixConcurrencyStrategy 接口实现的时候，如果每个实现方式都是在 HystrixPlugins.reset();
后重新注册，会不会导致创建多次 ServiceCombConcurrencyStrategy。这一点我不太确定，只是怀疑。
我觉得可以先判断 HystrixPlugins.getInstance().getConcurrencyStrategy 是否已经是
ServiceCombConcurrencyStrategy 实例，如果已经是这个实例可以直接 return
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[servicecomb-website] branch asf-site updated (3f71f10 -> 71e895b)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 3f71f10 publish website add 6a38c51 Update the contributing guide new 793bc0c Merge branch 'master' into asf-site new 71e895b Publish the website The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _developers/cn/contributing.md | 23 +- _developers/contributing.md| 17 +- content/cn/developers/contributing.html| 57 +- .../developers/release-validation-guide/index.html | 12 +- content/cn/developers/submit-codes/index.html | 2 +- content/cn/developers/submit-issues/index.html | 2 +- .../cn/developers/subscribe-mail-list/index.html | 2 +- content/cn/developers/use-gitter/index.html| 2 +- content/cn/developers/use-jira/index.html | 2 +- content/cn/docs/autoscale-on-company/index.html| 2 +- content/cn/docs/company-on-kubernetes/index.html | 20 +- .../cn/docs/config_center_integration/index.html | 14 +- content/cn/docs/consul-servicemesh.html| 20 +- content/cn/docs/crm-part-I/index.html | 212 +++--- .../customized-tracing-with-servicecomb/index.html | 12 +- .../index.html | 64 +- .../how-to-do-microservice-accept-test/index.html | 34 +- content/cn/docs/linuxcon-workshop-demo/index.html | 188 ++--- content/cn/docs/loadtest-saga-with-kubernetes.html | 2 +- .../mersher-flow-control/index.html| 4 +- .../mersher-service-management/index.html | 18 +- content/cn/docs/mersher-quick-start/index.html | 16 +- content/cn/docs/open-design/index.html | 30 +- .../index.html | 4 +- .../quick-start-advance/flow-control/index.html| 2 +- .../service-management/index.html | 2 +- content/cn/docs/quick-start-bmi/index.html | 18 +- .../cn/docs/quick-start-dataconsistency/index.html | 128 ++-- content/cn/docs/quick-start/index.html | 2 +- content/cn/docs/release-note-1-0-0.html| 6 +- content/cn/docs/saga_pack_design/index.html| 10 +- content/cn/docs/saga_with_cucumber/index.html | 36 +- .../index.html | 4 +- .../cn/docs/servicecomb-pack-cluster/index.html| 60 +- content/cn/docs/servicecomb-pack-consul/index.html | 24 +- content/cn/docs/servicecomb-pack-eureka/index.html | 2 +- .../servicecomb-springcloud-zuul-demo/index.html | 20 +- .../index.html | 2 +- content/cn/faqs/faqs-huawei-cloud/index.html | 2 +- content/cn/faqs/index.html | 40 +- .../cn/users/application-boot-process/index.html | 2 +- content/cn/users/communicate-protocol/index.html | 12 +- content/cn/users/customized-tracing/index.html | 18 +- content/cn/users/develop-with-jax-rs/index.html| 16 +- .../cn/users/develop-with-rest-template/index.html | 26 +- content/cn/users/develop-with-rpc/index.html | 26 +- .../develop-with-spring-boot-starter/index.html| 16 +- content/cn/users/develop-with-springmvc/index.html | 18 +- .../users/develop-with-transparent-rpc/index.html | 24 +- content/cn/users/distributed-tracing/index.html| 2 +- content/cn/users/dynamic-config/index.html | 16 +- content/cn/users/edge-in-1.0.0-m1/index.html | 12 +- content/cn/users/edging-service/nginx/index.html | 12 +- content/cn/users/edging-service/zuul/index.html| 8 +- content/cn/users/healthcheck/index.html| 18 +- content/cn/users/invoke-control/index.html | 2 +- content/cn/users/local-develop-test/index.html | 8 +- .../index.html | 12 +- content/cn/users/metrics-in-0.5.0/index.html | 8 +- content/cn/users/metrics-in-1.0.0-m1/index.html| 52 +- .../index.html | 2 +- .../index.html | 6 +- content/cn/users/run-mode/index.html | 6 +- content/cn/users/service-configurations/index.html | 8 +- content/cn/users/service-contract/index.html | 2 +- content/cn/users/service-definition/index.html | 2 +- content/cn/users/service-heartbeat/index.html | 8 +- .../users/service-interface-constraints/index.html | 18 +- content/cn/users/setup-environment/index.html | 46 +- content/cn/users/use-service-contract/index.html | 2 +- content/cn/users/use-tls/index.html| 2 +- content/developers/contributing.html
[servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit 793bc0c36064a0657dfb571ea864ac2e72b1a9d6 Merge: 3f71f10 6a38c51 Author: Willem Jiang AuthorDate: Thu Oct 17 10:34:23 2019 +0800 Merge branch 'master' into asf-site _developers/cn/contributing.md | 23 +++ _developers/contributing.md| 17 +++-- 2 files changed, 26 insertions(+), 14 deletions(-)
[servicecomb-website] branch master updated (17326cd -> 6a38c51)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 17326cd Merge pull request #200 from ChinX/master add 6a38c51 Update the contributing guide No new revisions were added by this update. Summary of changes: _developers/cn/contributing.md | 23 +++ _developers/contributing.md| 17 +++-- 2 files changed, 26 insertions(+), 14 deletions(-)
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #572: fix issue #571
coolbeevip commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335787303 ## File path: omega/omega-transport/omega-transport-feign/pom.xml ## @@ -71,6 +83,12 @@ slf4j-simple test + +com.netflix.hystrix +hystrix-core +1.5.18 Review comment: 依赖包的版本定义放到根目录的 pom.xml 会比较好管理 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] coolbeevip commented on issue #572: fix issue #571
coolbeevip commented on issue #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#issuecomment-542970207 > 非常感谢你能为ServiceComb Pack 提交patch。 > 建议单独添加一个Hystrix模块来处理这部分的功能， 因为Hystrix不但可以和Fegin联合使用，还有可能和其他的Transport模块组合在一起使用。 > > 还有我们需要添加单元测试，来验证线程切换的功能。 同意，模块名是不是可以叫 omega-transport-hystrix :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #572: fix issue #571
WillemJiang commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335783033 ## File path: omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixServiceCombAutoConfiguration.java ## @@ -0,0 +1,85 @@ +/* Review comment: 这部分的代码来源于什么地方，需要说清楚。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #572: fix issue #571
WillemJiang commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335783472 ## File path: omega/omega-transport/omega-transport-feign/src/main/java/org/apache/servicecomb/pack/omega/transport/feign/hystrix/HystrixCallableWrapper.java ## @@ -0,0 +1,29 @@ +package org.apache.servicecomb.pack.omega.transport.feign.hystrix; + +import java.util.concurrent.Callable; +import java.util.concurrent.ThreadPoolExecutor; + +/** + * 自定义包装hystrix callable 接口，便于处理线程变量等 + * @author : qixiangy...@163.com Review comment: 我们在项目中不使用author 标签，代码需要添加Apache License header This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #572: fix issue #571
WillemJiang commented on a change in pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#discussion_r335782470 ## File path: omega/omega-transport/omega-transport-feign/pom.xml ## @@ -28,6 +28,18 @@ 4.0.0 omega-transport-feign + Review comment: 不需要添加这部分的设置，因为在parent pom里面已经包含相关compiler的设置了。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] msnetc opened a new issue #1354: 对接 Nacos 配置中心
msnetc opened a new issue #1354: 对接 Nacos 配置中心 URL: https://github.com/apache/servicecomb-java-chassis/issues/1354 nacos的动态配置服务让您能够以中心化、外部化和动态化的方式管理所有环境的配置。动态配置消除了配置变更时重新部署应用和服务的需要。配置中心化管理让实现无状态服务更简单，也让按需弹性扩展服务更容易。 能否提供java-chassis对接Nacos的配置中心的demo? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] coveralls commented on issue #572: fix issue #571
coveralls commented on issue #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572#issuecomment-542674110 [](https://coveralls.io/builds/26347265) Coverage decreased (-1.1%) to 79.643% when pulling **e4fabd8585f399440d6221ad9772451dc27d9397 on xiangyuQi:issue-571** into **5c45d802a2d22d7a45ab35d0c7336a3112a255d5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-java-chassis] branch master updated: [SCB-1523] Stopping retrying another server when no server available
This is an automated email from the ASF dual-hosted git repository.
liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new 4595644 [SCB-1523] Stopping retrying another server when no server
available
4595644 is described below
commit 45956448d3685be1067d19b06e76ad02d663a518
Author: AngLi2
AuthorDate: Mon Oct 14 20:14:30 2019 +0800
[SCB-1523] Stopping retrying another server when no server available
---
.../java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
index df7424a..00155cb 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
@@ -98,7 +98,10 @@ public class LoadbalanceHandler implements Handler {
boolean isRetry = null != lastServer;
for (int i = 0; i < COUNT; i++) {
Server s = delegate.chooseServer((Invocation) key);
-if (s != null && !s.equals(lastServer)) {
+if (s == null) {
+ break;
+}
+if (!s.equals(lastServer)) {
lastServer = s;
break;
}
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1351: [SCB-1523] Stopping retrying another server when no server available
liubao68 merged pull request #1351: [SCB-1523] Stopping retrying another server when no server available URL: https://github.com/apache/servicecomb-java-chassis/pull/1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang opened a new issue #43: eliminate cross dependency
tianxiaoliang opened a new issue #43: eliminate cross dependency URL: https://github.com/apache/servicecomb-kie/issues/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang closed pull request #41: add go sum
tianxiaoliang closed pull request #41: add go sum URL: https://github.com/apache/servicecomb-kie/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] xiangyuQi commented on issue #571: omega 开启 hystrix，使用Feign调用bug
xiangyuQi commented on issue #571: omega 开启 hystrix，使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542660991 @WillemJiang @pengyu0929 @zhfeng 我提交了一个PR解决这个issue,有空可以看一下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] xiangyuQi opened a new pull request #572: fix issue #571
xiangyuQi opened a new pull request #572: fix issue #571 URL: https://github.com/apache/servicecomb-pack/pull/572 解决issue #571 OmegaContext 中使用了 InheritableThreadLocal 在feign调用开启hystrix时,hystrix会为每个feignClient创建线程池. InheritableThreadLocal在第一次创建线程时,可以正确继承到父线程的线程变量,但是当线程被复用时,InheritableThreadLocal不会被更新,导致无法在feign调用的header里传递globalTxId和localTxId 我参考了spring security解决securityContext 线程变量在使用hystrix时,传递线程变量的方案,针对OmegaContext里的线程变量进行了传递,并提供了可扩展的接口 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang opened a new pull request #41: add go sum
tianxiaoliang opened a new pull request #41: add go sum URL: https://github.com/apache/servicecomb-kie/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1351: [SCB-1523] Stopping retrying another server when no server available
coveralls edited a comment on issue #1351: [SCB-1523] Stopping retrying another server when no server available URL: https://github.com/apache/servicecomb-java-chassis/pull/1351#issuecomment-542487683 [](https://coveralls.io/builds/26345503) Coverage decreased (-0.02%) to 85.871% when pulling **1fae3bc5c98214956e87c498b9745afcb0ed0835 on AngLi2:duplicate-logs** into **5aa27f3424367a6000ba5b270ef9be9c86569630 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] AngLi2 closed pull request #1353: [SCB-1528] Optimizing some code implementations
AngLi2 closed pull request #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1352: [SCB-1511]when use method override, the generated swagger body is wro…
coveralls commented on issue #1352: [SCB-1511]when use method override, the generated swagger body is wro… URL: https://github.com/apache/servicecomb-java-chassis/pull/1352#issuecomment-542608033 [](https://coveralls.io/builds/26343872) Coverage decreased (-0.01%) to 85.876% when pulling **76b5b5d5a8f5aaa825e2fb05a14400fd30617d66 on liubao68:fix-override** into **5aa27f3424367a6000ba5b270ef9be9c86569630 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] AngLi2 commented on issue #1353: [SCB-1528] Optimizing some code implementations
AngLi2 commented on issue #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353#issuecomment-542603909 1. Iterating entrySet() is more efficent than entryKey() when call map.get(key) each time; 2. Collections.isEmpty() is more efficent than collections.size() == 0 3. Util classes should have private constructures 4. String.valueOf() is more efficent then + "" 5. BigDecimal() may cause some precision problems while BigDecimal.valueOf() not 6. Return empty collection instead of null can prevent NPE 7. Objects.equals(a, b) is better than a.equals(b) because of NPE 8. Data in enum shoud be private final This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] pengyu0929 removed a comment on issue #571: omega 开启 hystrix，使用Feign调用bug
pengyu0929 removed a comment on issue #571: omega 开启 hystrix，使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542161447 这个还是你们自己写吧，链接中已经写的比较清楚了。但是要考虑到如果使用者在omega端已经实现了一个策略，可能在代理的时候出现问题。 还有这种方式的扩展性比较差，只要新增一个线程变量就要重写一个类。 其他的就没什么了。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] AngLi2 opened a new pull request #1353: [SCB-1528] Optimizing some code implementations
AngLi2 opened a new pull request #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1352: [SCB-1511]when use method override, the generated swagger body is wro…
liubao68 opened a new pull request #1352: [SCB-1511]when use method override, the generated swagger body is wro… URL: https://github.com/apache/servicecomb-java-chassis/pull/1352 …ng (missed sorting) Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch little-cui-patch-2 created (now 45d5136)
This is an automated email from the ASF dual-hosted git repository. littlecui pushed a change to branch little-cui-patch-2 in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. at 45d5136 Update contributing.md No new revisions were added by this update.
[GitHub] [servicecomb-website] little-cui opened a new pull request #202: Update contributing.md
little-cui opened a new pull request #202: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] little-cui closed pull request #201: Update contributing.md
little-cui closed pull request #201: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch little-cui-patch-1 created (now ffbea89)
This is an automated email from the ASF dual-hosted git repository. littlecui pushed a change to branch little-cui-patch-1 in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. at ffbea89 Update contributing.md This branch includes the following new commits: new ffbea89 Update contributing.md The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [servicecomb-website] little-cui opened a new pull request #201: Update contributing.md
little-cui opened a new pull request #201: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] 01/01: Update contributing.md
This is an automated email from the ASF dual-hosted git repository. littlecui pushed a commit to branch little-cui-patch-1 in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit ffbea890ecce555cf1012beba7659f8dce80bab6 Author: little-cui AuthorDate: Wed Oct 16 15:24:14 2019 +0800 Update contributing.md --- _developers/contributing.md | 1 + 1 file changed, 1 insertion(+) diff --git a/_developers/contributing.md b/_developers/contributing.md index f105732..9e83a76 100755 --- a/_developers/contributing.md +++ b/_developers/contributing.md @@ -45,6 +45,7 @@ We recommend to work on the code from [Github](https://github.com/search?q=org% | [Service Center](https://github.com/apache/servicecomb-service-center) | Service registration and discovery | Go | | [Saga](https://github.com/apache/servicecomb-saga) | Data Eventually Consistency Solution for Microservice | Java | | [Website](https://github.com/apache/servicecomb-website) | ServiceComb Website | Markdown | +| [Kie](https://github.com/apache/servicecomb-kie) | Service for configuration management | Go | If you intend to work on the code and provide patches and other work you want to submit to the Apache ServiceComb projects, then you can fork the project on github and work on your own fork. The custom work you do should be done on branches you create, which can then be committed and pushed upstream, and then submitted to Apache ServiceComb as PRs (pull requests). You can find many resources online how to work on github projects and how to submit work to these projects.
[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix，使用Feign调用bug
WillemJiang commented on issue #571: omega 开启 hystrix，使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542556279 > 这个还是你们自己写吧，链接中已经写的比较清楚了。但是要考虑到如果使用者在omega端已经实现了一个策略，可能在代理的时候出现问题。 > 还有这种方式的扩展性比较差，只要新增一个线程变量就要重写一个类。 > 其他的就没什么了。 线程上下文切换的时候，需要解决OmegaContext传递的问题，我们需要知道你是如何传递ThreadLocal的， 最好是有一个测试能够复现这个问题，这样可以帮助我们比较快地解这一问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] AngLi2 commented on a change in pull request #1351: [SCB-1523] Stopping retrying another server when no server available
AngLi2 commented on a change in pull request #1351: [SCB-1523] Stopping
retrying another server when no server available
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1351#discussion_r335304033
##
File path:
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
##
@@ -98,6 +98,9 @@ public Server chooseServer(Object key) {
boolean isRetry = null != lastServer;
for (int i = 0; i < COUNT; i++) {
Server s = delegate.chooseServer((Invocation) key);
+if (s == null) {
+ break;
+}
Review comment:
Already updated.
break the loop when s == null
only continue the loop and retry another server when s.equals(lastServer)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page
tianxiaoliang merged pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page URL: https://github.com/apache/servicecomb-kie/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-kie] branch master updated: [SCB-1526] The contribution guide link is invalid in kie home page (#40)
This is an automated email from the ASF dual-hosted git repository. tianxiaoliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-kie.git The following commit(s) were added to refs/heads/master by this push: new 66c0b80 [SCB-1526] The contribution guide link is invalid in kie home page (#40) 66c0b80 is described below commit 66c0b8093a1dbd09412dbd9038f9c3ee97e70064 Author: little-cui AuthorDate: Wed Oct 16 14:52:05 2019 +0800 [SCB-1526] The contribution guide link is invalid in kie home page (#40) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fdbe2d9..ba4b88d 100644 --- a/README.md +++ b/README.md @@ -101,7 +101,7 @@ Bugs: [issues](https://issues.apache.org/jira/browse/SCB) ## Contributing -See [Contribution guide](/CONTRIBUTING.md) for details on submitting patches and the contribution workflow. +See [Contribution guide](http://servicecomb.apache.org/developers/contributing) for details on submitting patches and the contribution workflow. ## Reporting Issues
[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix，使用Feign调用bug
WillemJiang commented on issue #571: omega 开启 hystrix，使用Feign调用bug URL: https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542543770 > 我也碰到用Feign调用时，子事务获取不到globalTxId，导致报错。没有用Hystrix，只是单纯的Feign调用，经测试将Feign改为Dubbo调用就没问题。 你是用Feign调用Dubbo服务吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] little-cui opened a new pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page
little-cui opened a new pull request #40: [SCB-1526] The contribution guide link is invalid in kie home page URL: https://github.com/apache/servicecomb-kie/pull/40 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
