[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1349: [SCB-1525]print codec error stack
coveralls edited a comment on issue #1349: [SCB-1525]print codec error stack URL: https://github.com/apache/servicecomb-java-chassis/pull/1349#issuecomment-542136605 [](https://coveralls.io/builds/26515561) Coverage decreased (-0.002%) to 85.868% when pulling **45c0b19bfd6d643fd6c51e43150d9dd4ee24569d on liubao68:log-encode** into **ab1783ab636ca35b4ce4c56dc2c5fba2af763920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1349: [SCB-1525]print codec error stack
coveralls edited a comment on issue #1349: [SCB-1525]print codec error stack URL: https://github.com/apache/servicecomb-java-chassis/pull/1349#issuecomment-542136605 [](https://coveralls.io/builds/26515030) Coverage decreased (-0.006%) to 85.864% when pulling **7fae62f84a1a57cbbd6196089bffb812943b634f on liubao68:log-encode** into **ab1783ab636ca35b4ce4c56dc2c5fba2af763920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center
liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center URL: https://github.com/apache/servicecomb-java-chassis/pull/1356#issuecomment-545719948 > > You mentioned this components maybe used for spring cloud, and I checked project [spring-cloud-hauwei](https://github.com/huaweicloud/spring-cloud-huawei/blob/master/README_zh.md), this project has already project clients and discovery features for spring cloud. > > I just want to implement a client for servicecomb server components, such as service-center and kie. > This client will implement all APIs of service-center in the future, not only registry and discovery. > And it can be used by other microservice framework, not only spring cloud. This is a good idea. But I have some requirements that must be done to merge the code: 1. this code can replace the service-registry implementation. It's not a good idea to have two sets of code doing the same job. 2. this code can replace the implementation of spring-cloud-huawei implementation. Match the two requirements can veriry your API design is correct for future. For API module, frequently API change is very big problem, must do it very carefully in design and testing before make it visible to users. I'd prefer you refactor the code of service-registry, not impelement a new one using different techknowedges. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-mesher] branch master updated: [SCB-1497]support for skywalking. (#79)
This is an automated email from the ASF dual-hosted git repository. tianxiaoliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-mesher.git The following commit(s) were added to refs/heads/master by this push: new dc7ecfd [SCB-1497]support for skywalking. (#79) dc7ecfd is described below commit dc7ecfd69ab510428f4d0cf62da774c6426a34dc Author: surechen <814464...@qq.com> AuthorDate: Thu Oct 24 10:22:51 2019 +0800 [SCB-1497]support for skywalking. (#79) * support for skywalking. SCB-1497 Signed-off-by: surechen * fix for gosecure check * fix * Solution for compiling error * fix * Add go.sum * remove go.sum * fix compile problem * Modify according to code review comments Signed-off-by: surechen --- conf/mesher.yaml| 5 + docs/skywalking/skywalking.md | 36 +++ go.mod | 10 +- proxy/config/struct.go | 17 proxy/handler/skywalking_handler.go | 122 proxy/handler/skywalking_handler_test.go| 120 +++ proxy/pkg/skywalking/skywalking_manager.go | 79 +++ proxy/pkg/skywalking/skywalking_manager_test.go | 101 8 files changed, 487 insertions(+), 3 deletions(-) diff --git a/conf/mesher.yaml b/conf/mesher.yaml index 024810c..490844f 100644 --- a/conf/mesher.yaml +++ b/conf/mesher.yaml @@ -21,3 +21,8 @@ admin: #admin API #match: # status: 200 # body: ok +#servicecomb: +# apm: +#tracing: +# enable: true +# serverUri: 127.0.0.1:11800 \ No newline at end of file diff --git a/docs/skywalking/skywalking.md b/docs/skywalking/skywalking.md new file mode 100644 index 000..d3b3676 --- /dev/null +++ b/docs/skywalking/skywalking.md @@ -0,0 +1,36 @@ +# SkyWalking + +Skywalking-manager is a handler plugin of mesher, it reports tracing data to skywalking server. + +## Configurations +**In conf/mesher.conf** + +**servicecomb.apm.tracing.enable** +> *(optional, bool)* enable application performance manager + +**servicecomb.apm.tracing.serverUri** +> *(optional, string)* server address of skywalking + +## Example +```yaml +servicecomb: + apm: #application performance monitor +tracing: + enable: true #enable tracing ability + serverUri: 127.0.0.1:11800#url of skywalking +``` +## Step： + +# 1. SkyWawlking-Manager Init +**You must init skywawlking manager pkg which will manage connection and report msg to skywalking** +- For example: +- [1] You can import skywalking manager proxy/pkg/skywalking in file proxy/bootstrap/bootstrap.go. +- [2] Calling function Init() in proxy/pkg/skywalking manually to init skywalking manager. +- [3] Adding skywalking's consumer handler name SkyWalkingConsumer defined in proxy/pkg/skywalking to consumerChain. +- [4] Adding skywalking's provider handler name SkyWalkingProvider defined in proxy/pkg/skywalking to providerChain. +- more details about handler chains in [go-chassis](https://github.com/go-chassis/go-chassis#readme) + +# 2. SkyWalking-Handler Init +- You must import proxy/handler pkg to init skywalking handler. Not only skywalking handler, all the handlers which are customized for mesher are defined here. +- For example you can import handler pkg in file cmd/mesher/mesher.go + diff --git a/go.mod b/go.mod index db2168a..89a7514 100644 --- a/go.mod +++ b/go.mod @@ -21,14 +21,18 @@ require ( github.com/prometheus/client_model v0.0.0-20190115171406-56726106282f github.com/spf13/pflag v1.0.5 // indirect github.com/stretchr/testify v1.3.0 + github.com/tetratelabs/go2sky v0.1.1-0.20190703154722-1eaab8035277 github.com/urfave/cli v1.20.1-0.20181029213200-b67dcf995b6a golang.org/x/net v0.0.0-20190311183353-d8887717615a golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2 // indirect - google.golang.org/grpc v1.16.0 + google.golang.org/grpc v1.19.1 gopkg.in/inf.v0 v0.9.1 // indirect - gopkg.in/yaml.v2 v2.2.1 + gopkg.in/yaml.v2 v2.2.2 k8s.io/apimachinery v0.0.0-20181022183627-f71dbbc36e12 k8s.io/client-go v9.0.0+incompatible ) -replace github.com/openzipkin-contrib/zipkin-go-opentracing v0.3.5 => github.com/go-chassis/zipkin-go-opentracing v0.3.5-0.20190321072447-42cf74fc2a92 +replace ( + github.com/openzipkin-contrib/zipkin-go-opentracing v0.3.5 => github.com/go-chassis/zipkin-go-opentracing v0.3.5-0.20190321072447-42cf74fc2a92 + github.com/tetratelabs/go2sky v0.1.1-0.20190703154722-1eaab8035277 => github.com/SkyAPM/go2sky v0.1.1-0.20190703154722-1eaab8035277 +) diff --git a/proxy/config/struct.go b/proxy/config/struct.go index 87b35f1..a4a4c51 100644 --- a/proxy/config/struct.go +++
[GitHub] [servicecomb-kie] alec-z edited a comment on issue #48: The API paths in swagger are inconsistent with the actual paths when I start the service with docker
alec-z edited a comment on issue #48: The API paths in swagger are inconsistent with the actual paths when I start the service with docker URL: https://github.com/apache/servicecomb-kie/issues/48#issuecomment-545710863 The docker image servicecomb/kie:latest in hub.docker.com is outdated. Please push the really latest kie to hub.docker.com then the issue would disappear. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] alec-z commented on issue #48: The API paths in swagger are inconsistent with the actual paths when I start the service with docker
alec-z commented on issue #48: The API paths in swagger are inconsistent with the actual paths when I start the service with docker URL: https://github.com/apache/servicecomb-kie/issues/48#issuecomment-545710863 The docker image servicecomb/kie:latest in hub.docker.com is outdated. Please push the really latest kie to hub.docker.com then the issue will gone. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] alec-z edited a comment on issue #31: How to run kie without docker
alec-z edited a comment on issue #31: How to run kie without docker URL: https://github.com/apache/servicecomb-kie/issues/31#issuecomment-545709495 see https://github.com/apache/servicecomb-kie/pull/38 And u can find guide in Docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-kie] alec-z commented on issue #31: How to run kie without docker
alec-z commented on issue #31: How to run kie without docker URL: https://github.com/apache/servicecomb-kie/issues/31#issuecomment-545709495 see https://github.com/apache/servicecomb-kie/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch asf-site updated (71e895b -> d29d8b9)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 71e895b Publish the website add 03d0153 add project version to user guide add 646a0dd Merge pull request #205 from ChinX/master add 26c7583 article for introducing oas-validator new ebe589d Merge branch 'master' into asf-site new d29d8b9 Publish the website The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _data/navigation.yml | 34 +- _includes/sidebar.html | 4 +- _pages/cn/home.md | 2 +- _pages/home.md | 2 +- ...-use-oas-validator-help-standardize-oas-spec.md | 184 +++ .../oas-validator-1.png| Bin 0 -> 121783 bytes .../oas-validator-2.png| Bin 0 -> 13642 bytes content/404.html | 4 +- .../oas-validator-1.png| Bin 0 -> 121783 bytes .../oas-validator-2.png| Bin 0 -> 13642 bytes content/cn/404.html| 6 +- content/cn/developers/becomming-a-commiter.html| 6 +- content/cn/developers/contributing.html| 6 +- content/cn/developers/index.html | 6 +- content/cn/developers/release-guide/index.html | 6 +- .../developers/release-validation-guide/index.html | 6 +- .../developers/setup-committer-rights/index.html | 6 +- .../setup-develop-environment/index.html | 6 +- content/cn/developers/submit-codes/index.html | 6 +- content/cn/developers/submit-issues/index.html | 6 +- .../cn/developers/subscribe-mail-list/index.html | 6 +- content/cn/developers/team/index.html | 6 +- content/cn/developers/use-gitter/index.html| 6 +- content/cn/developers/use-jira/index.html | 6 +- .../index.html | 26 +- .../index.html | 26 +- .../index.html | 24 +- .../index.html | 29 +- .../docs/apache-servicecomb-day-slides/index.html | 26 +- .../apache-servicecomb-incubating-day/index.html | 26 +- .../index.html | 26 +- content/cn/docs/autoscale-on-company/index.html| 26 +- .../index.html | 26 +- .../index.html | 26 +- content/cn/docs/communication-btw-sc-ms/index.html | 26 +- content/cn/docs/company-on-kubernetes/index.html | 26 +- .../cn/docs/config_center_integration/index.html | 26 +- content/cn/docs/consul-servicemesh.html| 26 +- content/cn/docs/crm-part-I/index.html | 26 +- .../customized-tracing-with-servicecomb/index.html | 26 +- .../index.html | 26 +- .../index.html | 26 +- .../index.html | 26 +- content/cn/docs/distributed_saga_1/index.html | 26 +- content/cn/docs/distributed_saga_2/index.html | 26 +- content/cn/docs/distributed_saga_3/index.html | 26 +- content/cn/docs/go-to-cloud/index.html | 26 +- .../how-to-do-microservice-accept-test/index.html | 26 +- .../index.html | 26 +- .../docs/how-to-reform-a-legacy-system/index.html | 26 +- content/cn/docs/jira_beginner_guide/index.html | 26 +- content/cn/docs/join_the_community/index.html | 26 +- content/cn/docs/linuxcon-workshop-demo/index.html | 26 +- content/cn/docs/loadtest-saga-with-kubernetes.html | 26 +- .../cn/docs/maven_dependency_management/index.html | 26 +- .../cn/docs/mersher-quick-start-advance/index.html | 6 +- .../mersher-distributed-tracing/index.html | 6 +- .../mersher-flow-control/index.html| 6 +- .../mersher-load-balance/index.html| 6 +- .../mersher-service-management/index.html | 6 +- content/cn/docs/mersher-quick-start/index.html | 6 +- content/cn/docs/open-design/index.html | 26 +- .../index.html | 26 +- content/cn/docs/osi-microservices/index.html | 26 +- .../index.html | 26 +- .../distributed-tracing/index.html | 6 +- .../quick-start-advance/flow-control/index.html| 6 +- content/cn/docs/quick-start-advance/index.html | 6 +-
[servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit ebe589d85671addb292f0e0254bdc96541ef6364 Merge: 71e895b 26c7583 Author: Willem Jiang AuthorDate: Wed Oct 23 21:12:10 2019 +0800 Merge branch 'master' into asf-site _data/navigation.yml | 34 ++-- _includes/sidebar.html | 4 +- _pages/cn/home.md | 2 +- _pages/home.md | 2 +- ...-use-oas-validator-help-standardize-oas-spec.md | 184 + .../oas-validator-1.png| Bin 0 -> 121783 bytes .../oas-validator-2.png| Bin 0 -> 13642 bytes 7 files changed, 205 insertions(+), 21 deletions(-)
[GitHub] [servicecomb-website] WillemJiang commented on issue #203: Rename the package name from org.apache.servicecomb.saga to org.apache.servicecomb.pack
WillemJiang commented on issue #203: Rename the package name from org.apache.servicecomb.saga to org.apache.servicecomb.pack URL: https://github.com/apache/servicecomb-website/pull/203#issuecomment-545435577 Just checked the changes, we don't need to change these files as it's quite old one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch master updated: article for introducing oas-validator
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git
The following commit(s) were added to refs/heads/master by this push:
new 26c7583 article for introducing oas-validator
26c7583 is described below
commit 26c7583fe9b0dd034314e670aa4b2b022cb3a1c3
Author: Daniel Qian
AuthorDate: Wed Oct 23 15:02:37 2019 +0800
article for introducing oas-validator
---
...-use-oas-validator-help-standardize-oas-spec.md | 184 +
.../oas-validator-1.png| Bin 0 -> 121783 bytes
.../oas-validator-2.png| Bin 0 -> 13642 bytes
3 files changed, 184 insertions(+)
diff --git
a/_posts/cn/2019-10-23-use-oas-validator-help-standardize-oas-spec.md
b/_posts/cn/2019-10-23-use-oas-validator-help-standardize-oas-spec.md
new file mode 100644
index 000..6ba2960
--- /dev/null
+++ b/_posts/cn/2019-10-23-use-oas-validator-help-standardize-oas-spec.md
@@ -0,0 +1,184 @@
+---
+title: "使用OAS Validator帮助你规范OpenAPI Spec文档"
+lang: cn
+ref: use-oas-validator-help-standardize-oas-spec
+permalink: /cn/docs/use-oas-validator-help-standardize-oas-spec/
+excerpt: "本文将介绍如何规范你的OpenAPI Spec文档"
+last_modified_at: 2019-10-23T12:37:43+08:00
+author: Daniel Qian
+tags: [微服务]
+redirect_from:
+ - /theme-setup/
+---
+
+## 使用OAS Validator规范你的OpenAPI Spec文档
+
+当前主流的开发RESTful API的做法有两种：Code First和Contract First。Code
First指先写代码，然后生成Contract，而Contract First则是先写Contract再写代码实现。
+
+两种做法各有利弊，Code
First可以让开发人员先写接口实现，然后利用工具反向生成Contract，优点是快速开发，并能保证接口实现与Contract保证一致，缺点是Contract太过易变容易导致下游应用故障。Contract
First则可以让Contract的变动受控，保证下游应用的稳定性，缺点是需要人工来保证接口实现与Contact的一致性，具有一定难度。
+
+对于如何规范管理Contract，新开普软件研究院开源的[OAS
Validator[1]](https://github.com/NewCapec-Institute/oas-validator)提供了一些思路，下面简单介绍。
+
+### 合规性校验
+
+OAS Validator支持对使用[OpenAPI
V3[2]](https://github.com/OAI/OpenAPI-Specification)编写的Contract文档做合规性校验（也可称之为风格校验）。
+
+在一个微服务架构的系统中，提供RESTful
API的组件可能会有很多个，并且由不同开发人员/团队开发，那么在使用这些接口的时候有一个很自然的需求就是希望这些接口（或接口文档）的风格是一致的。OAS
Validator的合规性校验做的就是这部分工作。下面举例说明怎么使用合规性校验功能：
+
+1. 到 https://github.com/NewCapec-Institute/oas-validator clone下代码
+2. 然后 `mvn clean install`打包
+3. 到`oas-validator-web/target`目录下执行`java -jar oas-validator-web-exec.jar`启动OAS
Validator Web
+4. 访问 http://localhost:8080，进入合规性校验功能
+5. 把
[petstore.yaml](https://github.com/OAI/OpenAPI-Specification/blob/master/examples/v3.0/petstore.yaml)
内容贴到文本框中然后点击校验得到结果：
+
+```txt
+$.tags : 至少提供一个
+$.openapi : 必须>=3.0.2
+$.components.schemas.'Pet'.title : 必须提供
+$.components.schemas.'Pet'.properties.'id'.title : 必须提供
+$.components.schemas.'Pet'.properties.'name'.title : 必须提供
+$.components.schemas.'Pet'.properties.'tag'.title : 必须提供
+$.components.schemas.'Error'.title : 必须提供
+$.components.schemas.'Error'.properties.'code'.title : 必须提供
+$.components.schemas.'Error'.properties.'message'.title : 必须提供
+$.info.description : 必须提供
+$.paths./pets.get.tags[0] : 不在$.tags所定义的范围内
+$.paths./pets.get.responses.200.headers.'x-next' : 必须为upper hyphen case
+$.paths./pets.post.tags[0] : 不在$.tags所定义的范围内
+$.paths./pets/{petId}.get.tags[0] : 不在$.tags所定义的范围内
+```
+
+下面是功能截图：
+
+{:
.align-center}
+
+下面举例解释检查报告的意思：
+
+`$.components.schemas.'Pet'.title :
必须提供`，前面一段是[JsonPath[3]](https://github.com/json-path/JsonPath)，用来描述出问题的元素/属性的位置，“必须提供”则的意思是没有填写该属性。如下图：
+
+{:
.align-center}
+
+`title`是一个文档性字段，没有它虽然不影响接口的语义，但是对于下游应用的开发者来说没有它会造成理解上的困难，因此在这里我们把它设定为必填。
+
+再来看这一条报告 `$.paths./pets.get.responses.200.headers.'x-next' : 必须为upper hyphen
case`，同样前面是JsonPath，告诉你该属性应该为Upper Hyphen
Case，正确的写法应该是`X-Next`。和`title`属性一样Header的大小写不是一个技术问题，但是统一的大小写风格能够让下游应用的开发人员更舒适，从而有更少的Bug。
+
+### 兼容性校验
+
+不管你是采用Code First还是Contract
First，Contract的变动不可避免，那么如何保证变化后的Contract能够对下游应用向下兼容就成了不可回避的问题。这个问题的具体描述就是根据V1.0
Contract开发的下游应用是否依然能够与根据V1.1 Contract实现的接口正确交互。
+
+OAS Validator提供了这种兼容性校验，当然同样只支持OpenAPI V3文档。下面举例说明如何使用这一功能：
+
+我们先提供一个v1.0的OAS Spec：
+
+```yaml
+openapi: "3.0.0"
+info:
+ version: 1.0
+ title: Swagger Petstore
+paths:
+ /pets/{petId}:
+get:
+ operationId: showPetById
+ tags:
+- pets
+ parameters:
+- name: petId
+ in: path
+ required: true
+ schema:
+type: string
+ responses:
+'200':
+ description: Expected response to a valid request
+ content:
+application/json:
+ schema:
+$ref: "#/components/schemas/Pet"
+components:
+ schemas:
+Pet:
+ type: object
+ required:
+- id
+- name
+ properties:
+id:
+ type: integer
+ format: int64
+name:
+ type: string
+```
+
+再写一个v1.1的OAS Spec，添加了一个query参数`name`：
+
+```yaml
+openapi: "3.0.0"
[GitHub] [servicecomb-website] WillemJiang merged pull request #204: article for introducing oas-validator
WillemJiang merged pull request #204: article for introducing oas-validator URL: https://github.com/apache/servicecomb-website/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] WillemJiang closed pull request #202: Update contributing.md
WillemJiang closed pull request #202: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] WillemJiang commented on issue #202: Update contributing.md
WillemJiang commented on issue #202: Update contributing.md URL: https://github.com/apache/servicecomb-website/pull/202#issuecomment-545431505 The file has been updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch master updated: add project version to user guide
This is an automated email from the ASF dual-hosted git repository.
tianxiaoliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git
The following commit(s) were added to refs/heads/master by this push:
new 03d0153 add project version to user guide
new 646a0dd Merge pull request #205 from ChinX/master
03d0153 is described below
commit 03d015373ad4cd19bc97b171bcc62bfe96b286a7
Author: chinx
AuthorDate: Wed Oct 23 19:20:02 2019 +0800
add project version to user guide
---
_data/navigation.yml | 34 +-
_includes/sidebar.html | 4 ++--
_pages/cn/home.md | 2 +-
_pages/home.md | 2 +-
4 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/_data/navigation.yml b/_data/navigation.yml
index d4f399a..d2d0fd0 100755
--- a/_data/navigation.yml
+++ b/_data/navigation.yml
@@ -8,7 +8,7 @@ t:
- title: "Projects"
url: /developers/
group: "projects"
- - title: "Resources"
+ - title: "Documentation"
url: /users/
group: "users"
children:
@@ -68,24 +68,24 @@ t:
- title: "Mersher Distributed Tracing"
url: /docs/mersher-quick-start-advance/mersher-distributed-tracing/
users:
- - title: Java Chassis
+ - title: Java Chassis User Guide
children:
- - title: Java-chassis User Guide
+ - title: 1.2.1
url: https://docs.servicecomb.io/java-chassis/en_US/index.html
- - title: Saga
+ - title: Saga User Guide
children:
- - title: Saga User Guide
+ - title: 0.5.0
url: https://docs.servicecomb.io/saga/en_US/index.html
- - title: ServiceCenter
+ - title: ServiceCenter User Guide
children:
- - title: ServiceCenter User Guide
+ - title: 1.2.0
url: https://docs.servicecomb.io/service-center/en_US/index.html
- - title: Kie
+ - title: Kie User Guide
children:
- - title: Kie User Guide
+ - title: 0.1.0
url: /docs/kie/0.1.0/index.html
developers:
- title: "Projects"
@@ -159,13 +159,13 @@ t:
cn:
main:
- - title: "主页"
+ - title: "首页"
url: /cn/
group: "home"
- title: "项目"
url: /cn/developers/
group: "projects"
- - title: "资料"
+ - title: "文档"
url: /cn/users/
group: "users"
children:
@@ -226,19 +226,19 @@ t:
url:
/cn/docs/mersher-quick-start-advance/mersher-distributed-tracing/
users:
- - title: Java Chassis
+ - title: Java-chassis用户手册
children:
- - title: Java-chassis用户手册
+ - title: 1.2.1
url: https://docs.servicecomb.io/java-chassis/zh_CN/index.html
- - title: Saga
+ - title: Saga用户手册
children:
- - title: Saga用户手册
+ - title: 0.5.0
url: https://docs.servicecomb.io/saga/zh_CN/index.html
- - title: ServiceCenter
+ - title: ServiceCenter用户手册
children:
- - title: ServiceCenter用户手册
+ - title: 1.2.0
url: https://docs.servicecomb.io/service-center/zh_CN/index.html
developers:
diff --git a/_includes/sidebar.html b/_includes/sidebar.html
index f82f8fc..311694d 100644
--- a/_includes/sidebar.html
+++ b/_includes/sidebar.html
@@ -1,9 +1,9 @@
{% if page.author_profile or layout.author_profile or page.sidebar %}
{% if page.lang == 'cn' %}
- {{
site.data.ui-text[page.lang].breadcrumb_home_label | default: "Home" }} > ServiceComb
+ {{
site.data.ui-text[page.lang].breadcrumb_home_label | default: "Home" }} >
{{ page.title }}
{% else %}
- {{
site.data.ui-text[page.lang].breadcrumb_home_label | default: "Home" }} > ServiceComb
+ {{
site.data.ui-text[page.lang].breadcrumb_home_label | default: "Home" }} >
{{ page.title }}
{% endif %}
{% if page.author_profile or layout.author_profile %}{% include
author-profile.html %}{% endif %}
{% if page.sidebar %}
diff --git a/_pages/cn/home.md b/_pages/cn/home.md
index a917338..ac6e6f1 100755
--- a/_pages/cn/home.md
+++ b/_pages/cn/home.md
@@ -12,7 +12,7 @@ excerpt: '开箱即用、高性能、兼容流行生态、支持多语言的一
下载
-快速入门
+开始
'
intro:
diff --git a/_pages/home.md b/_pages/home.md
index f18c26b..62108ad 100755
--- a/_pages/home.md
+++ b/_pages/home.md
@@ -12,7 +12,7 @@ excerpt: 'Open-Source, Full-Stack Microservice Solution.With
out of the box, hig
Download
-Quick Start
+Get started
'
intro:
[GitHub] [servicecomb-website] tianxiaoliang merged pull request #205: add project version to user guide
tianxiaoliang merged pull request #205: add project version to user guide URL: https://github.com/apache/servicecomb-website/pull/205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] ChinX opened a new pull request #205: add project version to user guide
ChinX opened a new pull request #205: add project version to user guide URL: https://github.com/apache/servicecomb-website/pull/205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1349: [SCB-1525]print codec error stack
liubao68 commented on a change in pull request #1349: [SCB-1525]print codec
error stack
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1349#discussion_r337917563
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestCodec.java
##
@@ -61,7 +64,11 @@ public static void argsToRest(Object[] args,
RestOperationMeta restOperation,
try {
paramValues[idx] = param.getParamProcessor().getValue(request);
} catch (Exception e) {
-// Avoid information leak of user input.
+// Avoid information leak of user input, and add option for debug use.
+if (DynamicPropertyFactory.getInstance().getBooleanProperty(
+RestConst.PRINT_CODEC_ERROR_MESSGAGE, false).get()) {
+ LOG.error("", e);
+}
Review comment:
This will have drawbacks. We can not expose internal exception trace to
client(not recommented). And if we do serialize exception to the client, the
client may be not possible to decode the exception.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-website] chanjarster opened a new pull request #204: article for introducing oas-validator
chanjarster opened a new pull request #204: article for introducing oas-validator URL: https://github.com/apache/servicecomb-website/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-java-chassis] branch master updated: [SCB-1528] Optimizing some code implementations
This is an automated email from the ASF dual-hosted git repository.
yaohaishi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new ab1783a [SCB-1528] Optimizing some code implementations
ab1783a is described below
commit ab1783ab636ca35b4ce4c56dc2c5fba2af763920
Author: AngLi2
AuthorDate: Wed Oct 16 16:22:11 2019 +0800
[SCB-1528] Optimizing some code implementations
---
.../servicecomb/common/javassist/JavassistUtils.java | 2 +-
.../internal/converter/BodyParameterAdapter.java | 3 ++-
.../protobuf/internal/converter/ModelAdapter.java | 6 --
.../protobuf/internal/converter/PropertyAdapter.java | 3 ++-
.../rest/codec/param/CookieProcessorCreator.java | 3 ++-
.../servicecomb/demo/pojo/server/CodeFirstPojo.java | 12
.../org/apache/servicecomb/demo/utils/JAXBUtils.java | 3 +++
.../servicecomb/demo/signature/ServerSignature.java | 4 +++-
.../sources/ApolloConfigurationSourceImpl.java| 4 +---
.../servicecomb/config/client/ApolloClient.java | 12 +++-
.../sources/ConfigCenterConfigurationSourceImpl.java | 4 +---
.../edge/core/URLMappedEdgeDispatcher.java| 10 +-
.../foundation/common/log/NoCacheLog4j2Marker.java| 2 +-
.../servicecomb/foundation/common/net/NetUtils.java | 2 +-
.../bizkeeper/BizkeeperExceptionUtils.java| 3 +++
.../faultinjection/FaultInjectionUtil.java| 2 ++
.../faultinjection/TestFaultInjectConfig.java | 4
.../apache/servicecomb/loadbalance/RandomRuleExt.java | 2 +-
.../servicecomb/loadbalance/RoundRobinRuleExt.java| 2 +-
.../loadbalance/ServiceCombLoadBalancerStats.java | 11 +--
.../filter/InstancePropertyDiscoveryFilter.java | 8
.../loadbalance/filter/IsolationDiscoveryFilter.java | 8
.../loadbalance/filter/ZoneAwareDiscoveryFilter.java | 7 ---
.../authentication/provider/AccessController.java | 19 ++-
.../inspector/internal/swagger/SchemaFormat.java | 2 +-
.../servicecomb/it/edge/PreLoadBootListener.java | 2 +-
.../reference/CommonToHttpServletRequest.java | 2 +-
.../reference/TestCommonToHttpServletRequest.java | 4 ++--
.../samples/bmi/CalculatorServiceImpl.java| 2 +-
.../serviceregistry/api/registry/HealthCheckMode.java | 2 +-
.../serviceregistry/api/registry/WatchAction.java | 2 +-
.../serviceregistry/client/IpPortManager.java | 2 +-
.../serviceregistry/client/http/RequestParam.java | 2 +-
.../discovery/InstanceStatusDiscoveryFilter.java | 7 ---
.../servicecomb/swagger/converter/ConverterMgr.java | 4 +---
35 files changed, 82 insertions(+), 85 deletions(-)
diff --git
a/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
b/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
index dbdc0a1..0be5b83 100644
---
a/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
+++
b/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
@@ -87,7 +87,7 @@ public final class JavassistUtils {
@SuppressWarnings({"rawtypes", "unchecked"})
public static Class createEnum(ClassLoader classLoader,
String clsName, List values) {
-if (values == null || values.size() == 0) {
+if (values == null || values.isEmpty()) {
throw new Error("values is not allowed empty.");
}
diff --git
a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/BodyParameterAdapter.java
b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/BodyParameterAdapter.java
index 9062d94..9dee93c 100644
---
a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/BodyParameterAdapter.java
+++
b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/BodyParameterAdapter.java
@@ -16,6 +16,7 @@
*/
package org.apache.servicecomb.codec.protobuf.internal.converter;
+import java.util.Collections;
import java.util.List;
import io.swagger.models.ArrayModel;
@@ -66,7 +67,7 @@ public class BodyParameterAdapter implements
SwaggerTypeAdapter {
return ((ModelImpl) model).getEnum();
}
-return null;
+return Collections.emptyList();
}
@Override
diff --git
a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/ModelAdapter.java
b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/ModelAdapter.java
index 1cf99f1..78dab6b 100644
---
[GitHub] [servicecomb-java-chassis] yhs0092 merged pull request #1353: [SCB-1528] Optimizing some code implementations
yhs0092 merged pull request #1353: [SCB-1528] Optimizing some code implementations URL: https://github.com/apache/servicecomb-java-chassis/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
