[servicecomb-website] branch master updated (d395f57 -> 178a481)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from d395f57 Updated the release information with https add 5ad362a SCB-1578 Fixed the download page link issue add 178a481 SCB-1578 Fixed the download page link issue No new revisions were added by this update. Summary of changes: _release/cn/release.md | 52 +- _release/release.md| 50 2 files changed, 51 insertions(+), 51 deletions(-)
[servicecomb-website] 02/02: Publish the website
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit 29ec4b0b1746cacc228ad9742d9fe9ee17b8b45d Author: Willem Jiang AuthorDate: Sat Nov 9 22:52:09 2019 +0800 Publish the website --- content/cn/release/index.html | 52 +-- content/feed.xml | 2 +- content/release/index.html| 50 - 3 files changed, 52 insertions(+), 52 deletions(-) diff --git a/content/cn/release/index.html b/content/cn/release/index.html index a8f63d1..378af01 100644 --- a/content/cn/release/index.html +++ b/content/cn/release/index.html @@ -543,63 +543,63 @@ -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.3.0/; target="_blank">ServiceComb Service-Center 1.3.0 (released on 2019-11-07) +ServiceComb Service-Center 1.3.0 (released on 2019-11-07) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-toolkit/0.1.0/; target="_blank">ServiceComb Toolkit 0.1.0 (released on 2019-09-03) +ServiceComb toolkit 0.1.0 (released on 2019-09-04) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-pack/0.5.0/; target="_blank">ServiceComb Pack 0.5.0 (released on 2019-08-26) +ServiceComb Pack 0.5.0 (released on 2019-08-26) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.3.0/; target="_blank">ServiceComb Java-Chassis 1.3.0 (released on 2019-10-31) +ServiceComb Java-Chassis 1.3.0 (released on 2019-10-31) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-saga-actuator/0.3.0/; target="_blank">ServiceComb Saga Actuator 0.3.0 (released on 2018-12-18) +ServiceComb Saga Actuator 0.3.0 (released on 2018-12-18) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-saga/0.2.1/; target="_blank">ServiceComb Saga 0.2.1 (released on 2018-11-23) +ServiceComb Saga 0.2.1 (released on 2018-11-23) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-mesher/1.6.3/; target="_blank">ServiceComb Mesher 1.6.3 (released on 2019-9-9) +ServiceComb Mesher 1.6.3 (released on 2019-9-9) -https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-kie/0.1.0/; target="_blank">ServiceComb Kie 0.1.0 (released on 2019-10-26) +ServiceComb Kie 0.1.0 (released on 2019-10-26) 先前发行版本 : - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/; target="_blank">ServiceComb Service-Center 1.2.0 (released on 2019-04-06) - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/; target="_blank">ServiceComb Service-Center 1.1.0 (released on 2018-11-30) - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0/; target="_blank">ServiceComb Service-Center 1.0.0 (released on 2018-08-02) - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m2/; target="_blank">ServiceComb Service-Center 1.0.0-m2 (released on 2018-06-21) + ServiceComb Service-Center 1.2.0 (released on 2019-04-06) + ServiceComb Service-Center 1.1.0 (released on 2018-11-30) + ServiceComb Service-Center 1.0.0 (released on 2018-08-02) + ServiceComb Service-Center 1.0.0-m2 (released on 2018-06-21) -http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/; target="_blank">ServiceComb Service-Center 1.0.0-m1 (released on 2018-03-27) +ServiceComb Service-Center 1.0.0-m1 (released on 2018-03-27) - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.1/; target="_blank">ServiceComb Java-Chassis 1.2.1 (released on 2019-05-19) - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.2.0/; target="_blank">ServiceComb Java-Chassis 1.2.0 (released on 2019-04-12) - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-java-chassis/1.1.0/; target="_blank">ServiceComb Java-Chassis 1.1.0 (released on 2018-11-30) - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/; target="_blank">ServiceComb Java-Chassis 1.0.0 (released on 2018-08-02) - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/; target="_blank">ServiceComb Java-Chassis 1.0.0-m2 (released on 2018-06-21) + ServiceComb Java-Chassis 1.2.1 (released on 2019-05-19) + ServiceComb Java-Chassis 1.2.0 (released on 2019-04-12) + ServiceComb Java-Chassis 1.1.0 (released on 2018-11-30) + ServiceComb Java-Chassis 1.0.0 (released on 2018-08-02) + ServiceComb Java-Chassis 1.0.0-m2 (released on 2018-06-21) -http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/; target="_blank">ServiceComb Java-Chassis 1.0.0-m1 (released
[servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit eaaeaa8e48b55b7628904b527c7e7f5056ca617b Merge: 25f14ca 178a481 Author: Willem Jiang AuthorDate: Sat Nov 9 22:50:23 2019 +0800 Merge branch 'master' into asf-site _release/cn/release.md | 52 +- _release/release.md| 50 2 files changed, 51 insertions(+), 51 deletions(-)
[servicecomb-website] branch asf-site updated (25f14ca -> 29ec4b0)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 25f14ca Publish the website add 5ad362a SCB-1578 Fixed the download page link issue add 178a481 SCB-1578 Fixed the download page link issue new eaaeaa8 Merge branch 'master' into asf-site new 29ec4b0 Publish the website The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _release/cn/release.md| 52 +-- _release/release.md | 50 - content/cn/release/index.html | 52 +-- content/feed.xml | 2 +- content/release/index.html| 50 - 5 files changed, 103 insertions(+), 103 deletions(-)
[GitHub] [servicecomb-pack] WillemJiang commented on issue #590: 事务失败后做补偿操作（cancel）抛异常，事务结束
WillemJiang commented on issue #590: 事务失败后做补偿操作（cancel）抛异常，事务结束 URL: https://github.com/apache/servicecomb-pack/issues/590#issuecomment-552102233 > 1.版本0.5.0，用的是saga-spring-demo，alpha没有使用状态机 > https://github.com/apache/servicecomb-pack/blob/a89c7cd8b416c9b281fdbe28644cb6b7e2e78f91/omega/omega-context/src/main/java/org/apache/servicecomb/pack/omega/context/CallbackContext.java > 在apply方法中try catch住了cancel方法的异常，但是只打印了log,然后接着执行 sender.send(new TxCompensatedEvent(globalTxId, localTxId, parentTxId, compensationMethod)); > alpha收到TxCompensatedEvent后就更新command状态为dnwn增加sagaEndedEvent就结束事务了。 > 在整个过程中catch住了异常，但是接下来的处理逻辑和没有发生异常时是一样的。这样从数据记录就看不出补偿是否成功。不知道是不是我那里缺少配置造成的还是有其他的处理方式？ CallbackContext 抓住的异常是和回调方法相关的，这些异常有可能和你的配置有关。 因为如果不忽略这样的异常，Alpha下发的命令在下一次执行的时候还是有可能失败，因此通过日志输出方式来处理这样的问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster opened a new pull request #45: SCB-1570 Translate javadocs of oas-validator
chanjarster opened a new pull request #45: SCB-1570 Translate javadocs of oas-validator URL: https://github.com/apache/servicecomb-toolkit/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch master updated (d0f7d4b -> d395f57)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from d0f7d4b Update SC 1.3.0 Release Date add d395f57 Updated the release information with https No new revisions were added by this update. Summary of changes: _release/cn/java_chassis_downloads.md | 6 +++--- _release/cn/saga_downloads.md | 6 +++--- _release/cn/service_center_downloads.md | 6 +++--- _release/java_chassis_downloads.md | 6 +++--- _release/saga_downloads.md | 6 +++--- _release/service_center_downloads.md| 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-)
[servicecomb-website] 02/02: Publish the website
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit 25f14ca3eb657b2b863b0a09913a811e2d72 Author: Willem Jiang AuthorDate: Sat Nov 9 21:00:15 2019 +0800 Publish the website --- content/cn/release/java-chassis-downloads/index.html | 12 ++-- content/cn/release/saga-downloads/index.html | 10 +- .../cn/release/service-center-downloads/index.html | 20 ++-- content/feed.xml | 2 +- content/release/java-chassis-downloads/index.html| 12 ++-- content/release/saga-downloads/index.html| 10 +- content/release/service-center-downloads/index.html | 20 ++-- 7 files changed, 43 insertions(+), 43 deletions(-) diff --git a/content/cn/release/java-chassis-downloads/index.html b/content/cn/release/java-chassis-downloads/index.html index dfc07a3..81dfb57 100644 --- a/content/cn/release/java-chassis-downloads/index.html +++ b/content/cn/release/java-chassis-downloads/index.html @@ -573,20 +573,20 @@ Apache ServiceComb (incubating) Java-Chassis 1.0.0 - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-src.zip;>[src] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-src.zip.asc;>[asc] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache- [...] - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-bin.zip;>[Binary] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-bin.zip.asc;>[asc] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apac [...] + https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-src.zip;>[src] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-src.zip.asc;>[asc] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apac [...] + https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-bin.zip;>[Binary] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-bin.zip.asc;>[asc] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0/a [...] Service-Center 1.0.0 or above Apache ServiceComb (incubating) Java-Chassis 1.0.0-m2 - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-src.zip;>[src] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-src.zip.asc;>[asc] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1 [...] - http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-bin.zip;>[Binary] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-bin.zip.asc;>[asc] http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassi [...] + https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-src.zip;>[src] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-src.zip.asc;>[asc] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassi [...] + https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-bin.zip;>[Binary] https://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-java-chassis/1.0.0-m2/apache-servicecomb-incubating-java-chassis-distribution-1.0.0-m2-bin.zip.asc;>[asc]
[servicecomb-website] branch asf-site updated (91fc6d0 -> 25f14ca)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 91fc6d0 Publish the website add d395f57 Updated the release information with https new a52a223 Merge branch 'master' into asf-site new 25f14ca Publish the website The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _release/cn/java_chassis_downloads.md| 6 +++--- _release/cn/saga_downloads.md| 6 +++--- _release/cn/service_center_downloads.md | 6 +++--- _release/java_chassis_downloads.md | 6 +++--- _release/saga_downloads.md | 6 +++--- _release/service_center_downloads.md | 6 +++--- content/cn/release/java-chassis-downloads/index.html | 12 ++-- content/cn/release/saga-downloads/index.html | 10 +- .../cn/release/service-center-downloads/index.html | 20 ++-- content/feed.xml | 2 +- content/release/java-chassis-downloads/index.html| 12 ++-- content/release/saga-downloads/index.html| 10 +- content/release/service-center-downloads/index.html | 20 ++-- 13 files changed, 61 insertions(+), 61 deletions(-)
[GitHub] [servicecomb-pack] coolbeevip commented on issue #590: 事务失败后做补偿操作（cancel）抛异常，事务结束
coolbeevip commented on issue #590: 事务失败后做补偿操作（cancel）抛异常，事务结束 URL: https://github.com/apache/servicecomb-pack/issues/590#issuecomment-552089280 Thank you for the issue, I can reproduce it and add JIRA tracker https://issues.apache.org/jira/browse/SCB-1577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1380: [SCB-1575] Add README for Service-Center-Client
coveralls commented on issue #1380: [SCB-1575] Add README for Service-Center-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1380#issuecomment-552087547 [](https://coveralls.io/builds/26875162) Coverage decreased (-0.003%) to 85.489% when pulling **38bc82f0b12e1a4f46a7a91c2f9ecd477b093817 on zaneChou1:addReadme** into **be1b0bbb36c4467cea68fd4b2a16daa6202e3efe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] zaneChou1 opened a new pull request #1380: [SCB-1575] Add README for Service-Center-Client
zaneChou1 opened a new pull request #1380: [SCB-1575] Add README for Service-Center-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1380 To help users use the service-center-client more easily, add a README to the service-center-client. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1379: [SCB-1574] Add README for Kie-Client
coveralls edited a comment on issue #1379: [SCB-1574] Add README for Kie-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1379#issuecomment-552082188 [](https://coveralls.io/builds/26874718) Coverage decreased (-0.02%) to 85.469% when pulling **51aac9ff0468782a7f2a8eaeb62a999e5f0e3067 on zaneChou1:addREADME** into **be1b0bbb36c4467cea68fd4b2a16daa6202e3efe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1379: [SCB-1574] Add README for Kie-Client
coveralls edited a comment on issue #1379: [SCB-1574] Add README for Kie-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1379#issuecomment-552082188 [](https://coveralls.io/builds/26874704) Coverage decreased (-0.003%) to 85.489% when pulling **51aac9ff0468782a7f2a8eaeb62a999e5f0e3067 on zaneChou1:addREADME** into **be1b0bbb36c4467cea68fd4b2a16daa6202e3efe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1379: [SCB-1574] Add README for Kie-Client
coveralls edited a comment on issue #1379: [SCB-1574] Add README for Kie-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1379#issuecomment-552082188 [](https://coveralls.io/builds/26874697) Coverage decreased (-0.01%) to 85.481% when pulling **51aac9ff0468782a7f2a8eaeb62a999e5f0e3067 on zaneChou1:addREADME** into **be1b0bbb36c4467cea68fd4b2a16daa6202e3efe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1379: [SCB-1574] Add README for Kie-Client
coveralls commented on issue #1379: [SCB-1574] Add README for Kie-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1379#issuecomment-552082188 [](https://coveralls.io/builds/26874627) Coverage decreased (-0.009%) to 85.484% when pulling **51aac9ff0468782a7f2a8eaeb62a999e5f0e3067 on zaneChou1:addREADME** into **be1b0bbb36c4467cea68fd4b2a16daa6202e3efe on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator
to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344435349
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/parser/api/OpenApiAnnotationParser.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.parser.api;
+
+import java.lang.annotation.Annotation;
+
+import org.apache.servicecomb.toolkit.generator.OasContext;
+import org.apache.servicecomb.toolkit.generator.OperationContext;
+import org.apache.servicecomb.toolkit.generator.ParameterContext;
+import
org.apache.servicecomb.toolkit.generator.annotation.ClassAnnotationProcessor;
+import
org.apache.servicecomb.toolkit.generator.annotation.MethodAnnotationProcessor;
+import
org.apache.servicecomb.toolkit.generator.annotation.ParamAnnotationProcessor;
+
+public interface OpenApiAnnotationParser {
+
+ /**
+ *
+ * @param cls
+ * @param context
+ */
+ void parser(Class cls, OasContext context);
+
+ /**
+ * 用于排序, 对于同一个类，同时只能为springmvc或者jaxrs其中一种
Review comment:
I will translate it later
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator
to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344435335
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/MediaTypeConst.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator;
+
+/**
+ * Common media type constants
+ *
+ * @see http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7;>HTTP/1.1
section 3.7
+ */
+public class MediaTypeConst {
Review comment:
Why MediaTypes will be better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] zaneChou1 opened a new pull request #1379: [SCB-1574] Add README for Kie-Client
zaneChou1 opened a new pull request #1379: [SCB-1574] Add README for Kie-Client URL: https://github.com/apache/servicecomb-java-chassis/pull/1379 To help users use the Kie-client more easily, add a README to the Kie-client. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator
to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344435262
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/OasContext.java
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.commons.lang3.StringUtils;
+import
org.apache.servicecomb.toolkit.generator.parser.api.OpenApiAnnotationParser;
+
+import io.swagger.v3.oas.models.Components;
+import io.swagger.v3.oas.models.OpenAPI;
+import io.swagger.v3.oas.models.PathItem;
+import io.swagger.v3.oas.models.PathItem.HttpMethod;
+import io.swagger.v3.oas.models.Paths;
+import io.swagger.v3.oas.models.info.Info;
+import io.swagger.v3.oas.models.servers.Server;
+
+public class OasContext {
+
+ private OpenAPI openAPI;
+
+ private String basePath;
+
+ private Class cls;
+
+ private List operationList = new ArrayList<>();
+
+ private OpenApiAnnotationParser parser;
+
+ public OasContext(OpenApiAnnotationParser parser) {
+this(new OpenAPI(), parser);
+ }
+
+ public OasContext(OpenAPI openAPI, OpenApiAnnotationParser parser) {
+this.openAPI = openAPI;
+this.parser = parser;
+ }
+
+ public OpenAPI toOpenAPI() {
+ensurePaths();
+for (OperationContext operationCtx : operationList) {
+ if (!operationCtx.hasOperation()) {
+continue;
+ }
+
+ if (openAPI.getPaths() == null) {
+openAPI.setPaths(new Paths());
+ }
+
+ PathItem pathItem = openAPI.getPaths().get(operationCtx.getPath());
+ if (pathItem == null) {
+pathItem = new PathItem();
+openAPI.path(operationCtx.getPath(), pathItem);
+ }
+ pathItem.operation(HttpMethod.valueOf(operationCtx.getHttpMethod()),
operationCtx.toOperation());
+}
+
+// 如果没有restful资源则返回null
Review comment:
I will translate it later
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator
to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344435193
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/HttpStatus.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator;
+
+public class HttpStatus {
Review comment:
Why HttpStatuses will be better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator
to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344435033
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/util/ParamUtils.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.util;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.lang.reflect.Parameter;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.objectweb.asm.ClassReader;
+import org.objectweb.asm.ClassVisitor;
+import org.objectweb.asm.ClassWriter;
+import org.objectweb.asm.MethodVisitor;
+import org.objectweb.asm.Opcodes;
+import org.objectweb.asm.Type;
+
+public class ParamUtils {
+
+ private static final String STATIC_CLASS_INIT = "";
+
+ public static final Map paramterCache = new HashMap();
+
+ public static String getParamterName(Method method, Parameter parameter) {
+
+String[] parameterNames = paramterCache.get(method);
+
+if (parameterNames == null) {
+ parameterNames = initParamterNames(method);
+ if (parameterNames == null) {
+return null;
+ }
+}
+
+int paramIndex = getParamIndex(method, parameter);
+if (paramIndex >= 0) {
+ return parameterNames[paramIndex];
+}
+
+return null;
+ }
+
+ private static int getParamIndex(Method method, Parameter parameter) {
+Parameter[] parameters = method.getParameters();
+for (int i = 0; i < parameters.length; i++) {
+ if (parameters[i].equals(parameter)) {
+return i;
+ }
+}
+return -1;
+ }
+
+ private static String[] initParamterNames(Method m) {
Review comment:
I will correct it later
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator
to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344435032
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/util/ParamUtils.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.util;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.lang.reflect.Parameter;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.objectweb.asm.ClassReader;
+import org.objectweb.asm.ClassVisitor;
+import org.objectweb.asm.ClassWriter;
+import org.objectweb.asm.MethodVisitor;
+import org.objectweb.asm.Opcodes;
+import org.objectweb.asm.Type;
+
+public class ParamUtils {
+
+ private static final String STATIC_CLASS_INIT = "";
+
+ public static final Map paramterCache = new HashMap();
+
+ public static String getParamterName(Method method, Parameter parameter) {
Review comment:
I will correct it later
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3 URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434982 ## File path: oas-generator/pom.xml ## @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +toolkit +org.apache.servicecomb.toolkit +0.2.0-SNAPSHOT + + 4.0.0 + pom + +oas-generator-core +oas-generator-jaxrs +oas-generator-spring +oas-generator-servicecomb + + + oas-generator + + + + org.powermock + powermock-module-junit4 + 1.6.2 + test + + + + org.powermock + powermock-api-mockito + 1.6.2 + test + + + + + + +org.apache.maven.plugins +maven-compiler-plugin Review comment: I will remove it later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3 URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434898 ## File path: oas-generator/oas-generator-spring/pom.xml ## @@ -0,0 +1,42 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +oas-generator +org.apache.servicecomb.toolkit +0.2.0-SNAPSHOT + + 4.0.0 + + oas-generator-spring + + + + org.apache.servicecomb.toolkit + oas-generator-core + + + org.springframework + spring-web + 5.2.0.RELEASE Review comment: Yes, you're right. I will unify the 3rd party version in the next commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
kakulisen commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3 URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434758 ## File path: oas-generator/oas-generator-core/pom.xml ## @@ -0,0 +1,68 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +oas-generator +org.apache.servicecomb.toolkit +0.2.0-SNAPSHOT + + 4.0.0 + + oas-generator-core + + +2.0.9 Review comment: Yes, you're right. I will unify the 3rd party version in the next commit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434463
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/MediaTypeConst.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator;
+
+/**
+ * Common media type constants
+ *
+ * @see http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7;>HTTP/1.1
section 3.7
+ */
+public class MediaTypeConst {
Review comment:
Same as HttpStatus, besides named as MediaTypes will be better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434378
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/util/LocalVariableVisitor.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.util;
+
+import org.objectweb.asm.Label;
+import org.objectweb.asm.MethodVisitor;
+import org.objectweb.asm.Type;
+
+public class LocalVariableVisitor extends MethodVisitor {
+
+ private boolean isStatic;
Review comment:
Not used field
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434488
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/parser/api/OpenApiAnnotationParser.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.parser.api;
+
+import java.lang.annotation.Annotation;
+
+import org.apache.servicecomb.toolkit.generator.OasContext;
+import org.apache.servicecomb.toolkit.generator.OperationContext;
+import org.apache.servicecomb.toolkit.generator.ParameterContext;
+import
org.apache.servicecomb.toolkit.generator.annotation.ClassAnnotationProcessor;
+import
org.apache.servicecomb.toolkit.generator.annotation.MethodAnnotationProcessor;
+import
org.apache.servicecomb.toolkit.generator.annotation.ParamAnnotationProcessor;
+
+public interface OpenApiAnnotationParser {
+
+ /**
+ *
+ * @param cls
+ * @param context
+ */
+ void parser(Class cls, OasContext context);
+
+ /**
+ * 用于排序, 对于同一个类，同时只能为springmvc或者jaxrs其中一种
Review comment:
Chinese comment, translate to english will be better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434485
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/OasContext.java
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.commons.lang3.StringUtils;
+import
org.apache.servicecomb.toolkit.generator.parser.api.OpenApiAnnotationParser;
+
+import io.swagger.v3.oas.models.Components;
+import io.swagger.v3.oas.models.OpenAPI;
+import io.swagger.v3.oas.models.PathItem;
+import io.swagger.v3.oas.models.PathItem.HttpMethod;
+import io.swagger.v3.oas.models.Paths;
+import io.swagger.v3.oas.models.info.Info;
+import io.swagger.v3.oas.models.servers.Server;
+
+public class OasContext {
+
+ private OpenAPI openAPI;
+
+ private String basePath;
+
+ private Class cls;
+
+ private List operationList = new ArrayList<>();
+
+ private OpenApiAnnotationParser parser;
+
+ public OasContext(OpenApiAnnotationParser parser) {
+this(new OpenAPI(), parser);
+ }
+
+ public OasContext(OpenAPI openAPI, OpenApiAnnotationParser parser) {
+this.openAPI = openAPI;
+this.parser = parser;
+ }
+
+ public OpenAPI toOpenAPI() {
+ensurePaths();
+for (OperationContext operationCtx : operationList) {
+ if (!operationCtx.hasOperation()) {
+continue;
+ }
+
+ if (openAPI.getPaths() == null) {
+openAPI.setPaths(new Paths());
+ }
+
+ PathItem pathItem = openAPI.getPaths().get(operationCtx.getPath());
+ if (pathItem == null) {
+pathItem = new PathItem();
+openAPI.path(operationCtx.getPath(), pathItem);
+ }
+ pathItem.operation(HttpMethod.valueOf(operationCtx.getHttpMethod()),
operationCtx.toOperation());
+}
+
+// 如果没有restful资源则返回null
Review comment:
Chinese comment, translate to english will be better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434324
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/util/ParamUtils.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.util;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.lang.reflect.Parameter;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.objectweb.asm.ClassReader;
+import org.objectweb.asm.ClassVisitor;
+import org.objectweb.asm.ClassWriter;
+import org.objectweb.asm.MethodVisitor;
+import org.objectweb.asm.Opcodes;
+import org.objectweb.asm.Type;
+
+public class ParamUtils {
+
+ private static final String STATIC_CLASS_INIT = "";
+
+ public static final Map paramterCache = new HashMap();
+
+ public static String getParamterName(Method method, Parameter parameter) {
+
+String[] parameterNames = paramterCache.get(method);
+
+if (parameterNames == null) {
+ parameterNames = initParamterNames(method);
+ if (parameterNames == null) {
+return null;
+ }
+}
+
+int paramIndex = getParamIndex(method, parameter);
+if (paramIndex >= 0) {
+ return parameterNames[paramIndex];
+}
+
+return null;
+ }
+
+ private static int getParamIndex(Method method, Parameter parameter) {
+Parameter[] parameters = method.getParameters();
+for (int i = 0; i < parameters.length; i++) {
+ if (parameters[i].equals(parameter)) {
+return i;
+ }
+}
+return -1;
+ }
+
+ private static String[] initParamterNames(Method m) {
Review comment:
Typo, should be initParameterNames
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434434
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/HttpStatus.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator;
+
+public class HttpStatus {
Review comment:
Since it serves as constant values, should be abstract with a private
constructor or just with a private constructor to make it "constant"
Besides named as HttpStatuses will be better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #38: SCB-1547 add oas-generator to generate openapi v3
chanjarster commented on a change in pull request #38: SCB-1547 add
oas-generator to generate openapi v3
URL: https://github.com/apache/servicecomb-toolkit/pull/38#discussion_r344434307
##
File path:
oas-generator/oas-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/util/ParamUtils.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.generator.util;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.lang.reflect.Parameter;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.objectweb.asm.ClassReader;
+import org.objectweb.asm.ClassVisitor;
+import org.objectweb.asm.ClassWriter;
+import org.objectweb.asm.MethodVisitor;
+import org.objectweb.asm.Opcodes;
+import org.objectweb.asm.Type;
+
+public class ParamUtils {
+
+ private static final String STATIC_CLASS_INIT = "";
+
+ public static final Map paramterCache = new HashMap();
+
+ public static String getParamterName(Method method, Parameter parameter) {
Review comment:
Typo, should be getParameterName
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] wy-140314 commented on issue #590: 事务失败后做补偿操作（cancel）抛异常，事务结束
wy-140314 commented on issue #590: 事务失败后做补偿操作（cancel）抛异常，事务结束 URL: https://github.com/apache/servicecomb-pack/issues/590#issuecomment-552076896 1.版本0.5.0，用的是saga-spring-demo，alpha没有使用状态机 https://github.com/apache/servicecomb-pack/blob/a89c7cd8b416c9b281fdbe28644cb6b7e2e78f91/omega/omega-context/src/main/java/org/apache/servicecomb/pack/omega/context/CallbackContext.java 在apply方法中try catch住了cancel方法的异常，但是只打印了log,然后接着执行 sender.send(new TxCompensatedEvent(globalTxId, localTxId, parentTxId, compensationMethod)); alpha收到TxCompensatedEvent后就更新command状态为dnwn增加sagaEndedEvent就结束事务了。 在整个过程中catch住了异常，但是接下来的处理逻辑和没有发生异常时是一样的。这样从数据记录就看不出补偿是否成功。不知道是不是我那里缺少配置造成的还是有其他的处理方式？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
