[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1450: [SCB-1638]servicecenter do not handle websocket PING/PONG message
liubao68 opened a new pull request #1450: [SCB-1638]servicecenter do not handle websocket PING/PONG message URL: https://github.com/apache/servicecomb-java-chassis/pull/1450 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] DannyKiler opened a new issue #1449: springboot切cse中HttpServerFilter是否可以指定拦截路径
DannyKiler opened a new issue #1449: springboot切cse中HttpServerFilter是否可以指定拦截路径 URL: https://github.com/apache/servicecomb-java-chassis/issues/1449 不想让每个接口都进入Filter 请问这个该怎样实现 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] DannyKiler closed issue #1448: springboot切cse中不替换DispatcherServlet的影响
DannyKiler closed issue #1448: springboot切cse中不替换DispatcherServlet的影响 URL: https://github.com/apache/servicecomb-java-chassis/issues/1448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1447: serviceComb适配vertx-pac4j报错
liubao68 commented on issue #1447: serviceComb适配vertx-pac4j报错 URL: https://github.com/apache/servicecomb-java-chassis/issues/1447#issuecomment-563081765 这个问题看起来和java-chassis没有什么关系。 vert.x升级经常出现不兼容的变更， 可能需要你自行分析下解决方案。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1448: springboot切cse中不替换DispatcherServlet的影响
liubao68 commented on issue #1448: springboot切cse中不替换DispatcherServlet的影响 URL: https://github.com/apache/servicecomb-java-chassis/issues/1448#issuecomment-563081375 开发指南的说明部分都是java-chassis提供的功能，不是Spring MVC DispatcherServlet提供的功能。 如果不涉及“网关”、“服务发现”等场景，可以考虑[两个Servlet并存](https://docs.servicecomb.io/java-chassis/zh_CN/using-java-chassis-in-spring-boot/web-application.html)以保持历史代码功能的兼容 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #608: [SCB-1653] Use bblot version 1.3.3
coveralls commented on issue #608: [SCB-1653] Use bblot version 1.3.3 URL: https://github.com/apache/servicecomb-service-center/pull/608#issuecomment-563073969 [](https://coveralls.io/builds/27491939) Coverage decreased (-0.2%) to 60.116% when pulling **aa0082528a64aebcbce308c2b39927b149fa94ae on ChinX:master** into **c2dc0caef7069ff38cd7395582cf0883d4172dc4 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #608: [SCB-1653] Use bblot version 1.3.3
codecov-io commented on issue #608: [SCB-1653] Use bblot version 1.3.3 URL: https://github.com/apache/servicecomb-service-center/pull/608#issuecomment-563074037 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=h1) Report > Merging [#608](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/c2dc0caef7069ff38cd7395582cf0883d4172dc4?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=tree) ```diff @@Coverage Diff @@ ## master #608 +/- ## == - Coverage 57.85% 57.82% -0.04% == Files 204 204 Lines 1570915709 == - Hits 9088 9083 -5 - Misses 5974 5977 +3 - Partials 647 649 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=tree) | Coverage Δ | | |---|---|---| | [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/608/diff?src=pr=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: | | [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/608/diff?src=pr=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `78.85% <0%> (-2.29%)` | :arrow_down: | | [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/608/diff?src=pr=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `53.57% <0%> (-0.72%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/608/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/608/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `55.85% <0%> (+0.15%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/608/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=footer). Last update [c2dc0ca...aa00825](https://codecov.io/gh/apache/servicecomb-service-center/pull/608?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-service-center] ChinX opened a new pull request #608: [SCB-1653] Use bblot version 1.3.3
ChinX opened a new pull request #608: [SCB-1653] Use bblot version 1.3.3 URL: https://github.com/apache/servicecomb-service-center/pull/608 It solves the performance problem of etcd under the large database size. See details, https://www.cncf.io/blog/2019/05/09/performance-optimization-of-etcd-in-web-scale-data-scenario/ https://github.com/etcd-io/bbolt/pull/141 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster edited a comment on issue #62: 检查不符合规范时退出处理
chanjarster edited a comment on issue #62: 检查不符合规范时退出处理 URL: https://github.com/apache/servicecomb-toolkit/issues/62#issuecomment-563069255 Close this issue due to it's reported in JIRA, [see this](https://issues.apache.org/jira/browse/SCB-1651) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster closed issue #62: 检查不符合规范时退出处理
chanjarster closed issue #62: 检查不符合规范时退出处理 URL: https://github.com/apache/servicecomb-toolkit/issues/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on issue #62: 检查不符合规范时退出处理
chanjarster commented on issue #62: 检查不符合规范时退出处理 URL: https://github.com/apache/servicecomb-toolkit/issues/62#issuecomment-563069255 Close this issue 'cause it's reported in JIRA, [see this](https://issues.apache.org/jira/browse/SCB-1651) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on issue #65: SCB-1651 toolkit style check wrong exit code when not passed
chanjarster commented on issue #65: SCB-1651 toolkit style check wrong exit code when not passed URL: https://github.com/apache/servicecomb-toolkit/pull/65#issuecomment-563068786 @cashtang Nice work! Since toolkit is in the [release process](https://lists.apache.org/thread.html/0808fecd1d043bd2b3c83bb9752e63c3b41bdc6c69b03a27daaddf0a%40%3Cdev.servicecomb.apache.org%3E), after it's finished, you need to rebase this PR, and after that it'll be OK to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] DannyKiler opened a new issue #1448: springboot切cse中不替换DispatcherServlet的影响
DannyKiler opened a new issue #1448: springboot切cse中不替换DispatcherServlet的影响 URL: https://github.com/apache/servicecomb-java-chassis/issues/1448 如题，不替换DispatcherServlet对于项目改造切GDE会有什么影响吗，发现替换之后文件的上传下载功能改动较大。 https://docs.servicecomb.io/java-chassis/zh_CN/general-development/file-upload.html此处的基于SpringMvc上传操作是否对DispatcherServlet进行了替换 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] DannyKiler closed issue #1441: cse如何对response操作
DannyKiler closed issue #1441: cse如何对response操作 URL: https://github.com/apache/servicecomb-java-chassis/issues/1441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch asf-site updated (3ab93d6 -> 946aab9)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 3ab93d6 fix mersher to mesher add c99d64c fix the 404 link (#218) add 1576108 fix the 404 link (#219) add 485a196 fix multi language link (#220) add 4f02a19 fix documents link error and example code error (#224) add bf529ac fix mersher to mesher new 196e313 Merge branch 'master' into asf-site new 946aab9 Published the website The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _developers/cn/setup-develop-environment.md| 2 +- _docs/cn/quick-start.md| 14 +- _docs/getstarted/servicecomb/cn/getting-started.md | 2 +- _docs/quick-start.md | 12 +- _release/release.md| 34 +-- .../developers/release-validation-guide/index.html | 12 +- .../setup-develop-environment/index.html | 2 +- content/cn/developers/submit-codes/index.html | 2 +- content/cn/developers/submit-issues/index.html | 2 +- .../cn/developers/subscribe-mail-list/index.html | 2 +- content/cn/developers/use-gitter/index.html| 2 +- content/cn/developers/use-jira/index.html | 2 +- content/cn/docs/autoscale-on-company/index.html| 2 +- content/cn/docs/company-on-kubernetes/index.html | 20 +- .../cn/docs/config_center_integration/index.html | 14 +- content/cn/docs/consul-servicemesh.html| 20 +- content/cn/docs/crm-part-I/index.html | 212 +++ .../customized-tracing-with-servicecomb/index.html | 12 +- .../index.html | 64 ++--- content/cn/docs/getting-started/index.html | 2 +- .../how-to-do-microservice-accept-test/index.html | 34 +-- content/cn/docs/linuxcon-workshop-demo/index.html | 188 ++--- content/cn/docs/loadtest-saga-with-kubernetes.html | 2 +- .../index.html | 2 +- .../mesher-distributed-tracing}/index.html | 2 +- .../mesher-flow-control}/index.html| 6 +- .../mesher-load-balance}/index.html| 2 +- .../mesher-service-management}/index.html | 20 +- .../index.html | 18 +- content/cn/docs/open-design/index.html | 30 +- .../index.html | 4 +- .../quick-start-advance/flow-control/index.html| 2 +- .../service-management/index.html | 2 +- content/cn/docs/quick-start-bmi/index.html | 18 +- .../cn/docs/quick-start-dataconsistency/index.html | 128 - content/cn/docs/quick-start/index.html | 14 +- content/cn/docs/release-note-1-0-0.html| 6 +- content/cn/docs/saga_pack_design/index.html| 10 +- content/cn/docs/saga_with_cucumber/index.html | 36 +-- .../index.html | 4 +- .../cn/docs/servicecomb-pack-cluster/index.html| 60 ++-- content/cn/docs/servicecomb-pack-consul/index.html | 24 +- content/cn/docs/servicecomb-pack-eureka/index.html | 2 +- .../servicecomb-springcloud-zuul-demo/index.html | 20 +- .../index.html | 2 +- .../cn/docs/syncer/multi-servicecenters/index.html | 8 +- content/cn/docs/toolkit/oas-validator/index.html | 6 +- content/cn/docs/toolkit/quick-start/index.html | 2 +- .../index.html | 4 +- .../docs/users/application-boot-process/index.html | 2 +- .../cn/docs/users/communicate-protocol/index.html | 12 +- .../cn/docs/users/customized-tracing/index.html| 18 +- .../cn/docs/users/develop-with-jax-rs/index.html | 16 +- .../users/develop-with-rest-template/index.html| 26 +- content/cn/docs/users/develop-with-rpc/index.html | 26 +- .../develop-with-spring-boot-starter/index.html| 16 +- .../docs/users/develop-with-springmvc/index.html | 18 +- .../users/develop-with-transparent-rpc/index.html | 24 +- .../cn/docs/users/distributed-tracing/index.html | 2 +- content/cn/docs/users/dynamic-config/index.html| 16 +- content/cn/docs/users/edge-in-1.0.0-m1/index.html | 12 +- .../cn/docs/users/edging-service/nginx/index.html | 12 +- .../cn/docs/users/edging-service/zuul/index.html | 8 +- content/cn/docs/users/healthcheck/index.html | 18 +- content/cn/docs/users/invoke-control/index.html| 2 +- .../cn/docs/users/local-develop-test/index.html| 8 +- .../index.html | 12 +-
[servicecomb-website] branch master updated (4f02a19 -> bf529ac)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 4f02a19 fix documents link error and example code error (#224) add bf529ac fix mersher to mesher No new revisions were added by this update. Summary of changes: _data/navigation.yml | 48 _docs/cn/mersher-distributed-tracing.md| 16 +++--- _docs/cn/mersher-flow-control.md | 16 +++--- _docs/cn/mersher-load-balance.md | 26 - _docs/cn/mersher-quick-start-advance.md| 16 +++--- _docs/cn/mersher-quick-start.md| 66 +++--- _docs/cn/mersher-service-management.md | 26 - _docs/getstarted/servicecomb/cn/getting-started.md | 2 +- _docs/getstarted/servicecomb/getting-started.md| 2 +- _docs/mersher-distributed-tracing.md | 20 +++ _docs/mersher-flow-control.md | 22 _docs/mersher-load-balance.md | 26 - _docs/mersher-quick-start-advance.md | 18 +++--- _docs/mersher-quick-start.md | 66 +++--- _docs/mersher-service-management.md| 30 +- _release/cn/mesher_releaseNotes.md | 4 +- _release/mesher_releaseNotes.md| 4 +- 17 files changed, 204 insertions(+), 204 deletions(-)
[servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit 196e31370c577f47f1cf3cf3b3c2401b3e8135ab Merge: 3ab93d6 bf529ac Author: Willem Jiang AuthorDate: Mon Dec 9 12:14:29 2019 +0800 Merge branch 'master' into asf-site _developers/cn/setup-develop-environment.md| 2 +- _docs/cn/quick-start.md| 14 - _docs/getstarted/servicecomb/cn/getting-started.md | 2 +- _docs/quick-start.md | 12 _release/release.md| 34 +++--- 5 files changed, 32 insertions(+), 32 deletions(-)
[GitHub] [servicecomb-java-chassis] willard-kali commented on issue #1446: 请求的URL中存在冒号报错490
willard-kali commented on issue #1446: 请求的URL中存在冒号报错490 URL: https://github.com/apache/servicecomb-java-chassis/issues/1446#issuecomment-563051486 使用浏览器访问，尝试过这种写法，但是浏览器会自动将%3A转码为：。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] WillemJiang commented on issue #226: fix mersher to mesher
WillemJiang commented on issue #226: fix mersher to mesher URL: https://github.com/apache/servicecomb-website/pull/226#issuecomment-563049895 OK, I will merge the patch to master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] WillemJiang merged pull request #226: fix mersher to mesher
WillemJiang merged pull request #226: fix mersher to mesher URL: https://github.com/apache/servicecomb-website/pull/226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
chanjarster commented on a change in pull request #65: cli exit with status
code 1 when checkstyle or checkcompatibility were not passed
URL: https://github.com/apache/servicecomb-toolkit/pull/65#discussion_r355250966
##
File path:
cli/src/main/java/org/apache/servicecomb/toolkit/cli/ToolkitMain.java
##
@@ -43,9 +43,13 @@ public static void main(String[] args) {
CheckCompatibility.class, CheckCompatibilityAbbr.class,
Help.class
);
-Runnable cmd = builder.build().parse(args);
+try {
+ Runnable cmd = builder.build().parse(args);
-cmd.run();
+ cmd.run();
+} catch (CommandFailedException | ValidationFailedException ex) {
+ System.exit(1);
Review comment:
Should print exception message, and then exit(1)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
chanjarster commented on a change in pull request #65: cli exit with status
code 1 when checkstyle or checkcompatibility were not passed
URL: https://github.com/apache/servicecomb-toolkit/pull/65#discussion_r355250786
##
File path:
cli/src/main/java/org/apache/servicecomb/toolkit/cli/CheckStyleBase.java
##
@@ -92,7 +92,7 @@ public void run() {
LOGGER.info("path : {}\nerror : {}\n--",
OasObjectPropertyLocation.toPathString(violation.getLocation()),
violation.getError());
}
- return;
+ throw new CommandFailedException("check not passed");
Review comment:
I think we can also use ValidationFailedException here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
chanjarster commented on a change in pull request #65: cli exit with status
code 1 when checkstyle or checkcompatibility were not passed
URL: https://github.com/apache/servicecomb-toolkit/pull/65#discussion_r355250822
##
File path:
cli/src/main/java/org/apache/servicecomb/toolkit/cli/CommandFailedException.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.toolkit.cli;
+
+public class CommandFailedException extends RuntimeException {
Review comment:
This class is not necessary
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-toolkit] chanjarster commented on a change in pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
chanjarster commented on a change in pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed URL: https://github.com/apache/servicecomb-toolkit/pull/65#discussion_r355250661 ## File path: cli/pom.xml ## @@ -86,6 +86,14 @@ org.apache.servicecomb.toolkit oas-validator-compatibility + + + com.github.stefanbirkner Review comment: We should declare it in project root pom.xml's dependencyManagement part This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] cashtang opened a new pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
cashtang opened a new pull request #65: cli exit with status code 1 when checkstyle or checkcompatibility were not passed URL: https://github.com/apache/servicecomb-toolkit/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1034: spring-boot-starter命名建议
liubao68 commented on issue #1034: spring-boot-starter命名建议 URL: https://github.com/apache/servicecomb-java-chassis/issues/1034#issuecomment-563045748 fixed in master(2.0.0-SNAPSHOT) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] cashtang closed pull request #64: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
cashtang closed pull request #64: cli exit with status code 1 when checkstyle or checkcompatibility were not passed URL: https://github.com/apache/servicecomb-toolkit/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1034: spring-boot-starter命名建议
liubao68 closed issue #1034: spring-boot-starter命名建议 URL: https://github.com/apache/servicecomb-java-chassis/issues/1034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 closed issue #1213: rpc提供方方法重名，消费方调用时，会报方法名找不到的错误
liubao68 closed issue #1213: rpc提供方方法重名，消费方调用时，会报方法名找不到的错误 URL: https://github.com/apache/servicecomb-java-chassis/issues/1213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1213: rpc提供方方法重名，消费方调用时，会报方法名找不到的错误
liubao68 commented on issue #1213: rpc提供方方法重名，消费方调用时，会报方法名找不到的错误 URL: https://github.com/apache/servicecomb-java-chassis/issues/1213#issuecomment-563045619 fixed in 1.3.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] cashtang opened a new pull request #64: cli exit with status code 1 when checkstyle or checkcompatibility were not passed
cashtang opened a new pull request #64: cli exit with status code 1 when checkstyle or checkcompatibility were not passed URL: https://github.com/apache/servicecomb-toolkit/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-toolkit] cashtang closed pull request #63: System.exit(1) when checkstyle not passed
cashtang closed pull request #63: System.exit(1) when checkstyle not passed URL: https://github.com/apache/servicecomb-toolkit/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1446: 请求的URL中存在冒号报错490
liubao68 edited a comment on issue #1446: 请求的URL中存在冒号报错490 URL: https://github.com/apache/servicecomb-java-chassis/issues/1446#issuecomment-563026248 你尝试了： ``` https://ip:port/rest/微服务/query/test%3Aname ``` 吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1446: 请求的URL中存在冒号报错490
liubao68 commented on issue #1446: 请求的URL中存在冒号报错490 URL: https://github.com/apache/servicecomb-java-chassis/issues/1446#issuecomment-563026248 你尝试了： ``` https://ip:port/rest/微服务/query/test%%3Aname ``` 吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-java-chassis] branch master updated (7abdd2b -> d27a15e)
This is an automated email from the ASF dual-hosted git repository.
liubao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git.
from 7abdd2b [SCB-1638]servicecenter do not handle websocket PING/PONG
message and test error fixes (#1434)
add d27a15e [SCB-1624]change starter name according to spring boot
conventions. (#1439)
No new revisions were added by this update.
Summary of changes:
.../README.md | 6 +-
.../main/resources/archetype-resources/README.md | 6 +-
.../src/main/resources/archetype-resources/pom.xml | 2 +-
demo/demo-spring-boot-provider/pom.xml | 2 +-
.../demo-spring-boot-pojo-client/pom.xml | 2 +-
.../demo-spring-boot-pojo-server/pom.xml | 2 +-
.../it-producer-deploy-springboot2-servlet/pom.xml | 2 +-
.../pom.xml| 2 +-
integration-tests/spring-jaxrs-tests/pom.xml | 2 +-
.../pom.xml| 2 +-
.../pom.xml| 2 +-
java-chassis-dependencies/default/pom.xml | 12 ++--
java-chassis-distribution/pom.xml | 13 ++--
.../pom.xml| 6 +-
.../springboot/common/AbstractDiscoveryClient.java | 0
.../springboot/common/InstanceDiscoveryFilter.java | 0
.../pom.xml| 11 +--
.../starter/discovery/ScbDiscoveryClient.java | 0
.../discovery/ScbDiscoveryClientConfiguration.java | 0
.../discovery/ScbRibbonClientConfiguration.java| 80 +++---
.../starter/discovery/ScbRibbonConfiguration.java | 68 +-
.../ScbRibbonEndpointDiscoveryFilter.java | 0
.../starter/discovery/ServiceCombServerList.java | 0
.../starter/discovery/package-info.java| 0
.../src/main/resources/META-INF/spring.factories | 0
.../pom.xml| 8 +--
.../pom.xml| 8 +--
.../starter/servlet/RestServletInitializer.java| 0
.../springboot2/starter/servlet/package-info.java | 0
.../pom.xml| 9 +--
.../java-chassis-spring-boot-starter}/pom.xml | 6 +-
.../springboot2/starter/EnableServiceComb.java | 0
.../starter/ServiceCombSpringConfiguration.java| 0
.../pom.xml| 18 ++---
java-chassis-spring-boot/pom.xml | 8 ++-
35 files changed, 140 insertions(+), 137 deletions(-)
rename java-chassis-spring-boot/{spring-boot-common =>
java-chassis-spring-boot-common}/pom.xml (91%)
rename java-chassis-spring-boot/{spring-boot-common =>
java-chassis-spring-boot-common}/src/main/java/org/apache/servicecomb/springboot/common/AbstractDiscoveryClient.java
(100%)
rename java-chassis-spring-boot/{spring-boot-common =>
java-chassis-spring-boot-common}/src/main/java/org/apache/servicecomb/springboot/common/InstanceDiscoveryFilter.java
(100%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/pom.xml
(91%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/ScbDiscoveryClient.java
(100%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/ScbDiscoveryClientConfiguration.java
(100%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/ScbRibbonClientConfiguration.java
(97%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/ScbRibbonConfiguration.java
(97%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/ScbRibbonEndpointDiscoveryFilter.java
(100%)
rename
java-chassis-spring-boot/{spring-boot2-starter-parent/spring-boot2-starter-discovery
=>
java-chassis-spring-boot-starters/java-chassis-spring-boot-starter-discovery}/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/ServiceCombServerList.java
(100%)
rename
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1439: [SCB-1624]change starter name according to spring boot conventions.
liubao68 merged pull request #1439: [SCB-1624]change starter name according to spring boot conventions. URL: https://github.com/apache/servicecomb-java-chassis/pull/1439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
