[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1623: [SCB-1795] when use query object, sdk don't support fluent setter
coveralls commented on issue #1623: [SCB-1795] when use query object, sdk don't support fluent setter URL: https://github.com/apache/servicecomb-java-chassis/pull/1623#issuecomment-595645789 [](https://coveralls.io/builds/29172356) Coverage increased (+0.08%) to 84.995% when pulling **2ab82777124aeb1534413f1bff8c922afe6aea32 on heyile:scb-1795** into **908e20fdd30694d481b372fa178d3db7e39454bf on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] yhs0092 commented on issue #1619: cse是否支持schemaId或mappath粒度的契约注册控制
yhs0092 commented on issue #1619: cse是否支持schemaId或mappath粒度的契约注册控制 URL: https://github.com/apache/servicecomb-java-chassis/issues/1619#issuecomment-595643322 对于ServiceComb体系下的微服务而言，一个微服务的版本确定时，它的接口也是确定的。所以同一个微服务同一个版本的实例分两拨，一拨注册这些接口契约，另一拨注册那些接口契约，这种事情在ServiceComb的概念下是说不通的。 最终要怎么解决问题取决于你是怎么看待这两个集群中的服务的。如果因为环境不同，它们就是提供不同的功能的，那么可能改一下微服务名字，保证两个集群里的实例分属于不同名的两个微服务可能更好一些。让客户端分别调用。 如果这种不一致只是暂时的，你也可以考虑使用Java-Chassis的负载均衡模块自带的[根据实例属性进行路由转发](https://docs.servicecomb.io/java-chassis/zh_CN/references-handlers/loadbalance/)功能。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] YYKI closed issue #1602: 请教，highway通信模式下是否可以指定ip访问特定实例的接口
YYKI closed issue #1602: 请教，highway通信模式下是否可以指定ip访问特定实例的接口 URL: https://github.com/apache/servicecomb-java-chassis/issues/1602 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] zhufeizzz removed a comment on issue #1622: 跟SpringMVC共用的时候会存在路径冲突
zhufeizzz removed a comment on issue #1622: 跟SpringMVC共用的时候会存在路径冲突 URL: https://github.com/apache/servicecomb-java-chassis/issues/1622#issuecomment-595207392 SpringMVC本身可以根据Bean名称前缀进行排除，CSE是不是可以考虑生成Bean的时候按这个规范来生成啊 `org.springframework.web.servlet.handler.AbstractHandlerMethodMapping#SCOPED_TARGET_NAME_PREFIX` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] Bluselye commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？
Bluselye commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1611#issuecomment-595551432 使用Handler方式我试过了，请求异常时也会直接抛到业务层面，进不了handler. 一个异常日志如下： [15:08:34.101][E][ool-16-thread-2][a.r.s.i.UserDownloadResultImpl.193] -Request AppGalleryUserCenterService error:InvocationException: code=490;msg=CommonExceptionData [message=Cse Internal Bad Request] org.apache.servicecomb.swagger.invocation.exception.InvocationException: InvocationException: code=490;msg=CommonExceptionData [message=Cse Internal Bad Request] at org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory.doCreate(ExceptionFactory.java:79) at org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory.convertException(ExceptionFactory.java:124) at org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory.convertConsumerException(ExceptionFactory.java:83) at org.apache.servicecomb.swagger.invocation.Response.createConsumerFail(Response.java:129) at org.apache.servicecomb.swagger.invocation.Response.createFail(Response.java:122) at org.apache.servicecomb.swagger.invocation.Response.failResp(Response.java:165) at org.apache.servicecomb.bizkeeper.FallbackPolicyManager.getFallbackResponse(FallbackPolicyManager.java:44) at org.apache.servicecomb.bizkeeper.BizkeeperCommand.lambda$resumeWithFallback$0(BizkeeperCommand.java:65) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:50) at rx.internal.operators.OnSubscribeLift.call(OnSubscribeLift.java:30) at rx.Observable.unsafeSubscribe(Observable.java:8666) at rx.internal.operators.OperatorOnErrorResumeNextViaFunction$4.onError(OperatorOnErrorResumeNextViaFunction.java:142) at rx.internal.operators.OperatorDoOnEach$1.onError(OperatorDoOnEach.java:72) at rx.internal.operators.OperatorDoOnEach$1.onError(OperatorDoOnEach.java:72) at rx.observers.Subscribers$5.onError(Subscribers.java:230) ODS_HISPACE_OUTERCALL_LOG_DM at com.netflix.hystrix.AbstractCommand$DeprecatedOnRunHookApplication$1.onError(AbstractCommand.java:1431) at com.netflix.hystrix.AbstractCommand$ExecutionHookApplication$1.onError(AbstractCommand.java:1362) at org.apache.servicecomb.bizkeeper.BizkeeperCommand.lambda$null$1(BizkeeperCommand.java:84) at org.apache.servicecomb.swagger.invocation.AsyncResponse.fail(AsyncResponse.java:42) at org.apache.servicecomb.transport.rest.client.http.RestClientInvocation.fail(RestClientInvocation.java:278) at org.apache.servicecomb.transport.rest.client.http.RestClientInvocation.lambda$invoke$0(RestClientInvocation.java:112) at io.vertx.core.http.impl.HttpClientRequestBase.handleException(HttpClientRequestBase.java:139) at io.vertx.core.http.impl.HttpClientRequestBase.timeout(HttpClientRequestBase.java:211) at io.vertx.core.http.impl.HttpClientRequestBase.handleTimeout(HttpClientRequestBase.java:194) at io.vertx.core.http.impl.HttpClientRequestBase.lambda$setTimeout$0(HttpClientRequestBase.java:124) at io.vertx.core.impl.VertxImpl$InternalTimerHandler.handle(VertxImpl.java:906) at io.vertx.core.impl.VertxImpl$InternalTimerHandler.handle(VertxImpl.java:865) at io.vertx.core.impl.ContextImpl.executeTask(ContextImpl.java:320) at io.vertx.core.impl.EventLoopContext.lambda$executeAsync$0(EventLoopContext.java:38) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) at
[GitHub] [servicecomb-java-chassis] heyile opened a new pull request #1623: [SCB-1795] when use query object, sdk don't support fluent setter
heyile opened a new pull request #1623: [SCB-1795] when use query object, sdk don't support fluent setter URL: https://github.com/apache/servicecomb-java-chassis/pull/1623 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] zhufeizzz commented on issue #1622: 跟SpringMVC共用的时候会存在路径冲突
zhufeizzz commented on issue #1622: 跟SpringMVC共用的时候会存在路径冲突 URL: https://github.com/apache/servicecomb-java-chassis/issues/1622#issuecomment-595207392 SpringMVC本身可以根据Bean名称前缀进行排除，CSE是不是可以考虑生成Bean的时候按这个规范来生成啊 `org.springframework.web.servlet.handler.AbstractHandlerMethodMapping#SCOPED_TARGET_NAME_PREFIX` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] zhufeizzz opened a new issue #1622: 跟SpringMVC共用的时候会存在路径冲突
zhufeizzz opened a new issue #1622: 跟SpringMVC共用的时候会存在路径冲突
URL: https://github.com/apache/servicecomb-java-chassis/issues/1622
```
@RestSchema(schemaId = "RepeatServiceA")
@RequestMapping(path = "/rest/repeat-a")
public class RepeatService
@RestController("RepeatServiceB")
@RequestMapping(path = "/rest/repeat-a")
public class RepeatService {
```
比如下面这两种，因路径冲突SpringMVC会报“Ambiguous
mapping”异常。即使CSE和SpringMVC分别声明了独立的根路径。这种问题有什么解决建议吗？
```
spring:
mvc:
servlet:
path: /ui
servicecomb:
servlet:
urlPattern: /cse/*
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile edited a comment on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？
heyile edited a comment on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1616#issuecomment-595155467 @yhs0092 已经回了, 可以在 #1611 中讨论 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] yhs0092 commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？
yhs0092 commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1611#issuecomment-595161235 想捕获异常的话也可以考虑使用`Handler`扩展来做，放在consumer端Handler链里面。不过Java-Chassis框架以抛出`InvocationException`的方式表达错误返回码，如果你们有自定义的错误返回，并且使用RPC方式调用的话，让框架把InvocationException抛出来可能更好一些。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] Bluselye commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？
Bluselye commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1611#issuecomment-595155650 这个可以实现，但是我们目标要求能记录到异常信息，从HttpClientFilter中记录不到异常信息，异常会在产生后抛到业务层去。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？
heyile commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1616#issuecomment-595155467 海石已经回了, 可以在 #1611 中讨论 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] yhs0092 commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？
yhs0092 commented on issue #1611: ServiceComb有access.log访问自身的日志，那有没有调用其他服务的outcall.log?如果有该怎么配置？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1611#issuecomment-595154386 经过Java-Chassis发出去的REST请求都会经过`HttpClientFilter`，做一个扩展实现来打印日志应该可以满足需求吧： This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] Bluselye commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？
Bluselye commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1616#issuecomment-595153168 做个记录outcall.log的功能，想从框架里面做实现，目前来看不好实现 https://github.com/apache/servicecomb-java-chassis/issues/1611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？
heyile commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1616#issuecomment-595150048 你的使用场景是啥? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？
heyile commented on issue #1616: ServiceComb 进行RPC调用时RestClientInvocation可以支持自已实现么？ URL: https://github.com/apache/servicecomb-java-chassis/issues/1616#issuecomment-595149579 暂时没有把这个开放出来. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
