[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
coveralls edited a comment on pull request #1825: URL: https://github.com/apache/servicecomb-java-chassis/pull/1825#issuecomment-641591330 [](https://coveralls.io/builds/31355511) Coverage increased (+0.4%) to 86.816% when pulling **c497ee142e3af48f7e38b051cad0e309505449ce on jungan21:master** into **1c4f7c61d70bdac7df6f8ab2adc0f020c1d5db73 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
coveralls edited a comment on pull request #1825: URL: https://github.com/apache/servicecomb-java-chassis/pull/1825#issuecomment-641591330 [](https://coveralls.io/builds/31355393) Coverage increased (+0.4%) to 86.827% when pulling **c497ee142e3af48f7e38b051cad0e309505449ce on jungan21:master** into **1c4f7c61d70bdac7df6f8ab2adc0f020c1d5db73 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[servicecomb-java-chassis] branch master updated: [SCB-1991]support dynamic register service in local part 1: support bean registration
This is an automated email from the ASF dual-hosted git repository.
liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new 1c4f7c6 [SCB-1991]support dynamic register service in local part 1:
support bean registration
1c4f7c6 is described below
commit 1c4f7c61d70bdac7df6f8ab2adc0f020c1d5db73
Author: liubao
AuthorDate: Tue Jun 9 20:49:33 2020 +0800
[SCB-1991]support dynamic register service in local part 1: support bean
registration
---
coverage-reports/pom.xml | 19 +++
demo/demo-local-registry/README.md | 2 +-
.../demo/localRegistryClient/Application.java | 3 +
.../LocalRegistryServerTest.java | 22 ++-
.../RegistryBeansConfiguration.java| 49 ++
.../ServerEndpoint.yaml| 43 +
.../localregistry/LocalRegistryStore.java | 123 +++---
.../servicecomb/localregistry/RegistryBean.java| 178 +
8 files changed, 357 insertions(+), 82 deletions(-)
diff --git a/coverage-reports/pom.xml b/coverage-reports/pom.xml
index 133390a..ae7e00d 100644
--- a/coverage-reports/pom.xml
+++ b/coverage-reports/pom.xml
@@ -498,6 +498,25 @@
${project.version}
test
+
+
+ org.apache.servicecomb.demo
+ demo-zeroconfig-schemadiscovery-registry-client
+ ${project.version}
+ test
+
+
+ org.apache.servicecomb.demo
+ demo-zeroconfig-schemadiscovery-registry-server
+ ${project.version}
+ test
+
+
+ org.apache.servicecomb.demo
+ demo-zeroconfig-schemadiscovery-registry-tests
+ ${project.version}
+ test
+
diff --git a/demo/demo-local-registry/README.md
b/demo/demo-local-registry/README.md
index 6bb7dd8..7ace9bd 100644
--- a/demo/demo-local-registry/README.md
+++ b/demo/demo-local-registry/README.md
@@ -1,6 +1,6 @@
This demo is an integration test for testing local registration an discovery.
-Local registration an discovery is an mechanism that do not using Service
Center,
+Local registration and discovery is a mechanism that do not using Service
Center,
`Microservice` and `MicroserviceInstance` are constructed from configuration
file.
diff --git
a/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/Application.java
b/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/Application.java
index d54220a..c6ed407 100644
---
a/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/Application.java
+++
b/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/Application.java
@@ -45,6 +45,9 @@ public class Application {
RegistrationManager.INSTANCE.getSwaggerLoader().registerSwagger("demo-local-registry",
"demo-local-registry-server",
"CodeFirstEndpoint", CodeFirstService.class);
+
RegistrationManager.INSTANCE.getSwaggerLoader().registerSwagger("demo-local-registry",
+"demo-local-registry-server-bean",
+"CodeFirstEndpoint", CodeFirstService.class);
}
private static void runTest() throws Exception {
diff --git
a/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/LocalRegistryServerTest.java
b/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/LocalRegistryServerTest.java
index 058f091..759fd87 100644
---
a/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/LocalRegistryServerTest.java
+++
b/demo/demo-local-registry/demo-local-registry-client/src/main/java/org/apache/servicecomb/demo/localRegistryClient/LocalRegistryServerTest.java
@@ -33,6 +33,9 @@ public class LocalRegistryServerTest implements
CategorizedTestCase {
@RpcReference(microserviceName = "demo-local-registry-server", schemaId =
"CodeFirstEndpoint")
private CodeFirstService codeFirstService;
+ @RpcReference(microserviceName = "demo-local-registry-server-bean", schemaId
= "CodeFirstEndpoint")
+ private CodeFirstService codeFirstServiceBean;
+
RestTemplate template = RestTemplateBuilder.create();
@Override
@@ -48,15 +51,17 @@ public class LocalRegistryServerTest implements
CategorizedTestCase {
for (Microservice m : microserviceList) {
if (m.getServiceName().equals("demo-local-registry-client")
- || m.getServiceName().equals("demo-local-registry-server")) {
+ || m.getServiceName().equals("demo-local-registry-server")
+ || m.getServiceName().equals("demo-local-registry-server-bean")) {
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1824: [SCB-1991]support dynamic register service in local part 1: support b…
liubao68 merged pull request #1824: URL: https://github.com/apache/servicecomb-java-chassis/pull/1824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
liubao68 commented on a change in pull request #1825:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1825#discussion_r437823717
##
File path:
service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/server/ServerUtil.java
##
@@ -179,12 +179,12 @@ private static ServerMicroserviceInstance
buildServerMicroserviceInstanceFromMap
private static void startListenerForRegisterUnregisterEvent() {
try {
- byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able
to receive the data
while (true) {
+byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
DatagramPacket receivePacketBuffer = new DatagramPacket(buffer,
buffer.length);
multicastSocket.receive(receivePacketBuffer);
String receivedPacketString = new
String(receivePacketBuffer.getData(), ENCODE);
Review comment:
Maybe you misunderstanding my point. You should do this
```
multicastSocket.receive(receivePacketBuffer);
int len = receivePacketBuffer.getLength() ;
if(len > 0) {
String receivedPacketString = new String(receivePacketBuffer.getData(),
0, len, ENCODE);
}
```
And you can avoid creating new buffers for each receive, though this is not
very important because the next receive happens in seconds.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
liubao68 commented on a change in pull request #1825:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1825#discussion_r437823717
##
File path:
service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/server/ServerUtil.java
##
@@ -179,12 +179,12 @@ private static ServerMicroserviceInstance
buildServerMicroserviceInstanceFromMap
private static void startListenerForRegisterUnregisterEvent() {
try {
- byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able
to receive the data
while (true) {
+byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
DatagramPacket receivePacketBuffer = new DatagramPacket(buffer,
buffer.length);
multicastSocket.receive(receivePacketBuffer);
String receivedPacketString = new
String(receivePacketBuffer.getData(), ENCODE);
Review comment:
Maybe you misunderstanding my point. You should do this
```
multicastSocket.receive(receivePacketBuffer);
int len = multicastSocket.getLength() ;
if(len > 0) {
String receivedPacketString = new String(receivePacketBuffer.getData(),
0, len, ENCODE);
}
```
And you can avoid creating new buffers for each receive, though this is not
very important because the next receive happens in seconds.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
liubao68 commented on a change in pull request #1825:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1825#discussion_r437823717
##
File path:
service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/server/ServerUtil.java
##
@@ -179,12 +179,12 @@ private static ServerMicroserviceInstance
buildServerMicroserviceInstanceFromMap
private static void startListenerForRegisterUnregisterEvent() {
try {
- byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able
to receive the data
while (true) {
+byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
DatagramPacket receivePacketBuffer = new DatagramPacket(buffer,
buffer.length);
multicastSocket.receive(receivePacketBuffer);
String receivedPacketString = new
String(receivePacketBuffer.getData(), ENCODE);
Review comment:
Maybe you misunderstanding my point. You should do this
```
multicastSocket.receive(receivePacketBuffer);
int len = multicastSocket.getLength() ;
if(len > 0) {
String receivedPacketString = new String(receivePacketBuffer.getData(),
0, len, ENCODE);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] jungan21 commented on a change in pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
jungan21 commented on a change in pull request #1825:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1825#discussion_r437822660
##
File path:
service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/server/ServerUtil.java
##
@@ -179,12 +179,12 @@ private static ServerMicroserviceInstance
buildServerMicroserviceInstanceFromMap
private static void startListenerForRegisterUnregisterEvent() {
try {
- byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able
to receive the data
while (true) {
+byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
DatagramPacket receivePacketBuffer = new DatagramPacket(buffer,
buffer.length);
multicastSocket.receive(receivePacketBuffer);
String receivedPacketString = new
String(receivePacketBuffer.getData(), ENCODE);
Review comment:
good point. Unfortunately, based on the Multicast working mechanism, we
have to create a buffer before data is received. After data is received, then
buffer is filled with the received data. So we can't create a buffer with
size exactly same as the received data.
By the way, it's also mentioned in the JDK source code comments:
https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/java/net/DatagramSocket.java#L698-L700
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1824: [SCB-1991]support dynamic register service in local part 1: support b…
coveralls edited a comment on pull request #1824: URL: https://github.com/apache/servicecomb-java-chassis/pull/1824#issuecomment-641336464 [](https://coveralls.io/builds/31352837) Coverage increased (+0.02%) to 86.452% when pulling **2e46d44ac92dbfaef73eaaee6a3ccf85001a85f0 on liubao68:liubao** into **6974534ac55a1b7f6b4e53aa79e1f6e712e93cfa on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[servicecomb-website] 02/02: Publish the website
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git
commit 765400e3ec326942e6775b9d682b89ca98160da2
Author: Willem Jiang
AuthorDate: Wed Jun 10 09:04:40 2020 +0800
Publish the website
---
content/cn/summer2020.html | 4 ++--
content/feed.xml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/content/cn/summer2020.html b/content/cn/summer2020.html
index 4353570..873ba41 100644
--- a/content/cn/summer2020.html
+++ b/content/cn/summer2020.html
@@ -316,7 +316,7 @@
-ServiceComb summer2020项目如下：
+ServiceComb
summer2020项目如下：以下项目均采用 https://www.apache.org/licenses/LICENSE-2.0.txt;>Apache License 2.0
协议
微服务一键部署工具
@@ -356,7 +356,7 @@
如何参与
- 直接跟导师发邮件。导师将知道你完成后续工作。
+ 直接跟导师发邮件。导师将指导你完成后续工作。
了解更多如何参与的信息: https://isrc.iscas.ac.cn/summer2020/help/student.html#%E5%AD%A6%E7%94%9F%E5%A6%82%E4%BD%95%E6%8A%A5%E5%90%8D;>如何报名
diff --git a/content/feed.xml b/content/feed.xml
index 9d0ef62..70372e8 100644
--- a/content/feed.xml
+++ b/content/feed.xml
@@ -1,4 +1,4 @@
-http://www.w3.org/2005/Atom; >https://jekyllrb.com/;
version="3.8.5">Jekyll2020-05-29T08:13:13+08:00/feed.xmlApache ServiceCombThe homepage of
ServiceComb{name=nil,
avatar= [...]
+http://www.w3.org/2005/Atom; >https://jekyllrb.com/;
version="3.8.5">Jekyll2020-06-10T09:02:12+08:00/feed.xmlApache ServiceCombThe homepage of
ServiceComb{name=nil,
avatar= [...]
p本次讲座得到广东工业大学计算机院学生会同学们的鼎力支持和参与。报名通道开放后，报名人数迅速达到150+，活动放在学校报告厅举办。即便在周日，同学们的热情仍然很高，给广东工业大学的同学们点赞。/p
[servicecomb-website] branch master updated (ea0b1a1 -> bbd3f98)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from ea0b1a1 add summer 2020 license add a089994 Update the release information add bbd3f98 Added a new task of summer 2020 No new revisions were added by this update. Summary of changes: _pages/cn/home.md | 8 _pages/cn/summer2020.md | 16 +++- _pages/home.md | 6 +++--- 3 files changed, 18 insertions(+), 12 deletions(-)
[GitHub] [servicecomb-java-chassis] liubao68 closed pull request #1824: [SCB-1991]support dynamic register service in local part 1: support b…
liubao68 closed pull request #1824: URL: https://github.com/apache/servicecomb-java-chassis/pull/1824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[servicecomb-website] branch asf-site updated (825264c -> 765400e)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git. from 825264c Publish the website add ea0b1a1 add summer 2020 license add a089994 Update the release information add bbd3f98 Added a new task of summer 2020 new b34dc99 Merge branch 'master' into asf-site new 765400e Publish the website The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: _pages/cn/summer2020.md| 4 ++-- content/cn/summer2020.html | 4 ++-- content/feed.xml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #1824: [SCB-1991]support dynamic register service in local part 1: support b…
liubao68 commented on pull request #1824: URL: https://github.com/apache/servicecomb-java-chassis/pull/1824#issuecomment-641658985 retrigger CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[servicecomb-website] 01/02: Merge branch 'master' into asf-site
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git commit b34dc99f4e6774b61e654f35b603ea6611b6b953 Merge: 825264c bbd3f98 Author: Willem Jiang AuthorDate: Wed Jun 10 09:01:30 2020 +0800 Merge branch 'master' into asf-site _pages/cn/summer2020.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
liubao68 commented on a change in pull request #1825:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1825#discussion_r437803087
##
File path:
service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/server/ServerUtil.java
##
@@ -179,12 +179,12 @@ private static ServerMicroserviceInstance
buildServerMicroserviceInstanceFromMap
private static void startListenerForRegisterUnregisterEvent() {
try {
- byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able
to receive the data
while (true) {
+byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
DatagramPacket receivePacketBuffer = new DatagramPacket(buffer,
buffer.length);
multicastSocket.receive(receivePacketBuffer);
String receivedPacketString = new
String(receivePacketBuffer.getData(), ENCODE);
Review comment:
This logic seams not correct. Maybe you'd check the length of data
actually received and using the correct data.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[servicecomb-website] branch master updated: add summer 2020 license
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git The following commit(s) were added to refs/heads/master by this push: new ea0b1a1 add summer 2020 license ea0b1a1 is described below commit ea0b1a17c415e6d2e5b7d7e20028d08452199a21 Author: alec.zheng AuthorDate: Tue Jun 9 15:59:46 2020 +0800 add summer 2020 license --- _pages/cn/summer2020.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_pages/cn/summer2020.md b/_pages/cn/summer2020.md index 22f52d1..8533187 100644 --- a/_pages/cn/summer2020.md +++ b/_pages/cn/summer2020.md @@ -13,7 +13,7 @@ last_modified_at: 2020-05-25T09:46:01+08:00  -### ServiceComb summer2020项目如下： +### ServiceComb summer2020项目如下：以下项目均采用 [Apache License 2.0 协议](https://www.apache.org/licenses/LICENSE-2.0.txt) 1. 微服务一键部署工具 + 一个微服务系统会包含会多个微服务，微服务框架本身的也会包含多个组件，如注册中心，网关，分布式事务组件等，如何方便快速的将整个微服务在不同的环境中迁移是一个挑战。希望能使用Terraform开发一个工具，帮助ServiceComb微服务 应用一键迁移上云。（AWS, 华为云等）。 @@ -35,5 +35,5 @@ last_modified_at: 2020-05-25T09:46:01+08:00 + 所需技能: Java ### 如何参与 -+ 直接跟导师发邮件。导师将知道你完成后续工作。 ++ 直接跟导师发邮件。导师将指导你完成后续工作。 + 了解更多如何参与的信息: [如何报名](https://isrc.iscas.ac.cn/summer2020/help/student.html#%E5%AD%A6%E7%94%9F%E5%A6%82%E4%BD%95%E6%8A%A5%E5%90%8D)
[GitHub] [servicecomb-website] WillemJiang merged pull request #253: add summer 2020 license
WillemJiang merged pull request #253: URL: https://github.com/apache/servicecomb-website/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
coveralls commented on pull request #1825: URL: https://github.com/apache/servicecomb-java-chassis/pull/1825#issuecomment-641591330 [](https://coveralls.io/builds/31349126) Coverage increased (+0.003%) to 86.432% when pulling **b73ad72402b03002428a1896ac853485c436b6f0 on jungan21:master** into **6974534ac55a1b7f6b4e53aa79e1f6e712e93cfa on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] jungan21 opened a new pull request #1825: [SCB-1995]Fix incorrect message issue identifed through testing
jungan21 opened a new pull request #1825: URL: https://github.com/apache/servicecomb-java-chassis/pull/1825 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1824: [SCB-1991]support dynamic register service in local part 1: support b…
coveralls commented on pull request #1824: URL: https://github.com/apache/servicecomb-java-chassis/pull/1824#issuecomment-641336464 [](https://coveralls.io/builds/31339314) Coverage increased (+0.02%) to 86.452% when pulling **2e46d44ac92dbfaef73eaaee6a3ccf85001a85f0 on liubao68:liubao** into **6974534ac55a1b7f6b4e53aa79e1f6e712e93cfa on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1823: [SCB-1944]create a demo to show zero config work with schema discovery
coveralls commented on pull request #1823: URL: https://github.com/apache/servicecomb-java-chassis/pull/1823#issuecomment-640556996 [](https://coveralls.io/builds/31308626) Coverage decreased (-0.05%) to 86.44% when pulling **514f549c4711400caa67dbc59b64fc77a4a9272c on liubao68:liubao** into **f72b125376b95dcb21802a7f62e6f50e501fc051 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1824: [SCB-1991]support dynamic register service in local part 1: support b…
liubao68 opened a new pull request #1824: URL: https://github.com/apache/servicecomb-java-chassis/pull/1824 …ean registration Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1823: [SCB-1944]create a demo to show zero config work with schema discovery
liubao68 merged pull request #1823: URL: https://github.com/apache/servicecomb-java-chassis/pull/1823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [servicecomb-website] alec-z opened a new pull request #253: add summer 2020 license
alec-z opened a new pull request #253: URL: https://github.com/apache/servicecomb-website/pull/253 @WillemJiang add summer2020 projects license claim. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
