[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #125: fix status/value_type don't update

2020-03-25 Thread GitBox 
tianxiaoliang commented on a change in pull request #125: fix status/value_type 
don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397674245
 
 

 ##
 File path: server/service/mongo/kv/kv_dao.go
 ##
 @@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) 
error {
ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": 
kv.LabelID}, bson.D{
{"$set", bson.D{
{"value", kv.Value},
+   {"value_type", kv.ValueType},
 
 Review comment:
   我担心引入复杂性，类型这种东西以后我们要基于它做什么演进特性就麻烦了，我只想减少复杂度引起的思考


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #125: fix status/value_type don't update

2020-03-25 Thread GitBox 
tianxiaoliang commented on a change in pull request #125: fix status/value_type 
don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397651742
 
 

 ##
 File path: server/service/mongo/kv/kv_dao.go
 ##
 @@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) 
error {
ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": 
kv.LabelID}, bson.D{
{"$set", bson.D{
{"value", kv.Value},
+   {"value_type", kv.ValueType},
 
 Review comment:
   value_type 本来就不支持修改


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services