[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585072060 > > @WillemJiang I check the meaning of 'optional' in maven, this can not fullfil the purpose of the PR. By adding this, I want users include the file without notice to run across local and cloud. If 'optional' is defined, users still need to add this dependency in their pom. This is quite like not have this PR. > > 'optional' means it's not used by default, I'm not talking about the maven optional scope, I'm talking about if the user want to write the application to run with Huawei Cloud , he can add the dependency pom, but when we do the Apache release, we don't include this dependency pom by default. ```solution-basic``` is optional to users, they may not use this pom. The purpose of adding this pom is for easier of deploy. Or users will always be noticed to include the dependency and configure repositories. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585065271 @WillemJiang I check the meaning of 'optional' in maven, this can not fullfil the purpose of the PR. By adding this, I want users include the file without notice to run across local and cloud. If 'optional' is defined, users still need to add this dependency in their pom. This is quite like not have this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585013732 Users use it without notice. By adding this, samples provided in servicecomb-samples can run both in local and cloud This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
