[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3587: [SCB-2752] Filter out configurations with empty values

2023-01-28 Thread via GitHub


liubao68 commented on PR #3587:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/3587#issuecomment-1407530283

   如果是这样, 我理解这个修改不是很完整。 archaius不支持value=null的配置项, 
而其他配置源支持,所以比较合理的修改应该是在将其他配置也复制到archaius的时候,统一过滤掉value=null的MAP键值对。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3587: [SCB-2752] Filter out configurations with empty values

2023-01-19 Thread GitBox


liubao68 commented on PR #3587:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/3587#issuecomment-1396655273

   但是实际场景是怎么发生的了? 环境变量按照道理不会存在 null 的情况。 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3587: [SCB-2752] Filter out configurations with empty values

2023-01-18 Thread GitBox


liubao68 commented on PR #3587:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/3587#issuecomment-1396528635

   Can you provide any information on how to reproduce the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org