[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center
liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center URL: https://github.com/apache/servicecomb-java-chassis/pull/1356#issuecomment-545719948 > > You mentioned this components maybe used for spring cloud, and I checked project [spring-cloud-hauwei](https://github.com/huaweicloud/spring-cloud-huawei/blob/master/README_zh.md), this project has already project clients and discovery features for spring cloud. > > I just want to implement a client for servicecomb server components, such as service-center and kie. > This client will implement all APIs of service-center in the future, not only registry and discovery. > And it can be used by other microservice framework, not only spring cloud. This is a good idea. But I have some requirements that must be done to merge the code: 1. this code can replace the service-registry implementation. It's not a good idea to have two sets of code doing the same job. 2. this code can replace the implementation of spring-cloud-huawei implementation. Match the two requirements can veriry your API design is correct for future. For API module, frequently API change is very big problem, must do it very carefully in design and testing before make it visible to users. I'd prefer you refactor the code of service-registry, not impelement a new one using different techknowedges. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center
liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center URL: https://github.com/apache/servicecomb-java-chassis/pull/1356#issuecomment-545247606 You mentioned this components maybe used for spring cloud, and I checked project [spring-cloud-hauwei](https://github.com/huaweicloud/spring-cloud-huawei/blob/master/README_zh.md), this project has already provide clients and discovery features for spring cloud. java-chassis alreay provide [this feature](https://docs.servicecomb.io/java-chassis/zh_CN/using-java-chassis-in-spring-boot/components-for-spring-boot.html) too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center
liubao68 edited a comment on issue #1356: add a Java client of servicecomb-service-center URL: https://github.com/apache/servicecomb-java-chassis/pull/1356#issuecomment-545230273 Hello, thank you for you contribution and the idea provided in this PR. However I think it is not a good idea to put this implementation in servicecomb-java-chassis project, maybe create a new project is better. servicecomb-java-chassis already has it's own service-center client, in service-registry module. The best way for servicecomb-java-chassis to provide client api for service-center is to refactor the module code, and let other developers use only the module API. And design an open API set for integration other service-registry implementations, like consule, for example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
