[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-18 Thread GitBox
WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug
URL: 
https://github.com/apache/servicecomb-pack/issues/571#issuecomment-544050899
 
 
Thanks for the @xiangyuQi 's PR to address this issue, now we close this 
issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-16 Thread GitBox
WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug
URL: 
https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542556279
 
 
   > 这个还是你们自己写吧,链接中已经写的比较清楚了。但是要考虑到如果使用者在omega端已经实现了一个策略,可能在代理的时候出现问题。
   > 还有这种方式的扩展性比较差,只要新增一个线程变量就要重写一个类。
   > 其他的就没什么了。
   
   线程上下文切换的时候,需要解决OmegaContext传递的问题,我们需要知道你是如何传递ThreadLocal的, 
最好是有一个测试能够复现这个问题,这样可以帮助我们比较快地解这一问题。  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [servicecomb-pack] WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug

2019-10-16 Thread GitBox
WillemJiang commented on issue #571: omega 开启 hystrix,使用Feign调用bug
URL: 
https://github.com/apache/servicecomb-pack/issues/571#issuecomment-542543770
 
 
   > 
我也碰到用Feign调用时,子事务获取不到globalTxId,导致报错。没有用Hystrix,只是单纯的Feign调用,经测试将Feign改为Dubbo调用就没问题。
   
   你是用Feign调用Dubbo服务吗?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services