WillemJiang commented on a change in pull request #693: [SCB-548] support
gracefully shutdown
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r189155630
##########
File path:
core/src/main/java/org/apache/servicecomb/core/provider/consumer/InvokerUtils.java
##########
@@ -32,31 +35,31 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(InvokerUtils.class);
public static Object syncInvoke(String microserviceName, String schemaId,
String operationName, Object[] args) {
- ReferenceConfig referenceConfig =
ReferenceConfigUtils.getForInvoke(microserviceName);
- SchemaMeta schemaMeta =
referenceConfig.getMicroserviceMeta().ensureFindSchemaMeta(schemaId);
- Invocation invocation = InvocationFactory.forConsumer(referenceConfig,
schemaMeta, operationName, args);
- return syncInvoke(invocation);
+ validCanInvoke();
Review comment:
"validCanInvoke" is a bad name (It just check the status of Engine), how
about using the "checkEngineStatus".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
