[GitHub] wujimin commented on issue #732: SCB-333 Update to support the date time with JSR-310

2018-05-28 Thread GitBox 
wujimin commented on issue #732: SCB-333 Update to support the date time with 
JSR-310
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/732#issuecomment-392644183
 
 
   Unit Test
   Integration Test
   :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #732: SCB-333 Update to support the date time with JSR-310

2018-05-28 Thread GitBox 
wujimin commented on issue #732: SCB-333 Update to support the date time with 
JSR-310
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/732#issuecomment-392641531
 
 
   1.RestObjectMapper is for RESTful codec, it's better to add UT for it.
   2.this is just for codec, i'm not sure if we can generate swagger from 
JSR-310 dataTypes
 so it's better to add UT and IT for new dataTypes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services