This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 91df046e0825 [SPARK-41888][PYTHON][CONNECT][TESTS] Enable doctest for 
`DataFrame.observe`
91df046e0825 is described below

commit 91df046e0825c8916107de1cdf7c4a022fb1a53d
Author: Ruifeng Zheng <ruife...@apache.org>
AuthorDate: Wed Mar 20 23:26:30 2024 -0700

    [SPARK-41888][PYTHON][CONNECT][TESTS] Enable doctest for `DataFrame.observe`
    
    ### What changes were proposed in this pull request?
    Enable doctest for `DataFrame.observe`
    
    ### Why are the changes needed?
    for test coverage
    
    ### Does this PR introduce _any_ user-facing change?
    no, test-only
    
    ### How was this patch tested?
    ci
    
    ### Was this patch authored or co-authored using generative AI tooling?
    no
    
    Closes #45627 from zhengruifeng/enable_listener_doctest.
    
    Authored-by: Ruifeng Zheng <ruife...@apache.org>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 python/pyspark/sql/connect/dataframe.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/python/pyspark/sql/connect/dataframe.py 
b/python/pyspark/sql/connect/dataframe.py
index 7171bee24bd7..741606c89aa4 100644
--- a/python/pyspark/sql/connect/dataframe.py
+++ b/python/pyspark/sql/connect/dataframe.py
@@ -2243,9 +2243,6 @@ def _test() -> None:
 
     globs = pyspark.sql.connect.dataframe.__dict__.copy()
 
-    # TODO(SPARK-41888): Support StreamingQueryListener for DataFrame.observe
-    del pyspark.sql.connect.dataframe.DataFrame.observe.__doc__
-
     globs["spark"] = (
         PySparkSession.builder.appName("sql.connect.dataframe tests")
         .remote("local[4]")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to