This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 6a300ce9ed3 [SPARK-46140][SQL][TESTS] Remove comments about JVM module
options from `HiveExternalCatalogVersionsSuite`
6a300ce9ed3 is described below
commit 6a300ce9ed3c4191d24fc935ab9cfe55f52566e4
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Tue Nov 28 17:43:05 2023 -0800
[SPARK-46140][SQL][TESTS] Remove comments about JVM module options from
`HiveExternalCatalogVersionsSuite`
### What changes were proposed in this pull request?
This pr remove the no longer needed JVM module options from
`HiveExternalCatalogVersionsSuite` due to the minimum version for the current
test is Spark 3.3 (Spark 3.2 has already reached EOL).
### Why are the changes needed?
Complete the TODO left by SPARK-37159.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #44057 from LuciferYang/SPARK-46140.
Authored-by: yangjie01 <yangji...@baidu.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.../org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala | 2 --
1 file changed, 2 deletions(-)
diff --git
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
index f63e75c9e4e..52f20595a10 100644
---
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
+++
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
@@ -229,8 +229,6 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
"--conf", s"${WAREHOUSE_PATH.key}=${wareHousePath.getCanonicalPath}",
"--conf", s"spark.sql.test.version.index=$index",
"--driver-java-options",
s"-Dderby.system.home=${wareHousePath.getCanonicalPath} " +
- // TODO SPARK-37159 Consider to remove the following
- // JVM module options once the Spark 3.2 line is EOL.
JavaModuleOptions.defaultModuleOptions(),
tempPyFile.getCanonicalPath)
runSparkSubmit(args, Some(sparkHome.getCanonicalPath), isSparkTesting =
false)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
