This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 1af4b658064d [SPARK-46338][PS][TESTS] Re-enable the `get_item` test
for `BasicIndexingTests`
1af4b658064d is described below
commit 1af4b658064d05b15c4a8409a8aa13df63b64ca4
Author: Haejoon Lee <haejoon....@databricks.com>
AuthorDate: Sat Dec 9 13:46:13 2023 -0800
[SPARK-46338][PS][TESTS] Re-enable the `get_item` test for
`BasicIndexingTests`
### What changes were proposed in this pull request?
This PR proposes to re-enable the `get_item` test for `BasicIndexingTests`.
### Why are the changes needed?
To improve the test coverage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Enable the test.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #44271 from itholic/enable_test_getitem.
Authored-by: Haejoon Lee <haejoon....@databricks.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
python/pyspark/pandas/tests/test_indexing.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/python/pyspark/pandas/tests/test_indexing.py
b/python/pyspark/pandas/tests/test_indexing.py
index a4ca03005b33..eb86c9ffabc4 100644
--- a/python/pyspark/pandas/tests/test_indexing.py
+++ b/python/pyspark/pandas/tests/test_indexing.py
@@ -742,13 +742,13 @@ class IndexingTest(ComparisonTestBase):
self.assertRaises(AttributeError, lambda: psdf.X)
# not str/unicode
- # TODO?: pdf = pd.DataFrame(np.random.randn(10, 5))
- # TODO?: psdf = ps.from_pandas(pdf)
- # TODO?: self.assert_eq(psdf[0], pdf[0])
- # TODO?: self.assert_eq(psdf[[1, 2]], pdf[[1, 2]])
+ pdf = pd.DataFrame(np.random.randn(10, 5))
+ psdf = ps.from_pandas(pdf)
+ self.assert_eq(psdf[0], pdf[0])
+ self.assert_eq(psdf[[1, 2]], pdf[[1, 2]])
- # TODO?: self.assertRaises(KeyError, lambda: pdf[8])
- # TODO?: self.assertRaises(KeyError, lambda: pdf[[1, 8]])
+ self.assertRaises(KeyError, lambda: pdf[8])
+ self.assertRaises(KeyError, lambda: pdf[[1, 8]])
# non-string column names
pdf = pd.DataFrame(
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
