This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new f4958ba9587c [SPARK-48367][CONNECT][FOLLOWUP] Replace keywords that 
identify `lint-scala` detection results
f4958ba9587c is described below

commit f4958ba9587c7c7d956eef4b664f7c974a09aa42
Author: panbingkun <panbing...@baidu.com>
AuthorDate: Wed May 22 12:28:14 2024 +0900

    [SPARK-48367][CONNECT][FOLLOWUP] Replace keywords that identify 
`lint-scala` detection results
    
    ### What changes were proposed in this pull request?
    The pr is following up https://github.com/apache/spark/pull/46679.
    The pr aims to replace `keywords` (from `Requires formatting` to 
`Unformatted files found`) that identify `lint-scala` detection results.
    
    ### Why are the changes needed?
    According to the discussion and analysis of 
https://github.com/apache/spark/pull/46679#issuecomment-2122142979, with the 
upgrade of `org.antipathy:mvn-scalafmt_*` version, it seems more general to use 
`Unformatted files found` as the keyword, because it directly comes from `the 
prompt of error level output`.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    - Manually test
    ```
    (base) ➜  spark-community git:(SPARK-48367_FOLLOWUP) ✗ dev/lint-scala
    Scalastyle checks passed.
    Scalafmt checks passed.
    ```
    - Pass GA.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No.
    
    Closes #46684 from panbingkun/SPARK-48367_FOLLOWUP.
    
    Authored-by: panbingkun <panbing...@baidu.com>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 dev/lint-scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/lint-scala b/dev/lint-scala
index 28e034afda5f..03771954ff52 100755
--- a/dev/lint-scala
+++ b/dev/lint-scala
@@ -32,7 +32,7 @@ ERRORS=$(./build/mvn \
     -pl connector/connect/common \
     -pl connector/connect/server \
     -pl connector/connect/client/jvm \
-    2>&1 | grep -e "Requires formatting" \
+    2>&1 | grep -e "Unformatted files found" \
 )
 
 if test ! -z "$ERRORS"; then


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to