dongjoon-hyun commented on a change in pull request #226: Add a reference "Code Review Developer Guide" from Google's Engineering Practices documentation. URL: https://github.com/apache/spark-website/pull/226#discussion_r337303968
########## File path: contributing.md ########## @@ -189,8 +189,11 @@ that maintainability, consistency, and code quality come first. New algorithms s <h3>Code Review Criteria</h3> Before considering how to contribute code, it's useful to understand how code is reviewed, -and why changes may be rejected. Simply put, changes that have many or large positives, and -few negative effects or risks, are much more likely to be merged, and merged quickly. +and why changes may be rejected. See the +<a href="https://google.github.io/eng-practices/review/";>detailed guide for code reviewers</a> +from Google's Engineering Practices documentation. +Simply put, changes that have many or large +positives, and few negative effects or risks, are much more likely to be merged, and merged quickly. Review comment: Could you generate the corresponding HTML file? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
