This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new e28296e  [SPARK-34772][TESTS][FOLLOWUP] Disable a test case using Hive 
1.2.1 in Java9+ environment
e28296e is described below

commit e28296e1905ee34ce93847e0ee03d8b70b161ef7
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Sun Mar 21 17:59:55 2021 -0700

    [SPARK-34772][TESTS][FOLLOWUP] Disable a test case using Hive 1.2.1 in 
Java9+ environment
    
    ### What changes were proposed in this pull request?
    
    This PR aims to disable a new test case using Hive 1.2.1 from Java9+ test 
environment.
    
    ### Why are the changes needed?
    
    [HIVE-6113](https://issues.apache.org/jira/browse/HIVE-6113) upgraded 
Datanucleus to 4.x at Hive 2.0. Datanucleus 3.x doesn't support Java9+.
    
    **Java 9+ Environment**
    ```
    $ build/sbt "hive/testOnly *.HiveSparkSubmitSuite -- -z SPARK-34772" -Phive
    ...
    [info] *** 1 TEST FAILED ***
    [error] Failed: Total 1, Failed 1, Errors 0, Passed 0
    [error] Failed tests:
    [error]     org.apache.spark.sql.hive.HiveSparkSubmitSuite
    [error] (hive / Test / testOnly) sbt.TestsFailedException: Tests 
unsuccessful
    [error] Total time: 328 s (05:28), completed Mar 21, 2021, 5:32:39 PM
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    Fix the UT in Java9+ environment.
    
    ### How was this patch tested?
    
    Manually.
    
    ```
    $ build/sbt "hive/testOnly *.HiveSparkSubmitSuite -- -z SPARK-34772" -Phive
    ...
    [info] HiveSparkSubmitSuite:
    [info] - SPARK-34772: RebaseDateTime loadRebaseRecords should use Spark 
classloader instead of context !!! CANCELED !!! (26 milliseconds)
    [info]   org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast(JAVA_9) 
was true (HiveSparkSubmitSuite.scala:344)
    ```
    
    Closes #31916 from dongjoon-hyun/SPARK-HiveSparkSubmitSuite.
    
    Authored-by: Dongjoon Hyun <dh...@apple.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit c5fd94f1197faf8a974c7d7745cdebf42b3430b9)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala 
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
index 09f9f9e..f9ea4e3 100644
--- 
a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
+++ 
b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
@@ -339,6 +339,7 @@ class HiveSparkSubmitSuite
 
   test("SPARK-34772: RebaseDateTime loadRebaseRecords should use Spark 
classloader " +
     "instead of context") {
+    assume(!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
     val unusedJar = TestUtils.createJarWithClasses(Seq.empty)
 
     // We need to specify the metastore database location in case of conflict 
with other hive

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to