This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new 799ebd1 [SPARK-33819][CORE][3.1]
SingleFileEventLogFileReader/RollingEventLogFilesFileReader should be `package
private`
799ebd1 is described below
commit 799ebd1ce942c8c888ff59f593dd5d7a53ff48aa
Author: Dongjoon Hyun <dongj...@apache.org>
AuthorDate: Thu Dec 17 19:07:11 2020 +0900
[SPARK-33819][CORE][3.1]
SingleFileEventLogFileReader/RollingEventLogFilesFileReader should be `package
private`
### What changes were proposed in this pull request?
This PR aims to convert `EventLogFileReader`'s derived classes into
`package private`.
- SingleFileEventLogFileReader
- RollingEventLogFilesFileReader
`EventLogFileReader` itself is used in `scheduler` module during tests.
### Why are the changes needed?
This classes were designed to be internal. This PR hides it explicitly to
reduce the maintenance burden.
### Does this PR introduce _any_ user-facing change?
Yes, but these were exposed accidentally.
### How was this patch tested?
Pass CIs.
Closes #30819 from dongjoon-hyun/SPARK-33819-3.1.
Authored-by: Dongjoon Hyun <dongj...@apache.org>
Signed-off-by: HyukjinKwon <gurwls...@apache.org>
---
.../scala/org/apache/spark/deploy/history/EventLogFileReaders.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
b/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
index 9f63a64..30ff2c3 100644
---
a/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
+++
b/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala
@@ -164,7 +164,7 @@ object EventLogFileReader {
* FileNotFoundException could occur if the log file is renamed before getting
the
* status of log file.
*/
-class SingleFileEventLogFileReader(
+private[history] class SingleFileEventLogFileReader(
fs: FileSystem,
path: Path) extends EventLogFileReader(fs, path) {
private lazy val status = fileSystem.getFileStatus(rootPath)
@@ -203,7 +203,7 @@ class SingleFileEventLogFileReader(
* This reader lists the files only once; if caller would like to play with
updated list,
* it needs to create another reader instance.
*/
-class RollingEventLogFilesFileReader(
+private[history] class RollingEventLogFilesFileReader(
fs: FileSystem,
path: Path) extends EventLogFileReader(fs, path) {
import RollingEventLogFilesWriter._
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
