This is an automated email from the ASF dual-hosted git repository.

kabhwan pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.2 by this push:
     new 67abd7a  [MINOR][SS] Remove unused config 
"pauseBackgroundWorkForCommit" from RocksDB
67abd7a is described below

commit 67abd7a49c065a933109b262b181ca84cbfc5dc6
Author: Jungtaek Lim <kabhwan.opensou...@gmail.com>
AuthorDate: Sun Oct 31 07:49:48 2021 +0900

    [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
    
    ### What changes were proposed in this pull request?
    
    This PR proposes to remove unused config "pauseBackgroundWorkForCommit".
    
    ### Why are the changes needed?
    
    That is unused config which actually has to be always "true" even if it's 
being used.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Existing UTs
    
    Closes #34417 from HeartSaVioR/MINOR-remove-unused-config-in-rocksdb.
    
    Authored-by: Jungtaek Lim <kabhwan.opensou...@gmail.com>
    Signed-off-by: Jungtaek Lim <kabhwan.opensou...@gmail.com>
    (cherry picked from commit 00d9ed5dd278a10a2dff8f420fafab516f85c189)
    Signed-off-by: Jungtaek Lim <kabhwan.opensou...@gmail.com>
---
 .../scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala | 3 ---
 1 file changed, 3 deletions(-)

diff --git 
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
 
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
index 6004bdb..1ff8b41 100644
--- 
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
+++ 
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
@@ -499,7 +499,6 @@ class ByteArrayPair(var key: Array[Byte] = null, var value: 
Array[Byte] = null)
 case class RocksDBConf(
     minVersionsToRetain: Int,
     compactOnCommit: Boolean,
-    pauseBackgroundWorkForCommit: Boolean,
     blockSizeKB: Long,
     blockCacheSizeMB: Long,
     lockAcquireTimeoutMs: Long,
@@ -516,7 +515,6 @@ object RocksDBConf {
 
   // Configuration that specifies whether to compact the RocksDB data every 
time data is committed
   private val COMPACT_ON_COMMIT_CONF = ConfEntry("compactOnCommit", "false")
-  private val PAUSE_BG_WORK_FOR_COMMIT_CONF = 
ConfEntry("pauseBackgroundWorkForCommit", "true")
   private val BLOCK_SIZE_KB_CONF = ConfEntry("blockSizeKB", "4")
   private val BLOCK_CACHE_SIZE_MB_CONF = ConfEntry("blockCacheSizeMB", "8")
   private val LOCK_ACQUIRE_TIMEOUT_MS_CONF = ConfEntry("lockAcquireTimeoutMs", 
"60000")
@@ -560,7 +558,6 @@ object RocksDBConf {
     RocksDBConf(
       storeConf.minVersionsToRetain,
       getBooleanConf(COMPACT_ON_COMMIT_CONF),
-      getBooleanConf(PAUSE_BG_WORK_FOR_COMMIT_CONF),
       getPositiveLongConf(BLOCK_SIZE_KB_CONF),
       getPositiveLongConf(BLOCK_CACHE_SIZE_MB_CONF),
       getPositiveLongConf(LOCK_ACQUIRE_TIMEOUT_MS_CONF),

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to