This is an automated email from the ASF dual-hosted git repository. sarutak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 4f20898 [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13 4f20898 is described below commit 4f2089899dd7f21ba41c9ccfc0453a93afa1e7eb Author: Kousuke Saruta <saru...@oss.nttdata.com> AuthorDate: Fri Nov 19 20:33:23 2021 +0900 [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13 ### What changes were proposed in this pull request? This PR adds more MiMa exclusion rules for Scala 2.13. #34649 partially resolved the compatibility issue but additional 3 compatibility problems are raised. ``` $ build/sbt clean $ dev/change-scala-version.sh 2.13 $ build/sbt -Pscala-2.13 clean $ dev/mima ... [error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.13:3.2.0! Found 3 potential problems (filtered 910) [error] * synthetic method copy$default$8()scala.collection.mutable.ListBuffer in class org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments has a different result type in current version, where it is scala.Option rather than scala.collection.mutable.ListBuffer [error] filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.copy$default$8") [error] * synthetic method copy$default$9()scala.Option in class org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments has a different result type in current version, where it is Int rather than scala.Option [error] filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.copy$default$9") [error] * the type hierarchy of object org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments is different in current version. Missing types {scala.runtime.AbstractFunction10} [error] filter with: ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend$Arguments$") ... ``` ### Why are the changes needed? To keep the build stable. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Confirmed MiMa passed. ``` $ build/sbt clean $ dev/change-scala-version.sh 2.13 $ build/sbt -Pscala-2.13 clean $ dev/mima Closes #34664 from sarutak/followup-SPARK-35672-mima-take2. Authored-by: Kousuke Saruta <saru...@oss.nttdata.com> Signed-off-by: Kousuke Saruta <saru...@oss.nttdata.com> --- project/MimaExcludes.scala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala index 15df3d4..75fa001 100644 --- a/project/MimaExcludes.scala +++ b/project/MimaExcludes.scala @@ -37,8 +37,10 @@ object MimaExcludes { // Exclude rules for 3.3.x from 3.2.0 lazy val v33excludes = v32excludes ++ Seq( // [SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line - // This is necessary for Scala 2.13. + // The followings are necessary for Scala 2.13. ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.*"), + ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.*"), + ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend$Arguments$") ) // Exclude rules for 3.2.x from 3.1.1 --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org