This is an automated email from the ASF dual-hosted git repository. huaxingao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new ddc1803 [SPARK-38414][CORE][DSTREAM][EXAMPLES][ML][MLLIB][SQL] Remove redundant `@SuppressWarnings ` ddc1803 is described below commit ddc18038ca8be82e801d2554043ae06dafc3f31f Author: yangjie01 <yangji...@baidu.com> AuthorDate: Mon Mar 7 10:55:57 2022 -0800 [SPARK-38414][CORE][DSTREAM][EXAMPLES][ML][MLLIB][SQL] Remove redundant `@SuppressWarnings ` ### What changes were proposed in this pull request? This pr remove redundant `SuppressWarnings` in Spark Java code, all case inspected by IDE (IntelliJ) ### Why are the changes needed? Remove redundant `SuppressWarnings ` ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? Pass GA Closes #35732 from LuciferYang/cleanup-redundant-suppression. Authored-by: yangjie01 <yangji...@baidu.com> Signed-off-by: huaxingao <huaxin_...@apple.com> --- .../shuffle/RetryingBlockTransferorSuite.java | 1 - .../shuffle/sort/UnsafeShuffleWriterSuite.java | 1 - .../java/test/org/apache/spark/JavaAPISuite.java | 20 --------- .../mllib/JavaPowerIterationClusteringExample.java | 1 - .../mllib/JavaStratifiedSamplingExample.java | 1 - .../streaming/JavaStatefulNetworkWordCount.java | 1 - .../JavaLogisticRegressionSuite.java | 1 - .../JavaStreamingLogisticRegressionSuite.java | 1 - .../mllib/clustering/JavaStreamingKMeansSuite.java | 1 - .../mllib/evaluation/JavaRankingMetricsSuite.java | 1 - .../apache/spark/mllib/feature/JavaTfIdfSuite.java | 2 - .../spark/mllib/feature/JavaWord2VecSuite.java | 1 - .../spark/mllib/fpm/JavaAssociationRulesSuite.java | 1 - .../apache/spark/mllib/fpm/JavaFPGrowthSuite.java | 2 - .../spark/mllib/linalg/JavaVectorsSuite.java | 1 - .../spark/mllib/random/JavaRandomRDDsSuite.java | 7 ---- .../JavaStreamingLinearRegressionSuite.java | 1 - .../test/org/apache/spark/sql/JavaRowSuite.java | 1 - .../test/org/apache/spark/sql/JavaUDAFSuite.java | 1 - .../test/org/apache/spark/sql/JavaUDFSuite.java | 8 ---- .../org/apache/spark/streaming/JavaAPISuite.java | 49 ---------------------- 21 files changed, 103 deletions(-) diff --git a/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java b/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java index 1b44b06..985a7a3 100644 --- a/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java +++ b/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java @@ -240,7 +240,6 @@ public class RetryingBlockTransferorSuite { * retries -- the first interaction may include an IOException, which causes a retry of some * subset of the original blocks in a second interaction. */ - @SuppressWarnings("unchecked") private static void performInteractions(List<? extends Map<String, Object>> interactions, BlockFetchingListener listener) throws IOException, InterruptedException { diff --git a/core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java b/core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java index cd25f32..f4e09b7 100644 --- a/core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java +++ b/core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java @@ -89,7 +89,6 @@ public class UnsafeShuffleWriterSuite implements ShuffleChecksumTestHelper { } @Before - @SuppressWarnings("unchecked") public void setUp() throws Exception { MockitoAnnotations.openMocks(this).close(); tempDir = Utils.createTempDir(null, "test"); diff --git a/core/src/test/java/test/org/apache/spark/JavaAPISuite.java b/core/src/test/java/test/org/apache/spark/JavaAPISuite.java index 3796d3b..fd91237 100644 --- a/core/src/test/java/test/org/apache/spark/JavaAPISuite.java +++ b/core/src/test/java/test/org/apache/spark/JavaAPISuite.java @@ -130,7 +130,6 @@ public class JavaAPISuite implements Serializable { assertEquals(4, pUnion.count()); } - @SuppressWarnings("unchecked") @Test public void intersection() { List<Integer> ints1 = Arrays.asList(1, 10, 2, 3, 4, 5); @@ -216,7 +215,6 @@ public class JavaAPISuite implements Serializable { assertEquals(new Tuple2<>(3, 2), sortedPairs.get(2)); } - @SuppressWarnings("unchecked") @Test public void repartitionAndSortWithinPartitions() { List<Tuple2<Integer, Integer>> pairs = new ArrayList<>(); @@ -356,7 +354,6 @@ public class JavaAPISuite implements Serializable { assertEquals(correctIndexes, indexes.collect()); } - @SuppressWarnings("unchecked") @Test public void lookup() { JavaPairRDD<String, String> categories = sc.parallelizePairs(Arrays.asList( @@ -401,7 +398,6 @@ public class JavaAPISuite implements Serializable { assertEquals(5, Iterables.size(oddsAndEvens.lookup(false).get(0))); // Odds } - @SuppressWarnings("unchecked") @Test public void keyByOnPairRDD() { // Regression test for SPARK-4459 @@ -413,7 +409,6 @@ public class JavaAPISuite implements Serializable { assertEquals(1, (long) keyed.lookup("2").get(0)._1()); } - @SuppressWarnings("unchecked") @Test public void cogroup() { JavaPairRDD<String, String> categories = sc.parallelizePairs(Arrays.asList( @@ -433,7 +428,6 @@ public class JavaAPISuite implements Serializable { cogrouped.collect(); } - @SuppressWarnings("unchecked") @Test public void cogroup3() { JavaPairRDD<String, String> categories = sc.parallelizePairs(Arrays.asList( @@ -460,7 +454,6 @@ public class JavaAPISuite implements Serializable { cogrouped.collect(); } - @SuppressWarnings("unchecked") @Test public void cogroup4() { JavaPairRDD<String, String> categories = sc.parallelizePairs(Arrays.asList( @@ -491,7 +484,6 @@ public class JavaAPISuite implements Serializable { cogrouped.collect(); } - @SuppressWarnings("unchecked") @Test public void leftOuterJoin() { JavaPairRDD<Integer, Integer> rdd1 = sc.parallelizePairs(Arrays.asList( @@ -557,7 +549,6 @@ public class JavaAPISuite implements Serializable { } } - @SuppressWarnings("unchecked") @Test public void aggregateByKey() { JavaPairRDD<Integer, Integer> pairs = sc.parallelizePairs( @@ -583,7 +574,6 @@ public class JavaAPISuite implements Serializable { assertEquals(new HashSet<>(Arrays.asList(1, 3)), sets.get(5)); } - @SuppressWarnings("unchecked") @Test public void foldByKey() { List<Tuple2<Integer, Integer>> pairs = Arrays.asList( @@ -600,7 +590,6 @@ public class JavaAPISuite implements Serializable { assertEquals(3, sums.lookup(3).get(0).intValue()); } - @SuppressWarnings("unchecked") @Test public void reduceByKey() { List<Tuple2<Integer, Integer>> pairs = Arrays.asList( @@ -836,7 +825,6 @@ public class JavaAPISuite implements Serializable { assertEquals(11, pairsRDD.count()); } - @SuppressWarnings("unchecked") @Test public void mapsFromPairsToPairs() { List<Tuple2<Integer, String>> pairs = Arrays.asList( @@ -919,7 +907,6 @@ public class JavaAPISuite implements Serializable { } } - @SuppressWarnings("unchecked") @Test public void persist() { JavaDoubleRDD doubleRDD = sc.parallelizeDoubles(Arrays.asList(1.0, 1.0, 2.0, 3.0, 5.0, 8.0)); @@ -1018,7 +1005,6 @@ public class JavaAPISuite implements Serializable { assertEquals(expected, readRDD.collect()); } - @SuppressWarnings("unchecked") @Test public void sequenceFile() { String outputDir = new File(tempDir, "output").getAbsolutePath(); @@ -1108,7 +1094,6 @@ public class JavaAPISuite implements Serializable { } } - @SuppressWarnings("unchecked") @Test public void writeWithNewAPIHadoopFile() { String outputDir = new File(tempDir, "output").getAbsolutePath(); @@ -1159,7 +1144,6 @@ public class JavaAPISuite implements Serializable { assertEquals(expected, readRDD.collect()); } - @SuppressWarnings("unchecked") @Test public void objectFilesOfComplexTypes() { String outputDir = new File(tempDir, "output").getAbsolutePath(); @@ -1297,7 +1281,6 @@ public class JavaAPISuite implements Serializable { assertEquals(expected, results); } - @SuppressWarnings("unchecked") @Test public void mapOnPairRDD() { JavaRDD<Integer> rdd1 = sc.parallelize(Arrays.asList(1,2,3,4)); @@ -1310,7 +1293,6 @@ public class JavaAPISuite implements Serializable { new Tuple2<>(0, 4)), rdd3.collect()); } - @SuppressWarnings("unchecked") @Test public void collectPartitions() { JavaRDD<Integer> rdd1 = sc.parallelize(Arrays.asList(1, 2, 3, 4, 5, 6, 7), 3); @@ -1391,7 +1373,6 @@ public class JavaAPISuite implements Serializable { } @Test - @SuppressWarnings("unchecked") public void sampleByKey() { JavaRDD<Integer> rdd1 = sc.parallelize(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8), 3); JavaPairRDD<Integer, Integer> rdd2 = rdd1.mapToPair(i -> new Tuple2<>(i % 2, 1)); @@ -1411,7 +1392,6 @@ public class JavaAPISuite implements Serializable { } @Test - @SuppressWarnings("unchecked") public void sampleByKeyExact() { JavaRDD<Integer> rdd1 = sc.parallelize(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8), 3); JavaPairRDD<Integer, Integer> rdd2 = rdd1.mapToPair(i -> new Tuple2<>(i % 2, 1)); diff --git a/examples/src/main/java/org/apache/spark/examples/mllib/JavaPowerIterationClusteringExample.java b/examples/src/main/java/org/apache/spark/examples/mllib/JavaPowerIterationClusteringExample.java index 5155f18..e2260e1 100644 --- a/examples/src/main/java/org/apache/spark/examples/mllib/JavaPowerIterationClusteringExample.java +++ b/examples/src/main/java/org/apache/spark/examples/mllib/JavaPowerIterationClusteringExample.java @@ -37,7 +37,6 @@ public class JavaPowerIterationClusteringExample { SparkConf sparkConf = new SparkConf().setAppName("JavaPowerIterationClusteringExample"); JavaSparkContext sc = new JavaSparkContext(sparkConf); - @SuppressWarnings("unchecked") // $example on$ JavaRDD<Tuple3<Long, Long, Double>> similarities = sc.parallelize(Arrays.asList( new Tuple3<>(0L, 1L, 0.9), diff --git a/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java b/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java index 286b95c..b06b2cc 100644 --- a/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java +++ b/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java @@ -35,7 +35,6 @@ public class JavaStratifiedSamplingExample { SparkConf conf = new SparkConf().setAppName("JavaStratifiedSamplingExample"); JavaSparkContext jsc = new JavaSparkContext(conf); - @SuppressWarnings("unchecked") // $example on$ List<Tuple2<Integer, Character>> list = Arrays.asList( new Tuple2<>(1, 'a'), diff --git a/examples/src/main/java/org/apache/spark/examples/streaming/JavaStatefulNetworkWordCount.java b/examples/src/main/java/org/apache/spark/examples/streaming/JavaStatefulNetworkWordCount.java index 9d8bd7f..ec1185a 100644 --- a/examples/src/main/java/org/apache/spark/examples/streaming/JavaStatefulNetworkWordCount.java +++ b/examples/src/main/java/org/apache/spark/examples/streaming/JavaStatefulNetworkWordCount.java @@ -63,7 +63,6 @@ public class JavaStatefulNetworkWordCount { ssc.checkpoint("."); // Initial state RDD input to mapWithState - @SuppressWarnings("unchecked") List<Tuple2<String, Integer>> tuples = Arrays.asList(new Tuple2<>("hello", 1), new Tuple2<>("world", 1)); JavaPairRDD<String, Integer> initialRDD = ssc.sparkContext().parallelizePairs(tuples); diff --git a/mllib/src/test/java/org/apache/spark/ml/classification/JavaLogisticRegressionSuite.java b/mllib/src/test/java/org/apache/spark/ml/classification/JavaLogisticRegressionSuite.java index 7c63a87..3dd224b 100644 --- a/mllib/src/test/java/org/apache/spark/ml/classification/JavaLogisticRegressionSuite.java +++ b/mllib/src/test/java/org/apache/spark/ml/classification/JavaLogisticRegressionSuite.java @@ -107,7 +107,6 @@ public class JavaLogisticRegressionSuite extends SharedSparkSession { Assert.assertEquals("theProb", model2.getProbabilityCol()); } - @SuppressWarnings("unchecked") @Test public void logisticRegressionPredictorClassifierMethods() { LogisticRegression lr = new LogisticRegression(); diff --git a/mllib/src/test/java/org/apache/spark/mllib/classification/JavaStreamingLogisticRegressionSuite.java b/mllib/src/test/java/org/apache/spark/mllib/classification/JavaStreamingLogisticRegressionSuite.java index 8c6bced..d436c0e 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/classification/JavaStreamingLogisticRegressionSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/classification/JavaStreamingLogisticRegressionSuite.java @@ -57,7 +57,6 @@ public class JavaStreamingLogisticRegressionSuite { } @Test - @SuppressWarnings("unchecked") public void javaAPI() { List<LabeledPoint> trainingBatch = Arrays.asList( new LabeledPoint(1.0, Vectors.dense(1.0)), diff --git a/mllib/src/test/java/org/apache/spark/mllib/clustering/JavaStreamingKMeansSuite.java b/mllib/src/test/java/org/apache/spark/mllib/clustering/JavaStreamingKMeansSuite.java index d41fc0e..f61d547 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/clustering/JavaStreamingKMeansSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/clustering/JavaStreamingKMeansSuite.java @@ -56,7 +56,6 @@ public class JavaStreamingKMeansSuite { } @Test - @SuppressWarnings("unchecked") public void javaAPI() { List<Vector> trainingBatch = Arrays.asList( Vectors.dense(1.0), diff --git a/mllib/src/test/java/org/apache/spark/mllib/evaluation/JavaRankingMetricsSuite.java b/mllib/src/test/java/org/apache/spark/mllib/evaluation/JavaRankingMetricsSuite.java index e9d7e4f..50822c6 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/evaluation/JavaRankingMetricsSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/evaluation/JavaRankingMetricsSuite.java @@ -47,7 +47,6 @@ public class JavaRankingMetricsSuite extends SharedSparkSession { @Test public void rankingMetrics() { - @SuppressWarnings("unchecked") RankingMetrics<?> metrics = RankingMetrics.of(predictionAndLabels); Assert.assertEquals(0.355026, metrics.meanAveragePrecision(), 1e-5); Assert.assertEquals(0.75 / 3.0, metrics.precisionAt(4), 1e-5); diff --git a/mllib/src/test/java/org/apache/spark/mllib/feature/JavaTfIdfSuite.java b/mllib/src/test/java/org/apache/spark/mllib/feature/JavaTfIdfSuite.java index 05128ea..4508d2c 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/feature/JavaTfIdfSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/feature/JavaTfIdfSuite.java @@ -33,7 +33,6 @@ public class JavaTfIdfSuite extends SharedSparkSession { public void tfIdf() { // The tests are to check Java compatibility. HashingTF tf = new HashingTF(); - @SuppressWarnings("unchecked") JavaRDD<List<String>> documents = jsc.parallelize(Arrays.asList( Arrays.asList("this is a sentence".split(" ")), Arrays.asList("this is another sentence".split(" ")), @@ -53,7 +52,6 @@ public class JavaTfIdfSuite extends SharedSparkSession { public void tfIdfMinimumDocumentFrequency() { // The tests are to check Java compatibility. HashingTF tf = new HashingTF(); - @SuppressWarnings("unchecked") JavaRDD<List<String>> documents = jsc.parallelize(Arrays.asList( Arrays.asList("this is a sentence".split(" ")), Arrays.asList("this is another sentence".split(" ")), diff --git a/mllib/src/test/java/org/apache/spark/mllib/feature/JavaWord2VecSuite.java b/mllib/src/test/java/org/apache/spark/mllib/feature/JavaWord2VecSuite.java index 3e3abdd..a423e8b 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/feature/JavaWord2VecSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/feature/JavaWord2VecSuite.java @@ -33,7 +33,6 @@ import org.apache.spark.api.java.JavaRDD; public class JavaWord2VecSuite extends SharedSparkSession { @Test - @SuppressWarnings("unchecked") public void word2Vec() { // The tests are to check Java compatibility. String sentence = Strings.repeat("a b ", 100) + Strings.repeat("a c ", 10); diff --git a/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaAssociationRulesSuite.java b/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaAssociationRulesSuite.java index 15de566..1f3fa9d 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaAssociationRulesSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaAssociationRulesSuite.java @@ -29,7 +29,6 @@ public class JavaAssociationRulesSuite extends SharedSparkSession { @Test public void runAssociationRules() { - @SuppressWarnings("unchecked") JavaRDD<FPGrowth.FreqItemset<String>> freqItemsets = jsc.parallelize(Arrays.asList( new FreqItemset<>(new String[]{"a"}, 15L), new FreqItemset<>(new String[]{"b"}, 35L), diff --git a/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaFPGrowthSuite.java b/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaFPGrowthSuite.java index 46e9dd8..dda8884 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaFPGrowthSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/fpm/JavaFPGrowthSuite.java @@ -34,7 +34,6 @@ public class JavaFPGrowthSuite extends SharedSparkSession { @Test public void runFPGrowth() { - @SuppressWarnings("unchecked") JavaRDD<List<String>> rdd = jsc.parallelize(Arrays.asList( Arrays.asList("r z h k p".split(" ")), Arrays.asList("z y x w v u t s".split(" ")), @@ -61,7 +60,6 @@ public class JavaFPGrowthSuite extends SharedSparkSession { @Test public void runFPGrowthSaveLoad() { - @SuppressWarnings("unchecked") JavaRDD<List<String>> rdd = jsc.parallelize(Arrays.asList( Arrays.asList("r z h k p".split(" ")), Arrays.asList("z y x w v u t s".split(" ")), diff --git a/mllib/src/test/java/org/apache/spark/mllib/linalg/JavaVectorsSuite.java b/mllib/src/test/java/org/apache/spark/mllib/linalg/JavaVectorsSuite.java index f67f555..d854ba2 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/linalg/JavaVectorsSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/linalg/JavaVectorsSuite.java @@ -35,7 +35,6 @@ public class JavaVectorsSuite { @Test public void sparseArrayConstruction() { - @SuppressWarnings("unchecked") Vector v = Vectors.sparse(3, Arrays.asList( new Tuple2<>(0, 2.0), new Tuple2<>(2, 3.0))); diff --git a/mllib/src/test/java/org/apache/spark/mllib/random/JavaRandomRDDsSuite.java b/mllib/src/test/java/org/apache/spark/mllib/random/JavaRandomRDDsSuite.java index 6d11402..8f54060 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/random/JavaRandomRDDsSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/random/JavaRandomRDDsSuite.java @@ -117,7 +117,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { @Test - @SuppressWarnings("unchecked") public void testUniformVectorRDD() { long m = 100L; int n = 10; @@ -133,7 +132,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { } @Test - @SuppressWarnings("unchecked") public void testNormalVectorRDD() { long m = 100L; int n = 10; @@ -149,7 +147,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { } @Test - @SuppressWarnings("unchecked") public void testLogNormalVectorRDD() { double mean = 4.0; double std = 2.0; @@ -167,7 +164,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { } @Test - @SuppressWarnings("unchecked") public void testPoissonVectorRDD() { double mean = 2.0; long m = 100L; @@ -184,7 +180,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { } @Test - @SuppressWarnings("unchecked") public void testExponentialVectorRDD() { double mean = 2.0; long m = 100L; @@ -201,7 +196,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { } @Test - @SuppressWarnings("unchecked") public void testGammaVectorRDD() { double shape = 1.0; double jscale = 2.0; @@ -234,7 +228,6 @@ public class JavaRandomRDDsSuite extends SharedSparkSession { } @Test - @SuppressWarnings("unchecked") public void testRandomVectorRDD() { UniformGenerator generator = new UniformGenerator(); long m = 100L; diff --git a/mllib/src/test/java/org/apache/spark/mllib/regression/JavaStreamingLinearRegressionSuite.java b/mllib/src/test/java/org/apache/spark/mllib/regression/JavaStreamingLinearRegressionSuite.java index ab55447..449be86 100644 --- a/mllib/src/test/java/org/apache/spark/mllib/regression/JavaStreamingLinearRegressionSuite.java +++ b/mllib/src/test/java/org/apache/spark/mllib/regression/JavaStreamingLinearRegressionSuite.java @@ -56,7 +56,6 @@ public class JavaStreamingLinearRegressionSuite { } @Test - @SuppressWarnings("unchecked") public void javaAPI() { List<LabeledPoint> trainingBatch = Arrays.asList( new LabeledPoint(1.0, Vectors.dense(1.0)), diff --git a/sql/core/src/test/java/test/org/apache/spark/sql/JavaRowSuite.java b/sql/core/src/test/java/test/org/apache/spark/sql/JavaRowSuite.java index ca78d64..37f49ce 100644 --- a/sql/core/src/test/java/test/org/apache/spark/sql/JavaRowSuite.java +++ b/sql/core/src/test/java/test/org/apache/spark/sql/JavaRowSuite.java @@ -145,7 +145,6 @@ public class JavaRowSuite { doubleValue, stringValue, timestampValue, null); // Complex array - @SuppressWarnings("unchecked") List<Map<String, Long>> arrayOfMaps = Arrays.asList(simpleMap); List<Row> arrayOfRows = Arrays.asList(simpleStruct); diff --git a/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDAFSuite.java b/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDAFSuite.java index 08dc129..1da5fb4 100644 --- a/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDAFSuite.java +++ b/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDAFSuite.java @@ -43,7 +43,6 @@ public class JavaUDAFSuite { spark = null; } - @SuppressWarnings("unchecked") @Test public void udf1Test() { spark.range(1, 10).toDF("value").createOrReplaceTempView("df"); diff --git a/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDFSuite.java b/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDFSuite.java index 7e938ca..cd64f85 100644 --- a/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDFSuite.java +++ b/sql/core/src/test/java/test/org/apache/spark/sql/JavaUDFSuite.java @@ -55,7 +55,6 @@ public class JavaUDFSuite implements Serializable { spark = null; } - @SuppressWarnings("unchecked") @Test public void udf1Test() { spark.udf().register("stringLengthTest", (String str) -> str.length(), DataTypes.IntegerType); @@ -64,7 +63,6 @@ public class JavaUDFSuite implements Serializable { Assert.assertEquals(4, result.getInt(0)); } - @SuppressWarnings("unchecked") @Test public void udf2Test() { spark.udf().register("stringLengthTest", @@ -81,7 +79,6 @@ public class JavaUDFSuite implements Serializable { } } - @SuppressWarnings("unchecked") @Test public void udf3Test() { spark.udf().registerJava("stringLengthTest", StringLengthTest.class.getName(), @@ -95,7 +92,6 @@ public class JavaUDFSuite implements Serializable { Assert.assertEquals(9, result.getInt(0)); } - @SuppressWarnings("unchecked") @Test public void udf4Test() { spark.udf().register("inc", (Long i) -> i + 1, DataTypes.LongType); @@ -111,14 +107,12 @@ public class JavaUDFSuite implements Serializable { Assert.assertEquals(55, sum); } - @SuppressWarnings("unchecked") @Test(expected = AnalysisException.class) public void udf5Test() { spark.udf().register("inc", (Long i) -> i + 1, DataTypes.LongType); List<Row> results = spark.sql("SELECT inc(1, 5)").collectAsList(); } - @SuppressWarnings("unchecked") @Test public void udf6Test() { spark.udf().register("returnOne", () -> 1, DataTypes.IntegerType); @@ -126,7 +120,6 @@ public class JavaUDFSuite implements Serializable { Assert.assertEquals(1, result.getInt(0)); } - @SuppressWarnings("unchecked") @Test public void udf7Test() { String originConf = spark.conf().get(SQLConf.DATETIME_JAVA8API_ENABLED().key()); @@ -142,7 +135,6 @@ public class JavaUDFSuite implements Serializable { } } - @SuppressWarnings("unchecked") @Test public void sourceTest() { spark.udf().register("stringLengthTest", (String str) -> str.length(), DataTypes.IntegerType); diff --git a/streaming/src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java b/streaming/src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java index 8a57b0c..41c4bf9 100644 --- a/streaming/src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java +++ b/streaming/src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java @@ -75,7 +75,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertNotNull(ssc.sparkContext()); } - @SuppressWarnings("unchecked") @Test public void testContextState() { List<List<Integer>> inputData = Arrays.asList(Arrays.asList(1, 2, 3, 4)); @@ -89,7 +88,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(StreamingContextState.STOPPED, ssc.getState()); } - @SuppressWarnings("unchecked") @Test public void testCount() { List<List<Integer>> inputData = Arrays.asList( @@ -109,7 +107,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testMap() { List<List<String>> inputData = Arrays.asList( @@ -128,7 +125,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testWindow() { List<List<Integer>> inputData = Arrays.asList( @@ -150,7 +146,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testWindowWithSlideDuration() { List<List<Integer>> inputData = Arrays.asList( @@ -175,7 +170,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testFilter() { List<List<String>> inputData = Arrays.asList( @@ -194,7 +188,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testRepartitionMorePartitions() { List<List<Integer>> inputData = Arrays.asList( @@ -214,7 +207,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa } } - @SuppressWarnings("unchecked") @Test public void testRepartitionFewerPartitions() { List<List<Integer>> inputData = Arrays.asList( @@ -233,7 +225,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa } } - @SuppressWarnings("unchecked") @Test public void testGlom() { List<List<String>> inputData = Arrays.asList( @@ -252,7 +243,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testMapPartitions() { List<List<String>> inputData = Arrays.asList( @@ -291,7 +281,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa } } - @SuppressWarnings("unchecked") @Test public void testReduce() { List<List<Integer>> inputData = Arrays.asList( @@ -312,19 +301,16 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testReduceByWindowWithInverse() { testReduceByWindow(true); } - @SuppressWarnings("unchecked") @Test public void testReduceByWindowWithoutInverse() { testReduceByWindow(false); } - @SuppressWarnings("unchecked") private void testReduceByWindow(boolean withInverse) { List<List<Integer>> inputData = Arrays.asList( Arrays.asList(1,2,3), @@ -354,7 +340,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testQueueStream() { ssc.stop(); @@ -386,7 +371,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testTransform() { List<List<Integer>> inputData = Arrays.asList( @@ -408,7 +392,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testVariousTransform() { // tests whether all variations of transform can be called from Java @@ -495,7 +478,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa } - @SuppressWarnings("unchecked") @Test public void testVariousTransformWith() { // tests whether all variations of transformWith can be called from Java @@ -593,7 +575,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testFlatMap() { List<List<String>> inputData = Arrays.asList( @@ -615,7 +596,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testForeachRDD() { final LongAccumulator accumRdd = ssc.sparkContext().sc().longAccumulator(); @@ -641,7 +621,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(6, accumEle.value().intValue()); } - @SuppressWarnings("unchecked") @Test public void testPairFlatMap() { List<List<String>> inputData = Arrays.asList( @@ -690,7 +669,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testUnion() { List<List<Integer>> inputData1 = Arrays.asList( @@ -737,7 +715,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa // PairDStream Functions - @SuppressWarnings("unchecked") @Test public void testPairFilter() { List<List<String>> inputData = Arrays.asList( @@ -759,7 +736,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") private final List<List<Tuple2<String, String>>> stringStringKVStream = Arrays.asList( Arrays.asList(new Tuple2<>("california", "dodgers"), new Tuple2<>("california", "giants"), @@ -770,7 +746,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa new Tuple2<>("new york", "rangers"), new Tuple2<>("new york", "islanders"))); - @SuppressWarnings("unchecked") private final List<List<Tuple2<String, Integer>>> stringIntKVStream = Arrays.asList( Arrays.asList( new Tuple2<>("california", 1), @@ -783,7 +758,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa new Tuple2<>("new york", 3), new Tuple2<>("new york", 1))); - @SuppressWarnings("unchecked") @Test public void testPairMap() { // Maps pair -> pair of different type List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -811,7 +785,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testPairMapPartitions() { // Maps pair -> pair of different type List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -846,7 +819,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testPairMap2() { // Maps pair -> single List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -866,7 +838,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testPairToPairFlatMapWithChangingTypes() { // Maps pair -> pair List<List<Tuple2<String, Integer>>> inputData = Arrays.asList( @@ -905,7 +876,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testPairGroupByKey() { List<List<Tuple2<String, String>>> inputData = stringStringKVStream; @@ -942,7 +912,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa } } - @SuppressWarnings("unchecked") @Test public void testPairReduceByKey() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -967,7 +936,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testCombineByKey() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -993,7 +961,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testCountByValue() { List<List<String>> inputData = Arrays.asList( @@ -1019,7 +986,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testGroupByKeyAndWindow() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -1067,7 +1033,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa return new Tuple2<>(tuple._1(), new HashSet<>(tuple._2())); } - @SuppressWarnings("unchecked") @Test public void testReduceByKeyAndWindow() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -1092,7 +1057,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testUpdateStateByKey() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -1125,7 +1089,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testUpdateStateByKeyWithInitial() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -1165,7 +1128,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testReduceByKeyAndWindowWithInverse() { List<List<Tuple2<String, Integer>>> inputData = stringIntKVStream; @@ -1225,7 +1187,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, unorderedResult); } - @SuppressWarnings("unchecked") @Test public void testPairTransform() { List<List<Tuple2<Integer, Integer>>> inputData = Arrays.asList( @@ -1264,7 +1225,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testPairToNormalRDDTransform() { List<List<Tuple2<Integer, Integer>>> inputData = Arrays.asList( @@ -1295,7 +1255,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testMapValues() { List<List<Tuple2<String, String>>> inputData = stringStringKVStream; @@ -1323,7 +1282,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testFlatMapValues() { List<List<Tuple2<String, String>>> inputData = stringStringKVStream; @@ -1364,7 +1322,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testCoGroup() { List<List<Tuple2<String, String>>> stringStringKVStream1 = Arrays.asList( @@ -1430,7 +1387,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa } } - @SuppressWarnings("unchecked") @Test public void testJoin() { List<List<Tuple2<String, String>>> stringStringKVStream1 = Arrays.asList( @@ -1474,7 +1430,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testLeftOuterJoin() { List<List<Tuple2<String, String>>> stringStringKVStream1 = Arrays.asList( @@ -1507,7 +1462,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Assert.assertEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testCheckpointMasterRecovery() throws InterruptedException { List<List<String>> inputData = Arrays.asList( @@ -1543,7 +1497,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa Utils.deleteRecursively(tempDir); } - @SuppressWarnings("unchecked") @Test public void testContextGetOrCreate() throws InterruptedException { ssc.stop(); @@ -1648,7 +1601,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa StorageLevel.MEMORY_ONLY()); } - @SuppressWarnings("unchecked") @Test public void testTextFileStream() throws IOException { File testDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark"); @@ -1661,7 +1613,6 @@ public class JavaAPISuite extends LocalJavaStreamingContext implements Serializa assertOrderInvariantEquals(expected, result); } - @SuppressWarnings("unchecked") @Test public void testFileStream() throws IOException { File testDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), "spark"); --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org