This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 52a5d8dfe0d [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote` 52a5d8dfe0d is described below commit 52a5d8dfe0d0a9c85a8ac86be9e626d638510736 Author: itholic <haejoon....@databricks.com> AuthorDate: Tue May 30 20:21:48 2023 +0900 [SPARK-43680][PS][FOLLOWUP] Fix wrong usage for `is_remote` ### What changes were proposed in this pull request? This PR follow up for https://github.com/apache/spark/pull/41361 to fix misusage for `is_remote` on `if` clause. ### Why are the changes needed? To fix the wrong function call ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested. Closes #41376 from itholic/nullop_followup. Authored-by: itholic <haejoon....@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- python/pyspark/pandas/data_type_ops/null_ops.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/python/pyspark/pandas/data_type_ops/null_ops.py b/python/pyspark/pandas/data_type_ops/null_ops.py index ddd7bddcfbd..ab86f074b99 100644 --- a/python/pyspark/pandas/data_type_ops/null_ops.py +++ b/python/pyspark/pandas/data_type_ops/null_ops.py @@ -46,32 +46,32 @@ class NullOps(DataTypeOps): def lt(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex: _sanitize_list_like(right) result = pyspark_column_op("__lt__")(left, right) - if is_remote: - # In Spark Connect, it returns None instead of False, so we manually cast it. + if is_remote(): + # TODO(SPARK-43877): Fix behavior difference for compare binary functions. result = result.fillna(False) return result def le(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex: _sanitize_list_like(right) result = pyspark_column_op("__le__")(left, right) - if is_remote: - # In Spark Connect, it returns None instead of False, so we manually cast it. + if is_remote(): + # TODO(SPARK-43877): Fix behavior difference for compare binary functions. result = result.fillna(False) return result def ge(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex: _sanitize_list_like(right) result = pyspark_column_op("__ge__")(left, right) - if is_remote: - # In Spark Connect, it returns None instead of False, so we manually cast it. + if is_remote(): + # TODO(SPARK-43877): Fix behavior difference for compare binary functions. result = result.fillna(False) return result def gt(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex: _sanitize_list_like(right) result = pyspark_column_op("__gt__")(left, right) - if is_remote: - # In Spark Connect, it returns None instead of False, so we manually cast it. + if is_remote(): + # TODO(SPARK-43877): Fix behavior difference for compare binary functions. result = result.fillna(False) return result --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org