This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new f807bd239ae [SPARK-44857][CORE][UI] Fix `getBaseURI` error in Spark 
Worker LogPage UI buttons
f807bd239ae is described below

commit f807bd239aebe182a04f5452d6efdf458e44143c
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Thu Aug 17 18:07:07 2023 -0700

    [SPARK-44857][CORE][UI] Fix `getBaseURI` error in Spark Worker LogPage UI 
buttons
    
    ### What changes were proposed in this pull request?
    
    This PR aims to fix `getBaseURI` errors when we clicks Spark Worker LogPage 
UI buttons in Apache Spark 3.2.0+.
    
    ### Why are the changes needed?
    
    Run a Spark job and open the Spark Worker UI, http://localhost:8081 .
    ```
    $ sbin/start-master.sh
    $ sbin/start-worker.sh spark://127.0.0.1:7077
    $ bin/spark-shell --master spark://127.0.0.1:7077
    ```
    
    Click `stderr` and `Load New` button. The button is out of order currently 
due to the following error because `getBaseURI` is defined in `utils.js`.
    
    ![Screenshot 2023-08-17 at 2 38 45 
PM](https://github.com/apache/spark/assets/9700541/c2358ae3-46d2-43fe-9cc1-ce343725ce4c)
    
    ### Does this PR introduce _any_ user-facing change?
    
    This will make the buttons work.
    
    ### How was this patch tested?
    
    Manual.
    
    Closes #42546 from dongjoon-hyun/SPARK-44857.
    
    Authored-by: Dongjoon Hyun <dh...@apple.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala 
b/core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala
index bda95f323f3..6800a19b549 100644
--- a/core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala
@@ -102,6 +102,7 @@ private[ui] class LogPage(parent: WorkerWebUI) extends 
WebUIPage("logPage") with
       s"initLogPage('$logParams', $curLogLength, $startByte, $endByte, 
$logLength, $byteLength);"
 
     val content =
+      <script src={UIUtils.prependBaseUri(request, 
"/static/utils.js")}></script> ++
       <div>
         {linkToMaster}
         {range}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to