This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 79cc7f838f0 [SPARK-45032][CONNECT] Fix compilation warnings related to 
`Top-level wildcard is not allowed and will error under -Xsource:3`
79cc7f838f0 is described below

commit 79cc7f838f01879d63e7d249591ce7079f11801a
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Mon Sep 4 09:42:21 2023 +0900

    [SPARK-45032][CONNECT] Fix compilation warnings related to `Top-level 
wildcard is not allowed and will error under -Xsource:3`
    
    ### What changes were proposed in this pull request?
    Build with Scala 2.13, will result in the following compilation warnings:
    
    ```
    [warn] 
/Users/yangjie01/SourceCode/git/spark-mine-sbt/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala:175:32:
 [deprecation   | origin= | version=2.13.7] Top-level wildcard is not allowed 
and will error under -Xsource:3
    [warn]   def removeGrpcResponseSender[_](sender: 
ExecuteGrpcResponseSender[_]): Unit = synchronized {
    [warn]                                ^
    ```
    So this pr fix it.
    
    ### Why are the changes needed?
    Fix compilation warnings related to `Top-level wildcard is not allowed and 
will error under -Xsource:3`.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Pass GitHub Actions
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No
    
    Closes #42753 from LuciferYang/SPARK-45032.
    
    Authored-by: yangjie01 <yangji...@baidu.com>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 .../main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala
 
b/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala
index bce07133392..fb228935985 100644
--- 
a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala
+++ 
b/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala
@@ -172,7 +172,7 @@ private[connect] class ExecuteHolder(
     }
   }
 
-  def removeGrpcResponseSender[_](sender: ExecuteGrpcResponseSender[_]): Unit 
= synchronized {
+  def removeGrpcResponseSender(sender: ExecuteGrpcResponseSender[_]): Unit = 
synchronized {
     // if closed, we are shutting down and interrupting all senders already
     if (closedTime.isEmpty) {
       grpcResponseSenders -=


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to