Repository: spark Updated Branches: refs/heads/master ce40efa20 -> a129f0795
[SPARK-23429][CORE][FOLLOWUP] MetricGetter should rename to ExecutorMetricType in comments ## What changes were proposed in this pull request? MetricGetter should rename to ExecutorMetricType in comments. ## How was this patch tested? Just comments, no need to test. Closes #22884 from LantaoJin/SPARK-23429_FOLLOWUP. Authored-by: LantaoJin <jinlan...@gmail.com> Signed-off-by: Imran Rashid <iras...@cloudera.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/a129f079 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/a129f079 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/a129f079 Branch: refs/heads/master Commit: a129f079557204e3694754a5f9184c7f178cdf2a Parents: ce40efa Author: LantaoJin <jinlan...@gmail.com> Authored: Tue Oct 30 11:01:55 2018 -0500 Committer: Imran Rashid <iras...@cloudera.com> Committed: Tue Oct 30 11:01:55 2018 -0500 ---------------------------------------------------------------------- core/src/main/scala/org/apache/spark/Heartbeater.scala | 2 +- .../src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala | 2 +- core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala | 2 +- core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/a129f079/core/src/main/scala/org/apache/spark/Heartbeater.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/Heartbeater.scala b/core/src/main/scala/org/apache/spark/Heartbeater.scala index 5ba1b9b..84091ee 100644 --- a/core/src/main/scala/org/apache/spark/Heartbeater.scala +++ b/core/src/main/scala/org/apache/spark/Heartbeater.scala @@ -61,7 +61,7 @@ private[spark] class Heartbeater( /** * Get the current executor level metrics. These are returned as an array, with the index - * determined by MetricGetter.values + * determined by ExecutorMetricType.values */ def getCurrentMetrics(): ExecutorMetrics = { val metrics = ExecutorMetricType.values.map(_.getMetricValue(memoryManager)).toArray http://git-wip-us.apache.org/repos/asf/spark/blob/a129f079/core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala b/core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala index 2933f3b..1befd27 100644 --- a/core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala +++ b/core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala @@ -28,7 +28,7 @@ import org.apache.spark.metrics.ExecutorMetricType @DeveloperApi class ExecutorMetrics private[spark] extends Serializable { - // Metrics are indexed by MetricGetter.values + // Metrics are indexed by ExecutorMetricType.values private val metrics = new Array[Long](ExecutorMetricType.values.length) // the first element is initialized to -1, indicating that the values for the array http://git-wip-us.apache.org/repos/asf/spark/blob/a129f079/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala index f93d8a8..34b1160 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala @@ -265,7 +265,7 @@ private[spark] class DAGScheduler( // (taskId, stageId, stageAttemptId, accumUpdates) accumUpdates: Array[(Long, Int, Int, Seq[AccumulableInfo])], blockManagerId: BlockManagerId, - // executor metrics indexed by MetricGetter.values + // executor metrics indexed by ExecutorMetricType.values executorUpdates: ExecutorMetrics): Boolean = { listenerBus.post(SparkListenerExecutorMetricsUpdate(execId, accumUpdates, Some(executorUpdates))) http://git-wip-us.apache.org/repos/asf/spark/blob/a129f079/core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala b/core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala index 293e836..e92b8a2 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala @@ -175,7 +175,7 @@ case class SparkListenerExecutorMetricsUpdate( * @param execId executor id * @param stageId stage id * @param stageAttemptId stage attempt - * @param executorMetrics executor level metrics, indexed by MetricGetter.values + * @param executorMetrics executor level metrics, indexed by ExecutorMetricType.values */ @DeveloperApi case class SparkListenerStageExecutorMetrics( --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
