HyukjinKwon commented on pull request #305:
URL: https://github.com/apache/spark-website/pull/305#issuecomment-782552488
LGTM!
This is an automated message from the Apache Git Service.
To respond to the message, please log
dongjoon-hyun commented on pull request #305:
URL: https://github.com/apache/spark-website/pull/305#issuecomment-782554878
Thank you, @maropu and @HyukjinKwon !
This is an automated message from the Apache Git Service.
To
dongjoon-hyun merged pull request #304:
URL: https://github.com/apache/spark-website/pull/304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
attilapiros opened a new pull request #307:
URL: https://github.com/apache/spark-website/pull/307
After
https://github.com/apache/spark-website/commit/1bb4e571b6a575d1be2569da46e843beccc4
the next logical step is automate the checking of the documentation generation:
- check the
srowen commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782693086
Seems like a fine idea. I don't know how to enable workflows myself but can
click buttons if I know where to click.
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782729217
I checked this out one of my own repo and I assume this must be set:
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782692747
@dongjoon-hyun @srowen @HyukjinKwon as I see we might need to enable github
workflow for this to work
What do you think about this idea? Could you help me be
attilapiros edited a comment on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782695062
Thanks Sean! I found this page:
https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782695062
I found this page:
https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow
srowen commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782721677
Dongjoon and Hyukjin know it much better but if they don't pick this up in a
while I can try. I need to merge it first I assume?
HyukjinKwon commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782817894
That "Settings", even committers or PMCs don't have an access to that. We
just have the write access. For such requests, we should go through [INFRA
attilapiros commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-782824379
Sure, I have not forgotten that one. Actually I can do that parallel with
the workflow PR.
This is an
attilapiros opened a new pull request #308:
URL: https://github.com/apache/spark-website/pull/308
Most of the changes are the result of using a new CSS class:
`language-plaintext`.
There are a few removed empty lines and some lines are breaked at another
position.
attilapiros commented on a change in pull request #307:
URL: https://github.com/apache/spark-website/pull/307#discussion_r579783598
##
File path: .github/workflows/doc_gen.yml
##
@@ -0,0 +1,40 @@
+name: Check document generation
+
+on:
+ push:
+branches:
+- asf-site
+
HyukjinKwon commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-782824636
Ah, sure. I was just checking if I understood correctly. Thanks @attilapiros.
This is an automated
HyukjinKwon commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-782816702
Quick checking: we still need to pin the Jeykill to the latest, right?
This is an automated message
HyukjinKwon commented on a change in pull request #307:
URL: https://github.com/apache/spark-website/pull/307#discussion_r579768241
##
File path: .github/workflows/doc_gen.yml
##
@@ -0,0 +1,40 @@
+name: Check document generation
+
+on:
+ push:
+branches:
+- asf-site
+
attilapiros commented on pull request #308:
URL: https://github.com/apache/spark-website/pull/308#issuecomment-782829420
@HyukjinKwon
This is an automated message from the Apache Git Service.
To respond to the message,
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782831025
Thanks @HyukjinKwon I have opened:
https://issues.apache.org/jira/browse/INFRA-21450.
This is an
dongjoon-hyun commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782894282
According to INFRA-21450, the policy seems to enable GitHub Action Workflow
by default. I'm not sure how we can test this on PR.
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782896440
What about removing my 2nd commit (the temporary test). Merging this PR then
testing the idea with a new PR which won't be merged? If there is a problem we
can revert
HyukjinKwon commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782960002
@attilapiros, can you test this in your fork with changing the branch to
test? Then I think we can just merge and see if works good in the main repo too.
HyukjinKwon closed pull request #308:
URL: https://github.com/apache/spark-website/pull/308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
HyukjinKwon edited a comment on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-782817894
That "Settings", even committers or PMCs don't have an access to that. We
just have the write access. For such requests, we should go through [INFRA
dongjoon-hyun opened a new pull request #305:
URL: https://github.com/apache/spark-website/pull/305
This PR aims to add Apache Spark 3.0.2 documentation
- `site/docs/3.0.2`
- `latest -> 3.0.2`
This is an automated
dongjoon-hyun commented on pull request #305:
URL: https://github.com/apache/spark-website/pull/305#issuecomment-782265143
Thank you so much!
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun opened a new pull request #306:
URL: https://github.com/apache/spark-website/pull/306
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
attilapiros commented on pull request #304:
URL: https://github.com/apache/spark-website/pull/304#issuecomment-782260725
I fixed one more thing in addition to the requested changes: I have added
`--exclude-tags r` to `dev-run-integration-tests.sh` call as for
`make-distribution.sh` the
dongjoon-hyun merged pull request #305:
URL: https://github.com/apache/spark-website/pull/305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun edited a comment on pull request #305:
URL: https://github.com/apache/spark-website/pull/305#issuecomment-78225
cc @srowen , @HyukjinKwon , @viirya , @maropu
This is an automated message from the Apache
dongjoon-hyun commented on pull request #305:
URL: https://github.com/apache/spark-website/pull/305#issuecomment-78225
cc @srowen , @HyukjinKwon , @viirya
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on pull request #306:
URL: https://github.com/apache/spark-website/pull/306#issuecomment-782315040
cc @srowen , @HyukjinKwon , @cloud-fan , @viirya , @holdenk
This is an automated message from the
dongjoon-hyun merged pull request #306:
URL: https://github.com/apache/spark-website/pull/306
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun edited a comment on pull request #306:
URL: https://github.com/apache/spark-website/pull/306#issuecomment-782344428
Thank you, @viirya and @srowen !
This is an automated message from the Apache Git Service.
To
dongjoon-hyun commented on pull request #306:
URL: https://github.com/apache/spark-website/pull/306#issuecomment-782344428
Thank you, @viirya !
This is an automated message from the Apache Git Service.
To respond to the
maropu commented on pull request #305:
URL: https://github.com/apache/spark-website/pull/305#issuecomment-782388462
late lgtm. Thanks for the manager!
This is an automated message from the Apache Git Service.
To respond to
srowen commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-778633034
Comically, the merge script fails:
```
Traceback (most recent call last):
File "./merge_pr.py", line 287, in
main()
File "./merge_pr.py", line 278, in
attilapiros commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-778636006
Yes it will be the left double quotation mark:
https://www.fileformat.info/info/unicode/char/201c/index.htm
I can remove those.
attilapiros commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-778635666
@srowen please wait with the merge till I address @HyukjinKwon comments.
Regarding the non-ascii char I am afraid it could be the quote in my github
name:
attilapiros edited a comment on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-778635666
@srowen please wait with the merge till I address @HyukjinKwon comments: I
can change jekyll install to use a local path.
Regarding the non-ascii char I am
attilapiros commented on pull request #303:
URL: https://github.com/apache/spark-website/pull/303#issuecomment-778733149
I think we should merge the Spark PR first:
https://github.com/apache/spark/pull/31559
Then I will apply those solutions (adding Gemfile.lock to version control)
attilapiros commented on pull request #309:
URL: https://github.com/apache/spark-website/pull/309#issuecomment-783547425
@srowen @HyukjinKwon this was added for the Spark repo but here we also need
this to support Ruby 3
attilapiros opened a new pull request #309:
URL: https://github.com/apache/spark-website/pull/309
This adds webrick as gem to support Ruby 3.
To the generated documents it has no effect.
This is an automated
attilapiros commented on pull request #308:
URL: https://github.com/apache/spark-website/pull/308#issuecomment-783502623
It is good to know that both on Jekyll 3.6.3 and 4.2.0 this kind of errors
are reported when `jekyll serve` is used:
```
done in 1.677 seconds.
srowen commented on pull request #308:
URL: https://github.com/apache/spark-website/pull/308#issuecomment-783504123
I think it's because long ago I changed one of site/ or content/ to redirect
to the other to retain some older content paths. Yes I've seen it and can be
ignored. In fact
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-783673625
Oh there is a typo "documention" => "documentation".
This is an automated message from the Apache Git
attilapiros commented on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-783672863
@HyukjinKwon thanks, this was a great idea.
I tried it with some slight modification: simply cherry picked this change
into my fork's asf-site branch and pushed it.
attilapiros edited a comment on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-783672863
@HyukjinKwon thanks, this was a great idea.
I tried it with some slight modification: simply cherry picked this change
into my fork's asf-site branch and
zero323 edited a comment on pull request #355:
URL: https://github.com/apache/spark-website/pull/355#issuecomment-901305574
I was looking into it and [the
following](https://support.nabble.com/Downsizing-Nabble-td7609715.html):
> Forum owners who want their forum preserved can post
srowen opened a new pull request #355:
URL: https://github.com/apache/spark-website/pull/355
Nabble archive links appear to not work anymore. Use ASF pony mail links
instead for archives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
zero323 commented on pull request #355:
URL: https://github.com/apache/spark-website/pull/355#issuecomment-901305574
I was looking into it and [found
this](https://support.nabble.com/Downsizing-Nabble-td7609715.html):
> Forum owners who want their forum preserved can post to this
srowen closed pull request #355:
URL: https://github.com/apache/spark-website/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gengliangwang commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r691803255
##
File path: release-process.md
##
@@ -39,15 +39,82 @@ If you are a new Release Manager, you can read up on the
process from the follow
yutoacts commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-901576855
It ended up as https://github.com/apache/spark/pull/33537.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
yutoacts closed pull request #350:
URL: https://github.com/apache/spark-website/pull/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cloud-fan commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r691793523
##
File path: release-process.md
##
@@ -39,15 +39,82 @@ If you are a new Release Manager, you can read up on the
process from the follow
You
cloud-fan commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r691793389
##
File path: release-process.md
##
@@ -39,15 +39,82 @@ If you are a new Release Manager, you can read up on the
process from the follow
You
HyukjinKwon commented on pull request #355:
URL: https://github.com/apache/spark-website/pull/355#issuecomment-901519830
lgtm2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Ngone51 opened a new pull request #356:
URL: https://github.com/apache/spark-website/pull/356
This PR proposes to improve the guideline of `Preparing gpg key` section in
the release process. This's how it looks like before and after:
### Before
Ngone51 commented on pull request #356:
URL: https://github.com/apache/spark-website/pull/356#issuecomment-901591270
cc @HyukjinKwon @cloud-fan @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cloud-fan commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r693773768
##
File path: release-process.md
##
@@ -39,15 +39,90 @@ If you are a new Release Manager, you can read up on the
process from the follow
You
cloud-fan merged pull request #356:
URL: https://github.com/apache/spark-website/pull/356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cloud-fan commented on pull request #356:
URL: https://github.com/apache/spark-website/pull/356#issuecomment-906189763
merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Ngone51 commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r696361680
##
File path: release-process.md
##
@@ -39,15 +39,79 @@ If you are a new Release Manager, you can read up on the
process from the follow
You can
gengliangwang commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r696359512
##
File path: release-process.md
##
@@ -39,15 +39,79 @@ If you are a new Release Manager, you can read up on the
process from the follow
srowen closed pull request #353:
URL: https://github.com/apache/spark-website/pull/353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fredster33 opened a new pull request #354:
URL: https://github.com/apache/spark-website/pull/354
Note: there's a typo in my commit, it's supposed to spell "fixes".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
srowen closed pull request #354:
URL: https://github.com/apache/spark-website/pull/354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fredster33 edited a comment on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-89836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fredster33 commented on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-89836
This: https://imgur.com/a/jjyMKMM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
srowen commented on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-898774923
I may be blind but don't see 'fixes'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
srowen commented on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-898777125
That's fine, but what is your first comment referring to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
fredster33 commented on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-898775216
Markdown and Scala should be capitalized as proper nouns, IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
srowen commented on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-898779991
Oh, the commit message. That's fine, doesn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
fredster33 commented on pull request #354:
URL: https://github.com/apache/spark-website/pull/354#issuecomment-898779889
The "fies".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Ngone51 commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r691834308
##
File path: release-process.md
##
@@ -39,15 +39,82 @@ If you are a new Release Manager, you can read up on the
process from the follow
You can
cloud-fan commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r691867352
##
File path: release-process.md
##
@@ -39,15 +39,97 @@ If you are a new Release Manager, you can read up on the
process from the follow
You
Ngone51 commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r691848276
##
File path: release-process.md
##
@@ -39,15 +39,82 @@ If you are a new Release Manager, you can read up on the
process from the follow
You can
gengliangwang commented on a change in pull request #356:
URL: https://github.com/apache/spark-website/pull/356#discussion_r692174007
##
File path: release-process.md
##
@@ -39,15 +39,90 @@ If you are a new Release Manager, you can read up on the
process from the follow
yutoacts opened a new pull request #350:
URL: https://github.com/apache/spark-website/pull/350
Document "local-cluster" mode on developer-tools.md.
Related links:
https://github.com/apache/spark/pull/33568
https://github.com/apache/spark/pull/33537
asfgit closed pull request #351:
URL: https://github.com/apache/spark-website/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shaneknapp opened a new pull request #351:
URL: https://github.com/apache/spark-website/pull/351
a small update to the k8s/minikube integration test instructions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun commented on pull request #351:
URL: https://github.com/apache/spark-website/pull/351#issuecomment-891219026
+1, LGTM. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
srowen commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688140435
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and
include
fredster33 commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688140993
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and
srowen commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688142555
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and
include
fredster33 opened a new pull request #353:
URL: https://github.com/apache/spark-website/pull/353
By commenting it out, it will still appear when somebody starts a PR, but
then they do not need to remove it, as it will be gone after saving (but it is
still visible when editing).
--
This
fredster33 commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688143127
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and
HyukjinKwon commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688174979
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and
srowen commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889154172
I see, if this is really intended as a developer tool, this would be the
right place. The very old SPARK-595 thread suggests it isn't totally for
testing.
--
This is an
tgravescs commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889173380
Note if others disagree, I'm fine with leaving here in developer docs. I
would rather see it go in common docs where we describe all run modes or in
developer docs to
HyukjinKwon commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889145171
I actually suggested to avoid documenting it in the main docs because
local-cluster is test-only mode. But I am fine with doing it in
`docs/spark-standalone.md` too.
srowen commented on a change in pull request #350:
URL: https://github.com/apache/spark-website/pull/350#discussion_r679162872
##
File path: site/sitemap.xml
##
@@ -907,10 +907,6 @@
https://spark.apache.org/mllib/
weekly
-
Review comment:
(Revert this change)
tgravescs commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889172500
so I guess it isn't that big of deal because we don't do document it now and
doesn't seem to have been a big problem, but I assume this issue was filed for
a reason and
HyukjinKwon commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889188101
My only concern about documenting in the main docs is that it happens to
force us to investigate/document it together whenever a cluster related feature
(like archive,
srowen commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889139082
This doesn't quite feel like the right place to document this. How about
docs/spark-standalone.md in the main Spark project docs?
--
This is an automated message from the
yutoacts commented on a change in pull request #350:
URL: https://github.com/apache/spark-website/pull/350#discussion_r679593398
##
File path: site/sitemap.xml
##
@@ -907,10 +907,6 @@
https://spark.apache.org/mllib/
weekly
-
Review comment:
Reverted. Thank you.
yutoacts commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889578852
Thanks for the suggestions. If it goes in main docs, should it be documented
in `docs/spark-standalone.md` or `docs/submitting-applications.md` (as my
initial PR:
yutoacts edited a comment on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889578852
Thanks for the suggestions. If it goes in main docs, should it be documented
in `docs/spark-standalone.md` or `docs/submitting-applications.md` (as my
initial PR:
HyukjinKwon commented on pull request #350:
URL: https://github.com/apache/spark-website/pull/350#issuecomment-889574165
I am fine either way, no big deal. I will defer to @srowen and @tgravescs.
--
This is an automated message from the Apache Git Service.
To respond to the message,
1301 - 1400 of 1888 matches
Mail list logo
