[jira] [Commented] (STREAMS-423) reboot: cleanup source code using import .*;

2016-11-25 Thread Suneel Marthi (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696535#comment-15696535
 ] 

Suneel Marthi commented on STREAMS-423:
---

I guess this would have been addressed by checkstyle ?

> reboot: cleanup source code using import .*;
> 
>
> Key: STREAMS-423
> URL: https://issues.apache.org/jira/browse/STREAMS-423
> Project: Streams
>  Issue Type: Task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.5
>
>
> as ~smarthi mentioned, using import .*; is bad practice
> correct this in the >100 files where it occurs 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-455) LICENSE, NOTICE and DISCLAIMER in source control.

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-455:
---
Fix Version/s: (was: 0.5)
   0.4.1

> LICENSE, NOTICE and DISCLAIMER in source control.
> -
>
> Key: STREAMS-455
> URL: https://issues.apache.org/jira/browse/STREAMS-455
> Project: Streams
>  Issue Type: New Feature
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> per discussion on IPMC mailing list during 0.4 release, the -master and 
> -examples git repositories should have a root LICENSE, NOTICE and DISCLAIMER 
> checked into source control.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-462) Migrate website graphviz diagrams from git to confluence

2016-11-25 Thread Steve Blackmon (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696710#comment-15696710
 ] 

Steve Blackmon commented on STREAMS-462:


We should also add content to the website describing how to alter embedded 
diagrams using confluence.

> Migrate website graphviz diagrams from git to confluence
> 
>
> Key: STREAMS-462
> URL: https://issues.apache.org/jira/browse/STREAMS-462
> Project: Streams
>  Issue Type: Task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> a) migrate dot files out of our source control repos and into confluence
> b) place them in a page hierarchy aligned with our source hierarchy
> c) we'll manage their content from here on out in confluence
> d) we embed them in the web page as we currently do, using links such as 
> https://cwiki.apache.org/confluence/download/attachments/66854246/integration.svg.svg?api=v2
> e) the SVG representation of each diagram gets created by the confluence 
> plugin and exposed to the web by confluence CMS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-457) Facebook page provider uses obsolete schema

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-457:
---
Fix Version/s: (was: 0.5)
   0.4.1

> Facebook page provider uses obsolete schema
> ---
>
> Key: STREAMS-457
> URL: https://issues.apache.org/jira/browse/STREAMS-457
> Project: Streams
>  Issue Type: Bug
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Update model and converter to match API v2.8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-451) Remove CHANGELOG.md

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-451:
---
Fix Version/s: (was: 0.5)
   0.4.1

> Remove CHANGELOG.md
> ---
>
> Key: STREAMS-451
> URL: https://issues.apache.org/jira/browse/STREAMS-451
> Project: Streams
>  Issue Type: Task
>Reporter: Joey Frazee
>Assignee: Suneel Marthi
> Fix For: 0.4.1
>
>
> CHANGELOG.md hasn't been updated for the last two releases (since 0.2) and is 
> mostly redundant with stuff that could be automatically generated out of JIRA 
> or GitHub, so it's probably best off to remove it and link to JIRA or GitHub.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: streams-project #319

2016-11-25 Thread Apache Jenkins Server
See 

--
Started by upstream project "streams-master" build number 105
originally caused by:
 Started by user sblackmon
[EnvInject] - Loading node environment variables.
Building remotely on H11 (ubuntu) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git init  # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 5dffd5c32d0d150727a39104d428b21b52c911d4 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5dffd5c32d0d150727a39104d428b21b52c911d4
 > git rev-list 5dffd5c32d0d150727a39104d428b21b52c911d4 # timeout=10
Parsing POMs
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/streams-master-0.5-incubating-20161125.202808-33.pom
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
sonatype (https://oss.sonatype.org/content/repositories/snapshots)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
typesafe (http://repo.typesafe.com/typesafe/repo)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
google-api-services (http://google-api-client-libraries.appspot.com/mavenrepo)
Downloaded artifact 
https://repository.apache.org/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Modules changed, recalculating dependency graph
Established TCP socket on 34055
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[streams-project] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g -Xms256m 
-XX:MaxPermSize=512m -Dfile.encoding=UTF-8 -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.3.9 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 34055
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -s 
/tmp/settings6020579225700424110.xml -q -U site:attach-descriptor clean verify 
-DskipITs=true
Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal on 
project streams-project: Could not resolve dependencies for project 
org.apache.streams:streams-project:pom:0.5-incubating-SNAPSHOT: Could not find 
artifact org.apache.streams:streams-master:jar:0.5-incubating-SNAPSHOT in 
apache-snapshots (https://repository.apache.org/content/repositories/snapshots) 
-> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about 

[GitHub] incubator-streams pull request #330: Adding KEYS file

2016-11-25 Thread smarthi
GitHub user smarthi opened a pull request:

https://github.com/apache/incubator-streams/pull/330

Adding KEYS file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/smarthi/incubator-streams master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-streams/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #330


commit 7b1548bc6cb75756da82952a4239a6e1c99fa876
Author: smarthi 
Date:   2016-11-25T18:52:04Z

Adding KEYS file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


incubator-streams git commit: STREAMS-440: style xml comes from http, don’t need this master dependency

2016-11-25 Thread sblackmon
Repository: incubator-streams
Updated Branches:
  refs/heads/master 5dffd5c32 -> 025c201c5


STREAMS-440: style xml comes from http, don’t need this master dependency


Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/025c201c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/025c201c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/025c201c

Branch: refs/heads/master
Commit: 025c201c564b550a0c03f1c17245ee516c79891a
Parents: 5dffd5c
Author: Steve Blackmon @steveblackmon 
Authored: Fri Nov 25 14:33:20 2016 -0600
Committer: Steve Blackmon @steveblackmon 
Committed: Fri Nov 25 14:33:20 2016 -0600

--
 pom.xml | 5 -
 1 file changed, 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/025c201c/pom.xml
--
diff --git a/pom.xml b/pom.xml
index 2af57be..ef8e0ea 100644
--- a/pom.xml
+++ b/pom.xml
@@ -305,11 +305,6 @@
 org.slf4j
 slf4j-api
 
-
-org.apache.streams
-streams-master
-${project.version}
-
 
 
 



Build failed in Jenkins: streams-project-site #96

2016-11-25 Thread Apache Jenkins Server
See 

Changes:

[sblackmon] STREAMS-440: custom checkstyle.xml, address compliance

[sblackmon] STREAMS-440: style xml comes from http, don’t need this master

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-4 (ubuntu) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 025c201c564b550a0c03f1c17245ee516c79891a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 025c201c564b550a0c03f1c17245ee516c79891a
 > git rev-list a726a67eda20be4f6809cfac44710656d52dae34 # timeout=10
Parsing POMs
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/streams-master-0.5-incubating-20161125.202926-34.pom
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
sonatype (https://oss.sonatype.org/content/repositories/snapshots)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
typesafe (http://repo.typesafe.com/typesafe/repo)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
google-api-services (http://google-api-client-libraries.appspot.com/mavenrepo)
Downloaded artifact 
https://repository.apache.org/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Modules changed, recalculating dependency graph
Established TCP socket on 60108
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[streams-project-site] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g 
-Xms256m -XX:MaxPermSize=512m -Dfile.encoding=UTF-8 -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.3.9 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 60108
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -s 
/tmp/settings3300881454272320124.xml -q -U generate-sources site:site site:stage
Saving to 
outputFile=
Processed 0 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 145 ms
[JENKINS] Archiving site from 
 to 
/x1/jenkins/jenkins-home/jobs/streams-project-site/site
file:// 
- Session: Opened  

[jira] [Updated] (STREAMS-441) Remove compile dependency on guava for core packages

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-441:
---
Fix Version/s: (was: 0.5)
   0.4.1

> Remove compile dependency on guava for core packages
> 
>
> Key: STREAMS-441
> URL: https://issues.apache.org/jira/browse/STREAMS-441
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Suneel Marthi
> Fix For: 0.4.1
>
>
> To simplify the transitive dependency tree and reduce odds of users hitting 
> shading issues.
> streams-util
> streams-config
> streams-core
> streams-pojo
> streams-pojo-extensions
> streams-schemas/*
> streams-verbs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-456) Facebook page provider does not include many fields

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-456:
---
Fix Version/s: (was: 0.5)
   0.4.1

> Facebook page provider does not include many fields 
> 
>
> Key: STREAMS-456
> URL: https://issues.apache.org/jira/browse/STREAMS-456
> Project: Streams
>  Issue Type: Bug
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> FacebookPageDataCollector currently retrieves and writes only name and id.
> To get additional fields, you have to ask for them in the request.
> Update provider to ask for a configurable list of fields, which defaults to 
> all fields available in FB API 2.8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[39/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-amazon-aws/streams-persist-kinesis/src/main/java/org/apache/streams/amazon/kinesis/KinesisPersistWriter.java
--
diff --git 
a/streams-contrib/streams-amazon-aws/streams-persist-kinesis/src/main/java/org/apache/streams/amazon/kinesis/KinesisPersistWriter.java
 
b/streams-contrib/streams-amazon-aws/streams-persist-kinesis/src/main/java/org/apache/streams/amazon/kinesis/KinesisPersistWriter.java
index 0a39461..b61a364 100644
--- 
a/streams-contrib/streams-amazon-aws/streams-persist-kinesis/src/main/java/org/apache/streams/amazon/kinesis/KinesisPersistWriter.java
+++ 
b/streams-contrib/streams-amazon-aws/streams-persist-kinesis/src/main/java/org/apache/streams/amazon/kinesis/KinesisPersistWriter.java
@@ -16,8 +16,15 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.amazon.kinesis;
 
+import org.apache.streams.config.ComponentConfigurator;
+import org.apache.streams.config.StreamsConfigurator;
+import org.apache.streams.converter.TypeConverterUtil;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsPersistWriter;
+
 import com.amazonaws.ClientConfiguration;
 import com.amazonaws.Protocol;
 import com.amazonaws.auth.AWSCredentials;
@@ -30,11 +37,7 @@ import com.amazonaws.services.kinesis.model.PutRecordResult;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.base.Strings;
 import com.typesafe.config.Config;
-import org.apache.streams.config.ComponentConfigurator;
-import org.apache.streams.config.StreamsConfigurator;
-import org.apache.streams.converter.TypeConverterUtil;
-import org.apache.streams.core.StreamsDatum;
-import org.apache.streams.core.StreamsPersistWriter;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -48,87 +51,94 @@ import java.util.concurrent.Executors;
 import java.util.concurrent.TimeUnit;
 
 /**
- * Created by sblackmon on 9/2/15.
+ * KinesisPersistWriter writes documents to kinesis.
  */
 public class KinesisPersistWriter implements StreamsPersistWriter {
 
-public final static String STREAMS_ID = "KinesisPersistWriter";
+  public static final String STREAMS_ID = "KinesisPersistWriter";
 
-private static final Logger LOGGER = 
LoggerFactory.getLogger(KinesisPersistWriter.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(KinesisPersistWriter.class);
 
-protected volatile Queue persistQueue;
+  protected volatile Queue persistQueue;
 
-private ObjectMapper mapper = new ObjectMapper();
+  private ObjectMapper mapper = new ObjectMapper();
 
-private KinesisWriterConfiguration config;
+  private KinesisWriterConfiguration config;
 
-private List streamName;
+  private List streamName;
 
-private ExecutorService executor;
+  private ExecutorService executor;
 
-protected AmazonKinesisClient client;
-
-public KinesisPersistWriter() {
-Config config = StreamsConfigurator.config.getConfig("kinesis");
-this.config = new 
ComponentConfigurator<>(KinesisWriterConfiguration.class).detectConfiguration(config);
-this.persistQueue  = new ConcurrentLinkedQueue();
-}
+  protected AmazonKinesisClient client;
 
-public KinesisPersistWriter(KinesisWriterConfiguration config) {
-this.config = config;
-this.persistQueue  = new ConcurrentLinkedQueue();
-}
+  /**
+   * KinesisPersistWriter constructor - resolves KinesisWriterConfiguration 
from JVM 'kinesis'.
+   */
+  public KinesisPersistWriter() {
+Config config = StreamsConfigurator.config.getConfig("kinesis");
+this.config = new 
ComponentConfigurator<>(KinesisWriterConfiguration.class).detectConfiguration(config);
+this.persistQueue  = new ConcurrentLinkedQueue();
+  }
 
-public void setConfig(KinesisWriterConfiguration config) {
-this.config = config;
-}
+  /**
+   * KinesisPersistWriter constructor - uses provided 
KinesisWriterConfiguration.
+   */
+  public KinesisPersistWriter(KinesisWriterConfiguration config) {
+this.config = config;
+this.persistQueue  = new ConcurrentLinkedQueue();
+  }
 
-@Override
-public String getId() {
-return STREAMS_ID;
-}
+  public void setConfig(KinesisWriterConfiguration config) {
+this.config = config;
+  }
 
-@Override
-public void write(StreamsDatum entry) {
+  @Override
+  public String getId() {
+return STREAMS_ID;
+  }
 
-String document = (String) 
TypeConverterUtil.getInstance().convert(entry.getDocument(), String.class);
+  @Override
+  public void write(StreamsDatum entry) {
 
-PutRecordRequest putRecordRequest = new PutRecordRequest()
-.withStreamName(config.getStream())
-.withPartitionKey(entry.getId())
-.withData(ByteBuffer.wrap(document.getBytes()));
+

[15/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-monitoring/src/main/java/org/apache/streams/jackson/ThroughputQueueDeserializer.java
--
diff --git 
a/streams-monitoring/src/main/java/org/apache/streams/jackson/ThroughputQueueDeserializer.java
 
b/streams-monitoring/src/main/java/org/apache/streams/jackson/ThroughputQueueDeserializer.java
index e4d883d..35dbcd5 100644
--- 
a/streams-monitoring/src/main/java/org/apache/streams/jackson/ThroughputQueueDeserializer.java
+++ 
b/streams-monitoring/src/main/java/org/apache/streams/jackson/ThroughputQueueDeserializer.java
@@ -15,73 +15,78 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.jackson;
 
+import org.apache.streams.pojo.json.ThroughputQueueBroadcast;
+
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonDeserializer;
 import com.fasterxml.jackson.databind.JsonNode;
-import org.apache.streams.pojo.json.ThroughputQueueBroadcast;
 import org.slf4j.Logger;
 
+import java.io.IOException;
+import java.lang.management.ManagementFactory;
+import java.util.Arrays;
 import javax.management.MBeanAttributeInfo;
 import javax.management.MBeanInfo;
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
-import java.io.IOException;
-import java.lang.management.ManagementFactory;
-import java.util.Arrays;
 
 public class ThroughputQueueDeserializer extends 
JsonDeserializer {
-private static final Logger LOGGER = 
org.slf4j.LoggerFactory.getLogger(ThroughputQueueDeserializer.class);
 
-public ThroughputQueueDeserializer() {
+  private static final Logger LOGGER = 
org.slf4j.LoggerFactory.getLogger(ThroughputQueueDeserializer.class);
 
-}
+  public ThroughputQueueDeserializer() {
 
-@Override
-public ThroughputQueueBroadcast deserialize(JsonParser jsonParser, 
DeserializationContext deserializationContext) throws IOException, 
JsonProcessingException {
-try {
-MBeanServer server = ManagementFactory.getPlatformMBeanServer();
+  }
 
-ThroughputQueueBroadcast throughputQueueBroadcast = new 
ThroughputQueueBroadcast();
-JsonNode attributes = jsonParser.getCodec().readTree(jsonParser);
+  @Override
+  public ThroughputQueueBroadcast deserialize(JsonParser jsonParser, 
DeserializationContext deserializationContext) throws IOException, 
JsonProcessingException {
+try {
+  MBeanServer server = ManagementFactory.getPlatformMBeanServer();
 
-ObjectName name = new 
ObjectName(attributes.get("canonicalName").asText());
-MBeanInfo info = server.getMBeanInfo(name);
-throughputQueueBroadcast.setName(name.toString());
+  ThroughputQueueBroadcast throughputQueueBroadcast = new 
ThroughputQueueBroadcast();
+  JsonNode attributes = jsonParser.getCodec().readTree(jsonParser);
 
-for (MBeanAttributeInfo attribute : 
Arrays.asList(info.getAttributes())) {
-try {
-switch(attribute.getName()) {
-case "CurrentSize":
-throughputQueueBroadcast.setCurrentSize((long) 
server.getAttribute(name, attribute.getName()));
-break;
-case "AvgWait":
-throughputQueueBroadcast.setAvgWait((double) 
server.getAttribute(name, attribute.getName()));
-break;
-case "MaxWait":
-throughputQueueBroadcast.setMaxWait((long) 
server.getAttribute(name, attribute.getName()));
-break;
-case "Removed":
-throughputQueueBroadcast.setRemoved((long) 
server.getAttribute(name, attribute.getName()));
-break;
-case "Added":
-throughputQueueBroadcast.setAdded((long) 
server.getAttribute(name, attribute.getName()));
-break;
-case "Throughput":
-throughputQueueBroadcast.setThroughput((double) 
server.getAttribute(name, attribute.getName()));
-break;
-}
-} catch (Exception e) {
-LOGGER.error("Exception while trying to deserialize 
ThroughputQueueBroadcast object: {}", e);
-}
-}
+  ObjectName name = new 
ObjectName(attributes.get("canonicalName").asText());
+  MBeanInfo info = server.getMBeanInfo(name);
+  throughputQueueBroadcast.setName(name.toString());
 
-return throughputQueueBroadcast;
-} catch (Exception e) {
-return null;
+  

[20/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProvider.java
--
diff --git 
a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProvider.java
 
b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProvider.java
index 66c1104..2527d29 100644
--- 
a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProvider.java
+++ 
b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProvider.java
@@ -18,28 +18,26 @@
 
 package org.apache.streams.twitter.provider;
 
+import org.apache.streams.config.ComponentConfigurator;
+import org.apache.streams.config.StreamsConfiguration;
+import org.apache.streams.config.StreamsConfigurator;
+import org.apache.streams.core.DatumStatusCounter;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsResultSet;
+import org.apache.streams.jackson.StreamsJacksonMapper;
+import org.apache.streams.twitter.TwitterFollowingConfiguration;
+import org.apache.streams.twitter.converter.TwitterDateTimeFormat;
+
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.Lists;
-import com.google.common.collect.Queues;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.Uninterruptibles;
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigFactory;
 import com.typesafe.config.ConfigParseOptions;
-import org.apache.streams.config.ComponentConfigurator;
-import org.apache.streams.config.StreamsConfiguration;
-import org.apache.streams.config.StreamsConfigurator;
-import org.apache.streams.core.DatumStatusCounter;
-import org.apache.streams.core.StreamsDatum;
-import org.apache.streams.core.StreamsResultSet;
-import org.apache.streams.jackson.StreamsJacksonMapper;
-import org.apache.streams.twitter.TwitterFollowingConfiguration;
-import org.apache.streams.twitter.TwitterStreamConfiguration;
-import org.apache.streams.twitter.converter.TwitterDateTimeFormat;
-import org.apache.streams.util.ComponentUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import twitter4j.Twitter;
@@ -51,162 +49,184 @@ import java.io.PrintStream;
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
-import java.util.Queue;
-import java.util.concurrent.ConcurrentLinkedQueue;
-import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 
 /**
- * Created by sblackmon on 11/25/14.
+ * Retrieve all follow adjacencies from a list of user ids or names.
  */
 public class TwitterFollowingProvider extends TwitterUserInformationProvider {
 
-public static final String STREAMS_ID = "TwitterFollowingProvider";
-private static final Logger LOGGER = 
LoggerFactory.getLogger(TwitterFollowingProvider.class);
-
-protected final ReadWriteLock lock = new ReentrantReadWriteLock();
-
-private TwitterFollowingConfiguration config;
-
-List futures = new ArrayList<>();
-
-public static void main(String[] args) throws Exception {
+  public static final String STREAMS_ID = "TwitterFollowingProvider";
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(TwitterFollowingProvider.class);
+
+  protected final ReadWriteLock lock = new ReentrantReadWriteLock();
+
+  private TwitterFollowingConfiguration config;
+
+  List futures = new ArrayList<>();
+
+  /**
+   * To use from command line:
+   *
+   * 
+   * Supply (at least) the following required configuration in 
application.conf:
+   *
+   * 
+   * twitter.oauth.consumerKey
+   * twitter.oauth.consumerSecret
+   * twitter.oauth.accessToken
+   * twitter.oauth.accessTokenSecret
+   * twitter.info
+   *
+   * 
+   * Launch using:
+   *
+   * 
+   * mvn exec:java 
-Dexec.mainClass=org.apache.streams.twitter.provider.TwitterFollowingProvider 
-Dexec.args="application.conf tweets.json"
+   *
+   * @param args args
+   * @throws Exception Exception
+   */
+  public static void main(String[] args) throws Exception {
+
+Preconditions.checkArgument(args.length >= 2);
+
+String configfile = args[0];
+String outfile = args[1];
+
+Config reference = ConfigFactory.load();
+File file = new File(configfile);
+assert (file.exists());
+Config testResourceConfig = ConfigFactory.parseFileAnySyntax(file, 

[26/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-instagram/src/main/java/org/apache/streams/instagram/provider/recentmedia/InstagramRecentMediaProvider.java
--
diff --git 
a/streams-contrib/streams-provider-instagram/src/main/java/org/apache/streams/instagram/provider/recentmedia/InstagramRecentMediaProvider.java
 
b/streams-contrib/streams-provider-instagram/src/main/java/org/apache/streams/instagram/provider/recentmedia/InstagramRecentMediaProvider.java
index 9a31b5a..c68ef95 100644
--- 
a/streams-contrib/streams-provider-instagram/src/main/java/org/apache/streams/instagram/provider/recentmedia/InstagramRecentMediaProvider.java
+++ 
b/streams-contrib/streams-provider-instagram/src/main/java/org/apache/streams/instagram/provider/recentmedia/InstagramRecentMediaProvider.java
@@ -12,15 +12,9 @@ software distributed under the License is distributed on an
 KIND, either express or implied. See the License for the
 specific language governing permissions and limitations
 under the License. */
+
 package org.apache.streams.instagram.provider.recentmedia;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.google.common.base.Preconditions;
-import com.google.common.util.concurrent.Uninterruptibles;
-import com.typesafe.config.Config;
-import com.typesafe.config.ConfigFactory;
-import com.typesafe.config.ConfigParseOptions;
 import org.apache.streams.config.ComponentConfigurator;
 import org.apache.streams.config.StreamsConfiguration;
 import org.apache.streams.config.StreamsConfigurator;
@@ -29,6 +23,14 @@ import org.apache.streams.instagram.InstagramConfiguration;
 import org.apache.streams.instagram.provider.InstagramAbstractProvider;
 import org.apache.streams.instagram.provider.InstagramDataCollector;
 import org.apache.streams.jackson.StreamsJacksonMapper;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.base.Preconditions;
+import com.google.common.util.concurrent.Uninterruptibles;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import com.typesafe.config.ConfigParseOptions;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -40,78 +42,91 @@ import java.util.Iterator;
 import java.util.concurrent.TimeUnit;
 
 /**
- * Instagram {@link org.apache.streams.core.StreamsProvider} that provides the 
recent media data for a group of users
+ * Instagram {@link org.apache.streams.core.StreamsProvider} that provides the 
recent media data for a group of users.
  *
+ * 
  * Retrieve recent posts from a list of user ids or names.
  *
- *  To use from command line:
- *
- *  Supply (at least) the following required configuration in application.conf:
- *
- *  instagram.clientKey
- *  instagram.usersInfo.authorizedTokens
- *  instagram.usersInfo.users
- *
- *  Launch using:
- *
- *  mvn exec:java 
-Dexec.mainClass=org.apache.streams.instagram.provider.recentmedia.InstagramRecentMediaProvider
 -Dexec.args="application.conf media.json"
  */
 public class InstagramRecentMediaProvider extends InstagramAbstractProvider {
 
-public static final String STREAMS_ID = "InstagramRecentMediaProvider";
-
-private static final Logger LOGGER = 
LoggerFactory.getLogger(InstagramRecentMediaProvider.class);
-
-private static ObjectMapper MAPPER = StreamsJacksonMapper.getInstance();
-
-public InstagramRecentMediaProvider() {
-}
-
-public InstagramRecentMediaProvider(InstagramConfiguration config) {
-super(config);
-}
-
-@Override
-protected InstagramDataCollector getInstagramDataCollector() {
-return new InstagramRecentMediaCollector(super.dataQueue, 
super.config);
-}
-
-public static void main(String[] args) throws Exception {
-
-Preconditions.checkArgument(args.length >= 2);
-
-String configfile = args[0];
-String outfile = args[1];
-
-Config reference = ConfigFactory.load();
-File conf_file = new File(configfile);
-assert(conf_file.exists());
-Config conf = ConfigFactory.parseFileAnySyntax(conf_file, 
ConfigParseOptions.defaults().setAllowMissing(false));
-
-Config typesafe  = conf.withFallback(reference).resolve();
-
-StreamsConfiguration streamsConfiguration = 
StreamsConfigurator.detectConfiguration(typesafe);
-InstagramConfiguration config = new 
ComponentConfigurator<>(InstagramConfiguration.class).detectConfiguration(typesafe,
 "instagram");
-InstagramRecentMediaProvider provider = new 
InstagramRecentMediaProvider(config);
-
-PrintStream outStream = new PrintStream(new BufferedOutputStream(new 
FileOutputStream(outfile)));
-provider.prepare(config);
-provider.startStream();
-do {
-

[18/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-twitter/src/test/java/org/apache/streams/twitter/test/utils/TwitterDocumentClassifierTest.java
--
diff --git 
a/streams-contrib/streams-provider-twitter/src/test/java/org/apache/streams/twitter/test/utils/TwitterDocumentClassifierTest.java
 
b/streams-contrib/streams-provider-twitter/src/test/java/org/apache/streams/twitter/test/utils/TwitterDocumentClassifierTest.java
index a1ca7c5..418491a 100644
--- 
a/streams-contrib/streams-provider-twitter/src/test/java/org/apache/streams/twitter/test/utils/TwitterDocumentClassifierTest.java
+++ 
b/streams-contrib/streams-provider-twitter/src/test/java/org/apache/streams/twitter/test/utils/TwitterDocumentClassifierTest.java
@@ -24,6 +24,7 @@ import org.apache.streams.twitter.pojo.Follow;
 import org.apache.streams.twitter.pojo.Retweet;
 import org.apache.streams.twitter.pojo.Tweet;
 import org.apache.streams.twitter.pojo.User;
+
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -34,55 +35,60 @@ import java.util.List;
  */
 public class TwitterDocumentClassifierTest {
 
-private String tweet = "{\"created_at\":\"Wed Dec 11 22:27:34 + 
2013\",\"id\":12345,\"id_str\":\"12345\",\"text\":\"text\",\"source\":\"source\",\"truncated\":false,\"in_reply_to_status_id\":null,\"in_reply_to_status_id_str\":null,\"in_reply_to_user_id\":null,\"in_reply_to_user_id_str\":null,\"in_reply_to_screen_name\":null,\"user\":{\"id\":91407775,\"id_str\":\"12345\",\"name\":\"name\",\"screen_name\":\"screen_name\",\"location\":\"\",\"url\":null,\"description\":null,\"protected\":false,\"followers_count\":136,\"friends_count\":0,\"listed_count\":1,\"created_at\":\"Fri
 Nov 20 19:29:02 + 
2009\",\"favourites_count\":0,\"utc_offset\":null,\"time_zone\":null,\"geo_enabled\":false,\"verified\":false,\"statuses_count\":1793,\"lang\":\"en\",\"contributors_enabled\":false,\"is_translator\":false,\"profile_background_color\":\"C0DEED\",\"profile_background_image_url\":\"http:\\/\\/profile_background_image_url.png\",\"profile_background_image_url_https\":\"https:\\/\\/profile_b
 
ackground_image_url_https.png\",\"profile_background_tile\":false,\"profile_image_url\":\"http:\\/\\/profile_image_url.jpg\",\"profile_image_url_https\":\"https:\\/\\/profile_image_url_https.jpg\",\"profile_link_color\":\"0084B4\",\"profile_sidebar_border_color\":\"C0DEED\",\"profile_sidebar_fill_color\":\"DDEEF6\",\"profile_text_color\":\"33\",\"profile_use_background_image\":true,\"default_profile\":true,\"default_profile_image\":false,\"following\":null,\"follow_request_sent\":null,\"notifications\":null},\"geo\":null,\"coordinates\":null,\"place\":null,\"contributors\":null,\"retweet_count\":0,\"favorite_count\":0,\"entities\":{\"hashtags\":[],\"symbols\":[],\"urls\":[{\"url\":\"http:\\/\\/url\",\"expanded_url\":\"http:\\/\\/expanded_url\",\"display_url\":\"display_url\",\"indices\":[118,140]}],\"user_mentions\":[]},\"favorited\":false,\"retweeted\":false,\"possibly_sensitive\":false,\"filter_level\":\"medium\",\"lang\":\"en\"}\n";
-private String retweet = "{\"created_at\":\"Wed Dec 11 22:27:34 + 
2013\",\"id\":23456,\"id_str\":\"23456\",\"text\":\"text\",\"source\":\"web\",\"truncated\":false,\"in_reply_to_status_id\":null,\"in_reply_to_status_id_str\":null,\"in_reply_to_user_id\":null,\"in_reply_to_user_id_str\":null,\"in_reply_to_screen_name\":null,\"user\":{\"id\":163149656,\"id_str\":\"34567\",\"name\":\"name\",\"screen_name\":\"screen_name\",\"location\":\"location\",\"url\":\"http:\\/\\/www.youtube.com\\/watch?v=url\",\"description\":\"description\\u00ed\",\"protected\":false,\"followers_count\":41,\"friends_count\":75,\"listed_count\":2,\"created_at\":\"Mon
 Jul 05 17:35:49 + 
2010\",\"favourites_count\":4697,\"utc_offset\":-10800,\"time_zone\":\"Buenos 
Aires\",\"geo_enabled\":false,\"verified\":false,\"statuses_count\":5257,\"lang\":\"es\",\"contributors_enabled\":false,\"is_translator\":false,\"profile_background_color\":\"C4A64B\",\"profile_background_image_url\":\"http:\\/\\/a0.twimg.com\\
 

[06/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProviderTask.java
--
diff --git 
a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProviderTask.java
 
b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProviderTask.java
index 3405882..26272ea 100644
--- 
a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProviderTask.java
+++ 
b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProviderTask.java
@@ -18,17 +18,22 @@
 
 package org.apache.streams.local.tasks;
 
-import com.google.common.util.concurrent.Uninterruptibles;
 import org.apache.streams.config.StreamsConfiguration;
-import org.apache.streams.core.*;
+import org.apache.streams.core.DatumStatus;
+import org.apache.streams.core.DatumStatusCountable;
+import org.apache.streams.core.DatumStatusCounter;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsProvider;
+import org.apache.streams.core.StreamsResultSet;
 import org.apache.streams.core.util.DatumUtils;
 import org.apache.streams.local.counters.StreamsTaskCounter;
+
+import com.google.common.util.concurrent.Uninterruptibles;
 import org.joda.time.DateTime;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.math.BigInteger;
-import java.util.Map;
 import java.util.Queue;
 import java.util.UUID;
 import java.util.concurrent.BlockingQueue;
@@ -40,219 +45,219 @@ import java.util.concurrent.atomic.AtomicBoolean;
  */
 public class StreamsProviderTask extends BaseStreamsTask implements 
DatumStatusCountable {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(StreamsProviderTask.class);
+  private final static Logger LOGGER = 
LoggerFactory.getLogger(StreamsProviderTask.class);
 
-public DatumStatusCounter getDatumStatusCounter() {
-return this.statusCounter;
-}
+  public DatumStatusCounter getDatumStatusCounter() {
+return this.statusCounter;
+  }
 
-private static enum Type {
-PERPETUAL,
-READ_CURRENT,
-READ_NEW,
-READ_RANGE
-}
+  private static enum Type {
+PERPETUAL,
+READ_CURRENT,
+READ_NEW,
+READ_RANGE
+  }
 
-private static final int START = 0;
-private static final int END = 1;
+  private static final int START = 0;
+  private static final int END = 1;
 
-private StreamsProvider provider;
-private final AtomicBoolean keepRunning = new AtomicBoolean(true);
-private final AtomicBoolean flushing = new AtomicBoolean(false);
-private final AtomicBoolean started = new AtomicBoolean(false);
-private Type type;
-private BigInteger sequence;
-private DateTime[] dateRange;
-private StreamsConfiguration config;
+  private StreamsProvider provider;
+  private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+  private final AtomicBoolean flushing = new AtomicBoolean(false);
+  private final AtomicBoolean started = new AtomicBoolean(false);
+  private Type type;
+  private BigInteger sequence;
+  private DateTime[] dateRange;
+  private StreamsConfiguration config;
 
-private int timeout;
-private long sleepTime;
-private int zeros = 0;
-private DatumStatusCounter statusCounter = new DatumStatusCounter();
-private StreamsTaskCounter counter;
+  private int timeout;
+  private long sleepTime;
+  private int zeros = 0;
+  private DatumStatusCounter statusCounter = new DatumStatusCounter();
+  private StreamsTaskCounter counter;
 
-/**
- * Constructor for a StreamsProvider to execute {@link 
org.apache.streams.core.StreamsProvider:readCurrent()}
- * @param provider
- */
-public StreamsProviderTask(StreamsProvider provider, boolean perpetual, 
StreamsConfiguration streamConfig) {
-super(streamConfig);
-streamConfig = super.streamConfig;
-this.provider = provider;
-if( perpetual )
-this.type = Type.PERPETUAL;
-else
-this.type = Type.READ_CURRENT;
-this.timeout = super.streamConfig.getProviderTimeoutMs().intValue();
-this.sleepTime = streamConfig.getBatchFrequencyMs();
-}
+  /**
+   * Constructor for a StreamsProvider to execute {@link 
org.apache.streams.core.StreamsProvider:readCurrent()}
+   * @param provider
+   */
+  public StreamsProviderTask(StreamsProvider provider, boolean perpetual, 
StreamsConfiguration streamConfig) {
+super(streamConfig);
+streamConfig = super.streamConfig;
+this.provider = provider;
+if( perpetual )
+  this.type = Type.PERPETUAL;
+else
+  this.type = Type.READ_CURRENT;
+this.timeout = super.streamConfig.getProviderTimeoutMs().intValue();
+this.sleepTime = 

[34/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-persist-hdfs/src/main/java/org/apache/streams/hdfs/WebHdfsPersistWriter.java
--
diff --git 
a/streams-contrib/streams-persist-hdfs/src/main/java/org/apache/streams/hdfs/WebHdfsPersistWriter.java
 
b/streams-contrib/streams-persist-hdfs/src/main/java/org/apache/streams/hdfs/WebHdfsPersistWriter.java
index 492eccb..4554c0f 100644
--- 
a/streams-contrib/streams-persist-hdfs/src/main/java/org/apache/streams/hdfs/WebHdfsPersistWriter.java
+++ 
b/streams-contrib/streams-persist-hdfs/src/main/java/org/apache/streams/hdfs/WebHdfsPersistWriter.java
@@ -18,13 +18,6 @@
 
 package org.apache.streams.hdfs;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.google.common.base.Strings;
-import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.fs.CommonConfigurationKeysPublic;
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.security.UserGroupInformation;
 import org.apache.streams.config.ComponentConfigurator;
 import org.apache.streams.config.StreamsConfigurator;
 import org.apache.streams.converter.LineReadWriteUtil;
@@ -34,6 +27,15 @@ import org.apache.streams.core.DatumStatusCounter;
 import org.apache.streams.core.StreamsDatum;
 import org.apache.streams.core.StreamsPersistWriter;
 import org.apache.streams.jackson.StreamsJacksonMapper;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.base.Strings;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.CommonConfigurationKeysPublic;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.security.UserGroupInformation;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -50,249 +52,278 @@ import java.util.List;
 import java.util.Queue;
 import java.util.zip.GZIPOutputStream;
 
+/**
+ * WebHdfsPersistWriter writes to hdfs.
+ */
 public class WebHdfsPersistWriter implements StreamsPersistWriter, Flushable, 
Closeable, DatumStatusCountable {
 
-public final static String STREAMS_ID = "WebHdfsPersistWriter";
-
-private final static Logger LOGGER = 
LoggerFactory.getLogger(WebHdfsPersistWriter.class);
-
-private FileSystem client;
-private Path path;
-private int linesPerFile;
-private int totalRecordsWritten = 0;
-private final List writtenFiles = new ArrayList();
-private int fileLineCounter = 0;
-private OutputStreamWriter currentWriter = null;
-
-private static final int BYTES_IN_MB = 1024 * 1024;
-private static final int BYTES_BEFORE_FLUSH = 64 * BYTES_IN_MB;
-private volatile int totalByteCount = 0;
-private volatile int byteCount = 0;
-
-public boolean terminate = false;
-
-protected volatile Queue persistQueue;
-
-private ObjectMapper mapper;
-private LineReadWriteUtil lineWriterUtil;
-
-protected HdfsWriterConfiguration hdfsConfiguration;
-
-public WebHdfsPersistWriter() {
-this(new 
ComponentConfigurator<>(HdfsWriterConfiguration.class).detectConfiguration(StreamsConfigurator.getConfig().getConfig("hdfs")));
-}
-
-public WebHdfsPersistWriter(HdfsWriterConfiguration hdfsConfiguration) {
-this.hdfsConfiguration = hdfsConfiguration;
-this.linesPerFile = hdfsConfiguration.getLinesPerFile().intValue();
+  public static final String STREAMS_ID = "WebHdfsPersistWriter";
+
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(WebHdfsPersistWriter.class);
+
+  private FileSystem client;
+  private Path path;
+  private int linesPerFile;
+  private int totalRecordsWritten = 0;
+  private final List writtenFiles = new ArrayList();
+  private int fileLineCounter = 0;
+  private OutputStreamWriter currentWriter = null;
+
+  private static final int BYTES_IN_MB = 1024 * 1024;
+  private static final int BYTES_BEFORE_FLUSH = 64 * BYTES_IN_MB;
+  private volatile int totalByteCount = 0;
+  private volatile int byteCount = 0;
+
+  public boolean terminate = false;
+
+  protected volatile Queue persistQueue;
+
+  private ObjectMapper mapper;
+  private LineReadWriteUtil lineWriterUtil;
+
+  protected HdfsWriterConfiguration hdfsConfiguration;
+
+  public WebHdfsPersistWriter() {
+this(new 
ComponentConfigurator<>(HdfsWriterConfiguration.class).detectConfiguration(StreamsConfigurator.getConfig().getConfig("hdfs")));
+  }
+
+  public WebHdfsPersistWriter(HdfsWriterConfiguration hdfsConfiguration) {
+this.hdfsConfiguration = hdfsConfiguration;
+this.linesPerFile = hdfsConfiguration.getLinesPerFile().intValue();
+  }
+
+  /**
+   * getURI from hdfsConfiguration.
+   * @return URI
+   * @throws URISyntaxException URISyntaxException
+   */
+  // TODO: combine with WebHdfsPersistReader.getURI
+  public URI getURI() throws URISyntaxException {
+StringBuilder uriBuilder = new StringBuilder();
+

[27/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-google/google-gplus/src/test/java/com/google/gplus/provider/TestGPlusUserActivityCollector.java
--
diff --git 
a/streams-contrib/streams-provider-google/google-gplus/src/test/java/com/google/gplus/provider/TestGPlusUserActivityCollector.java
 
b/streams-contrib/streams-provider-google/google-gplus/src/test/java/com/google/gplus/provider/TestGPlusUserActivityCollector.java
index 677b22f..3620346 100644
--- 
a/streams-contrib/streams-provider-google/google-gplus/src/test/java/com/google/gplus/provider/TestGPlusUserActivityCollector.java
+++ 
b/streams-contrib/streams-provider-google/google-gplus/src/test/java/com/google/gplus/provider/TestGPlusUserActivityCollector.java
@@ -19,6 +19,12 @@
 
 package com.google.gplus.provider;
 
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.google.gplus.configuration.UserInfo;
+import org.apache.streams.jackson.StreamsJacksonMapper;
+import org.apache.streams.util.api.requests.backoff.BackOffStrategy;
+import 
org.apache.streams.util.api.requests.backoff.impl.ConstantTimeBackOffStrategy;
+
 import com.carrotsearch.randomizedtesting.RandomizedTest;
 import com.carrotsearch.randomizedtesting.annotations.Repeat;
 import com.fasterxml.jackson.databind.DeserializationFeature;
@@ -29,11 +35,7 @@ import com.google.api.services.plus.model.Activity;
 import com.google.api.services.plus.model.ActivityFeed;
 import com.google.common.collect.Lists;
 import com.google.gplus.serializer.util.GPlusActivityDeserializer;
-import org.apache.streams.core.StreamsDatum;
-import org.apache.streams.google.gplus.configuration.UserInfo;
-import org.apache.streams.jackson.StreamsJacksonMapper;
-import org.apache.streams.util.api.requests.backoff.BackOffStrategy;
-import 
org.apache.streams.util.api.requests.backoff.impl.ConstantTimeBackOffStrategy;
+
 import org.joda.time.DateTime;
 import org.junit.Test;
 import org.mockito.invocation.InvocationOnMock;
@@ -55,231 +57,256 @@ import static org.mockito.Mockito.when;
  */
 public class TestGPlusUserActivityCollector extends RandomizedTest {
 
+  private static final String ACTIVITY_TEMPLATE = "{ \"kind\": 
\"plus#activity\", \"etag\": 
\"\\\"Vea_b94Y77GDGgRK7gFNPnolKQw/v1-6aVSBGT4qiStMoz7f2_AN2fM\\\"\", \"title\": 
\"\", \"published\": \"%s\", \"updated\": \"2014-10-27T06:26:33.927Z\", \"id\": 
\"z13twrlznpvtzz52w22mdt1y0k3of1djw04\", \"url\": 
\"https://plus.google.com/116771159471120611293/posts/GR7CGR8N5VL\;, \"actor\": 
{ \"id\": \"116771159471120611293\", \"displayName\": \"displayName\", \"url\": 
\"https://plus.google.com/116771159471120611293\;, \"image\": { \"url\": 
\"https://lh6.googleusercontent.com/-C0fiZBxdvw0/AAI/J5k/K4pgR3_-_ms/photo.jpg?sz=50\;
 } }, \"verb\": \"share\", \"object\": { \"objectType\": \"activity\", \"id\": 
\"z13zgvtiurjgfti1v234iflghvq2c1dge04\", \"actor\": { \"id\": 
\"104954254300557350002\", \"displayName\": \"displayName\", \"url\": 
\"https://plus.google.com/104954254300557350002\;, \"image\": { \"url\": 
\"https://lh4.googleusercontent.com/-SO1scj4p2LA/AAI/I-s/efA
 9LBVe144/photo.jpg?sz=50\" } }, \"content\": \"\", \"url\": 
\"https://plus.google.com/104954254300557350002/posts/AwewXhtn7ws\;, 
\"replies\": { \"totalItems\": 0, \"selfLink\": 
\"https://content.googleapis.com/plus/v1/activities/z13twrlznpvtzz52w22mdt1y0k3of1djw04/comments\;
 }, \"plusoners\": { \"totalItems\": 9, \"selfLink\": 
\"https://content.googleapis.com/plus/v1/activities/z13twrlznpvtzz52w22mdt1y0k3of1djw04/people/plusoners\;
 }, \"resharers\": { \"totalItems\": 0, \"selfLink\": 
\"https://content.googleapis.com/plus/v1/activities/z13twrlznpvtzz52w22mdt1y0k3of1djw04/people/resharers\;
 }, \"attachments\": [ { \"objectType\": \"photo\", \"id\": 
\"104954254300557350002.6074732746360957410\", \"content\": \"26/10/2014 - 1\", 
\"url\": 
\"https://plus.google.com/photos/104954254300557350002/albums/6074732747132702225/6074732746360957410\;,
 \"image\": { \"url\": 
\"https://lh4.googleusercontent.com/-oO3fnARlDm0/VE3JP1xHKeI/eCY/-X2jzc6HruA/w506-h750/2014%2B-%2B1\;,
 \"type\": \"ima
 ge/jpeg\" }, \"fullImage\": { \"url\": 
\"https://lh4.googleusercontent.com/-oO3fnARlDm0/VE3JP1xHKeI/eCY/-X2jzc6HruA/w600-h1141/2014%2B-%2B1\;,
 \"type\": \"image/jpeg\", \"height\": 1141, \"width\": 600 } } ] }, 
\"annotation\": \"Truth 😜\", \"provider\": { \"title\": \"Reshared Post\" }, 
\"access\": { \"kind\": \"plus#acl\", \"description\": \"Public\", \"items\": [ 
{ \"type\": \"public\" } ] } }";
+  private static final ObjectMapper MAPPER = 
StreamsJacksonMapper.getInstance();
+  private static final String IN_RANGE_IDENTIFIER = "data in range";
 
-private static final String ACTIVITY_TEMPLATE = "{ \"kind\": 
\"plus#activity\", \"etag\": 
\"\\\"Vea_b94Y77GDGgRK7gFNPnolKQw/v1-6aVSBGT4qiStMoz7f2_AN2fM\\\"\", 

[12/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-plugins/streams-plugin-hive/src/main/java/org/apache/streams/plugins/hive/StreamsHiveResourceGeneratorMojo.java
--
diff --git 
a/streams-plugins/streams-plugin-hive/src/main/java/org/apache/streams/plugins/hive/StreamsHiveResourceGeneratorMojo.java
 
b/streams-plugins/streams-plugin-hive/src/main/java/org/apache/streams/plugins/hive/StreamsHiveResourceGeneratorMojo.java
index 8638046..eb9490d 100644
--- 
a/streams-plugins/streams-plugin-hive/src/main/java/org/apache/streams/plugins/hive/StreamsHiveResourceGeneratorMojo.java
+++ 
b/streams-plugins/streams-plugin-hive/src/main/java/org/apache/streams/plugins/hive/StreamsHiveResourceGeneratorMojo.java
@@ -34,49 +34,57 @@ import org.slf4j.LoggerFactory;
 import java.io.File;
 import java.util.List;
 
-@Mojo(  name = "generate-resources",
-defaultPhase = LifecyclePhase.GENERATE_RESOURCES
-)
-@Execute(   goal = "generate-resources",
-phase = LifecyclePhase.GENERATE_RESOURCES
-)
+@Mojo (
+name = "generate-resources",
+defaultPhase = LifecyclePhase.GENERATE_RESOURCES
+)
+@Execute (
+goal = "generate-resources",
+phase = LifecyclePhase.GENERATE_RESOURCES
+)
 public class StreamsHiveResourceGeneratorMojo extends AbstractMojo {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(StreamsHiveResourceGeneratorMojo.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(StreamsHiveResourceGeneratorMojo.class);
 
-private volatile MojoFailureException mojoFailureException;
+  private volatile MojoFailureException mojoFailureException;
 
-@Component
-private MavenProject project;
+  @Component
+  private MavenProject project;
 
-@Parameter( defaultValue = "${project.basedir}", readonly = true )
-private File basedir;
+  @Parameter( defaultValue = "${project.basedir}", readonly = true )
+  private File basedir;
 
-@Parameter( defaultValue = "src/main/jsonschema", readonly = true ) // 
Maven 3 only
-public String sourceDirectory;
+  @Parameter( defaultValue = "src/main/jsonschema", readonly = true ) // Maven 
3 only
+  public String sourceDirectory;
 
-@Parameter( readonly = true ) // Maven 3 only
-public List sourcePaths;
+  @Parameter( readonly = true ) // Maven 3 only
+  public List sourcePaths;
 
-@Parameter(defaultValue = "./target/generated-resources/hive", readonly = 
true)
-public String targetDirectory;
+  @Parameter(defaultValue = "./target/generated-resources/hive", readonly = 
true)
+  public String targetDirectory;
 
-public void execute() throws MojoExecutionException, MojoFailureException {
+  /**
+   * execute StreamsHiveResourceGeneratorMojo.
+   * @throws MojoExecutionException MojoExecutionException
+   * @throws MojoFailureException MojoFailureException
+   */
+  public void execute() throws MojoExecutionException, MojoFailureException {
 
-//addProjectDependenciesToClasspath();
+//addProjectDependenciesToClasspath();
 
-StreamsHiveGenerationConfig config = new StreamsHiveGenerationConfig();
+StreamsHiveGenerationConfig config = new StreamsHiveGenerationConfig();
 
-if( sourcePaths != null && sourcePaths.size() > 0)
-config.setSourcePaths(sourcePaths);
-else
-config.setSourceDirectory(sourceDirectory);
-config.setTargetDirectory(targetDirectory);
+if ( sourcePaths != null && sourcePaths.size() > 0) {
+  config.setSourcePaths(sourcePaths);
+} else {
+  config.setSourceDirectory(sourceDirectory);
+}
+config.setTargetDirectory(targetDirectory);
 
-StreamsHiveResourceGenerator streamsHiveResourceGenerator = new 
StreamsHiveResourceGenerator(config);
+StreamsHiveResourceGenerator streamsHiveResourceGenerator = new 
StreamsHiveResourceGenerator(config);
 
-streamsHiveResourceGenerator.run();
+streamsHiveResourceGenerator.run();
 
-}
+  }
 
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-plugins/streams-plugin-hive/src/test/java/org/apache/streams/plugins/test/StreamsHiveResourceGeneratorCLITest.java
--
diff --git 
a/streams-plugins/streams-plugin-hive/src/test/java/org/apache/streams/plugins/test/StreamsHiveResourceGeneratorCLITest.java
 
b/streams-plugins/streams-plugin-hive/src/test/java/org/apache/streams/plugins/test/StreamsHiveResourceGeneratorCLITest.java
index 33113aa..827a992 100644
--- 
a/streams-plugins/streams-plugin-hive/src/test/java/org/apache/streams/plugins/test/StreamsHiveResourceGeneratorCLITest.java
+++ 
b/streams-plugins/streams-plugin-hive/src/test/java/org/apache/streams/plugins/test/StreamsHiveResourceGeneratorCLITest.java
@@ -19,13 +19,12 @@
 
 package org.apache.streams.plugins.test;
 
-import 

[13/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-plugins/streams-plugin-elasticsearch/src/main/java/org/apache/streams/plugins/elasticsearch/StreamsElasticsearchResourceGeneratorMojo.java
--
diff --git 
a/streams-plugins/streams-plugin-elasticsearch/src/main/java/org/apache/streams/plugins/elasticsearch/StreamsElasticsearchResourceGeneratorMojo.java
 
b/streams-plugins/streams-plugin-elasticsearch/src/main/java/org/apache/streams/plugins/elasticsearch/StreamsElasticsearchResourceGeneratorMojo.java
index 1485023..ea512b3 100644
--- 
a/streams-plugins/streams-plugin-elasticsearch/src/main/java/org/apache/streams/plugins/elasticsearch/StreamsElasticsearchResourceGeneratorMojo.java
+++ 
b/streams-plugins/streams-plugin-elasticsearch/src/main/java/org/apache/streams/plugins/elasticsearch/StreamsElasticsearchResourceGeneratorMojo.java
@@ -16,6 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.plugins.elasticsearch;
 
 import org.apache.maven.plugin.AbstractMojo;
@@ -33,58 +34,59 @@ import org.slf4j.LoggerFactory;
 import java.io.File;
 import java.util.List;
 
-@Mojo(  name = "generate-resources",
-defaultPhase = LifecyclePhase.GENERATE_RESOURCES
-)
-@Execute(   goal = "generate-resources",
-phase = LifecyclePhase.GENERATE_RESOURCES
-)
+@Mojo (  name = "generate-resources",
+defaultPhase = LifecyclePhase.GENERATE_RESOURCES
+)
+@Execute (   goal = "generate-resources",
+phase = LifecyclePhase.GENERATE_RESOURCES
+)
 public class StreamsElasticsearchResourceGeneratorMojo extends AbstractMojo {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(StreamsElasticsearchResourceGeneratorMojo.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(StreamsElasticsearchResourceGeneratorMojo.class);
 
-private volatile MojoFailureException mojoFailureException;
+  private volatile MojoFailureException mojoFailureException;
 
-@Component
-private MavenProject project;
+  @Component
+  private MavenProject project;
 
-//@Component
-//private Settings settings;
-//
-//@Parameter( defaultValue = "${localRepository}", readonly = true, 
required = true )
-//protected ArtifactRepository localRepository;
-//
-//@Parameter( defaultValue = "${plugin}", readonly = true ) // Maven 3 only
-//private PluginDescriptor plugin;
-//
-@Parameter( defaultValue = "${project.basedir}", readonly = true )
-private File basedir;
+  //@Component
+  //private Settings settings;
+  //
+  //@Parameter( defaultValue = "${localRepository}", readonly = true, 
required = true )
+  //protected ArtifactRepository localRepository;
+  //
+  //@Parameter( defaultValue = "${plugin}", readonly = true ) // Maven 3 
only
+  //private PluginDescriptor plugin;
+  //
+  @Parameter( defaultValue = "${project.basedir}", readonly = true )
+  private File basedir;
 
-@Parameter( defaultValue = "src/main/jsonschema", readonly = true ) // 
Maven 3 only
-public String sourceDirectory;
+  @Parameter( defaultValue = "src/main/jsonschema", readonly = true ) // Maven 
3 only
+  public String sourceDirectory;
 
-@Parameter( readonly = true ) // Maven 3 only
-public List sourcePaths;
+  @Parameter( readonly = true ) // Maven 3 only
+  public List sourcePaths;
 
-@Parameter(defaultValue = 
"./target/generated-resources/streams-plugin-elasticsearch", readonly = true)
-public String targetDirectory;
+  @Parameter(defaultValue = 
"./target/generated-resources/streams-plugin-elasticsearch", readonly = true)
+  public String targetDirectory;
 
-public void execute() throws MojoExecutionException, MojoFailureException {
+  public void execute() throws MojoExecutionException, MojoFailureException {
 
-//addProjectDependenciesToClasspath();
+//addProjectDependenciesToClasspath();
 
-StreamsElasticsearchGenerationConfig config = new 
StreamsElasticsearchGenerationConfig();
+StreamsElasticsearchGenerationConfig config = new 
StreamsElasticsearchGenerationConfig();
 
-if( sourcePaths != null && sourcePaths.size() > 0)
-config.setSourcePaths(sourcePaths);
-else
-config.setSourceDirectory(sourceDirectory);
-config.setTargetDirectory(targetDirectory);
+if ( sourcePaths != null && sourcePaths.size() > 0) {
+  config.setSourcePaths(sourcePaths);
+} else {
+  config.setSourceDirectory(sourceDirectory);
+}
+config.setTargetDirectory(targetDirectory);
 
-StreamsElasticsearchResourceGenerator 
streamsElasticsearchResourceGenerator = new 
StreamsElasticsearchResourceGenerator(config);
+StreamsElasticsearchResourceGenerator 
streamsElasticsearchResourceGenerator = new 
StreamsElasticsearchResourceGenerator(config);
 
-

[35/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/neo4j/CypherQueryGraphHelper.java
--
diff --git 
a/streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/neo4j/CypherQueryGraphHelper.java
 
b/streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/neo4j/CypherQueryGraphHelper.java
index 86ab72f..e322990 100644
--- 
a/streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/neo4j/CypherQueryGraphHelper.java
+++ 
b/streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/neo4j/CypherQueryGraphHelper.java
@@ -18,17 +18,19 @@
 
 package org.apache.streams.graph.neo4j;
 
+import org.apache.streams.data.util.PropertyUtil;
+import org.apache.streams.graph.QueryGraphHelper;
+import org.apache.streams.jackson.StreamsJacksonMapper;
+import org.apache.streams.pojo.json.Activity;
+import org.apache.streams.pojo.json.ActivityObject;
+
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.google.common.base.Joiner;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
-import org.apache.streams.data.util.PropertyUtil;
-import org.apache.streams.graph.QueryGraphHelper;
-import org.apache.streams.jackson.StreamsJacksonMapper;
-import org.apache.streams.pojo.json.Activity;
-import org.apache.streams.pojo.json.ActivityObject;
+
 import org.javatuples.Pair;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -42,178 +44,196 @@ import java.util.Map;
  */
 public class CypherQueryGraphHelper implements QueryGraphHelper {
 
-private final static ObjectMapper MAPPER = 
StreamsJacksonMapper.getInstance();
+  private static final ObjectMapper MAPPER = 
StreamsJacksonMapper.getInstance();
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(Neo4jHttpGraphHelper.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(Neo4jHttpGraphHelper.class);
 
-public final static String getVertexLongIdStatementTemplate = "MATCH (v) 
WHERE ID(v) =  RETURN v";
-public final static String getVertexStringIdStatementTemplate = "MATCH (v 
{id: ''} ) RETURN v";
+  public static final String getVertexLongIdStatementTemplate = "MATCH (v) 
WHERE ID(v) =  RETURN v";
+  public static final String getVertexStringIdStatementTemplate = "MATCH (v 
{id: ''} ) RETURN v";
 
-public final static String createVertexStatementTemplate = "MATCH (x {id: 
''}) "+
-"CREATE UNIQUE (v: { props }) "+
-"ON CREATE SET v  "+
-"RETURN v";
+  public static final String createVertexStatementTemplate =
+  "MATCH (x {id: ''}) "
+  + "CREATE UNIQUE (v: { props }) "
+  + "ON CREATE SET v  "
+  + "RETURN v";
 
-public final static String mergeVertexStatementTemplate = "MERGE (v: 
{id: ''}) "+
-"ON CREATE SET v , v = { props }, v.`@timestamp` = 
timestamp() "+
-"ON MATCH SET v , v = { props }, v.`@timestamp` = 
timestamp() "+
-"RETURN v";
 
-public final static String createEdgeStatementTemplate = "MATCH 
(s: {id: ''}),(d: {id: ''}) "+
-"CREATE UNIQUE (s)-[r: ]->(d) "+
-"RETURN r";
 
-public Pair> getVertexRequest(String 
streamsId) {
+  public static final String mergeVertexStatementTemplate =
+  "MERGE (v: {id: ''}) "
+  + "ON CREATE SET v , v = { props }, v.`@timestamp` = 
timestamp() "
+  + "ON MATCH SET v , v = { props }, v.`@timestamp` = 
timestamp() "
+  + "RETURN v";
 
-ST getVertex = new ST(getVertexStringIdStatementTemplate);
-getVertex.add("id", streamsId);
+  public static final String createEdgeStatementTemplate =
+  "MATCH (s: {id: ''}),(d: {id: ''}) "
+  + "CREATE UNIQUE (s)-[r: ]->(d) "
+  + "RETURN r";
 
-Pair> queryPlusParameters = new 
Pair(getVertex.render(), null);
+  /**
+   * getVertexRequest.
+   * @param streamsId streamsId
+   * @return pair (streamsId, parameterMap)
+   */
+  public Pair> getVertexRequest(String streamsId) {
 
-LOGGER.debug("getVertexRequest", queryPlusParameters.toString());
+ST getVertex = new ST(getVertexStringIdStatementTemplate);
+getVertex.add("id", streamsId);
 
-return queryPlusParameters;
-}
-
-@Override
-public Pair> getVertexRequest(Long vertexId) {
+Pair> queryPlusParameters = new 
Pair(getVertex.render(), null);
 
-ST getVertex = new ST(getVertexLongIdStatementTemplate);
-getVertex.add("id", vertexId);
+LOGGER.debug("getVertexRequest", queryPlusParameters.toString());
 
-

[30/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/serializer/FacebookActivityUtil.java
--
diff --git 
a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/serializer/FacebookActivityUtil.java
 
b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/serializer/FacebookActivityUtil.java
index 2cf2a7c..93ac199 100644
--- 
a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/serializer/FacebookActivityUtil.java
+++ 
b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/serializer/FacebookActivityUtil.java
@@ -18,11 +18,6 @@
 
 package org.apache.streams.facebook.serializer;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ObjectNode;
-import com.google.common.base.Joiner;
-import com.google.common.base.Optional;
-import com.google.common.collect.Lists;
 import org.apache.streams.data.util.ActivityUtil;
 import org.apache.streams.exceptions.ActivitySerializerException;
 import org.apache.streams.facebook.Cover;
@@ -38,6 +33,13 @@ import org.apache.streams.pojo.json.Activity;
 import org.apache.streams.pojo.json.ActivityObject;
 import org.apache.streams.pojo.json.Image;
 import org.apache.streams.pojo.json.Provider;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import com.google.common.base.Joiner;
+import com.google.common.base.Optional;
+import com.google.common.collect.Lists;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -46,158 +48,163 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
+/**
+ * FacebookActivityUtil helps convert facebook data to activity formats.
+ */
 public class FacebookActivityUtil {
-private static final Logger LOGGER = 
LoggerFactory.getLogger(FacebookActivityUtil.class);
-
-/**
- * Updates the given Activity object with the values from the Page
- * @param page the object to use as the source
- * @param activity the target of the updates.  Will receive all values 
from the Page.
- * @throws org.apache.streams.exceptions.ActivitySerializerException
- */
-public static void updateActivity(Page page, Activity activity) throws 
ActivitySerializerException {
-activity.setActor(buildActor(page));
-activity.setId(null);
-activity.setProvider(getProvider());
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(FacebookActivityUtil.class);
+
+  /**
+   * Updates the given Activity object with the values from the Page.
+   * @param page the object to use as the source
+   * @param activity the target of the updates.  Will receive all values from 
the Page.
+   * @throws ActivitySerializerException
+   */
+  public static void updateActivity(Page page, Activity activity) throws 
ActivitySerializerException {
+activity.setActor(buildActor(page));
+activity.setId(null);
+activity.setProvider(getProvider());
+  }
+
+  /**
+   * Updates the given Activity object with the values from the Post.
+   * @param post post
+   * @param activity activity
+   * @throws ActivitySerializerException
+   */
+  public static void updateActivity(Post post, Activity activity) throws 
ActivitySerializerException {
+activity.setActor(buildActor(post));
+activity.setId(formatId(post.getId()));
+activity.setProvider(getProvider());
+activity.setUpdated(post.getUpdatedTime());
+activity.setPublished(post.getCreatedTime());
+
+if (post.getLink() != null && post.getLink().length() > 0) {
+  List links = new ArrayList<>();
+  links.add(post.getLink());
+  activity.setLinks(links);
 }
 
-/**
- * Updates the given Activity object with the values from the Post
- * @param post
- * @param activity
- * @throws ActivitySerializerException
- */
-public static void updateActivity(Post post, Activity activity) throws 
ActivitySerializerException {
-activity.setActor(buildActor(post));
-activity.setId(formatId(post.getId()));
-activity.setProvider(getProvider());
-activity.setUpdated(post.getUpdatedTime());
-activity.setPublished(post.getCreatedTime());
-
-if(post.getLink() != null && post.getLink().length() > 0) {
-List links = new ArrayList<>();
-links.add(post.getLink());
-activity.setLinks(links);
-}
-
-activity.setContent(post.getMessage());
-
-activity.setVerb("post");
-activity.setObject(buildObject(post));
-buildExtensions(activity, post);
+activity.setContent(post.getMessage());
+
+activity.setVerb("post");
+activity.setObject(buildObject(post));
+buildExtensions(activity, post);
+  }
+

[29/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-google/google-gmail/src/main/java/com/google/gmail/provider/GMailProvider.java
--
diff --git 
a/streams-contrib/streams-provider-google/google-gmail/src/main/java/com/google/gmail/provider/GMailProvider.java
 
b/streams-contrib/streams-provider-google/google-gmail/src/main/java/com/google/gmail/provider/GMailProvider.java
index 5cc6fe7..e11628f 100644
--- 
a/streams-contrib/streams-provider-google/google-gmail/src/main/java/com/google/gmail/provider/GMailProvider.java
+++ 
b/streams-contrib/streams-provider-google/google-gmail/src/main/java/com/google/gmail/provider/GMailProvider.java
@@ -18,6 +18,13 @@
 
 package com.google.gmail.provider;
 
+import org.apache.streams.config.ComponentConfigurator;
+import org.apache.streams.config.StreamsConfigurator;
+import org.apache.streams.core.DatumStatusCounter;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsProvider;
+import org.apache.streams.core.StreamsResultSet;
+
 import com.google.common.base.Preconditions;
 import com.google.gmail.GMailConfiguration;
 import com.googlecode.gmail4j.GmailClient;
@@ -26,12 +33,7 @@ import com.googlecode.gmail4j.http.HttpGmailConnection;
 import com.googlecode.gmail4j.javamail.ImapGmailClient;
 import com.googlecode.gmail4j.javamail.ImapGmailConnection;
 import com.googlecode.gmail4j.rss.RssGmailClient;
-import org.apache.streams.config.ComponentConfigurator;
-import org.apache.streams.config.StreamsConfigurator;
-import org.apache.streams.core.DatumStatusCounter;
-import org.apache.streams.core.StreamsDatum;
-import org.apache.streams.core.StreamsProvider;
-import org.apache.streams.core.StreamsResultSet;
+
 import org.joda.time.DateTime;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -50,141 +52,141 @@ import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
 
 /**
- * Created by sblackmon on 12/10/13.
+ * GMailProvider collects messages from GMail.
  */
 public class GMailProvider implements StreamsProvider, Serializable {
 
-public final static String STREAMS_ID = "GMailProvider";
-
-private final static Logger LOGGER = 
LoggerFactory.getLogger(GMailProvider.class);
+  public final static String STREAMS_ID = "GMailProvider";
 
-private GMailConfiguration config;
+  private final static Logger LOGGER = 
LoggerFactory.getLogger(GMailProvider.class);
 
-private Class klass;
+  private GMailConfiguration config;
 
-public GMailConfiguration getConfig() {
-return config;
-}
+  private Class klass;
 
-public void setConfig(GMailConfiguration config) {
-this.config = config;
-}
+  public GMailConfiguration getConfig() {
+return config;
+  }
 
-protected BlockingQueue inQueue = new LinkedBlockingQueue<>(1);
+  public void setConfig(GMailConfiguration config) {
+this.config = config;
+  }
 
-protected volatile Queue providerQueue = new 
ConcurrentLinkedQueue<>();
-protected Future task;
+  protected BlockingQueue inQueue = new LinkedBlockingQueue<>(1);
 
-public BlockingQueue getInQueue() {
-return inQueue;
-}
+  protected volatile Queue providerQueue = new 
ConcurrentLinkedQueue<>();
+  protected Future task;
 
-protected GmailClient rssClient;
-protected ImapGmailClient imapClient;
+  public BlockingQueue getInQueue() {
+return inQueue;
+  }
 
-private ExecutorService executor;
+  protected GmailClient rssClient;
+  protected ImapGmailClient imapClient;
 
-private static ExecutorService newFixedThreadPoolWithQueueSize(int 
nThreads, int queueSize) {
-return new ThreadPoolExecutor(nThreads, nThreads,
-5000L, TimeUnit.MILLISECONDS,
-new ArrayBlockingQueue(queueSize, true), new 
ThreadPoolExecutor.CallerRunsPolicy());
-}
+  private ExecutorService executor;
 
-public GMailProvider() {
-this.config = new ComponentConfigurator<>(GMailConfiguration.class)
-  
.detectConfiguration(StreamsConfigurator.getConfig().getConfig("gmail"));
-}
+  private static ExecutorService newFixedThreadPoolWithQueueSize(int nThreads, 
int queueSize) {
+return new ThreadPoolExecutor(nThreads, nThreads,
+5000L, TimeUnit.MILLISECONDS,
+new ArrayBlockingQueue(queueSize, true), new 
ThreadPoolExecutor.CallerRunsPolicy());
+  }
 
-public GMailProvider(GMailConfiguration config) {
-this.config = config;
-}
+  public GMailProvider() {
+this.config = new ComponentConfigurator<>(GMailConfiguration.class)
+
.detectConfiguration(StreamsConfigurator.getConfig().getConfig("gmail"));
+  }
 
-public GMailProvider(Class klass) {
-this.config = new ComponentConfigurator<>(GMailConfiguration.class)
-  
.detectConfiguration(StreamsConfigurator.getConfig().getConfig("gmail"));
-  

Build failed in Jenkins: streams-project #318

2016-11-25 Thread Apache Jenkins Server
See 

Changes:

[sblackmon] STREAMS-440: custom checkstyle.xml, address compliance

--
Started by user sblackmon
[EnvInject] - Loading node environment variables.
Building remotely on H11 (ubuntu) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git init  # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 5dffd5c32d0d150727a39104d428b21b52c911d4 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5dffd5c32d0d150727a39104d428b21b52c911d4
 > git rev-list a726a67eda20be4f6809cfac44710656d52dae34 # timeout=10
Parsing POMs
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
sonatype (https://oss.sonatype.org/content/repositories/snapshots)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
typesafe (http://repo.typesafe.com/typesafe/repo)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
google-api-services (http://google-api-client-libraries.appspot.com/mavenrepo)
Downloaded artifact 
https://repository.apache.org/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Modules changed, recalculating dependency graph
Established TCP socket on 51464
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[streams-project] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g -Xms256m 
-XX:MaxPermSize=512m -Dfile.encoding=UTF-8 -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.3.9 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 51464
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -s 
/tmp/settings8261044487834934711.xml -q -U site:attach-descriptor clean verify 
-DskipITs=true
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal on project streams-project: Could not resolve 
dependencies for project 
org.apache.streams:streams-project:pom:0.5-incubating-SNAPSHOT: Could not find 
artifact org.apache.streams:streams-master:jar:0.5-incubating-SNAPSHOT in 
apache-snapshots (https://repository.apache.org/content/repositories/snapshots) 
-> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[JENKINS] Archiving 

[jira] [Commented] (STREAMS-316) add “apache’ to the artifact name

2016-11-25 Thread Suneel Marthi (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696531#comment-15696531
 ] 

Suneel Marthi commented on STREAMS-316:
---

Do we still wanna address this?

> add “apache’ to the artifact name
> -
>
> Key: STREAMS-316
> URL: https://issues.apache.org/jira/browse/STREAMS-316
> Project: Streams
>  Issue Type: Task
>Reporter: Steve Blackmon
>Assignee: Suneel Marthi
>Priority: Trivial
> Fix For: 0.5
>
>
> Suggestions from 0.2-rc3 vote:
> - You may want to consider adding “apache’ to the artifact name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: streams-examples #152

2016-11-25 Thread Apache Jenkins Server
See 

--
Started by upstream project "streams-project" build number 320
originally caused by:
 Started by user sblackmon
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (ubuntu) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams-examples.git # 
 > timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams-examples.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams-examples.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 3eb2e35260b8922dc24c208abf70799c41557d2d (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 3eb2e35260b8922dc24c208abf70799c41557d2d
 > git rev-list 3eb2e35260b8922dc24c208abf70799c41557d2d # timeout=10
Parsing POMs
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/streams-master-0.5-incubating-20161125.202926-34.pom
Downloaded artifact 
https://repository.apache.org/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Modules changed, recalculating dependency graph
Established TCP socket on 38437
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[streams-examples] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g 
-Xms256m -XX:MaxPermSize=512m -Dfile.encoding=ISO-8859-1 -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.3.9 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 38437
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -s 
/tmp/settings4306415028002257.xml clean install verify
[INFO] Scanning for projects...
[INFO] 
[INFO] Reactor Build Order:
[INFO] 
[INFO] streams-examples
[INFO] streams-examples-flink
[INFO] flink-twitter-collection
[INFO] streams-examples-local
[INFO] elasticsearch-hdfs
[INFO] elasticsearch-reindex
[INFO] mongo-elasticsearch-sync
[INFO] twitter-follow-neo4j
[INFO] twitter-history-elasticsearch
[INFO] twitter-userstream-elasticsearch
[INFO] 
[INFO] 
[INFO] Building streams-examples 0.5-incubating-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.6:clean (default-clean) @ streams-examples ---
[INFO] Deleting 
[INFO] 
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @ 
streams-examples ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-java) @ 
streams-examples ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-banned-dependencies) @ 
streams-examples ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-no-snapshots) @ 
streams-examples ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.4:process (default) @ 
streams-examples ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.4:process (process-resource-bundles) 
@ streams-examples ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.19.1:test (test) @ streams-examples ---
[INFO] No tests to run.
[JENKINS] Recording test results[INFO] 
[INFO] --- 

Build failed in Jenkins: streams-project-site #97

2016-11-25 Thread Apache Jenkins Server
See 

--
Started by upstream project "streams-project" build number 320
originally caused by:
 Started by user sblackmon
[EnvInject] - Loading node environment variables.
Building remotely on H11 (ubuntu) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 025c201c564b550a0c03f1c17245ee516c79891a (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 025c201c564b550a0c03f1c17245ee516c79891a
 > git rev-list 025c201c564b550a0c03f1c17245ee516c79891a # timeout=10
Parsing POMs
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
sonatype (https://oss.sonatype.org/content/repositories/snapshots)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
typesafe (http://repo.typesafe.com/typesafe/repo)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
google-api-services (http://google-api-client-libraries.appspot.com/mavenrepo)
Downloaded artifact 
https://repository.apache.org/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Modules changed, recalculating dependency graph
Established TCP socket on 46889
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[streams-project-site] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g 
-Xms256m -XX:MaxPermSize=512m -Dfile.encoding=UTF-8 -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.3.9 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 46889
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -s 
/tmp/settings5961478595869487313.xml -q -U generate-sources site:site site:stage
Saving to 
outputFile=
Processed 0 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 126 ms
[JENKINS] Archiving site from 
 to 
/x1/jenkins/jenkins-home/jobs/streams-project-site/site
file:// 
- Session: Opened  
file:// 
- Session: Disconnecting  
file:// 
- Session: Disconnected
Saving to 
outputFile=

[jira] [Created] (STREAMS-462) Migrate website graphviz diagrams from git to confluence

2016-11-25 Thread Steve Blackmon (JIRA)
Steve Blackmon created STREAMS-462:
--

 Summary: Migrate website graphviz diagrams from git to confluence
 Key: STREAMS-462
 URL: https://issues.apache.org/jira/browse/STREAMS-462
 Project: Streams
  Issue Type: Task
Reporter: Steve Blackmon
Assignee: Steve Blackmon


a) migrate dot files out of our source control repos and into confluence
b) place them in a page hierarchy aligned with our source hierarchy
c) we'll manage their content from here on out in confluence
d) we embed them in the web page as we currently do, using links such as 
https://cwiki.apache.org/confluence/download/attachments/66854246/integration.svg.svg?api=v2
e) the SVG representation of each diagram gets created by the confluence plugin 
and exposed to the web by confluence CMS.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (STREAMS-440) Bring codebase into compliance with requirement for sensible javadoc headers

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon resolved STREAMS-440.

Resolution: Fixed
  Assignee: Steve Blackmon  (was: Suneel Marthi)

> Bring codebase into compliance with requirement for sensible javadoc headers
> 
>
> Key: STREAMS-440
> URL: https://issues.apache.org/jira/browse/STREAMS-440
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
> Attachments: checkstyle.txt, checkstyle.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-440) Bring codebase into compliance with requirement for sensible javadoc headers

2016-11-25 Thread Steve Blackmon (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696809#comment-15696809
 ] 

Steve Blackmon commented on STREAMS-440:


This merged in 5dffd5c32d0d150727a39104d428b21b52c911d4

> Bring codebase into compliance with requirement for sensible javadoc headers
> 
>
> Key: STREAMS-440
> URL: https://issues.apache.org/jira/browse/STREAMS-440
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
> Attachments: checkstyle.txt, checkstyle.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-440) Bring codebase into compliance with requirement for sensible javadoc headers

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-440:
---
Fix Version/s: (was: 0.5)
   0.4.1

> Bring codebase into compliance with requirement for sensible javadoc headers
> 
>
> Key: STREAMS-440
> URL: https://issues.apache.org/jira/browse/STREAMS-440
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Suneel Marthi
> Fix For: 0.4.1
>
> Attachments: checkstyle.txt, checkstyle.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-440) Bring codebase into compliance with requirement for sensible javadoc headers

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696909#comment-15696909
 ] 

ASF GitHub Bot commented on STREAMS-440:


Github user steveblackmon closed the pull request at:

https://github.com/apache/incubator-streams/pull/328


> Bring codebase into compliance with requirement for sensible javadoc headers
> 
>
> Key: STREAMS-440
> URL: https://issues.apache.org/jira/browse/STREAMS-440
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
> Attachments: checkstyle.txt, checkstyle.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (STREAMS-463) Move every class in all repos underneath org.apache.streams

2016-11-25 Thread Steve Blackmon (JIRA)
Steve Blackmon created STREAMS-463:
--

 Summary: Move every class in all repos underneath 
org.apache.streams
 Key: STREAMS-463
 URL: https://issues.apache.org/jira/browse/STREAMS-463
 Project: Streams
  Issue Type: Task
Reporter: Steve Blackmon
Assignee: Steve Blackmon


There are several modules with classes and testClasses that aren't under the 
org.apache.streams namespace.

This results in check style failures and potential confusion for developers.  
There's no reason to preserve this practice.

Move every class in all repos underneath org.apache.streams.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (STREAMS-423) reboot: cleanup source code using import .*;

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon resolved STREAMS-423.

Resolution: Fixed

> reboot: cleanup source code using import .*;
> 
>
> Key: STREAMS-423
> URL: https://issues.apache.org/jira/browse/STREAMS-423
> Project: Streams
>  Issue Type: Task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>
> as ~smarthi mentioned, using import .*; is bad practice
> correct this in the >100 files where it occurs 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-440) Bring codebase into compliance with requirement for sensible javadoc headers

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696908#comment-15696908
 ] 

ASF GitHub Bot commented on STREAMS-440:


Github user steveblackmon commented on the issue:

https://github.com/apache/incubator-streams/pull/328
  
this merged w


> Bring codebase into compliance with requirement for sensible javadoc headers
> 
>
> Key: STREAMS-440
> URL: https://issues.apache.org/jira/browse/STREAMS-440
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
> Attachments: checkstyle.txt, checkstyle.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-streams issue #328: STREAMS-440: custom checkstyle.xml, address co...

2016-11-25 Thread steveblackmon
Github user steveblackmon commented on the issue:

https://github.com/apache/incubator-streams/pull/328
  
this merged w


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-streams issue #328: STREAMS-440: custom checkstyle.xml, address co...

2016-11-25 Thread steveblackmon
Github user steveblackmon commented on the issue:

https://github.com/apache/incubator-streams/pull/328
  
this merged with 5dffd5c32d0d150727a39104d428b21b52c911d4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-streams pull request #328: STREAMS-440: custom checkstyle.xml, add...

2016-11-25 Thread steveblackmon
Github user steveblackmon closed the pull request at:

https://github.com/apache/incubator-streams/pull/328


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STREAMS-440) Bring codebase into compliance with requirement for sensible javadoc headers

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696907#comment-15696907
 ] 

ASF GitHub Bot commented on STREAMS-440:


Github user steveblackmon commented on the issue:

https://github.com/apache/incubator-streams/pull/328
  
this merged with 5dffd5c32d0d150727a39104d428b21b52c911d4


> Bring codebase into compliance with requirement for sensible javadoc headers
> 
>
> Key: STREAMS-440
> URL: https://issues.apache.org/jira/browse/STREAMS-440
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
> Attachments: checkstyle.txt, checkstyle.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-452) Proof-of-concept JSON Schema validation during test phases

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-452:
---
Fix Version/s: (was: 0.4)
   0.4.1

> Proof-of-concept JSON Schema validation during test phases
> --
>
> Key: STREAMS-452
> URL: https://issues.apache.org/jira/browse/STREAMS-452
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>
> Perform JSON Schema validation on test documents using project json schemas 
> during test phases for streams-schema-activitystreams.
> Same pattern to be applied throughout providers later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-423) reboot: cleanup source code using import .*;

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-423:
---
Fix Version/s: (was: 0.5)
   0.4.1

> reboot: cleanup source code using import .*;
> 
>
> Key: STREAMS-423
> URL: https://issues.apache.org/jira/browse/STREAMS-423
> Project: Streams
>  Issue Type: Task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>
> as ~smarthi mentioned, using import .*; is bad practice
> correct this in the >100 files where it occurs 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-423) reboot: cleanup source code using import .*;

2016-11-25 Thread Steve Blackmon (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696814#comment-15696814
 ] 

Steve Blackmon commented on STREAMS-423:


yes this can be closed after merge of STREAMS-440.

> reboot: cleanup source code using import .*;
> 
>
> Key: STREAMS-423
> URL: https://issues.apache.org/jira/browse/STREAMS-423
> Project: Streams
>  Issue Type: Task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4.1
>
>
> as ~smarthi mentioned, using import .*; is bad practice
> correct this in the >100 files where it occurs 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-452) Proof-of-concept JSON Schema validation during test phases

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-452:
---
Fix Version/s: (was: 0.4.1)
   0.4

> Proof-of-concept JSON Schema validation during test phases
> --
>
> Key: STREAMS-452
> URL: https://issues.apache.org/jira/browse/STREAMS-452
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4
>
>
> Perform JSON Schema validation on test documents using project json schemas 
> during test phases for streams-schema-activitystreams.
> Same pattern to be applied throughout providers later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-452) Proof-of-concept JSON Schema validation during test phases

2016-11-25 Thread Steve Blackmon (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696813#comment-15696813
 ] 

Steve Blackmon commented on STREAMS-452:


This merged with 4f100f3a2e97ddc512a9d745b999625602ad274e

> Proof-of-concept JSON Schema validation during test phases
> --
>
> Key: STREAMS-452
> URL: https://issues.apache.org/jira/browse/STREAMS-452
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.4
>
>
> Perform JSON Schema validation on test documents using project json schemas 
> during test phases for streams-schema-activitystreams.
> Same pattern to be applied throughout providers later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

2016-11-25 Thread steveblackmon
GitHub user steveblackmon opened a pull request:

https://github.com/apache/incubator-streams/pull/331

STREAMS-458: GPlusTypeConverter fix + gplus converter integration testing

GPlusTypeConverter fails processing recent plus#person w…ithout a gender

Run type converter on live-collected documents during integration test 
cycle.
Collect both a person and an organization.
Check that nodes are present before accessing them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-458

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-streams/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit f15ca8897806281c7e60f97142e7f151bb0291e4
Author: Steve Blackmon @steveblackmon 
Date:   2016-11-26T02:18:42Z

STREAMS-458: GPlusTypeConverter fails processing recent plus#person without 
a gender

Run type converter on live-collected documents during integration test 
cycle.
Collect both a person and an organization.
Check that nodes are present before accessing them.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-streams issue #330: Adding KEYS file

2016-11-25 Thread steveblackmon
Github user steveblackmon commented on the issue:

https://github.com/apache/incubator-streams/pull/330
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


incubator-streams git commit: Adding KEYS file

2016-11-25 Thread smarthi
Repository: incubator-streams
Updated Branches:
  refs/heads/master 025c201c5 -> 85e360a02


Adding KEYS file


Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/85e360a0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/85e360a0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/85e360a0

Branch: refs/heads/master
Commit: 85e360a028f330f5e6c48b050aa29d08c71bf41a
Parents: 025c201
Author: smarthi 
Authored: Fri Nov 25 13:52:04 2016 -0500
Committer: smarthi 
Committed: Sat Nov 26 01:35:23 2016 -0500

--
 KEYS | 167 ++
 1 file changed, 167 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/85e360a0/KEYS
--
diff --git a/KEYS b/KEYS
new file mode 100644
index 000..2620dc5
--- /dev/null
+++ b/KEYS
@@ -0,0 +1,167 @@
+This file contains the PGP keys of various developers.
+
+Users: pgp < KEYS
+   gpg --import KEYS
+Developers:
+pgp -kxa  and append it to this file.
+(pgpk -ll  && pgpk -xa ) >> this file.
+(gpg --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+pub   2048R/3F94A968 2013-01-07
+uid  Jason Letourneau 
+sig 33F94A968 2013-01-07  Jason Letourneau 
+sub   2048R/020FBED0 2013-01-07
+sig  3F94A968 2013-01-07  Jason Letourneau 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: GnuPG v1.4.12 (Darwin)
+
+mQENBFDrCSQBCADrCEd8fjnwpYn6aW7caXtwcrduZKbRPVisa+K+V9K1cm2zNg7Z
+unOk5cvlyLE3l8m2324I2cFml/ing/NaK6PY2+xJg+c9EXQ73/u5ccMU7NYuMYEG
+bPK5FMmr6B8q0UhpNIVZ0S2ZV1mfROGaLGPkQPuP36sU+u6Z6R/CruT7f6V/GVJ8
+66HQ087Lb24JTi1j5boLQlAIEFtF15eGxB45LT6IklEKAVf/B2TJK2TWDkcB6p0/
+j1EglDcOIPXcGBHTco4xC/qIDjpqAWd2N6KTcHB8ZHgpAQrq0PIC0iOqxWMfzdvA
+CFEhCKdH99Kqut9HGIl5++jwDlo2ntZh/52XABEBAAG0KEphc29uIExldG91cm5l
+YXUgPGxldG91cm5lYXVAYXBhY2hlLm9yZz6JATgEEwECACIFAlDrCSQCGwMGCwkI
+BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEN+dqCk/lKlo50gIAN4MyxP4RAbgirEK
+j3wN0LnC7yzofi6+PMT03E4XKV9tTDB4xNROjxDAly5N6KuKk7F/QleQKVdQEQL1
+7YKnYV45QK1oYn2x06IkNwCFw4dNDqn41Gd2QpJY5twKTVFf0o3Fd7QBDCfoiW01
+Ke8ymubN9bdKN/LjjmkiCslhrweLScySDxv5upaPZvNP8cHrk8MsoDJRtsuxUQ7e
+/kQaNLLTNSW8bXevft5IEKUVky5YbPnPSea0iOjMR9gYaOE3N+Vik1NjixjKe3NF
+TnbJNSobHUkmVcD6xaNcAlX+0J9kaNH6+abp119a18Bg47rtN1EVLJYNKk5u8MJz
+EHNqTk25AQ0EUOsJJAEIAKWqm/hH97xE/re7HBz4PcSeXaYbaV4gYR6crfQNEUUF
+4xguHLVK/cpQBfB1aZJp/oJdB1v3ervYiN+PCSYOriTAK1SOj0zbOqEsmLmIOy/w
+FKGEJocVbNfpMlFcLKSL+Eq4Zz7FTUNvLksF5nI9llA/2spGncHj7DU1w0tvExjI
+EIaglfEpVsFlmehC1BMdoIeTDYnarY78A5hZ5ydDxbVk78qYpRJMC9N5Ez4IAY8N
+QGXNgA8wTpb2y86oCkEgNRl2RuEhRce0SjEZ+euttVvxRpzqEusdsQJbs8Eg5wpF
+h8+ZF63fUPTyqscZtkCeHbcskjMykow0pfB90xNtROkAEQEAAYkBHwQYAQIACQUC
+UOsJJAIbDAAKCRDfnagpP5SpaFbgCADNR6m7BdNs9lnpfVTjmgA5Bxg3ZoCJilbk
+7OM3QxvdcoDnb0iXJEgoAIO1QaiK395eQmam/dHupzVcwI/86Q2eDWUTx4zcUYRv
+m2C6P5yiEuH2792rLJ1SJbMy7AA3ZzBPwobjLmujHu9nO6SdX4hbpH3/LW+Xe3zV
+k+sS4gxii4SYQWqQyBf27nZIVVxcBVVdB0KmFcw6IEV7/LVho/tBpKV1BUoDeZj1
+BrhHUb9vCD16k6NX+gjQhKgRmZuljnC87ruUxLDEqhmiViVEjzrusx5uLVK7FmzF
+fLsE3mi3F0I3eJVwUFXji+nIeZXszGWvstmz8ADWWyvkEblYBv7H
+=iVYc
+-END PGP PUBLIC KEY BLOCK-
+
+pub  4096R/68D51867 2014-12-11 Steve Blackmon 
+  Key fingerprint = F869 F111 9FCD 1952 E379  71CD F824 5949 68D5 1867
+sub  4096R/4EB79D36 2014-12-11
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: SKS 1.1.6
+Comment: Hostname: keys2.kfwebs.net
+
+mQINBFSKDjYBEADGXFvQYlRV/8cigZ9eAis1B8kyERiRtyjYfB7BWb7sfwao4cs2eoPLzQHz
+zz5AW61EabQHrcqKWPVIdQe2ag3MeOp/cpuuiAnc4x5ioJjTYwrTImu9uadfGw63gUe4ynVk
+Oer6XeI0YO8H7rsWw40PQle7XEN1i/+kiZyk/cmHXJdQG5GUsnXc+3gSVMbUmBlo6huNbHEG
+jWyQEa152HOZX4eS1W0YThJvVLPwrduDHx7G/Lma9cMxCH2Dz37/BaG7nji8kqS6jNomzYT3
+GDRWu9DtQ8n/uZ4WJo2HG8dqSiTpC261i8JYjgm+4Ic6cRK64jI7gdNehfaN6KIbj0T8ttZz
+HVGex2e7wYE2kDZ1LGiA4dOYWCgnRwpKBrE4sh7/HCUURkJouQVGsbejsJPpSC2isrU/t447
+fieIM+8e3F9S932XCabTTHqhY5qXAPV/5csb0PjHo3DmoDMhwaoC+VhyxeNctymsQKvKYdZl
+ugRRxmYYa2JF11GwMd+QM0YgwpOqIKna8OshXHAGisDEaS+HSr3wJ5VoKRV1KnysGSXSnrsM
+jV6pb9ZmSdbaJnnAa3FZWLuguco97R8tnFfeZIXsc4AkywPPG75i9gyUsaUWm+ACsSxefhoY
+u1FFTSPOVGWAH3MAL0Noxk7PF6CfAJvH63fH3eNOKUYT8M8WFQARAQABtCVTdGV2ZSBCbGFj
+a21vbiA8c2JsYWNrbW9uQGFwYWNoZS5vcmc+iQIcBBABAgAGBQJUkj+1AAoJEBxXIVvuqkLA
+ixYP/26Bfm8v7eWhCoSoqMUcknIyZCvTYtqNedIhZX/6W3gX9kEVKSrsHdOxgKfrpk5KHb2P
+yuQ/INskrzSUvsokNbzgbHIy0qCT3/v3aFBVadhMpo2BCnn5ds3D4Qy4GF7wKarBsPGjjgqz
+/GgIT8Q8MhwOzCgo3jyUkmB7R69KwevEBNdtHXxqzMf7asEzv218pxOYDWkYO446dTckvzGN
+m2GVUlyjyLqLOb/zm8RcIH3tDTmNy3C4nOx76muX6WtV0io7nZukj+5LXZU6jjEHEYnKjxTX
+FQRXFkReAM7Tfk6NBCEVaHmGNrume9w6YQbLVsy3VKjgYDA7L2dlfOcrLZiNCp7nUdQ/CMx4

[jira] [Closed] (STREAMS-196) Implement Datum Monitoring through JMX

2016-11-25 Thread Suneel Marthi (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suneel Marthi closed STREAMS-196.
-

> Implement Datum Monitoring through JMX
> --
>
> Key: STREAMS-196
> URL: https://issues.apache.org/jira/browse/STREAMS-196
> Project: Streams
>  Issue Type: Improvement
>Reporter: Ryan Ebanks
> Fix For: 0.2
>
>
> Allow datum monitoring through JMX
> * Implement class that will replace Datum Countable
> * Depricate DatumCountable
> * Change StreamsTasks to use new classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (STREAMS-196) Implement Datum Monitoring through JMX

2016-11-25 Thread Suneel Marthi (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suneel Marthi resolved STREAMS-196.
---
   Resolution: Fixed
Fix Version/s: 0.2

> Implement Datum Monitoring through JMX
> --
>
> Key: STREAMS-196
> URL: https://issues.apache.org/jira/browse/STREAMS-196
> Project: Streams
>  Issue Type: Improvement
>Reporter: Ryan Ebanks
> Fix For: 0.2
>
>
> Allow datum monitoring through JMX
> * Implement class that will replace Datum Countable
> * Depricate DatumCountable
> * Change StreamsTasks to use new classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Work started] (STREAMS-441) Remove compile dependency on guava for core packages

2016-11-25 Thread Suneel Marthi (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on STREAMS-441 started by Suneel Marthi.
-
> Remove compile dependency on guava for core packages
> 
>
> Key: STREAMS-441
> URL: https://issues.apache.org/jira/browse/STREAMS-441
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Suneel Marthi
> Fix For: 0.4.1
>
>
> To simplify the transitive dependency tree and reduce odds of users hitting 
> shading issues.
> streams-util
> streams-config
> streams-core
> streams-pojo
> streams-pojo-extensions
> streams-schemas/*
> streams-verbs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-458) GPlusTypeConverter fails processing recent plus#person without a gender

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697298#comment-15697298
 ] 

ASF GitHub Bot commented on STREAMS-458:


GitHub user steveblackmon opened a pull request:

https://github.com/apache/incubator-streams/pull/331

STREAMS-458: GPlusTypeConverter fix + gplus converter integration testing

GPlusTypeConverter fails processing recent plus#person w…ithout a gender

Run type converter on live-collected documents during integration test 
cycle.
Collect both a person and an organization.
Check that nodes are present before accessing them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-458

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-streams/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit f15ca8897806281c7e60f97142e7f151bb0291e4
Author: Steve Blackmon @steveblackmon 
Date:   2016-11-26T02:18:42Z

STREAMS-458: GPlusTypeConverter fails processing recent plus#person without 
a gender

Run type converter on live-collected documents during integration test 
cycle.
Collect both a person and an organization.
Check that nodes are present before accessing them.




> GPlusTypeConverter fails processing recent plus#person without a gender
> ---
>
> Key: STREAMS-458
> URL: https://issues.apache.org/jira/browse/STREAMS-458
> Project: Streams
>  Issue Type: Bug
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Running GPlusTypeConverterTest against the output of GPlusUserDataProviderIT:
> java.lang.NullPointerException: null
>   at 
> com.google.gplus.serializer.util.GPlusPersonDeserializer.deserialize(GPlusPersonDeserializer.java:65)
> Rework to ensure GPlusTypeConverter doesn't crash on valid input.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-streams issue #330: Adding KEYS file

2016-11-25 Thread smarthi
Github user smarthi commented on the issue:

https://github.com/apache/incubator-streams/pull/330
  
could u merge and commit this? @steveblackmon 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


incubator-streams git commit: closes apache/incubator-streams#330 *Fixed*

2016-11-25 Thread smarthi
Repository: incubator-streams
Updated Branches:
  refs/heads/master 85e360a02 -> 745451d8e


closes apache/incubator-streams#330 *Fixed*


Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/745451d8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/745451d8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/745451d8

Branch: refs/heads/master
Commit: 745451d8eb6dcdf297b79c7bf21e9d66efc04f1f
Parents: 85e360a
Author: smarthi 
Authored: Sat Nov 26 01:42:30 2016 -0500
Committer: smarthi 
Committed: Sat Nov 26 01:42:30 2016 -0500

--

--




[GitHub] incubator-streams pull request #330: Adding KEYS file

2016-11-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-streams/pull/330


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: streams-project-site #98

2016-11-25 Thread Apache Jenkins Server
See 

Changes:

[smarthi] Adding KEYS file

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H11 (ubuntu) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-streams.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-streams.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 745451d8eb6dcdf297b79c7bf21e9d66efc04f1f (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 745451d8eb6dcdf297b79c7bf21e9d66efc04f1f
 > git rev-list 025c201c564b550a0c03f1c17245ee516c79891a # timeout=10
Parsing POMs
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Downloaded artifact 
https://repository.apache.org/content/repositories/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/streams-master-0.5-incubating-20161125.202926-34.pom
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
sonatype (https://oss.sonatype.org/content/repositories/snapshots)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
typesafe (http://repo.typesafe.com/typesafe/repo)
Failed to transfer Could not find metadata 
org.apache.streams:streams-master:0.5-incubating-SNAPSHOT/maven-metadata.xml in 
google-api-services (http://google-api-client-libraries.appspot.com/mavenrepo)
Downloaded artifact 
https://repository.apache.org/snapshots/org/apache/streams/streams-master/0.5-incubating-SNAPSHOT/maven-metadata.xml
Modules changed, recalculating dependency graph
Established TCP socket on 37171
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[streams-project-site] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g 
-Xms256m -XX:MaxPermSize=512m -Dfile.encoding=UTF-8 -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.3.9/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.3.9 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 37171
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
using settings config with name simple-deploy-settings-no-mirror
Replacing all maven server entries not found in credentials list is true
Executing Maven:  -B -f 
 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/1 -s 
/tmp/settings404569669124596319.xml -q -U generate-sources site:site site:stage
Saving to 
outputFile=
Processed 0 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
Finished in 649 ms
[JENKINS] Archiving site from 
 to 
/x1/jenkins/jenkins-home/jobs/streams-project-site/site
file:// 
- Session: Opened  
file:// 
- Session: Disconnecting  

[GitHub] incubator-streams issue #320: STREAMS-441: Remove compile dependency on guav...

2016-11-25 Thread smarthi
Github user smarthi commented on the issue:

https://github.com/apache/incubator-streams/pull/320
  
I addressed the modules listed in the jira and a few more as best as I 
could. @steveblackmon please review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STREAMS-441) Remove compile dependency on guava for core packages

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697474#comment-15697474
 ] 

ASF GitHub Bot commented on STREAMS-441:


Github user smarthi commented on the issue:

https://github.com/apache/incubator-streams/pull/320
  
I addressed the modules listed in the jira and a few more as best as I 
could. @steveblackmon please review this.


> Remove compile dependency on guava for core packages
> 
>
> Key: STREAMS-441
> URL: https://issues.apache.org/jira/browse/STREAMS-441
> Project: Streams
>  Issue Type: Improvement
>Reporter: Steve Blackmon
>Assignee: Suneel Marthi
> Fix For: 0.4.1
>
>
> To simplify the transitive dependency tree and reduce odds of users hitting 
> shading issues.
> streams-util
> streams-config
> streams-core
> streams-pojo
> streams-pojo-extensions
> streams-schemas/*
> streams-verbs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-458) GPlusTypeConverter fails processing recent plus#person without a gender

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697403#comment-15697403
 ] 

ASF GitHub Bot commented on STREAMS-458:


Github user smarthi commented on a diff in the pull request:

https://github.com/apache/incubator-streams/pull/331#discussion_r89666757
  
--- Diff: 
streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
 ---
@@ -93,15 +93,17 @@ public void testProcessPerson() throws IOException, 
ActivitySerializerException
 GooglePlusActivityUtil.updateActivity(person, activity);
 
 assertEquals(retList.size(), 1);
-assert (retList.get(0).getDocument() instanceof Activity);
+assert(retList.get(0).getDocument() instanceof Activity);
--- End diff --

change all 'assert' to 'Assert.assertXXX()'. this needs to be done here and 
many other places in the project.


> GPlusTypeConverter fails processing recent plus#person without a gender
> ---
>
> Key: STREAMS-458
> URL: https://issues.apache.org/jira/browse/STREAMS-458
> Project: Streams
>  Issue Type: Bug
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Running GPlusTypeConverterTest against the output of GPlusUserDataProviderIT:
> java.lang.NullPointerException: null
>   at 
> com.google.gplus.serializer.util.GPlusPersonDeserializer.deserialize(GPlusPersonDeserializer.java:65)
> Rework to ensure GPlusTypeConverter doesn't crash on valid input.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-458) GPlusTypeConverter fails processing recent plus#person without a gender

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697401#comment-15697401
 ] 

ASF GitHub Bot commented on STREAMS-458:


Github user smarthi commented on a diff in the pull request:

https://github.com/apache/incubator-streams/pull/331#discussion_r89666745
  
--- Diff: 
streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
 ---
@@ -27,18 +27,19 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.module.SimpleModule;
 import com.google.api.services.plus.model.Person;
+import com.google.gplus.processor.GooglePlusTypeConverter;
 import com.google.gplus.serializer.util.GPlusActivityDeserializer;
 import com.google.gplus.serializer.util.GPlusPersonDeserializer;
 import com.google.gplus.serializer.util.GooglePlusActivityUtil;
-
 import org.apache.commons.lang.StringUtils;
--- End diff --

use lang3


> GPlusTypeConverter fails processing recent plus#person without a gender
> ---
>
> Key: STREAMS-458
> URL: https://issues.apache.org/jira/browse/STREAMS-458
> Project: Streams
>  Issue Type: Bug
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Running GPlusTypeConverterTest against the output of GPlusUserDataProviderIT:
> java.lang.NullPointerException: null
>   at 
> com.google.gplus.serializer.util.GPlusPersonDeserializer.deserialize(GPlusPersonDeserializer.java:65)
> Rework to ensure GPlusTypeConverter doesn't crash on valid input.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

2016-11-25 Thread smarthi
Github user smarthi commented on a diff in the pull request:

https://github.com/apache/incubator-streams/pull/331#discussion_r89666757
  
--- Diff: 
streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
 ---
@@ -93,15 +93,17 @@ public void testProcessPerson() throws IOException, 
ActivitySerializerException
 GooglePlusActivityUtil.updateActivity(person, activity);
 
 assertEquals(retList.size(), 1);
-assert (retList.get(0).getDocument() instanceof Activity);
+assert(retList.get(0).getDocument() instanceof Activity);
--- End diff --

change all 'assert' to 'Assert.assertXXX()'. this needs to be done here and 
many other places in the project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

2016-11-25 Thread smarthi
Github user smarthi commented on a diff in the pull request:

https://github.com/apache/incubator-streams/pull/331#discussion_r89666745
  
--- Diff: 
streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
 ---
@@ -27,18 +27,19 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.module.SimpleModule;
 import com.google.api.services.plus.model.Person;
+import com.google.gplus.processor.GooglePlusTypeConverter;
 import com.google.gplus.serializer.util.GPlusActivityDeserializer;
 import com.google.gplus.serializer.util.GPlusPersonDeserializer;
 import com.google.gplus.serializer.util.GooglePlusActivityUtil;
-
 import org.apache.commons.lang.StringUtils;
--- End diff --

use lang3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

2016-11-25 Thread smarthi
Github user smarthi commented on a diff in the pull request:

https://github.com/apache/incubator-streams/pull/331#discussion_r89666770
  
--- Diff: 
streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
 ---
@@ -121,16 +122,10 @@ public void testProcessActivity() throws IOException, 
ActivitySerializerExceptio
 GooglePlusActivityUtil.updateActivity(gPlusActivity, activity);
 
 assertEquals(retList.size(), 1);
-assert (retList.get(0).getDocument() instanceof Activity);
+assert(retList.get(0).getDocument() instanceof Activity);
--- End diff --

change to Assert.assertTrue(retList.get(0) instanceOf Activity);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STREAMS-458) GPlusTypeConverter fails processing recent plus#person without a gender

2016-11-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697405#comment-15697405
 ] 

ASF GitHub Bot commented on STREAMS-458:


Github user smarthi commented on a diff in the pull request:

https://github.com/apache/incubator-streams/pull/331#discussion_r89666770
  
--- Diff: 
streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
 ---
@@ -121,16 +122,10 @@ public void testProcessActivity() throws IOException, 
ActivitySerializerExceptio
 GooglePlusActivityUtil.updateActivity(gPlusActivity, activity);
 
 assertEquals(retList.size(), 1);
-assert (retList.get(0).getDocument() instanceof Activity);
+assert(retList.get(0).getDocument() instanceof Activity);
--- End diff --

change to Assert.assertTrue(retList.get(0) instanceOf Activity);


> GPlusTypeConverter fails processing recent plus#person without a gender
> ---
>
> Key: STREAMS-458
> URL: https://issues.apache.org/jira/browse/STREAMS-458
> Project: Streams
>  Issue Type: Bug
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Running GPlusTypeConverterTest against the output of GPlusUserDataProviderIT:
> java.lang.NullPointerException: null
>   at 
> com.google.gplus.serializer.util.GPlusPersonDeserializer.deserialize(GPlusPersonDeserializer.java:65)
> Rework to ensure GPlusTypeConverter doesn't crash on valid input.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STREAMS-255) Merge streams-master into streams-project

2016-11-25 Thread Steve Blackmon (JIRA)

[ 
https://issues.apache.org/jira/browse/STREAMS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15697172#comment-15697172
 ] 

Steve Blackmon commented on STREAMS-255:


Per discussion on mailing list - Why separate Streams-Master and 
Streams-Project ? - we decided to merge streams-master and streams-project 
permanently, presuming there are no unwelcome surprises doing so.

> Merge streams-master into streams-project
> -
>
> Key: STREAMS-255
> URL: https://issues.apache.org/jira/browse/STREAMS-255
> Project: Streams
>  Issue Type: Sub-task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.1
>
>
> Merge important parts of streams-master into streams-project and remove 
> parent relationship.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STREAMS-255) Merge streams-master into streams-project

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon updated STREAMS-255:
---
Fix Version/s: (was: 0.1)
   0.5
   0.2

> Merge streams-master into streams-project
> -
>
> Key: STREAMS-255
> URL: https://issues.apache.org/jira/browse/STREAMS-255
> Project: Streams
>  Issue Type: Sub-task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.2, 0.5
>
>
> Merge important parts of streams-master into streams-project and remove 
> parent relationship.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (STREAMS-255) Merge streams-master into streams-project

2016-11-25 Thread Steve Blackmon (JIRA)

 [ 
https://issues.apache.org/jira/browse/STREAMS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Blackmon reopened STREAMS-255:


> Merge streams-master into streams-project
> -
>
> Key: STREAMS-255
> URL: https://issues.apache.org/jira/browse/STREAMS-255
> Project: Streams
>  Issue Type: Sub-task
>Reporter: Steve Blackmon
>Assignee: Steve Blackmon
> Fix For: 0.1
>
>
> Merge important parts of streams-master into streams-project and remove 
> parent relationship.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[17/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-youtube/src/main/java/com/youtube/serializer/YoutubeActivityUtil.java
--
diff --git 
a/streams-contrib/streams-provider-youtube/src/main/java/com/youtube/serializer/YoutubeActivityUtil.java
 
b/streams-contrib/streams-provider-youtube/src/main/java/com/youtube/serializer/YoutubeActivityUtil.java
index ab2f55c..4754353 100644
--- 
a/streams-contrib/streams-provider-youtube/src/main/java/com/youtube/serializer/YoutubeActivityUtil.java
+++ 
b/streams-contrib/streams-provider-youtube/src/main/java/com/youtube/serializer/YoutubeActivityUtil.java
@@ -19,6 +19,13 @@
 
 package com.youtube.serializer;
 
+import org.apache.streams.exceptions.ActivitySerializerException;
+import org.apache.streams.pojo.extensions.ExtensionUtil;
+import org.apache.streams.pojo.json.Activity;
+import org.apache.streams.pojo.json.ActivityObject;
+import org.apache.streams.pojo.json.Image;
+import org.apache.streams.pojo.json.Provider;
+
 import com.google.api.client.util.Maps;
 import com.google.api.services.youtube.model.Channel;
 import com.google.api.services.youtube.model.Thumbnail;
@@ -27,12 +34,6 @@ import com.google.api.services.youtube.model.Video;
 import com.google.common.base.Joiner;
 import com.google.common.base.Optional;
 import com.google.common.collect.Lists;
-import org.apache.streams.exceptions.ActivitySerializerException;
-import org.apache.streams.pojo.extensions.ExtensionUtil;
-import org.apache.streams.pojo.json.Activity;
-import org.apache.streams.pojo.json.ActivityObject;
-import org.apache.streams.pojo.json.Image;
-import org.apache.streams.pojo.json.Provider;
 import org.joda.time.DateTime;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -41,153 +42,160 @@ import java.util.HashMap;
 import java.util.Map;
 
 public class YoutubeActivityUtil {
-private static final Logger LOGGER = 
LoggerFactory.getLogger(YoutubeActivityUtil.class);
-
-/**
- * Given a {@link com.google.api.services.youtube.YouTube.Videos} object 
and an
- * {@link org.apache.streams.pojo.json.Activity} object, fill out the 
appropriate details
- *
- * @param video
- * @param activity
- * @throws org.apache.streams.exceptions.ActivitySerializerException
- */
-public static void updateActivity(Video video, Activity activity, String 
channelId) throws ActivitySerializerException {
-activity.setActor(buildActor(video, 
video.getSnippet().getChannelId()));
-activity.setVerb("post");
-
-activity.setId(formatId(activity.getVerb(),
-Optional.fromNullable(
-video.getId())
-.orNull()));
-
-activity.setPublished(new 
DateTime(video.getSnippet().getPublishedAt().getValue()));
-activity.setTitle(video.getSnippet().getTitle());
-activity.setContent(video.getSnippet().getDescription());
-activity.setUrl("https://www.youtube.com/watch?v=; + video.getId());
-
-activity.setProvider(getProvider());
-
-activity.setObject(buildActivityObject(video));
-
-addYoutubeExtensions(activity, video);
-}
-
 
-/**
- * Given a {@link com.google.api.services.youtube.model.Channel} object 
and an
- * {@link org.apache.streams.pojo.json.Activity} object, fill out the 
appropriate details
- *
- * @param channel
- * @param activity
- * @throws org.apache.streams.exceptions.ActivitySerializerException
- */
-public static void updateActivity(Channel channel, Activity activity, 
String channelId) throws ActivitySerializerException {
-try {
-activity.setProvider(getProvider());
-activity.setVerb("post");
-activity.setActor(createActorForChannel(channel));
-Map extensions = Maps.newHashMap();
-extensions.put("youtube", channel);
-activity.setAdditionalProperty("extensions", extensions);
-} catch (Throwable t) {
-throw new ActivitySerializerException(t);
-}
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(YoutubeActivityUtil.class);
+
+  /**
+   * Given a {@link com.google.api.services.youtube.YouTube.Videos} object and 
an
+   * {@link org.apache.streams.pojo.json.Activity} object, fill out the 
appropriate details
+   *
+   * @param video Video
+   * @param activity Activity
+   * @throws ActivitySerializerException ActivitySerializerException
+   */
+  public static void updateActivity(Video video, Activity activity, String 
channelId) throws ActivitySerializerException {
+activity.setActor(buildActor(video, video.getSnippet().getChannelId()));
+activity.setVerb("post");
+
+activity.setId(formatId(activity.getVerb(),
+Optional.fromNullable(
+video.getId())
+.orNull()));
+
+activity.setPublished(new 

[33/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-processor-jackson/src/main/java/org/apache/streams/jackson/CleanAdditionalPropertiesProcessor.java
--
diff --git 
a/streams-contrib/streams-processor-jackson/src/main/java/org/apache/streams/jackson/CleanAdditionalPropertiesProcessor.java
 
b/streams-contrib/streams-processor-jackson/src/main/java/org/apache/streams/jackson/CleanAdditionalPropertiesProcessor.java
index 6c08eb1..ae0709a 100644
--- 
a/streams-contrib/streams-processor-jackson/src/main/java/org/apache/streams/jackson/CleanAdditionalPropertiesProcessor.java
+++ 
b/streams-contrib/streams-processor-jackson/src/main/java/org/apache/streams/jackson/CleanAdditionalPropertiesProcessor.java
@@ -19,14 +19,15 @@ under the License.
 
 package org.apache.streams.jackson;
 
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsProcessor;
+
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.fasterxml.jackson.datatype.jsonorg.JsonOrgModule;
 import com.google.common.collect.Lists;
-import org.apache.streams.core.StreamsDatum;
-import org.apache.streams.core.StreamsProcessor;
-import org.apache.streams.jackson.StreamsJacksonMapper;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -36,53 +37,58 @@ import java.util.Map;
 
 /**
  * This processor walks an input objectnode and corrects any artifacts
- * that may have occured from improper serialization of jsonschema2pojo beans.
+ * that may have occured from improper serialization of jackson beans.
  *
+ * 
  * The logic is also available for inclusion in other module via static import.
  */
 public class CleanAdditionalPropertiesProcessor implements StreamsProcessor {
 
-public static final String STREAMS_ID = 
"CleanAdditionalPropertiesProcessor";
+  public static final String STREAMS_ID = "CleanAdditionalPropertiesProcessor";
 
-private static final Logger LOGGER = 
LoggerFactory.getLogger(CleanAdditionalPropertiesProcessor.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(CleanAdditionalPropertiesProcessor.class);
 
-private ObjectMapper mapper;
+  private ObjectMapper mapper;
 
-@Override
-public String getId() {
-return STREAMS_ID;
-}
+  @Override
+  public String getId() {
+return STREAMS_ID;
+  }
 
-@Override
-public List process(StreamsDatum datum) {
-List result = Lists.newLinkedList();
-ObjectNode activity = this.mapper.convertValue(datum.getDocument(), 
ObjectNode.class);
-cleanAdditionalProperties(activity);
-datum.setDocument(activity);
-result.add(datum);
-return result;
-}
+  @Override
+  public List process(StreamsDatum datum) {
+List result = Lists.newLinkedList();
+ObjectNode activity = this.mapper.convertValue(datum.getDocument(), 
ObjectNode.class);
+cleanAdditionalProperties(activity);
+datum.setDocument(activity);
+result.add(datum);
+return result;
+  }
 
-@Override
-public void prepare(Object o) {
-this.mapper = StreamsJacksonMapper.getInstance();
-this.mapper.registerModule(new JsonOrgModule());
-}
+  @Override
+  public void prepare(Object configurationObject) {
+this.mapper = StreamsJacksonMapper.getInstance();
+this.mapper.registerModule(new JsonOrgModule());
+  }
 
-@Override
-public void cleanUp() {
+  @Override
+  public void cleanUp() {
 
-}
+  }
 
-public static void cleanAdditionalProperties(ObjectNode node) {
-if( node.get("additionalProperties") != null ) {
-ObjectNode additionalProperties = (ObjectNode) 
node.get("additionalProperties");
-cleanAdditionalProperties(additionalProperties);
-Iterator> jsonNodeIterator = 
additionalProperties.fields();
-while( jsonNodeIterator.hasNext() ) {
-Map.Entry entry = jsonNodeIterator.next();
-node.put(entry.getKey(), entry.getValue());
-}
-}
+  /**
+   * Recursively removes all additionalProperties maps.
+   * @param node ObjectNode
+   */
+  public static void cleanAdditionalProperties(ObjectNode node) {
+if ( node.get("additionalProperties") != null ) {
+  ObjectNode additionalProperties = (ObjectNode) 
node.get("additionalProperties");
+  cleanAdditionalProperties(additionalProperties);
+  Iterator> jsonNodeIterator = 
additionalProperties.fields();
+  while ( jsonNodeIterator.hasNext() ) {
+Map.Entry entry = jsonNodeIterator.next();
+node.put(entry.getKey(), entry.getValue());
+  }
 }
+  }
 }


[05/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/queues/ThroughputQueueMultiThreadTest.java
--
diff --git 
a/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/queues/ThroughputQueueMultiThreadTest.java
 
b/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/queues/ThroughputQueueMultiThreadTest.java
index 60df89c..ad4aa28 100644
--- 
a/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/queues/ThroughputQueueMultiThreadTest.java
+++ 
b/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/queues/ThroughputQueueMultiThreadTest.java
@@ -17,299 +17,304 @@
  */
 package org.apache.streams.local.queues;
 
+import org.apache.streams.util.ComponentUtils;
+
 import com.carrotsearch.randomizedtesting.RandomizedTest;
 import com.carrotsearch.randomizedtesting.annotations.Repeat;
-import org.apache.streams.util.ComponentUtils;
 import org.joda.time.DateTime;
 import org.junit.After;
 import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.lang.management.ManagementFactory;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
 import javax.management.InstanceNotFoundException;
 import javax.management.ObjectName;
-import java.lang.management.ManagementFactory;
-import java.util.concurrent.*;
 
 /**
  * MultiThread unit tests for {@link 
org.apache.streams.local.queues.ThroughputQueue}
  */
 public class ThroughputQueueMultiThreadTest extends RandomizedTest {
 
-private static final Logger LOGGER = 
LoggerFactory.getLogger(ThroughputQueueMultiThreadTest.class);
-private static final String MBEAN_ID = "testQueue";
-private static final String STREAM_ID = "test_stream";
-private static long STREAM_START_TIME = (new DateTime()).getMillis();
-
-/**
- * Remove registered mbeans from previous tests
- * @throws Exception
- */
-@After
-public void unregisterMXBean() throws Exception {
-try {
-ManagementFactory.getPlatformMBeanServer().unregisterMBean(new 
ObjectName(String.format(ThroughputQueue.NAME_TEMPLATE, MBEAN_ID, STREAM_ID, 
STREAM_START_TIME)));
-} catch (InstanceNotFoundException ife) {
-//No-op
-}
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ThroughputQueueMultiThreadTest.class);
+  private static final String MBEAN_ID = "testQueue";
+  private static final String STREAM_ID = "test_stream";
+  private static long STREAM_START_TIME = (new DateTime()).getMillis();
+
+  /**
+   * Remove registered mbeans from previous tests
+   * @throws Exception
+   */
+  @After
+  public void unregisterMXBean() throws Exception {
+try {
+  ManagementFactory.getPlatformMBeanServer().unregisterMBean(new 
ObjectName(String.format(ThroughputQueue.NAME_TEMPLATE, MBEAN_ID, STREAM_ID, 
STREAM_START_TIME)));
+} catch (InstanceNotFoundException ife) {
+  //No-op
 }
-
-@After
-public void removeLocalMBeans() {
-try {
-ComponentUtils.removeAllMBeansOfDomain("org.apache.streams.local");
-} catch (Exception e) {
-//No op.  proceed to next test
-}
+  }
+
+  @After
+  public void removeLocalMBeans() {
+try {
+  ComponentUtils.removeAllMBeansOfDomain("org.apache.streams.local");
+} catch (Exception e) {
+  //No op.  proceed to next test
 }
-
-
-/**
- * Test that queue will block on puts when the queue is full
- * @throws InterruptedException
- */
-@Test
-public void testBlockOnFullQueue() throws InterruptedException {
-int queueSize = randomIntBetween(1, 3000);
-ExecutorService executor = Executors.newSingleThreadExecutor();
-CountDownLatch full = new CountDownLatch(1);
-CountDownLatch finished = new CountDownLatch(1);
-ThroughputQueue queue = new ThroughputQueue(queueSize);
-BlocksOnFullQueue testThread = new BlocksOnFullQueue(full, finished, 
queue, queueSize);
-executor.submit(testThread);
-full.await();
-assertEquals(queueSize, queue.size());
-assertEquals(queueSize, queue.getCurrentSize());
-assertFalse(testThread.isComplete()); //test that it is blocked
-safeSleep(1000);
-assertFalse(testThread.isComplete()); //still blocked
-queue.take();
-finished.await();
-assertEquals(queueSize, queue.size());
-assertEquals(queueSize, queue.getCurrentSize());
-assertTrue(testThread.isComplete());
-executor.shutdownNow();
-executor.awaitTermination(500, TimeUnit.MILLISECONDS);
+  }
+
+
+  /**
+   * Test that 

[23/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-rss/src/test/java/org/apache/streams/rss/provider/RssStreamProviderTaskIT.java
--
diff --git 
a/streams-contrib/streams-provider-rss/src/test/java/org/apache/streams/rss/provider/RssStreamProviderTaskIT.java
 
b/streams-contrib/streams-provider-rss/src/test/java/org/apache/streams/rss/provider/RssStreamProviderTaskIT.java
index cb71c90..6722f3c 100644
--- 
a/streams-contrib/streams-provider-rss/src/test/java/org/apache/streams/rss/provider/RssStreamProviderTaskIT.java
+++ 
b/streams-contrib/streams-provider-rss/src/test/java/org/apache/streams/rss/provider/RssStreamProviderTaskIT.java
@@ -15,13 +15,14 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.rss.provider;
 
 import org.apache.streams.core.StreamsDatum;
+
 import org.joda.time.DateTime;
 import org.joda.time.DateTimeZone;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 import java.net.URL;
@@ -37,111 +38,113 @@ import static org.junit.Assert.assertTrue;
  */
 public class RssStreamProviderTaskIT {
 
-
-@Before
-public void clearPreviouslySeen() {
-//some test runners run in parallel so needs to be synchronized
-//if tests are run in parallel test will have undetermined results.
-synchronized (RssStreamProviderTask.PREVIOUSLY_SEEN) {
-RssStreamProviderTask.PREVIOUSLY_SEEN.clear();
-}
+  /**
+   * clearPreviouslySeen.
+   */
+  @Before
+  public void clearPreviouslySeen() {
+//some test runners run in parallel so needs to be synchronized
+//if tests are run in parallel test will have undetermined results.
+synchronized (RssStreamProviderTask.PREVIOUSLY_SEEN) {
+  RssStreamProviderTask.PREVIOUSLY_SEEN.clear();
 }
+  }
 
-/**
- * Test that a task can read a valid rss from a url and queue the data
- * @throws Exception
- */
-@Test
-public void testNonPerpetualNoTimeFramePull() throws Exception {
-com.healthmarketscience.common.util.resource.Handler.init();
-BlockingQueue queue = new LinkedBlockingQueue<>();
-RssStreamProviderTask task = new RssStreamProviderTask(queue, "fake 
url");
-Set batch = task.queueFeedEntries(new 
URL("resource:///test_rss_xml/economist1.xml"));
-assertEquals("Expected batch size to be the same as amount of queued 
datums", batch.size(), queue.size());
-RssStreamProviderTask.PREVIOUSLY_SEEN.put("fake url", batch);
-//Test that  it will out previously seen articles
-queue.clear();
-batch = task.queueFeedEntries(new 
URL("resource:///test_rss_xml/economist1.xml"));
-assertEquals("Expected batch size to be the same as amount of queued 
datums", batch.size(), queue.size());
-}
+  /**
+   * Test that a task can read a valid rss from a url and queue the data.
+   * @throws Exception Exception
+   */
+  @Test
+  public void testNonPerpetualNoTimeFramePull() throws Exception {
+com.healthmarketscience.common.util.resource.Handler.init();
+BlockingQueue queue = new LinkedBlockingQueue<>();
+RssStreamProviderTask task = new RssStreamProviderTask(queue, "fake url");
+Set batch = task.queueFeedEntries(new 
URL("resource:///test_rss_xml/economist1.xml"));
+assertEquals("Expected batch size to be the same as amount of queued 
datums", batch.size(), queue.size());
+RssStreamProviderTask.PREVIOUSLY_SEEN.put("fake url", batch);
+//Test that  it will out previously seen articles
+queue.clear();
+batch = task.queueFeedEntries(new 
URL("resource:///test_rss_xml/economist1.xml"));
+assertEquals("Expected batch size to be the same as amount of queued 
datums", batch.size(), queue.size());
+  }
 
-/**
- * Test that perpetual streams will not output previously seen articles
- * @throws Exception
- */
-@Test
-public void testPerpetualNoTimeFramePull() throws Exception {
-com.healthmarketscience.common.util.resource.Handler.init();
-BlockingQueue queue = new LinkedBlockingQueue<>();
-RssStreamProviderTask task = new RssStreamProviderTask(queue, "fake 
url", new DateTime().minusYears(5), 1, true);
-Set batch = task.queueFeedEntries(new 
URL("resource:///test_rss_xml/economist1.xml"));
-assertEquals("Expected batch size to be the same as amount of queued 
datums", batch.size(), queue.size());
-RssStreamProviderTask.PREVIOUSLY_SEEN.put("fake url", batch);
-//Test that it will not out previously seen articles
-queue.clear();
-batch = task.queueFeedEntries(new 
URL("resource:///test_rss_xml/economist1.xml"));
-assertEquals("Expected queue size to be 0", 0, queue.size());
-assertEquals("Expected batch size to be 20", 20, batch.size());
-

[02/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-util/src/main/java/org/apache/streams/util/schema/Schema.java
--
diff --git 
a/streams-util/src/main/java/org/apache/streams/util/schema/Schema.java 
b/streams-util/src/main/java/org/apache/streams/util/schema/Schema.java
index 795bf98..a9517c1 100644
--- a/streams-util/src/main/java/org/apache/streams/util/schema/Schema.java
+++ b/streams-util/src/main/java/org/apache/streams/util/schema/Schema.java
@@ -15,6 +15,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.util.schema;
 
 import com.fasterxml.jackson.databind.JsonNode;
@@ -26,49 +27,69 @@ import java.net.URI;
  */
 public class Schema {
 
-private final URI id;
-private final URI uri;
-private final JsonNode content;
-private final Schema parent;
-private final boolean generate;
+  private final URI id;
+  private final URI uri;
+  private final JsonNode content;
+  private final Schema parent;
+  private final boolean generate;
 
-public Schema(URI uri, JsonNode content, Schema parent, boolean generate) {
-this.uri = uri;
-this.content = content;
-this.parent = parent;
-this.generate = generate;
-this.id = content.has("id") ? URI.create(content.get("id").asText()) : 
null;
-}
+  /**
+   * Schema constructor.
+   * @param uri uri
+   * @param content JsonNode content
+   * @param parent Schema parent
+   * @param generate whether to generate
+   */
+  public Schema(URI uri, JsonNode content, Schema parent, boolean generate) {
+this.uri = uri;
+this.content = content;
+this.parent = parent;
+this.generate = generate;
+this.id = content.has("id") ? URI.create(content.get("id").asText()) : 
null;
+  }
 
-public URI getId() {
-return id;
-}
+  public URI getId() {
+return id;
+  }
 
-public URI getURI() {
-return uri;
-}
+  public URI getUri() {
+return uri;
+  }
 
-public JsonNode getContent() {
-return content;
-}
+  public JsonNode getContent() {
+return content;
+  }
 
-public JsonNode getParentContent() {
-if( parent != null )
-return parent.getContent();
-else return null;
+  /**
+   * getParentContent.
+   * @return Parent.Content
+   */
+  public JsonNode getParentContent() {
+if ( parent != null ) {
+  return parent.getContent();
+} else {
+  return null;
 }
+  }
 
-public URI getParentURI() {
-if( parent != null ) return parent.getURI();
-else return null;
+  /**
+   * getParentUri.
+   * @return Parent.Uri
+   */
+  public URI getParentUri() {
+if ( parent != null ) {
+  return parent.getUri();
+} else {
+  return null;
 }
+  }
 
-public boolean isGenerated() {
-return generate;
-}
+  public boolean isGenerated() {
+return generate;
+  }
 
-public Schema getParent() {
-return parent;
-}
+  public Schema getParent() {
+return parent;
+  }
 
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-util/src/main/java/org/apache/streams/util/schema/SchemaStore.java
--
diff --git 
a/streams-util/src/main/java/org/apache/streams/util/schema/SchemaStore.java 
b/streams-util/src/main/java/org/apache/streams/util/schema/SchemaStore.java
index 779df41..4fca239 100644
--- a/streams-util/src/main/java/org/apache/streams/util/schema/SchemaStore.java
+++ b/streams-util/src/main/java/org/apache/streams/util/schema/SchemaStore.java
@@ -15,6 +15,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.util.schema;
 
 import com.fasterxml.jackson.databind.node.ObjectNode;
@@ -27,33 +28,34 @@ import java.util.Iterator;
 /**
  * A SchemaStore resolves and indexes json schemas and makes their properties 
available.
  *
+ * 
  * Implementations include
  * - SchemaStoreImpl
  */
 public interface SchemaStore extends Comparator {
-
-Schema create(URI uri);
 
-Schema create(Schema parent, String path);
+  Schema create(URI uri);
+
+  Schema create(Schema parent, String path);
 
-void clearCache();
+  void clearCache();
 
-Integer getSize();
+  Integer getSize();
 
-Optional getById(URI id);
+  Optional getById(URI id);
 
-Optional getByUri(URI uri);
+  Optional getByUri(URI uri);
 
-Integer getFileUriCount();
+  Integer getFileUriCount();
 
-Integer getHttpUriCount();
+  Integer getHttpUriCount();
 
-Iterator getSchemaIterator();
+  Iterator getSchemaIterator();
 
-ObjectNode resolveProperties(Schema schema, ObjectNode fieldNode, String 
resourceId);
+  ObjectNode resolveProperties(Schema schema, ObjectNode fieldNode, String 
resourceId);
 
-

[07/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/queues/ThroughputQueue.java
--
diff --git 
a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/queues/ThroughputQueue.java
 
b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/queues/ThroughputQueue.java
index deb657a..aae12a0 100644
--- 
a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/queues/ThroughputQueue.java
+++ 
b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/queues/ThroughputQueue.java
@@ -18,11 +18,11 @@
 package org.apache.streams.local.queues;
 
 import org.apache.streams.local.builders.LocalStreamBuilder;
+
+import org.apache.commons.lang.NotImplementedException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.apache.commons.lang.NotImplementedException;
 
-import javax.management.*;
 import java.lang.management.ManagementFactory;
 import java.util.Collection;
 import java.util.Iterator;
@@ -32,6 +32,12 @@ import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
+import javax.management.InstanceAlreadyExistsException;
+import javax.management.MBeanRegistrationException;
+import javax.management.MBeanServer;
+import javax.management.MalformedObjectNameException;
+import javax.management.NotCompliantMBeanException;
+import javax.management.ObjectName;
 
 /**
  * A {@link java.util.concurrent.BlockingQueue} implementation that allows the 
measure measurement of how
@@ -44,437 +50,437 @@ import java.util.concurrent.locks.ReentrantReadWriteLock;
  */
 public class ThroughputQueue implements BlockingQueue, 
ThroughputQueueMXBean {
 
-public static final String NAME_TEMPLATE = 
"org.apache.streams.local:type=ThroughputQueue,name=%s,identifier=%s,startedAt=%s";
-
-private static final Logger LOGGER = 
LoggerFactory.getLogger(ThroughputQueue.class);
-
-private BlockingQueue underlyingQueue;
-private AtomicLong elementsAdded;
-private AtomicLong elementsRemoved;
-private AtomicLong startTime;
-private AtomicLong totalQueueTime;
-private long maxQueuedTime;
-private volatile boolean active;
-private ReadWriteLock maxQueueTimeLock;
-
-/**
- * Creates an unbounded, unregistered {@code ThroughputQueue}
- */
-public ThroughputQueue() {
-this(-1, null, LocalStreamBuilder.DEFAULT_STREAM_IDENTIFIER, -1);
+  public static final String NAME_TEMPLATE = 
"org.apache.streams.local:type=ThroughputQueue,name=%s,identifier=%s,startedAt=%s";
+
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ThroughputQueue.class);
+
+  private BlockingQueue underlyingQueue;
+  private AtomicLong elementsAdded;
+  private AtomicLong elementsRemoved;
+  private AtomicLong startTime;
+  private AtomicLong totalQueueTime;
+  private long maxQueuedTime;
+  private volatile boolean active;
+  private ReadWriteLock maxQueueTimeLock;
+
+  /**
+   * Creates an unbounded, unregistered {@code ThroughputQueue}
+   */
+  public ThroughputQueue() {
+this(-1, null, LocalStreamBuilder.DEFAULT_STREAM_IDENTIFIER, -1);
+  }
+
+  /**
+   *
+   * @param streamIdentifier
+   * @param startedAt
+   */
+  public ThroughputQueue(String streamIdentifier, long startedAt) {
+this(-1, null, streamIdentifier, startedAt);
+  }
+
+  /**
+   * Creates a bounded, unregistered {@code ThroughputQueue}
+   *
+   * @param maxSize maximum capacity of queue, if maxSize < 1 then unbounded
+   */
+  public ThroughputQueue(int maxSize) {
+this(maxSize, null, LocalStreamBuilder.DEFAULT_STREAM_IDENTIFIER, -1);
+  }
+
+  /**
+   *
+   * @param maxSize
+   * @param streamIdentifier
+   * @param startedAt
+   */
+  public ThroughputQueue(int maxSize, String streamIdentifier, long startedAt) 
{
+this(maxSize, null, streamIdentifier, startedAt);
+  }
+
+  /**
+   * Creates an unbounded, registered {@code ThroughputQueue}
+   *
+   * @param id unique id for this queue to be registered with. if id == NULL 
then not registered
+   */
+  public ThroughputQueue(String id) {
+this(-1, id, LocalStreamBuilder.DEFAULT_STREAM_IDENTIFIER, -1);
+  }
+
+  /**
+   *
+   * @param id
+   * @param streamIdentifier
+   * @param startedAt
+   */
+  public ThroughputQueue(String id, String streamIdentifier, long startedAt) {
+this(-1, id, streamIdentifier, startedAt);
+  }
+
+  /**
+   *
+   * @param maxSize
+   * @param id
+   */
+  public ThroughputQueue(int maxSize, String id) {
+this(maxSize, id, LocalStreamBuilder.DEFAULT_STREAM_IDENTIFIER, -1);
+
+  }
+
+  /**
+   * Creates a bounded, registered {@code ThroughputQueue}
+   *
+   * @param maxSize maximum capacity of 

[11/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorMojoIT.java
--
diff --git 
a/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorMojoIT.java
 
b/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorMojoIT.java
index f2ccd2a..a1d48cc 100644
--- 
a/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorMojoIT.java
+++ 
b/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorMojoIT.java
@@ -41,46 +41,45 @@ import static 
org.apache.streams.plugins.test.StreamsPojoSourceGeneratorTest.jav
  */
 public class StreamsPojoSourceGeneratorMojoIT extends TestCase {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(StreamsPojoSourceGeneratorMojoIT.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(StreamsPojoSourceGeneratorMojoIT.class);
 
-protected void setUp() throws Exception
-{
-// required for mojo lookups to work
-super.setUp();
-}
+  protected void setUp() throws Exception {
+// required for mojo lookups to work
+super.setUp();
+  }
 
 
-@Test
-public void testStreamsPojoSourceGeneratorMojo() throws Exception {
+  @Test
+  public void testStreamsPojoSourceGeneratorMojo() throws Exception {
 
-File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/streams-plugin-pojo" );
+File testDir = ResourceExtractor.simpleExtractResources( getClass(), 
"/streams-plugin-pojo" );
 
-Verifier verifier;
+Verifier verifier;
 
-verifier = new Verifier( testDir.getAbsolutePath() );
+verifier = new Verifier( testDir.getAbsolutePath() );
 
-List cliOptions = new ArrayList();
-cliOptions.add( "-N" );
-verifier.executeGoals( Lists.newArrayList(
-"clean",
-"dependency:unpack-dependencies",
-"generate-sources",
-"compile"));
+List cliOptions = new ArrayList();
+cliOptions.add( "-N" );
+verifier.executeGoals( Lists.newArrayList(
+"clean",
+"dependency:unpack-dependencies",
+"generate-sources",
+"compile"));
 
-verifier.verifyErrorFreeLog();
+verifier.verifyErrorFreeLog();
 
-verifier.resetStreams();
+verifier.resetStreams();
 
-File testOutput = new File(testDir.getAbsolutePath() + 
"/target/generated-sources/pojo-mojo");
+File testOutput = new File(testDir.getAbsolutePath() + 
"/target/generated-sources/pojo-mojo");
 
-assert( testOutput != null );
-assert( testOutput.exists() == true );
-assert( testOutput.isDirectory() == true );
+assert ( testOutput != null );
+assert ( testOutput.exists() == true );
+assert ( testOutput.isDirectory() == true );
 
-Iterable outputIterator = 
Files.fileTreeTraverser().breadthFirstTraversal(testOutput)
-.filter(javaFilter);
-Collection outputCollection = Lists.newArrayList(outputIterator);
-assert( outputCollection.size() > 133 );
+Iterable outputIterator = 
Files.fileTreeTraverser().breadthFirstTraversal(testOutput)
+.filter(javaFilter);
+Collection outputCollection = Lists.newArrayList(outputIterator);
+assert ( outputCollection.size() > 133 );
 
-}
+  }
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorTest.java
--
diff --git 
a/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorTest.java
 
b/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorTest.java
index 7e04e3e..a16c1da 100644
--- 
a/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorTest.java
+++ 
b/streams-plugins/streams-plugin-pojo/src/test/java/org/apache/streams/plugins/test/StreamsPojoSourceGeneratorTest.java
@@ -19,72 +19,75 @@
 
 package org.apache.streams.plugins.test;
 
+import org.apache.streams.plugins.StreamsPojoGenerationConfig;
+import org.apache.streams.plugins.StreamsPojoSourceGenerator;
+
 import com.google.common.base.Predicate;
 import com.google.common.collect.Lists;
 import com.google.common.io.Files;
-import org.apache.streams.plugins.StreamsPojoGenerationConfig;
-import org.apache.streams.plugins.StreamsPojoSourceGenerator;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.slf4j.Logger;
 import 

[09/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-pojo/src/test/java/org/apache/streams/pojo/test/RFC3339UtilsTest.java
--
diff --git 
a/streams-pojo/src/test/java/org/apache/streams/pojo/test/RFC3339UtilsTest.java 
b/streams-pojo/src/test/java/org/apache/streams/pojo/test/RFC3339UtilsTest.java
index b44e72a..bce756a 100644
--- 
a/streams-pojo/src/test/java/org/apache/streams/pojo/test/RFC3339UtilsTest.java
+++ 
b/streams-pojo/src/test/java/org/apache/streams/pojo/test/RFC3339UtilsTest.java
@@ -19,6 +19,7 @@
 package org.apache.streams.pojo.test;
 
 import org.apache.streams.data.util.RFC3339Utils;
+
 import org.joda.time.DateTime;
 import org.joda.time.DateTimeZone;
 import org.junit.Test;
@@ -38,189 +39,190 @@ import static org.junit.Assert.fail;
  */
 public class RFC3339UtilsTest {
 
-@Test
-public void validUTC() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00Z");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(12)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-}
-
-@Test
-public void validUTCSubSecond() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00.7Z");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(12)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-assertThat(parsed.millisOfSecond().get(), is(equalTo(700)));
-}
-
-@Test
-public void validUTCSubSecondMultiDigit() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00.7343Z");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(12)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-assertThat(parsed.millisOfSecond().get(), is(equalTo(734)));
-}
-
-@Test
-public void validEST() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00-05:00");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(17)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-}
-
-@Test
-public void validESTSubSecond() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00.7-05:00");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(17)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-assertThat(parsed.millisOfSecond().get(), is(equalTo(700)));
-}
-
-@Test
-public void validESTSubSecondMultiDigit() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00.7343-05:00");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(17)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-assertThat(parsed.millisOfSecond().get(), is(equalTo(734)));
-}
-
-@Test
-public void validESTNoSeparator() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00-0500");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(17)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-}
-
-@Test
-public void validESTSubSecondNoSeparator() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00.7-0500");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(17)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-assertThat(parsed.millisOfSecond().get(), is(equalTo(700)));
-}
-
-@Test
-public void validESTSubSecondMultiDigitNoSeparator() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00.7343-0500");
-assertThat(parsed.minuteOfHour().get(), is(equalTo(0)));
-assertThat(parsed.hourOfDay().get(), is(equalTo(17)));
-assertThat(parsed.dayOfMonth().get(), is(equalTo(25)));
-assertThat(parsed.monthOfYear().get(), is(equalTo(12)));
-assertThat(parsed.millisOfSecond().get(), is(equalTo(734)));
-}
-
-@Test
-public void validCET() {
-DateTime parsed = parseUTC("2014-12-25T12:00:00+01:00");
-assertThat(parsed.minuteOfHour().get(), 

[21/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityConverter.java
--
diff --git 
a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityConverter.java
 
b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityConverter.java
index ef74371..b8ce79b 100644
--- 
a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityConverter.java
+++ 
b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityConverter.java
@@ -18,65 +18,69 @@
 
 package org.apache.streams.twitter.converter;
 
-import com.google.common.collect.Lists;
-import org.apache.commons.lang.NotImplementedException;
 import org.apache.streams.data.ActivityConverter;
 import org.apache.streams.exceptions.ActivityConversionException;
 import org.apache.streams.pojo.json.Activity;
 import org.apache.streams.twitter.pojo.User;
 
+import com.google.common.collect.Lists;
+import org.apache.commons.lang.NotImplementedException;
+
 import java.util.List;
 
 import static 
org.apache.streams.twitter.converter.util.TwitterActivityUtil.updateActivity;
 
 public class TwitterJsonUserActivityConverter implements 
ActivityConverter {
 
-public static Class requiredClass = User.class;
+  public static Class requiredClass = User.class;
 
-@Override
-public Class requiredClass() {
-return requiredClass;
-}
+  @Override
+  public Class requiredClass() {
+return requiredClass;
+  }
 
-private static TwitterJsonUserActivityConverter instance = new 
TwitterJsonUserActivityConverter();
+  private static TwitterJsonUserActivityConverter instance = new 
TwitterJsonUserActivityConverter();
 
-public static TwitterJsonUserActivityConverter getInstance() {
-return instance;
-}
+  public static TwitterJsonUserActivityConverter getInstance() {
+return instance;
+  }
 
-@Override
-public String serializationFormat() {
-return null;
-}
+  @Override
+  public String serializationFormat() {
+return null;
+  }
 
-@Override
-public User fromActivity(Activity deserialized) throws 
ActivityConversionException {
-throw new NotImplementedException();
-}
+  @Override
+  public User fromActivity(Activity deserialized) throws 
ActivityConversionException {
+throw new NotImplementedException();
+  }
 
-@Override
-public List toActivityList(User user) throws 
ActivityConversionException {
+  @Override
+  public List fromActivityList(List list) {
+throw new NotImplementedException();
+  }
 
-Activity activity = new Activity();
-updateActivity(user, activity);
 
-return Lists.newArrayList(activity);
-}
+  @Override
+  public List toActivityList(User user) throws 
ActivityConversionException {
 
-@Override
-public List fromActivityList(List list) {
-throw new NotImplementedException();
-}
+Activity activity = new Activity();
+updateActivity(user, activity);
+
+return Lists.newArrayList(activity);
+  }
 
-@Override
-public List toActivityList(List serializedList) {
-List result = Lists.newArrayList();
-for( User item : serializedList ) {
-try {
-List activities = toActivityList(item);
-result.addAll(activities);
-} catch (ActivityConversionException e) {}
-}
-return result;
+  @Override
+  public List toActivityList(List serializedList) {
+List result = Lists.newArrayList();
+for ( User item : serializedList ) {
+  try {
+List activities = toActivityList(item);
+result.addAll(activities);
+  } catch (ActivityConversionException ex) {
+//
+  }
 }
+return result;
+  }
 }

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityObjectConverter.java
--
diff --git 
a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityObjectConverter.java
 
b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityObjectConverter.java
index d62b1e8..7cb4158 100644
--- 
a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityObjectConverter.java
+++ 
b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityObjectConverter.java
@@ -18,47 

[31/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/FacebookProvider.java
--
diff --git 
a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/FacebookProvider.java
 
b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/FacebookProvider.java
index e907082..be59bd7 100644
--- 
a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/FacebookProvider.java
+++ 
b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/FacebookProvider.java
@@ -15,16 +15,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.facebook.provider;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.google.common.collect.Queues;
-import com.google.common.collect.Sets;
-import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.common.util.concurrent.MoreExecutors;
-import com.typesafe.config.ConfigRenderOptions;
 import org.apache.streams.config.StreamsConfigurator;
 import org.apache.streams.core.StreamsDatum;
 import org.apache.streams.core.StreamsProvider;
@@ -34,6 +27,16 @@ import org.apache.streams.facebook.IdConfig;
 import org.apache.streams.jackson.StreamsJacksonMapper;
 import org.apache.streams.util.ComponentUtils;
 import org.apache.streams.util.SerializationUtil;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.collect.Queues;
+import com.google.common.collect.Sets;
+import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.typesafe.config.ConfigRenderOptions;
+
 import org.joda.time.DateTime;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -44,7 +47,8 @@ import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
-import java.util.concurrent.*;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.Executors;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 /**
@@ -52,103 +56,109 @@ import java.util.concurrent.atomic.AtomicBoolean;
  */
 public abstract class FacebookProvider implements StreamsProvider {
 
-private final static String STREAMS_ID = "FacebookProvider";
-
-private static final Logger LOGGER = 
LoggerFactory.getLogger(FacebookProvider.class);
-private static final ObjectMapper MAPPER = 
StreamsJacksonMapper.getInstance();
-private static final int MAX_BATCH_SIZE = 2000;
-
-protected FacebookConfiguration configuration;
-protected BlockingQueue datums;
-
-private AtomicBoolean isComplete;
-private ListeningExecutorService executor;
-List futures = new ArrayList<>();
-
-private FacebookDataCollector dataCollector;
-
-public FacebookProvider() {
-try {
-this.configuration = 
MAPPER.readValue(StreamsConfigurator.config.getConfig("facebook").root().render(ConfigRenderOptions.concise()),
 FacebookConfiguration.class);
-} catch (IOException ioe) {
-LOGGER.error("Exception trying to read default config : {}", ioe);
-}
-}
-
-public FacebookProvider(FacebookConfiguration configuration) {
-this.configuration = (FacebookConfiguration) 
SerializationUtil.cloneBySerialization(configuration);
-}
-
-@Override
-public String getId() {
-return STREAMS_ID;
-}
+  private static final String STREAMS_ID = "FacebookProvider";
 
-@Override
-public void startStream() {
-ListenableFuture future = executor.submit(getDataCollector());
-futures.add(future);
-executor.shutdown();
-}
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(FacebookProvider.class);
+  private static final ObjectMapper MAPPER = 
StreamsJacksonMapper.getInstance();
+  private static final int MAX_BATCH_SIZE = 2000;
 
-protected abstract FacebookDataCollector getDataCollector();
-
-@Override
-public StreamsResultSet readCurrent() {
-int batchSize = 0;
-BlockingQueue batch = Queues.newLinkedBlockingQueue();
-while(!this.datums.isEmpty() && batchSize < MAX_BATCH_SIZE) {
-
ComponentUtils.offerUntilSuccess(ComponentUtils.pollWhileNotEmpty(this.datums), 
batch);
-++batchSize;
-}
-return new StreamsResultSet(batch);
-}
+  protected FacebookConfiguration configuration;
+  protected BlockingQueue datums;
 
-@Override
-public StreamsResultSet 

[04/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/test/writer/DatumCounterWriter.java
--
diff --git 
a/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/test/writer/DatumCounterWriter.java
 
b/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/test/writer/DatumCounterWriter.java
index b7f777e..0c7af1e 100644
--- 
a/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/test/writer/DatumCounterWriter.java
+++ 
b/streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/test/writer/DatumCounterWriter.java
@@ -18,11 +18,16 @@
 
 package org.apache.streams.local.test.writer;
 
-import com.google.common.collect.Lists;
 import org.apache.streams.core.StreamsDatum;
 import org.apache.streams.core.StreamsPersistWriter;
 
-import java.util.*;
+import com.google.common.collect.Lists;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Random;
+import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.atomic.AtomicLong;
 
@@ -31,79 +36,79 @@ import java.util.concurrent.atomic.AtomicLong;
  */
 public class DatumCounterWriter implements StreamsPersistWriter{
 
-@Override
-public String getId() {
-return "DatumCounterWriter";
-}
+  @Override
+  public String getId() {
+return "DatumCounterWriter";
+  }
 
-/**
- * Set of all ids that have been claimed.  Ensures all instances are 
assigned unique ids
- */
-public static Set CLAIMED_ID = new HashSet();
-/**
- * Random instance to generate ids
- */
-public static final Random RAND = new Random();
-/**
- * Set of instance ids that received data. Usefully for testing 
parrallelization is actually working.
- */
-public final static Set SEEN_DATA = Collections.newSetFromMap(new 
ConcurrentHashMap());
-/**
- * The total count of data seen by a all instances of a processor.
- */
-public static final ConcurrentHashMap COUNTS = new 
ConcurrentHashMap<>();
-/**
- * The documents received
- */
-public static final ConcurrentHashMap RECEIVED = new 
ConcurrentHashMap<>();
+  /**
+   * Set of all ids that have been claimed.  Ensures all instances are 
assigned unique ids
+   */
+  public static Set CLAIMED_ID = new HashSet();
+  /**
+   * Random instance to generate ids
+   */
+  public static final Random RAND = new Random();
+  /**
+   * Set of instance ids that received data. Usefully for testing 
parrallelization is actually working.
+   */
+  public final static Set SEEN_DATA = Collections.newSetFromMap(new 
ConcurrentHashMap());
+  /**
+   * The total count of data seen by a all instances of a processor.
+   */
+  public static final ConcurrentHashMap COUNTS = new 
ConcurrentHashMap<>();
+  /**
+   * The documents received
+   */
+  public static final ConcurrentHashMap RECEIVED = new 
ConcurrentHashMap<>();
 
-private int counter = 0;
-private String writerId;
-private Integer id;
+  private int counter = 0;
+  private String writerId;
+  private Integer id;
 
-public DatumCounterWriter(String writerId) {
-this.writerId = writerId;
-}
+  public DatumCounterWriter(String writerId) {
+this.writerId = writerId;
+  }
 
-@Override
-public void write(StreamsDatum entry) {
-++this.counter;
-SEEN_DATA.add(this.id);
-synchronized (RECEIVED) {
-List documents = RECEIVED.get(this.writerId);
-if(documents == null) {
-List docs = Lists.newLinkedList();
-docs.add(entry.getDocument());
-RECEIVED.put(this.writerId, docs);
-} else {
-documents.add(entry.getDocument());
-}
-}
+  @Override
+  public void write(StreamsDatum entry) {
+++this.counter;
+SEEN_DATA.add(this.id);
+synchronized (RECEIVED) {
+  List documents = RECEIVED.get(this.writerId);
+  if(documents == null) {
+List docs = Lists.newLinkedList();
+docs.add(entry.getDocument());
+RECEIVED.put(this.writerId, docs);
+  } else {
+documents.add(entry.getDocument());
+  }
 }
+  }
 
-@Override
-public void prepare(Object configurationObject) {
-synchronized (CLAIMED_ID) {
-this.id = RAND.nextInt();
-while(!CLAIMED_ID.add(this.id)) {
-this.id = RAND.nextInt();
-}
-}
+  @Override
+  public void prepare(Object configurationObject) {
+synchronized (CLAIMED_ID) {
+  this.id = RAND.nextInt();
+  while(!CLAIMED_ID.add(this.id)) {
+this.id = RAND.nextInt();

[28/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-google/google-gplus/src/main/java/com/google/gplus/serializer/util/GPlusActivityDeserializer.java
--
diff --git 
a/streams-contrib/streams-provider-google/google-gplus/src/main/java/com/google/gplus/serializer/util/GPlusActivityDeserializer.java
 
b/streams-contrib/streams-provider-google/google-gplus/src/main/java/com/google/gplus/serializer/util/GPlusActivityDeserializer.java
index 7ff1d1e..79f1815 100644
--- 
a/streams-contrib/streams-provider-google/google-gplus/src/main/java/com/google/gplus/serializer/util/GPlusActivityDeserializer.java
+++ 
b/streams-contrib/streams-provider-google/google-gplus/src/main/java/com/google/gplus/serializer/util/GPlusActivityDeserializer.java
@@ -27,6 +27,7 @@ import com.fasterxml.jackson.databind.JsonNode;
 import com.google.api.client.util.DateTime;
 import com.google.api.client.util.Lists;
 import com.google.api.services.plus.model.Activity;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -34,130 +35,137 @@ import java.io.IOException;
 import java.util.List;
 
 /**
- * Custom deserializer for GooglePlus' Person model
+ * Custom deserializer for GooglePlus' Person model.
  */
 public class GPlusActivityDeserializer extends JsonDeserializer {
-private final static Logger LOGGER = 
LoggerFactory.getLogger(GPlusActivityDeserializer.class);
-
-/**
- * Because the GooglePlus Activity object {@link 
com.google.api.services.plus.model.Activity} contains complex objects
- * within its hierarchy, we have to use a custom deserializer
- *
- * @param jsonParser
- * @param deserializationContext
- * @return The deserialized {@link 
com.google.api.services.plus.model.Activity} object
- * @throws IOException
- * @throws JsonProcessingException
- */
-@Override
-public Activity deserialize(JsonParser jsonParser, DeserializationContext 
deserializationContext) throws IOException {
-
-JsonNode node = jsonParser.getCodec().readTree(jsonParser);
-Activity activity = new Activity();
-
-try {
-activity.setUrl(node.get("url").asText());
-activity.setEtag(node.get("etag").asText());
-activity.setTitle(node.get("title").asText());
-
activity.setPublished(DateTime.parseRfc3339(node.get("published").asText()));
-
activity.setUpdated(DateTime.parseRfc3339(node.get("updated").asText()));
-activity.setId(node.get("id").asText());
-activity.setVerb(node.get("verb").asText());
-
-activity.setActor(buildActor(node));
-
-activity.setObject(buildPlusObject(node));
-} catch (Exception e) {
-LOGGER.error("Exception while trying to deserialize activity 
object: {}", e);
-}
 
-return activity;
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(GPlusActivityDeserializer.class);
+
+  /**
+   * Because the GooglePlus Activity object {@link 
com.google.api.services.plus.model.Activity} contains complex objects
+   * within its hierarchy, we have to use a custom deserializer
+   *
+   * @param jsonParser jsonParser
+   * @param deserializationContext deserializationContext
+   * @return The deserialized {@link 
com.google.api.services.plus.model.Activity} object
+   * @throws IOException IOException
+   * @throws JsonProcessingException JsonProcessingException
+   */
+  @Override
+  public Activity deserialize(JsonParser jsonParser, DeserializationContext 
deserializationContext) throws IOException {
+
+JsonNode node = jsonParser.getCodec().readTree(jsonParser);
+Activity activity = new Activity();
+
+try {
+  activity.setUrl(node.get("url").asText());
+  activity.setEtag(node.get("etag").asText());
+  activity.setTitle(node.get("title").asText());
+  
activity.setPublished(DateTime.parseRfc3339(node.get("published").asText()));
+  activity.setUpdated(DateTime.parseRfc3339(node.get("updated").asText()));
+  activity.setId(node.get("id").asText());
+  activity.setVerb(node.get("verb").asText());
+
+  activity.setActor(buildActor(node));
+
+  activity.setObject(buildPlusObject(node));
+} catch (Exception ex) {
+  LOGGER.error("Exception while trying to deserialize activity object: 
{}", ex);
 }
 
-/**
- * Given a raw JsonNode, build out the G+ {@link 
com.google.api.services.plus.model.Activity.Actor} object
- *
- * @param node
- * @return {@link com.google.api.services.plus.model.Activity.Actor} object
- */
-private Activity.Actor buildActor(JsonNode node) {
-Activity.Actor actor = new Activity.Actor();
-JsonNode actorNode = node.get("actor");
-
-actor.setId(actorNode.get("id").asText());
-actor.setDisplayName(actorNode.get("displayName").asText());
-

[25/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-moreover/src/main/java/org/apache/streams/moreover/MoreoverJsonActivitySerializer.java
--
diff --git 
a/streams-contrib/streams-provider-moreover/src/main/java/org/apache/streams/moreover/MoreoverJsonActivitySerializer.java
 
b/streams-contrib/streams-provider-moreover/src/main/java/org/apache/streams/moreover/MoreoverJsonActivitySerializer.java
index 17fde37..91d487e 100644
--- 
a/streams-contrib/streams-provider-moreover/src/main/java/org/apache/streams/moreover/MoreoverJsonActivitySerializer.java
+++ 
b/streams-contrib/streams-provider-moreover/src/main/java/org/apache/streams/moreover/MoreoverJsonActivitySerializer.java
@@ -18,6 +18,9 @@
 
 package org.apache.streams.moreover;
 
+import org.apache.streams.data.ActivitySerializer;
+import org.apache.streams.pojo.json.Activity;
+
 import com.fasterxml.jackson.databind.AnnotationIntrospector;
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -25,9 +28,6 @@ import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector;
 import com.moreover.api.Article;
 import org.apache.commons.lang.NotImplementedException;
-import org.apache.streams.data.ActivitySerializer;
-import org.apache.streams.moreover.MoreoverUtils;
-import org.apache.streams.pojo.json.Activity;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -35,64 +35,64 @@ import java.io.IOException;
 import java.util.List;
 
 /**
- * Deserializes Moreover JSON format into Activities
+ * Deserializes Moreover JSON format into Activities.
  */
 public class MoreoverJsonActivitySerializer implements 
ActivitySerializer {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(MoreoverJsonActivitySerializer.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(MoreoverJsonActivitySerializer.class);
 
-public MoreoverJsonActivitySerializer() {
-}
+  public MoreoverJsonActivitySerializer() {
+  }
 
-@Override
-public String serializationFormat() {
-return "application/json+vnd.moreover.com.v1";
-}
+  @Override
+  public String serializationFormat() {
+return "application/json+vnd.moreover.com.v1";
+  }
 
-@Override
-public String serialize(Activity deserialized) {
-throw new UnsupportedOperationException("Cannot currently serialize to 
Moreover JSON");
-}
+  @Override
+  public String serialize(Activity deserialized) {
+throw new UnsupportedOperationException("Cannot currently serialize to 
Moreover JSON");
+  }
 
-@Override
-public Activity deserialize(String serialized) {
-serialized = serialized.replaceAll("\\[[ ]*\\]", "null");
-
-LOGGER.debug(serialized);
-
-ObjectMapper mapper = new ObjectMapper();
-AnnotationIntrospector introspector = new 
JaxbAnnotationIntrospector(mapper.getTypeFactory());
-mapper.setAnnotationIntrospector(introspector);
-mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, 
Boolean.FALSE);
-mapper.configure(DeserializationFeature.FAIL_ON_INVALID_SUBTYPE, 
Boolean.FALSE);
-mapper.configure(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY, 
Boolean.TRUE);
-
mapper.configure(DeserializationFeature.ACCEPT_EMPTY_STRING_AS_NULL_OBJECT, 
Boolean.TRUE);
-mapper.configure(DeserializationFeature.WRAP_EXCEPTIONS, Boolean.TRUE);
-
-Article article;
-try {
-ObjectNode node = (ObjectNode)mapper.readTree(serialized);
-node.remove("tags");
-node.remove("locations");
-node.remove("companies");
-node.remove("topics");
-node.remove("media");
-node.remove("outboundUrls");
-ObjectNode jsonNodes = (ObjectNode) node.get("source").get("feed");
-jsonNodes.remove("editorialTopics");
-jsonNodes.remove("tags");
-jsonNodes.remove("autoTopics");
-article = mapper.convertValue(node, Article.class);
-} catch (IOException e) {
-throw new IllegalArgumentException("Unable to deserialize", e);
-}
-return MoreoverUtils.convert(article);
-}
+  @Override
+  public Activity deserialize(String serialized) {
+serialized = serialized.replaceAll("\\[[ ]*\\]", "null");
 
-@Override
-public List deserializeAll(List serializedList) {
-throw new NotImplementedException("Not currently implemented");
+LOGGER.debug(serialized);
+
+ObjectMapper mapper = new ObjectMapper();
+AnnotationIntrospector introspector = new 
JaxbAnnotationIntrospector(mapper.getTypeFactory());
+mapper.setAnnotationIntrospector(introspector);
+mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, 

[08/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
--
diff --git 
a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
 
b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
index f6fcaac..9e5089e 100644
--- 
a/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
+++ 
b/streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
@@ -18,25 +18,38 @@
 
 package org.apache.streams.local.builders;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.google.common.util.concurrent.Uninterruptibles;
-import org.apache.streams.config.ComponentConfigurator;
 import org.apache.streams.config.StreamsConfiguration;
 import org.apache.streams.config.StreamsConfigurator;
-import org.apache.streams.core.*;
+import org.apache.streams.core.DatumStatusCountable;
+import org.apache.streams.core.StreamBuilder;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsPersistWriter;
+import org.apache.streams.core.StreamsProcessor;
+import org.apache.streams.core.StreamsProvider;
 import org.apache.streams.jackson.StreamsJacksonMapper;
 import org.apache.streams.local.LocalRuntimeConfiguration;
 import org.apache.streams.local.counters.StreamsTaskCounter;
 import 
org.apache.streams.local.executors.ShutdownStreamOnUnhandleThrowableThreadPoolExecutor;
 import org.apache.streams.local.monitoring.MonitoringConfiguration;
 import org.apache.streams.local.queues.ThroughputQueue;
-import org.apache.streams.local.tasks.*;
+import org.apache.streams.local.tasks.BaseStreamsTask;
+import org.apache.streams.local.tasks.LocalStreamProcessMonitorThread;
+import org.apache.streams.local.tasks.StatusCounterMonitorThread;
+import org.apache.streams.local.tasks.StreamsProviderTask;
+import org.apache.streams.local.tasks.StreamsTask;
 import org.apache.streams.monitoring.tasks.BroadcastMonitorThread;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.common.util.concurrent.Uninterruptibles;
 import org.joda.time.DateTime;
 import org.slf4j.Logger;
 
 import java.math.BigInteger;
-import java.util.*;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
@@ -49,452 +62,452 @@ import java.util.concurrent.TimeUnit;
  */
 public class LocalStreamBuilder implements StreamBuilder {
 
-private static final Logger LOGGER = 
org.slf4j.LoggerFactory.getLogger(LocalStreamBuilder.class);
-private static final int DEFAULT_QUEUE_SIZE = 500;
-
-public static final String TIMEOUT_KEY = "TIMEOUT";
-public static final String BROADCAST_KEY = "broadcastURI";
-public static final String STREAM_IDENTIFIER_KEY = "streamsID";
-public static final String BROADCAST_INTERVAL_KEY = 
"monitoring_broadcast_interval_ms";
-public static final String DEFAULT_STREAM_IDENTIFIER = "Unknown_Stream";
-public static final String DEFAULT_STARTED_AT_KEY = "startedAt";
-
-private Map providers;
-private Map components;
-private LocalRuntimeConfiguration streamConfig;
-private Map futures;
-private ExecutorService executor;
-private ExecutorService monitor;
-private int totalTasks;
-private int monitorTasks;
-private LocalStreamProcessMonitorThread monitorThread;
-private Map tasks;
-private Thread shutdownHook;
-private BroadcastMonitorThread broadcastMonitor;
-private int maxQueueCapacity;
-private String streamIdentifier = DEFAULT_STREAM_IDENTIFIER;
-private DateTime startedAt = new DateTime();
-private boolean useDeprecatedMonitors;
-
-/**
- * Creates a local stream builder with all configuration resolved by 
typesafe
- */
-public LocalStreamBuilder() {
-this(new 
ObjectMapper().convertValue(StreamsConfigurator.detectConfiguration(), 
LocalRuntimeConfiguration.class));
+  private static final Logger LOGGER = 
org.slf4j.LoggerFactory.getLogger(LocalStreamBuilder.class);
+  private static final int DEFAULT_QUEUE_SIZE = 500;
+
+  public static final String TIMEOUT_KEY = "TIMEOUT";
+  public static final String BROADCAST_KEY = "broadcastURI";
+  public static final String STREAM_IDENTIFIER_KEY = "streamsID";
+  public static final String BROADCAST_INTERVAL_KEY = 
"monitoring_broadcast_interval_ms";
+  public static final String DEFAULT_STREAM_IDENTIFIER = "Unknown_Stream";
+  public static final String 

[10/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-pojo/src/main/java/org/apache/streams/data/DocumentClassifier.java
--
diff --git 
a/streams-pojo/src/main/java/org/apache/streams/data/DocumentClassifier.java 
b/streams-pojo/src/main/java/org/apache/streams/data/DocumentClassifier.java
index bcb14b7..b15722f 100644
--- a/streams-pojo/src/main/java/org/apache/streams/data/DocumentClassifier.java
+++ b/streams-pojo/src/main/java/org/apache/streams/data/DocumentClassifier.java
@@ -27,13 +27,13 @@ import java.util.List;
  */
 public interface DocumentClassifier extends Serializable {
 
-/**
- * Assess the structure of the document, and identify whether the provided 
document is
- * a structural match for one or more typed forms.
- *
- * @param document the document
- * @return a serializable pojo class this document matches
- */
-List detectClasses(Object document);
+  /**
+   * Assess the structure of the document, and identify whether the provided 
document is
+   * a structural match for one or more typed forms.
+   *
+   * @param document the document
+   * @return a serializable pojo class this document matches
+   */
+  List detectClasses(Object document);
 
 }

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-pojo/src/main/java/org/apache/streams/data/util/ActivityUtil.java
--
diff --git 
a/streams-pojo/src/main/java/org/apache/streams/data/util/ActivityUtil.java 
b/streams-pojo/src/main/java/org/apache/streams/data/util/ActivityUtil.java
index dc10df1..c7e8337 100644
--- a/streams-pojo/src/main/java/org/apache/streams/data/util/ActivityUtil.java
+++ b/streams-pojo/src/main/java/org/apache/streams/data/util/ActivityUtil.java
@@ -18,123 +18,140 @@
 
 package org.apache.streams.data.util;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.node.ObjectNode;
 import org.apache.streams.jackson.StreamsJacksonMapper;
 import org.apache.streams.pojo.json.Activity;
 import org.apache.streams.pojo.json.ActivityObject;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
+
 import java.util.HashMap;
 import java.util.Map;
 
 /**
  * Utility class for managing activities
  *
+ * 
  * Deprecated: Use {@link org.apache.streams.pojo.extensions.ExtensionUtil}
  */
 @Deprecated
 public class ActivityUtil {
 
-private ActivityUtil() {}
-
-/**
- * Property on the activity object to use for extensions
- */
-public static final String EXTENSION_PROPERTY = "extensions";
-/**
- * The number of +1, Like, favorites, etc that the post has received
- */
-public static final String LIKES_EXTENSION = "likes";
-/**
- * The number of retweets, shares, etc that the post has received
- */
-public static final String REBROADCAST_EXTENSION = "rebroadcasts";
-/**
- * The language of the post
- */
-public static final String LANGUAGE_EXTENSION = "language";
-/**
- * Location that the post was made or the actor's residence
- */
-public static final String LOCATION_EXTENSION = "location";
-/**
- * Country that the post was made
- */
-public static final String LOCATION_EXTENSION_COUNTRY = "country";
-/**
- * Specific JSON-geo coordinates (long,lat)
- */
-public static final String LOCATION_EXTENSION_COORDINATES = "coordinates";
-
-private static final ObjectMapper mapper = 
StreamsJacksonMapper.getInstance();
-
-/**
- * Creates a standard extension property
- * @param activity activity to create the property in
- * @return the Map representing the extensions property
- */
-@SuppressWarnings("unchecked")
-@Deprecated
-public static Map ensureExtensions(Activity activity) {
-Map extensions = 
(Map)activity.getAdditionalProperties().get(EXTENSION_PROPERTY);
-if(extensions == null) {
-extensions = new HashMap<>();
-activity.setAdditionalProperty(EXTENSION_PROPERTY, extensions);
-}
-return extensions;
-}
+  private ActivityUtil() {}
 
-/**
- * Gets a formatted ID
- * @param providerName name of the provider
- * @param personId ID of the person within the system
- * @return id::people:
- */
-public static String getPersonId(String providerName, String personId) {
-return String.format("id:%s:people:%s", providerName, personId);
-}
+  /**
+   * Property on the activity object to use for extensions.
+   */
+  public static final String EXTENSION_PROPERTY = "extensions";
 
-/**
- * Gets a formatted provider ID
- * @param providerName name of the provider
- * @return id:providers:
- */
-public static String getProviderId(String providerName) {
-return 

[40/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-components/streams-http/src/main/java/org/apache/streams/components/http/processor/SimpleHTTPGetProcessor.java
--
diff --git 
a/streams-components/streams-http/src/main/java/org/apache/streams/components/http/processor/SimpleHTTPGetProcessor.java
 
b/streams-components/streams-http/src/main/java/org/apache/streams/components/http/processor/SimpleHTTPGetProcessor.java
index 5868ba6..871a08b 100644
--- 
a/streams-components/streams-http/src/main/java/org/apache/streams/components/http/processor/SimpleHTTPGetProcessor.java
+++ 
b/streams-components/streams-http/src/main/java/org/apache/streams/components/http/processor/SimpleHTTPGetProcessor.java
@@ -18,10 +18,20 @@
 
 package org.apache.streams.components.http.processor;
 
+import org.apache.streams.components.http.HttpProcessorConfiguration;
+import org.apache.streams.config.ComponentConfigurator;
+import org.apache.streams.config.StreamsConfigurator;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsProcessor;
+import org.apache.streams.jackson.StreamsJacksonMapper;
+import org.apache.streams.pojo.extensions.ExtensionUtil;
+import org.apache.streams.pojo.json.ActivityObject;
+
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.google.common.base.Strings;
+
 import org.apache.commons.codec.binary.Base64;
 import org.apache.http.HttpEntity;
 import org.apache.http.client.methods.CloseableHttpResponse;
@@ -30,14 +40,6 @@ import org.apache.http.client.utils.URIBuilder;
 import org.apache.http.impl.client.CloseableHttpClient;
 import org.apache.http.impl.client.HttpClients;
 import org.apache.http.util.EntityUtils;
-import org.apache.streams.components.http.HttpProcessorConfiguration;
-import org.apache.streams.config.ComponentConfigurator;
-import org.apache.streams.config.StreamsConfigurator;
-import org.apache.streams.core.StreamsDatum;
-import org.apache.streams.core.StreamsProcessor;
-import org.apache.streams.jackson.StreamsJacksonMapper;
-import org.apache.streams.pojo.extensions.ExtensionUtil;
-import org.apache.streams.pojo.json.ActivityObject;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -50,230 +52,249 @@ import java.util.List;
 import java.util.Map;
 
 /**
- * Processor retrieves contents from an known url and stores the resulting 
object in an extension field
+ * Processor retrieves contents from an known url and stores the resulting 
object in an extension field.
  */
 public class SimpleHTTPGetProcessor implements StreamsProcessor {
 
-private final static String STREAMS_ID = "SimpleHTTPGetProcessor";
+  private static final String STREAMS_ID = "SimpleHTTPGetProcessor";
 
-// from root config id
-private final static String EXTENSION = "account_type";
+  // from root config id
+  private static final String EXTENSION = "account_type";
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(SimpleHTTPGetProcessor.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(SimpleHTTPGetProcessor.class);
 
-protected ObjectMapper mapper;
+  protected ObjectMapper mapper;
 
-protected URIBuilder uriBuilder;
+  protected URIBuilder uriBuilder;
 
-protected CloseableHttpClient httpclient;
+  protected CloseableHttpClient httpclient;
 
-protected HttpProcessorConfiguration configuration;
+  protected HttpProcessorConfiguration configuration;
 
-protected String authHeader;
-public SimpleHTTPGetProcessor() {
-this(new ComponentConfigurator<>(HttpProcessorConfiguration.class)
-  
.detectConfiguration(StreamsConfigurator.getConfig().getConfig("http")));
-}
+  protected String authHeader;
 
-public SimpleHTTPGetProcessor(HttpProcessorConfiguration 
processorConfiguration) {
-LOGGER.info("creating SimpleHTTPGetProcessor");
-LOGGER.info(processorConfiguration.toString());
-this.configuration = processorConfiguration;
-}
+  /**
+   * SimpleHTTPGetProcessor constructor - resolves HttpProcessorConfiguration 
from JVM 'http'.
+   */
+  public SimpleHTTPGetProcessor() {
+this(new ComponentConfigurator<>(HttpProcessorConfiguration.class)
+
.detectConfiguration(StreamsConfigurator.getConfig().getConfig("http")));
+  }
 
-@Override
-public String getId() {
-return STREAMS_ID;
-}
+  /**
+   * SimpleHTTPGetProcessor constructor - uses provided 
HttpProcessorConfiguration.
+   */
+  public SimpleHTTPGetProcessor(HttpProcessorConfiguration 
processorConfiguration) {
+LOGGER.info("creating SimpleHTTPGetProcessor");
+LOGGER.info(processorConfiguration.toString());
+this.configuration = processorConfiguration;
+  }
 
-/**
- Override this to store a result other than exact json 

[42/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
STREAMS-440: custom checkstyle.xml, address compliance

Squashed commit of the following:

commit bf329d31fd71a3e1fc21a76073876204ca806f88
Author: Steve Blackmon @steveblackmon 
Date:   Wed Nov 23 09:57:31 2016 -0600

STREAMS-440: retrieve checkstyle xml from streams-master site

commit 45e0edbcc7cfe755b520e04d2eab2fce3f28f0fb
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 19:57:17 2016 -0600

STREAMS-440: streams-verbs

reduce wc -l target/checkstyle_result.xml from 400 to 36

commit fb911c9653108289f00b253751dce4693e77f2d9
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 19:24:43 2016 -0600

STREAMS-440: streams-util

reduce wc -l target/checkstyle_result.xml from 1520 to 61

commit 887762372f97d60e2a4c1ba6ec4c55da07b81ffc
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:39:11 2016 -0600

STREAMS-440: streams-schema-activitystreams2

reduce wc -l target/checkstyle_result.xml from 78 to 6

commit f8dd9a935f063305994a75fb162af98008c92a32
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:36:44 2016 -0600

STREAMS-440: streams-schema-activitystreams

reduce wc -l target/checkstyle_result.xml from 35 to 5

commit ff50402e9e049b973f8db2eb947a892ada59fa73
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:34:00 2016 -0600

STREAMS-440: streams-runtime-storm

commit bdcea2d43d04e595e15905ae604916f3b984bbf9
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:33:18 2016 -0600

STREAMS-440: streams-runtime-pig

reduce wc -l target/checkstyle_result.xml from 452 to 75

commit 010a2b8407594b156e2f94c472ebd8fe6b3e3f1f
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:30:32 2016 -0600

STREAMS-440: streams-runtime-local

reduce wc -l target/checkstyle_result.xml from 3997 to 908

commit 262657144cc57c1893f93b4340a8f791cd1a56c4
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:23:07 2016 -0600

STREAMS-440: streams-runtime-dropwizard

reduce wc -l target/checkstyle_result.xml from 311 to 19

commit 86890fc0f82106093010f1971175ed54179a0c58
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:13:35 2016 -0600

STREAMS-440: streams-pojo-extensions

reduce wc -l target/checkstyle_result.xml from 230 to 16

commit 5ff2a253b31ed774d7f9e09e7449ab7bbc19d5f6
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 18:00:37 2016 -0600

STREAMS-440: streams-pojo

reduce wc -l target/checkstyle_result.xml from 822 to 70

commit 10d0b8d25c469865a995448cf3433b382cf59ad3
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 17:23:36 2016 -0600

STREAMS-440: streams-plugin-scala

reduce wc -l target/checkstyle_result.xml from 517 to 22

commit c505110874ab097acbee5638690caed4fb353668
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 17:08:35 2016 -0600

STREAMS-440: streams-plugin-pojo

reduce wc -l target/checkstyle_result.xml to 19

commit f2757328f2d0db9b196ac9eb7baaecebcd9db918
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 16:58:06 2016 -0600

STREAMS-440: streams-plugin-pig

reduce wc -l target/checkstyle_result.xml from 422 to 20

commit 54232cd7a272f72a72f5f1ea27ffb429d0d16e8c
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 15:30:08 2016 -0600

STREAMS-440: streams-plugin-hive

reduce wc -l target/checkstyle_result.xml from 442 to 20

commit 89e6dbf402bd61a7628d4d760bab126b2a75cd30
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 15:14:53 2016 -0600

STREAMS-440: streams-plugin-hbase

reduce wc -l target/checkstyle_result.xml from 346 to 18

commit 6226f79ca23fe6ee99a8ceb9866fbc2219241c5e
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 14:57:15 2016 -0600

STREAMS-440: streams-plugin-elasticsearch

reduce wc -l target/checkstyle_result.xml from 522 to 23

commit 4dc32f145c3d88bcb879cc95e2d53a51badde02a
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 14:44:11 2016 -0600

STREAMS-440: streams-plugin-cassandra

reduce wc -l target/checkstyle_result.xml from 512 to 20

commit bebccb51b7bc90767dd768cc05453f596b032ad8
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 14:21:18 2016 -0600

STREAMS-440: streams-monitoring

reduce wc -l target/checkstyle_result.xml to 38

commit 9556e9840de1cfb2862fe2ba8e270cb23f268068
Author: Steve Blackmon @steveblackmon 
Date:   Tue Nov 22 10:32:21 2016 -0600

STREAMS-440: streams-core

reduce wc -l target/checkstyle_result.xml from 317 to 33

commit 

[01/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
Repository: incubator-streams
Updated Branches:
  refs/heads/master a726a67ed -> 5dffd5c32


http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationGenericOrdering.java
--
diff --git 
a/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationGenericOrdering.java
 
b/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationGenericOrdering.java
index a9a5ced..9bff713 100644
--- 
a/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationGenericOrdering.java
+++ 
b/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationGenericOrdering.java
@@ -27,48 +27,67 @@ import com.google.common.collect.Ordering;
  */
 public class ObjectCombinationGenericOrdering extends 
Ordering {
 
-public ObjectCombinationGenericOrdering() {}
+  public ObjectCombinationGenericOrdering() {}
 
-@Override
-public int compare(ObjectCombination left, ObjectCombination right) {
-if( wildcardCount(left) < wildcardCount(right))
-return -1;
-if( wildcardCount(left) > wildcardCount(right))
-return 1;
-if( !wildcard(left.getActor()) && wildcard(right.getActor()))
-return -1;
-if( wildcard(left.getActor()) && !wildcard(right.getActor()))
-return 1;
-if( !wildcard(left.getObject()) && wildcard(right.getObject()))
-return -1;
-if( wildcard(left.getObject()) && !wildcard(right.getObject()))
-return 1;
-if( !wildcard(left.getTarget()) && wildcard(right.getTarget()))
-return -1;
-if( wildcard(left.getTarget()) && !wildcard(right.getTarget()))
-return 1;
-if( !wildcard(left.getProvider()) && wildcard(right.getProvider()))
-return -1;
-if( wildcard(left.getProvider()) && !wildcard(right.getProvider()))
-return 1;
-return 0;
+  @Override
+  public int compare(ObjectCombination left, ObjectCombination right) {
+if ( wildcardCount(left) < wildcardCount(right)) {
+  return -1;
+} else if ( wildcardCount(left) > wildcardCount(right)) {
+  return 1;
+} else if ( !wildcard(left.getActor()) && wildcard(right.getActor())) {
+  return -1;
+} else if ( wildcard(left.getActor()) && !wildcard(right.getActor())) {
+  return 1;
+} else if ( !wildcard(left.getObject()) && wildcard(right.getObject())) {
+  return -1;
+} else if ( wildcard(left.getObject()) && !wildcard(right.getObject())) {
+  return 1;
+} else if ( !wildcard(left.getTarget()) && wildcard(right.getTarget())) {
+  return -1;
+} else if ( wildcard(left.getTarget()) && !wildcard(right.getTarget())) {
+  return 1;
+} else if ( !wildcard(left.getProvider()) && 
wildcard(right.getProvider())) {
+  return -1;
+} else if ( wildcard(left.getProvider()) && 
!wildcard(right.getProvider())) {
+  return 1;
+} else {
+  return 0;
 }
+  }
 
-public int wildcardCount(ObjectCombination objectCombination) {
-int wildcardCount = 0;
-if( wildcard(objectCombination.getActor()))
-wildcardCount++;
-if( wildcard(objectCombination.getObject()))
-wildcardCount++;
-if( wildcard(objectCombination.getTarget()))
-wildcardCount++;
-if( wildcard(objectCombination.getProvider()))
-wildcardCount++;
-return wildcardCount;
+  /**
+   * count wildcards in this ObjectCombination.
+   * @param objectCombination ObjectCombination
+   * @return count
+   */
+  public int wildcardCount(ObjectCombination objectCombination) {
+int wildcardCount = 0;
+if ( wildcard(objectCombination.getActor())) {
+  wildcardCount++;
 }
+if ( wildcard(objectCombination.getObject())) {
+  wildcardCount++;
+}
+if ( wildcard(objectCombination.getTarget())) {
+  wildcardCount++;
+}
+if ( wildcard(objectCombination.getProvider())) {
+  wildcardCount++;
+}
+return wildcardCount;
+  }
 
-public boolean wildcard(String pattern) {
-if( pattern.equals("*")) return true;
-else return false;
+  /**
+   * is pattern a wildcard.
+   * @param pattern String
+   * @return true or false
+   */
+  public boolean wildcard(String pattern) {
+if ( pattern.equals("*")) {
+  return true;
+} else {
+  return false;
 }
+  }
 }

http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationSpecificOrdering.java
--
diff --git 
a/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationSpecificOrdering.java
 
b/streams-verbs/src/main/java/org/apache/streams/verbs/ObjectCombinationSpecificOrdering.java
index 90f9f56..18b6d8b 

[14/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-plugins/streams-plugin-cassandra/src/main/java/org/apache/streams/plugins/cassandra/StreamsCassandraResourceGenerator.java
--
diff --git 
a/streams-plugins/streams-plugin-cassandra/src/main/java/org/apache/streams/plugins/cassandra/StreamsCassandraResourceGenerator.java
 
b/streams-plugins/streams-plugin-cassandra/src/main/java/org/apache/streams/plugins/cassandra/StreamsCassandraResourceGenerator.java
index 7f8eb25..7afa9fc 100644
--- 
a/streams-plugins/streams-plugin-cassandra/src/main/java/org/apache/streams/plugins/cassandra/StreamsCassandraResourceGenerator.java
+++ 
b/streams-plugins/streams-plugin-cassandra/src/main/java/org/apache/streams/plugins/cassandra/StreamsCassandraResourceGenerator.java
@@ -16,8 +16,16 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
 package org.apache.streams.plugins.cassandra;
 
+import org.apache.streams.util.schema.FieldType;
+import org.apache.streams.util.schema.FieldUtil;
+import org.apache.streams.util.schema.GenerationConfig;
+import org.apache.streams.util.schema.Schema;
+import org.apache.streams.util.schema.SchemaStore;
+import org.apache.streams.util.schema.SchemaStoreImpl;
+
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.google.common.base.Joiner;
@@ -25,12 +33,6 @@ import com.google.common.base.Optional;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
 import com.google.common.collect.Lists;
-import org.apache.streams.util.schema.FieldType;
-import org.apache.streams.util.schema.FieldUtil;
-import org.apache.streams.util.schema.GenerationConfig;
-import org.apache.streams.util.schema.Schema;
-import org.apache.streams.util.schema.SchemaStore;
-import org.apache.streams.util.schema.SchemaStoreImpl;
 import org.jsonschema2pojo.util.URLUtil;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -44,341 +46,369 @@ import java.util.List;
 import java.util.Map;
 
 import static com.google.common.base.Preconditions.checkNotNull;
-import static org.apache.commons.lang3.StringUtils.defaultString;
 import static org.apache.streams.util.schema.FileUtil.dropExtension;
 import static org.apache.streams.util.schema.FileUtil.dropSourcePathPrefix;
 import static org.apache.streams.util.schema.FileUtil.resolveRecursive;
 import static org.apache.streams.util.schema.FileUtil.writeFile;
 
 /**
- * Created by sblackmon on 5/3/16.
+ * Resource Generator for Cassandra.
  */
 public class StreamsCassandraResourceGenerator implements Runnable {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(StreamsCassandraResourceGenerator.class);
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(StreamsCassandraResourceGenerator.class);
 
-private final static String LS = System.getProperty("line.separator");
+  private static final String LS = System.getProperty("line.separator");
 
-private StreamsCassandraGenerationConfig config;
+  private StreamsCassandraGenerationConfig config;
 
-private SchemaStore schemaStore = new SchemaStoreImpl();
+  private SchemaStore schemaStore = new SchemaStoreImpl();
 
-private int currentDepth = 0;
+  private int currentDepth = 0;
 
-public static void main(String[] args) {
-StreamsCassandraGenerationConfig config = new 
StreamsCassandraGenerationConfig();
+  /**
+   * Run from CLI without Maven
+   *
+   * 
+   * java -jar streams-plugin-cassandra-jar-with-dependencies.jar 
StreamsCassandraResourceGenerator src/main/jsonschema target/generated-resources
+   *
+   * @param args [sourceDirectory, targetDirectory]
+   */
+  public static void main(String[] args) {
+StreamsCassandraGenerationConfig config = new 
StreamsCassandraGenerationConfig();
 
-String sourceDirectory = "./src/main/jsonschema";
-String targetDirectory = "./target/generated-resources/cassandra";
+String sourceDirectory = "./src/main/jsonschema";
+String targetDirectory = "./target/generated-resources/cassandra";
 
-if( args.length > 0 )
-sourceDirectory = args[0];
-if( args.length > 1 )
-targetDirectory = args[1];
-
-config.setSourceDirectory(sourceDirectory);
-config.setTargetDirectory(targetDirectory);
-
-StreamsCassandraResourceGenerator streamsCassandraResourceGenerator = 
new StreamsCassandraResourceGenerator(config);
-streamsCassandraResourceGenerator.run();
+if ( args.length > 0 ) {
+  sourceDirectory = args[0];
 }
-
-public StreamsCassandraResourceGenerator(StreamsCassandraGenerationConfig 
config) {
-this.config = config;
+if ( args.length > 1 ) {
+  targetDirectory = args[1];
 }
 
-public void run() {
+config.setSourceDirectory(sourceDirectory);
+

[16/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-provider-youtube/src/test/java/com/youtube/serializer/YoutubeEventClassifierTest.java
--
diff --git 
a/streams-contrib/streams-provider-youtube/src/test/java/com/youtube/serializer/YoutubeEventClassifierTest.java
 
b/streams-contrib/streams-provider-youtube/src/test/java/com/youtube/serializer/YoutubeEventClassifierTest.java
index 57f9be5..16565bb 100644
--- 
a/streams-contrib/streams-provider-youtube/src/test/java/com/youtube/serializer/YoutubeEventClassifierTest.java
+++ 
b/streams-contrib/streams-provider-youtube/src/test/java/com/youtube/serializer/YoutubeEventClassifierTest.java
@@ -18,32 +18,33 @@
 
 package com.youtube.serializer;
 
-import com.google.api.services.youtube.model.Video;
 import com.fasterxml.jackson.databind.node.ObjectNode;
+import com.google.api.services.youtube.model.Video;
 import org.junit.Test;
 
-
 import static org.junit.Assert.assertEquals;
 
 public class YoutubeEventClassifierTest {
-private final String testVideo = 
"{\"etag\":\"\\\"4FSIjSQU83ZJMYAO0IqRYMvZX98/V0q3OIauZ3ZAkszLUDbHL45yEGM\\\"\",\"id\":\"sUOepRctwVE\",\"kind\":\"youtube#video\",\"snippet\":{\"channelId\":\"UCNENOn2nmwguQYkejKhJGPQ\",\"channelTitle\":\"Carilion
 Clinic\",\"description\":\"Join Carilion Clinic's Heart Failure experts for a 
LIVE Google+ Hangout on Feb. 23, 12:30-1 p.m. to learn more about heart 
failure, treatment options, and lifestyle changes. Learn more: 
https://plus.google.com/u/0/events/cj074q9r6csgv6i2kqhi2isc6k0\",\"publishedAt\":{\"value\":1422977409000,\"dateOnly\":false,\"timeZoneShift\":-360},\"thumbnails\":{\"default\":{\"height\":480,\"url\":\"https://i.ytimg.com/vi/sUOepRctwVE/sddefault.jpg\",\"width\":640}},\"title\":\"Be
 Heart Smart: Congestive Heart Failure LIVE 
Event\"},\"statistics\":{\"commentCount\":1,\"dislikeCount\":0,\"favoriteCount\":0,\"likeCount\":0,\"viewCount\":9}}";
-private final String testObjectNode = 
"{\"etag\":\"\\\"4FSIjSQU83ZJMYAO0IqRYMvZX98/V0q3OIauZ3ZAkszLUDbHL45yEGM\\\"\",\"id\":\"sUOepRctwVE\",\"kind\":\"youtube#somethingElse\",\"snippet\":{\"channelId\":\"UCNENOn2nmwguQYkejKhJGPQ\",\"channelTitle\":\"Carilion
 Clinic\",\"description\":\"Join Carilion Clinic's Heart Failure experts for a 
LIVE Google+ Hangout on Feb. 23, 12:30-1 p.m. to learn more about heart 
failure, treatment options, and lifestyle changes. Learn more: 
https://plus.google.com/u/0/events/cj074q9r6csgv6i2kqhi2isc6k0\",\"publishedAt\":{\"value\":1422977409000,\"dateOnly\":false,\"timeZoneShift\":-360},\"thumbnails\":{\"default\":{\"height\":480,\"url\":\"https://i.ytimg.com/vi/sUOepRctwVE/sddefault.jpg\",\"width\":640}},\"title\":\"Be
 Heart Smart: Congestive Heart Failure LIVE 
Event\"},\"statistics\":{\"commentCount\":1,\"dislikeCount\":0,\"favoriteCount\":0,\"likeCount\":0,\"viewCount\":9}}";
-@Test
-public void testVideoClassification() {
-Class klass = YoutubeEventClassifier.detectClass(testVideo);
-
-assertEquals(klass, Video.class);
-}
-
-@Test(expected=IllegalArgumentException.class)
-public void testExceptionClassification() {
-YoutubeEventClassifier.detectClass("");
-}
-
-@Test
-public void testObjectNodeClassification() {
-Class klass = YoutubeEventClassifier.detectClass(testObjectNode);
-
-assertEquals(klass, ObjectNode.class);
-}
+
+  private final String testVideo = 
"{\"etag\":\"\\\"4FSIjSQU83ZJMYAO0IqRYMvZX98/V0q3OIauZ3ZAkszLUDbHL45yEGM\\\"\",\"id\":\"sUOepRctwVE\",\"kind\":\"youtube#video\",\"snippet\":{\"channelId\":\"UCNENOn2nmwguQYkejKhJGPQ\",\"channelTitle\":\"Carilion
 Clinic\",\"description\":\"Join Carilion Clinic's Heart Failure experts for a 
LIVE Google+ Hangout on Feb. 23, 12:30-1 p.m. to learn more about heart 
failure, treatment options, and lifestyle changes. Learn more: 
https://plus.google.com/u/0/events/cj074q9r6csgv6i2kqhi2isc6k0\",\"publishedAt\":{\"value\":1422977409000,\"dateOnly\":false,\"timeZoneShift\":-360},\"thumbnails\":{\"default\":{\"height\":480,\"url\":\"https://i.ytimg.com/vi/sUOepRctwVE/sddefault.jpg\",\"width\":640}},\"title\":\"Be
 Heart Smart: Congestive Heart Failure LIVE 
Event\"},\"statistics\":{\"commentCount\":1,\"dislikeCount\":0,\"favoriteCount\":0,\"likeCount\":0,\"viewCount\":9}}";
+  private final String testObjectNode = 
"{\"etag\":\"\\\"4FSIjSQU83ZJMYAO0IqRYMvZX98/V0q3OIauZ3ZAkszLUDbHL45yEGM\\\"\",\"id\":\"sUOepRctwVE\",\"kind\":\"youtube#somethingElse\",\"snippet\":{\"channelId\":\"UCNENOn2nmwguQYkejKhJGPQ\",\"channelTitle\":\"Carilion
 Clinic\",\"description\":\"Join Carilion Clinic's Heart Failure experts for a 
LIVE Google+ Hangout on Feb. 23, 12:30-1 p.m. to learn more about heart 
failure, treatment options, and lifestyle changes. Learn more: 

[36/42] incubator-streams git commit: STREAMS-440: custom checkstyle.xml, address compliance

2016-11-25 Thread sblackmon
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/5dffd5c3/streams-contrib/streams-persist-elasticsearch/src/test/java/org/apache/streams/elasticsearch/test/ElasticsearchPersistUpdaterIT.java
--
diff --git 
a/streams-contrib/streams-persist-elasticsearch/src/test/java/org/apache/streams/elasticsearch/test/ElasticsearchPersistUpdaterIT.java
 
b/streams-contrib/streams-persist-elasticsearch/src/test/java/org/apache/streams/elasticsearch/test/ElasticsearchPersistUpdaterIT.java
index d34f53f..e356aff 100644
--- 
a/streams-contrib/streams-persist-elasticsearch/src/test/java/org/apache/streams/elasticsearch/test/ElasticsearchPersistUpdaterIT.java
+++ 
b/streams-contrib/streams-persist-elasticsearch/src/test/java/org/apache/streams/elasticsearch/test/ElasticsearchPersistUpdaterIT.java
@@ -18,27 +18,24 @@
 
 package org.apache.streams.elasticsearch.test;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.typesafe.config.Config;
-import com.typesafe.config.ConfigFactory;
-import com.typesafe.config.ConfigParseOptions;
-import org.apache.commons.io.Charsets;
-import org.apache.commons.io.IOUtils;
 import org.apache.streams.config.ComponentConfigurator;
-import org.apache.streams.config.StreamsConfiguration;
-import org.apache.streams.config.StreamsConfigurator;
 import org.apache.streams.core.StreamsDatum;
 import org.apache.streams.elasticsearch.ElasticsearchClientManager;
 import org.apache.streams.elasticsearch.ElasticsearchPersistUpdater;
-import org.apache.streams.elasticsearch.ElasticsearchPersistWriter;
 import org.apache.streams.elasticsearch.ElasticsearchWriterConfiguration;
 import org.apache.streams.jackson.StreamsJacksonMapper;
 import org.apache.streams.pojo.json.Activity;
 import org.apache.streams.pojo.json.ActivityObject;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+import com.typesafe.config.ConfigParseOptions;
+
+import org.apache.commons.io.Charsets;
+import org.apache.commons.io.IOUtils;
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthRequest;
 import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
-import org.elasticsearch.action.admin.indices.delete.DeleteIndexRequest;
-import org.elasticsearch.action.admin.indices.delete.DeleteIndexResponse;
 import 
org.elasticsearch.action.admin.indices.exists.indices.IndicesExistsRequest;
 import 
org.elasticsearch.action.admin.indices.exists.indices.IndicesExistsResponse;
 import org.elasticsearch.action.search.SearchRequestBuilder;
@@ -53,151 +50,150 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.InputStream;
 import java.util.List;
-import java.util.Properties;
 
 import static junit.framework.TestCase.assertTrue;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
 
 /**
- * Created by sblackmon on 10/20/14.
+ * Integration Test for
+ * @see org.apache.streams.elasticsearch.ElasticsearchPersistUpdater
  */
 public class ElasticsearchPersistUpdaterIT {
 
-private final static Logger LOGGER = 
LoggerFactory.getLogger(ElasticsearchPersistUpdaterIT.class);
-
-private static ObjectMapper MAPPER = StreamsJacksonMapper.getInstance();
-
-protected ElasticsearchWriterConfiguration testConfiguration;
-protected Client testClient;
-
-@Before
-public void prepareTest() throws Exception {
-
-Config reference  = ConfigFactory.load();
-File conf_file = new 
File("target/test-classes/ElasticsearchPersistUpdaterIT.conf");
-assert(conf_file.exists());
-Config testResourceConfig  = 
ConfigFactory.parseFileAnySyntax(conf_file, 
ConfigParseOptions.defaults().setAllowMissing(false));
-Config typesafe  = 
testResourceConfig.withFallback(reference).resolve();
-testConfiguration = new 
ComponentConfigurator<>(ElasticsearchWriterConfiguration.class).detectConfiguration(typesafe,
 "elasticsearch");
-testClient = new 
ElasticsearchClientManager(testConfiguration).getClient();
-
-ClusterHealthRequest clusterHealthRequest = 
Requests.clusterHealthRequest();
-ClusterHealthResponse clusterHealthResponse = 
testClient.admin().cluster().health(clusterHealthRequest).actionGet();
-assertNotEquals(clusterHealthResponse.getStatus(), 
ClusterHealthStatus.RED);
-
-IndicesExistsRequest indicesExistsRequest = 
Requests.indicesExistsRequest(testConfiguration.getIndex());
-IndicesExistsResponse indicesExistsResponse = 
testClient.admin().indices().exists(indicesExistsRequest).actionGet();
-assertTrue(indicesExistsResponse.isExists());
-
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ElasticsearchPersistUpdaterIT.class);
+
+  private static ObjectMapper MAPPER = StreamsJacksonMapper.getInstance();
+
+