Re: svn commit: r982415 - in /subversion/trunk/subversion/libsvn_ra_serf: commit.c replay.c serf.c update.c

2010-08-04 Thread Daniel Shahaf
rhuij...@apache.org wrote on Wed, Aug 04, 2010 at 22:20:30 -: > Author: rhuijben > Date: Wed Aug 4 22:20:30 2010 > New Revision: 982415 > > URL: http://svn.apache.org/viewvc?rev=982415&view=rev > Log: > Following up on r982398, fix a few more mostly theoretical error leaks. > Thanks; review

svn commit: r982429 - /subversion/trunk/subversion/tests/cmdline/svnrdump_tests.py

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 22:51:01 2010 New Revision: 982429 URL: http://svn.apache.org/viewvc?rev=982429&view=rev Log: * subversion/tests/cmdline/svnrdump_tests.py (test_list): Mark skeleton_load XFail for serf and dav. The loader doesn't drive the commit editor properly yet. (Direc

svn commit: r982417 - /subversion/branches/performance/subversion/libsvn_fs_fs/fs_fs.c

2010-08-04 Thread stefan2
Author: stefan2 Date: Wed Aug 4 22:23:34 2010 New Revision: 982417 URL: http://svn.apache.org/viewvc?rev=982417&view=rev Log: Instead of using plain APR files, use cached file handles for FSFS read operations. * subversion/libsvn_fs_fs/fs_fs.c (DEFAULT_FILE_COOKIE, REF_FILE_COOKIE): define fil

svn commit: r982415 - in /subversion/trunk/subversion/libsvn_ra_serf: commit.c replay.c serf.c update.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 22:20:30 2010 New Revision: 982415 URL: http://svn.apache.org/viewvc?rev=982415&view=rev Log: Following up on r982398, fix a few more mostly theoretical error leaks. * subversion/libsvn_ra_serf/commit.c (create_proppatch_body): Explicitly clear result from

svn propchange: r982386 - svn:log

2010-08-04 Thread rhuijben
Author: rhuijben Revision: 982386 Modified property: svn:log Modified: svn:log at Wed Aug 4 21:57:10 2010 -- --- svn:log (original) +++ svn:log Wed Aug 4 21:57:10 2010 @@ -11,7 +11,12 @@ can still exist when deleted.

svn commit: r982410 - /subversion/trunk/subversion/libsvn_wc/deprecated.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 21:27:58 2010 New Revision: 982410 URL: http://svn.apache.org/viewvc?rev=982410&view=rev Log: * subversion/libsvn_wc/deprecated.c (svn_wc_props_modified_p): Fix error leak. Found by: gstein Modified: subversion/trunk/subversion/libsvn_wc/deprecated.c Modi

svn propchange: r982275 - svn:log

2010-08-04 Thread rhuijben
Author: rhuijben Revision: 982275 Modified property: svn:log Modified: svn:log at Wed Aug 4 21:21:10 2010 -- --- svn:log (original) +++ svn:log Wed Aug 4 21:21:10 2010 @@ -2,4 +2,4 @@ (set_new_dir_to_incomplete_baton_

svn commit: r982398 - in /subversion/trunk/subversion/libsvn_ra_serf: property.c ra_serf.h

2010-08-04 Thread danielsh
Author: danielsh Date: Wed Aug 4 20:49:15 2010 New Revision: 982398 URL: http://svn.apache.org/viewvc?rev=982398&view=rev Log: Plug an ra_serf error leak. * subversion/libsvn_ra_serf/property.c (svn_ra_serf__walk_all_props): Wrap SVN_ERR() around the 'svn_ra_serf__walker_visitor_t walker()

svn commit: r982397 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/deprecated.c libsvn_wc/props.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 20:45:46 2010 New Revision: 982397 URL: http://svn.apache.org/viewvc?rev=982397&view=rev Log: Reintroduce svn_wc_props_modified_p2() to allow cheap access to the wc_db knowledge about whether properties are modified. Clients like TortoiseSVN and AnkhSVN will use t

svn commit: r982391 - in /subversion/branches/performance/subversion: include/svn_io.h libsvn_subr/stream.c

2010-08-04 Thread stefan2
Author: stefan2 Date: Wed Aug 4 20:22:10 2010 New Revision: 982391 URL: http://svn.apache.org/viewvc?rev=982391&view=rev Log: Upon second thought, svn_stream_from_aprfile3 should be renamed to svn_stream_from_cached_file_handle. * subversion/include/svn_io.h (svn_stream_from_cached_file_handl

svn commit: r982386 - /subversion/trunk/subversion/libsvn_client/merge.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 20:08:39 2010 New Revision: 982386 URL: http://svn.apache.org/viewvc?rev=982386&view=rev Log: Remove the assumption that deleted directories must still exist from the merge code in libsvn_client. This fixes several tests for Single-DB. After we switch to single-d

svn propchange: r982365 - svn:log

2010-08-04 Thread rhuijben
Author: rhuijben Revision: 982365 Modified property: svn:log Modified: svn:log at Wed Aug 4 19:46:37 2010 -- --- svn:log (original) +++ svn:log Wed Aug 4 19:46:37 2010 @@ -7,4 +7,5 @@ with proper error messages. * sub

Re: svn commit: r982375 - in /subversion/branches/performance/subversion: include/svn_io.h libsvn_subr/stream.c

2010-08-04 Thread Hyrum K. Wright
On Wed, Aug 4, 2010 at 2:27 PM, wrote: > Author: stefan2 > Date: Wed Aug  4 19:27:41 2010 > New Revision: 982375 > > URL: http://svn.apache.org/viewvc?rev=982375&view=rev > Log: > Introduce a variant of svn_stream_from_aprfile2, that takes cached file > handles > instead of APR file handles. > >

svn commit: r982375 - in /subversion/branches/performance/subversion: include/svn_io.h libsvn_subr/stream.c

2010-08-04 Thread stefan2
Author: stefan2 Date: Wed Aug 4 19:27:41 2010 New Revision: 982375 URL: http://svn.apache.org/viewvc?rev=982375&view=rev Log: Introduce a variant of svn_stream_from_aprfile2, that takes cached file handles instead of APR file handles. * subversion/include/svn_io.h (svn_stream_from_aprfile3): d

svn commit: r982365 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c update_editor.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 19:13:10 2010 New Revision: 982365 URL: http://svn.apache.org/viewvc?rev=982365&view=rev Log: Apply some sanity checks similar to those in svn_wc_add4() to svn_wc_add_repos_file4(). This handles some assertions in Single-DB mode, with proper error messages. * sub

svn commit: r982360 - in /subversion/branches/performance/subversion/libsvn_fs_fs: caching.c fs.h

2010-08-04 Thread stefan2
Author: stefan2 Date: Wed Aug 4 18:56:24 2010 New Revision: 982360 URL: http://svn.apache.org/viewvc?rev=982360&view=rev Log: Introduce a process-global open file handle cache and make it available to FSFS code. A reference in fs_fs_data_t is used instead of a global "svn_get_fh_cache" function

svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c

2010-08-04 Thread stefan2
Author: stefan2 Date: Wed Aug 4 18:43:29 2010 New Revision: 982355 URL: http://svn.apache.org/viewvc?rev=982355&view=rev Log: Fix an issue with fulltext caching already present in production SVN: APR pools often won't reuse memory fragments if they are larger than 80kB. Using string buffers while

svn commit: r982307 - in /subversion/trunk/subversion/libsvn_wc: wc_db.c wc_db.h

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 15:37:45 2010 New Revision: 982307 URL: http://svn.apache.org/viewvc?rev=982307&view=rev Log: Mark two wc__db apis as only being used for a very specific purpose. * subversion/libsvn_wc/wc_db.c (svn_wc__db_temp_base_set_props, svn_wc__db_temp_working_set_pro

svn commit: r982295 - /subversion/trunk/subversion/tests/libsvn_diff/parse-diff-test.c

2010-08-04 Thread dannas
Author: dannas Date: Wed Aug 4 15:19:40 2010 New Revision: 982295 URL: http://svn.apache.org/viewvc?rev=982295&view=rev Log: Add XFailing test for parsing git diffs with spaces in the paths. Note that we only need to parse the '--git diff a/path b/path' line for added and deleted empty files. In

svn commit: r982291 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 15:11:29 2010 New Revision: 982291 URL: http://svn.apache.org/viewvc?rev=982291&view=rev Log: * subversion/libsvn_wc/wc_db.c (*): Replace tabs with whitespace. No functional changes. Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c Modified: subvers

svn propchange: r982283 - svn:log

2010-08-04 Thread rhuijben
Author: rhuijben Revision: 982283 Modified property: svn:log Modified: svn:log at Wed Aug 4 15:01:15 2010 -- --- svn:log (original) +++ svn:log Wed Aug 4 15:01:15 2010 @@ -1,8 +1,10 @@ -In Single-DB make sure that when w

svn commit: r982283 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 15:00:17 2010 New Revision: 982283 URL: http://svn.apache.org/viewvc?rev=982283&view=rev Log: In Single-DB make sure that when we remove a node from wc_db, we also remove all its children. Or re-adding them might give it its children back. * subversion/libsvn_wc/

svn commit: r982275 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 14:56:41 2010 New Revision: 982275 URL: http://svn.apache.org/viewvc?rev=982275&view=rev Log: * subversion/libsvn_wc/wc_db.c (set_new_dir_to_incomplete_baton_txn): Following up on recent discussion, just store infinite depth even though it is mostly equivale

svn commit: r982268 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 14:37:39 2010 New Revision: 982268 URL: http://svn.apache.org/viewvc?rev=982268&view=rev Log: * subversion/libsvn_wc/update_editor.c (close_edit): Disable some code that checks for missing administrative data for single-db, updating the comment to explain th

svn commit: r982267 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 14:36:25 2010 New Revision: 982267 URL: http://svn.apache.org/viewvc?rev=982267&view=rev Log: * subversion/libsvn_wc/update_editor.c (modcheck_found_node): Don't perform expensive checks if we already found a non-delete somewhere else. Modified: subvers

svn commit: r982259 - /subversion/trunk/subversion/tests/cmdline/diff_tests.py

2010-08-04 Thread dannas
Author: dannas Date: Wed Aug 4 14:11:50 2010 New Revision: 982259 URL: http://svn.apache.org/viewvc?rev=982259&view=rev Log: Add XFailing diff test for creating git diffs with added and deleted empty files. The git diff format only displays '---' and '+++' lines if we have text changes. Currently

svn commit: r982256 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/adm_crawler.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 14:08:19 2010 New Revision: 982256 URL: http://svn.apache.org/viewvc?rev=982256&view=rev Log: Add an libsvn_wc api for restoring missing nodes. * subversion/include/svn_wc.h (svn_wc_copy3): Fix reference to latest version. (svn_wc_restore): New function. * s

svn commit: r982248 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2010-08-04 Thread julianfoad
Author: julianfoad Date: Wed Aug 4 13:40:34 2010 New Revision: 982248 URL: http://svn.apache.org/viewvc?rev=982248&view=rev Log: Remove some redundant code. * subversion/libsvn_fs_fs/fs_fs.c (recover_find_max_ids): Don't bother reading the noderev id or creating a noderev structure, as we

svn commit: r982246 - /subversion/trunk/subversion/include/private/svn_wc_private.h

2010-08-04 Thread julianfoad
Author: julianfoad Date: Wed Aug 4 13:32:32 2010 New Revision: 982246 URL: http://svn.apache.org/viewvc?rev=982246&view=rev Log: * subversion/include/private/svn_wc_private.h (svn_wc__node_walk_children): Tweak the doc string. Modified: subversion/trunk/subversion/include/private/svn_wc_pr

svn commit: r982245 - /subversion/branches/1.6.x/STATUS

2010-08-04 Thread stylesen
Author: stylesen Date: Wed Aug 4 13:24:51 2010 New Revision: 982245 URL: http://svn.apache.org/viewvc?rev=982245&view=rev Log: * STATUS: Move r980811 and r981921 groups to the proper block, they were in vetoed block. Modified: subversion/branches/1.6.x/STATUS Modified: subversion/branches

svn commit: r982231 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 12:24:03 2010 New Revision: 982231 URL: http://svn.apache.org/viewvc?rev=982231&view=rev Log: * subversion/libsvn_wc/update_editor.c (complete_directory): Update documentation of root case to document the current state of the code and also handle excluded fi

svn commit: r982224 - /subversion/trunk/subversion/libsvn_wc/node.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 11:46:55 2010 New Revision: 982224 URL: http://svn.apache.org/viewvc?rev=982224&view=rev Log: * subversion/libsvn_wc/node.c (walker_helper): Retrieve status and kind at once instead of in two separate wc_db calls. (svn_wc__temp_get_keep_local): Resolve war

svn commit: r982173 - /subversion/trunk/subversion/svn/log-cmd.c

2010-08-04 Thread rhuijben
Author: rhuijben Date: Wed Aug 4 09:21:13 2010 New Revision: 982173 URL: http://svn.apache.org/viewvc?rev=982173&view=rev Log: * subversion/svn/log-cmd.c (svn_cl__log): Check for paths starting with a '/' instead of using svn_dirent_is_absolute() as a '/a' style path is not absolute on