svn commit: r1555340 - /subversion/trunk/subversion/libsvn_fs_fs/cached_data.c

2014-01-04 Thread stefan2
Author: stefan2 Date: Sat Jan 4 12:03:57 2014 New Revision: 1555340 URL: http://svn.apache.org/r1555340 Log: Follow-up to r1555297: Fix a NULL-pointer access. * subversion/libsvn_fs_fs/cached_data.c (svn_fs_fs__get_file_delta_stream): Check the target's data_rep only

svn commit: r1555350 - /subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread stefan2
Author: stefan2 Date: Sat Jan 4 14:04:36 2014 New Revision: 1555350 URL: http://svn.apache.org/r1555350 Log: Fix segfault in svnmucc. * subversion/libsvn_client/mtcc.c (svn_client_mtcc_commit): We explicitly destroy the MTCC pool and have no knowledge about its

svn commit: r1555403 - in /subversion/trunk: NOTICE subversion/libsvn_subr/version.c

2014-01-04 Thread breser
Author: breser Date: Sat Jan 4 19:02:54 2014 New Revision: 1555403 URL: http://svn.apache.org/r1555403 Log: Happy New Year! * NOTICE: Bump copyright year to 2014. * subversion/libsvn_subr/version.c (svn_version_extended): Bump copyright year to 2014. Modified: subversion/trunk/NOTICE

RE: svn commit: r1555350 -/subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread Bert Huijben
You only know this for the success path. The fs api should hide these details.. There is no way we can document these guarantees for public APIs and really assume that all existing and future users follow all these new requirements for a new Fs layer cache. We had similar caches in the past,

Re: svn commit: r1555350 -/subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread Stefan Fuhrmann
On Sat, Jan 4, 2014 at 9:47 PM, Bert Huijben b...@qqmail.nl wrote: You only know this for the success path. The fs api should hide these details.. With all due respect, the fault is svn_client_mtcc_commit destroying mtcc-pool before destroying mtcc itself (via its owning pool). Hence, the

RE: svn commit: r1555350-/subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread Bert Huijben
There are more users of the commit logic than just our command line tools and libsvn client. The Ra API is a public API that can't just be broken for nicer logic in the Fs layer. Mucc is just another driver of the Ra commit logic. If we have to revert something it would have to be the added

Re: svn commit: r1555350 -/subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread Stefan Fuhrmann
Hi Bert, All your arguments would be valid and I would fully agree with them, if the FS layer was the root cause of the pool issue. However, IMO, that is not the case and r1555297 merely accidentally caused free memory to be reused earlier than before. My understanding of mucc_commit is the

svn commit: r1555440 - /subversion/trunk/tools/server-side/fsfs-stats.c

2014-01-04 Thread stefan2
Author: stefan2 Date: Sun Jan 5 01:04:34 2014 New Revision: 1555440 URL: http://svn.apache.org/r1555440 Log: Fix out-of-array-bounds issue in the fsfs-stats tool when processing format 7 repositories. * tools/server-side/fsfs-stats.c (read_log_rev_or_packfile): Since unused / padding blocks

svn commit: r1555441 - /subversion/trunk/subversion/libsvn_fs_fs/pack.c

2014-01-04 Thread stefan2
Author: stefan2 Date: Sun Jan 5 01:04:53 2014 New Revision: 1555441 URL: http://svn.apache.org/r1555441 Log: * subversion/libsvn_fs_fs/pack.c (auto_pad_block): Fix p2l index entries for unused sections. Modified: subversion/trunk/subversion/libsvn_fs_fs/pack.c Modified: