Re: svn commit: r1911830 - /subversion/branches/1.14.x/STATUS

2023-08-22 Thread Nathan Hartman
On Tue, Aug 22, 2023 at 7:08 PM Nathan Hartman wrote: > > On Mon, Aug 21, 2023 at 12:59 PM Daniel Sahlberg > wrote: >> >> I'm at a loss why the backport.pl script doesn't do the backport of the >> approved r1906502. When running the script manually, it

Re: svn commit: r1911830 - /subversion/branches/1.14.x/STATUS

2023-08-22 Thread Nathan Hartman
On Mon, Aug 21, 2023 at 12:59 PM Daniel Sahlberg < daniel.l.sahlb...@gmail.com> wrote: > I'm at a loss why the backport.pl script doesn't do the backport of the > approved r1906502. When running the script manually, it reports the > candidate changes but nothing under Approved. > > [[[ > svnsvn@sv

Re: svn commit: r1903267 - /subversion/trunk/Makefile.in

2022-08-08 Thread Nathan Hartman
On Sun, Aug 7, 2022 at 6:48 AM wrote: > > Author: futatuki > Date: Sun Aug 7 10:48:25 2022 > New Revision: 1903267 > > URL: http://svn.apache.org/viewvc?rev=1903267&view=rev > Log: > * Makefile.in > (fast-clean, clean-swig-py): Remove __pycache__ directory as well as *.pyc > > Suggested by: har

Re: svn commit: r1902582 - /subversion/trunk/tools/dist/release.py

2022-07-14 Thread Nathan Hartman
On Thu, Jul 14, 2022 at 3:55 PM Daniel Sahlberg wrote: > > Thanks for the review. I've committed a few changes as r1902722. More below. > > Den ons 13 juli 2022 kl 15:57 skrev Daniel Shahaf : >> >> dsahlb...@apache.org wrote on Fri, Jul 08, 2022 at 20:47:42 -: >> > +++ subversion/trunk/tools/d

Re: svn commit: r1902590 - /subversion/trunk/tools/client-side/store-plaintext-password.py

2022-07-14 Thread Nathan Hartman
On Thu, Jul 14, 2022 at 10:02 AM Daniel Sahlberg wrote: > > Den tors 14 juli 2022 kl 15:52 skrev Daniel Shahaf : >> >> Nathan Hartman wrote on Wed, 13 Jul 2022 15:29 +00:00: >> > On Wed, Jul 13, 2022 at 10:55 AM Daniel Shahaf >> > wrote: >>

Re: svn commit: r1902590 - /subversion/trunk/tools/client-side/store-plaintext-password.py

2022-07-13 Thread Nathan Hartman
On Wed, Jul 13, 2022 at 10:55 AM Daniel Shahaf wrote: > > Nathan Hartman wrote on Wed, 13 Jul 2022 13:43 +00:00: > > On Wed, Jul 13, 2022 at 9:33 AM Daniel Shahaf > > wrote: > > > >> dsahlb...@apache.org wrote on Fri, Jul 08, 2022 at 23:39:14 -: > >>

Re: svn commit: r1902590 - /subversion/trunk/tools/client-side/store-plaintext-password.py

2022-07-13 Thread Nathan Hartman
On Wed, Jul 13, 2022 at 9:33 AM Daniel Shahaf wrote: > dsahlb...@apache.org wrote on Fri, Jul 08, 2022 at 23:39:14 -: > > A new script to store/update a password in the plain text password store > > > > * tools/client-side/store-plaintext-password.py > > As above > > > > Discussed on dev@:

Re: svn commit: r1899714 - /subversion/trunk/tools/buildbot/master/README

2022-04-10 Thread Nathan Hartman
On Sun, Apr 10, 2022 at 3:15 PM Daniel Sahlberg wrote: > Den sön 10 apr. 2022 kl 21:11 skrev : > >> Author: dsahlberg >> Date: Sun Apr 10 19:11:45 2022 >> New Revision: 1899714 >> >> URL: http://svn.apache.org/viewvc?rev=1899714&view=rev >> Log: >> Update url to buildbot config repo >> >> * tools

Re: svn commit: r1899431 - /subversion/trunk/tools/dist/README.backport

2022-03-31 Thread Nathan Hartman
On Thu, Mar 31, 2022 at 10:01 AM Daniel Sahlberg wrote: > > Den tors 31 mars 2022 kl 15:24 skrev : >> >> Author: hartmannathan >> Date: Thu Mar 31 13:24:23 2022 >> New Revision: 1899431 >> >> URL: http://svn.apache.org/viewvc?rev=1899431&view=rev >> Log: >> * tools/dist/README.backport: Update nam

Re: svn commit: r1899311 - /subversion/branches/1.14.x/STATUS

2022-03-31 Thread Nathan Hartman
On Thu, Mar 31, 2022 at 9:09 AM Nathan Hartman wrote: > My bad. Hopefully r1899430 fixes it. > > How do I manually run backport.pl? Let me rephrase that question: How do I manually trigger it so we don't have to wait for the cron job? Cheers, Nathan

Re: svn commit: r1899311 - /subversion/branches/1.14.x/STATUS

2022-03-31 Thread Nathan Hartman
On Thu, Mar 31, 2022 at 6:58 AM Mark Phippard wrote: > > Could someone perhaps manually merge this? > > We need the backports working to finish this process and get the release out. > > > On Thu, Mar 31, 2022 at 2:31 AM Daniel Sahlberg > wrote: > > > > Hi, > > > > The backport below is stuck. bac

Re: svn commit: r1899276 - /subversion/site/publish/upcoming.part.html

2022-03-28 Thread Nathan Hartman
On Mon, Mar 28, 2022 at 3:55 AM Daniel Sahlberg wrote: > This commit doesn't look correct. > > I executed the generate-upcoming-changes-log.sh manually yesterday and it > created r1899244, removing a lot of log entries belonging to 1.14.1. This > commit (which was executed by cron) restores them.

Re: svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2022-01-10 Thread Nathan Hartman
On Mon, Jan 10, 2022 at 6:44 AM wrote: > > Author: stsp > Date: Mon Jan 10 11:44:46 2022 > New Revision: 1896877 > > URL: http://svn.apache.org/viewvc?rev=1896877&view=rev > Log: > Fix misleading -r option documentation for some svnadmin subcommands. > > The commands delrevprop, lstxns, rev-size,

Re: svn commit: r1896898 - /subversion/branches/1.14.x/STATUS

2022-01-10 Thread Nathan Hartman
On Mon, Jan 10, 2022 at 4:51 PM Daniel Sahlberg wrote: > > Den mån 10 jan. 2022 kl 22:45 skrev : >> >> Author: dsahlberg >> Date: Mon Jan 10 21:45:27 2022 >> New Revision: 1896898 >> >> URL: http://svn.apache.org/viewvc?rev=1896898&view=rev >> Log: >> * STATUS: Vote for r1896877 (snip) > As far as

Re: svn commit: r1896485 - /subversion/site/staging/download.html

2022-01-06 Thread Nathan Hartman
On Thu, Jan 6, 2022 at 1:17 AM Nathan Hartman wrote: > > On Wed, Jan 5, 2022 at 1:03 PM Daniel Sahlberg > wrote: > > > > I think we should now merge staging => publish, everything looks good to > > me. Do you want to check and do the honors? > > Sure.

Re: svn commit: r1896485 - /subversion/site/staging/download.html

2022-01-05 Thread Nathan Hartman
On Wed, Jan 5, 2022 at 1:03 PM Daniel Sahlberg wrote: > > Den ons 5 jan. 2022 kl 16:22 skrev Nathan Hartman : >> So, I think it might be a good idea to revert this change and let >> Infra manage how they supply those arrays; if it seems as though >> they're provi

Re: svn commit: r1896485 - /subversion/site/staging/download.html

2022-01-05 Thread Nathan Hartman
On Wed, Jan 5, 2022 at 7:45 AM Daniel Sahlberg wrote: > > Den tis 28 dec. 2021 kl 21:14 skrev : >> >> Author: dsahlberg >> Date: Tue Dec 28 20:14:17 2021 >> New Revision: 1896485 >> >> URL: http://svn.apache.org/viewvc?rev=1896485&view=rev >> Log: >> In site/staging: The ASF download script curren

Re: svn commit: r1894491 - /subversion/trunk/INSTALL

2021-10-24 Thread Nathan Hartman
On Fri, Oct 22, 2021 at 2:43 PM wrote: > Add a warning regarding the ZLib ASM "optimizations" that are known to be > buggy. > > * INSTALL: In "Building the Latest Source under Windows" (snip) > + Please note that you MUST NOT build ZLib with the included assembler > + optimized code. I

Re: svn commit: r1891237 - in /subversion/site/staging/docs: ./ api/ api/1.13/ api/1.13/search/ api/1.14/ api/1.14/search/ javahl/ javahl/1.13/ javahl/1.13/org/ javahl/1.13/org/apache/ javahl/1.13/org

2021-07-05 Thread Nathan Hartman
On Mon, Jul 5, 2021 at 9:27 PM Daniel Shahaf wrote: > Daniel Sahlberg wrote on Sat, Jul 03, 2021 at 23:45:01 +0200: > > It seems that the API and JavaHL docs for 1.13 and 1.14 are missing. I > have > > generated them from the branches. > > Are there any relevant differences between the branches (

Re: svn commit: r1889114 - /subversion/trunk/subversion/tests/libsvn_subr/task-test.c

2021-04-22 Thread Nathan Hartman
On Fri, Apr 23, 2021 at 12:59 AM wrote: > Modified: subversion/trunk/subversion/tests/libsvn_subr/task-test.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/task-test.c?rev=1889114&r1=1889113&r2=1889114&view=diff > =

Re: svn commit: r1888589 - in /subversion/trunk: build.conf subversion/tests/libsvn_subr/task-test.c

2021-04-22 Thread Nathan Hartman
On Wed, Apr 21, 2021 at 11:58 PM Daniel Shahaf wrote: > > + partial_result = apr_palloc(result_pool, sizeof(partial_result)); > > s/sizeof(foo)/sizeof(*foo)/, here and later in the function. > > I'm surprised that no one caught this in post-commit reviews. In fact, > I wonder whether people

Re: svn commit: r1870062 - /subversion/site/publish/docs/release-notes/1.14.html

2019-11-21 Thread Nathan Hartman
On Thu, Nov 21, 2019 at 9:09 PM Daniel Shahaf wrote: > hartmannat...@apache.org wrote on Thu, 21 Nov 2019 04:23 +00:00: > > +The convenience script that downloads Subversion's minimal > > +build-time dependencies, get-deps.sh, has been updated to download > > +py3c. This script is found in the so