Re: svn commit: r937524 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/prop_tests.py tests/cmdline/svntest/sandbox.py

2010-05-20 Thread Greg Stein
Thanks for the ping. The patch looks good except for the incoming-delete case. If the svn_string_compare() succeeds, but mine==NULL, then you get the crash. I think the mine==NULL needs to remain on the outer-if test. Other than that... looks great. Commit! Cheers, -g On Thu, May 20, 2010 at

Re: svn commit: r953617 - in /subversion/trunk/subversion/libsvn_wc: merge.c props.c wc-queries.sql wc_db.c wc_db.h workqueue.c workqueue.h

2010-06-11 Thread Greg Stein
On Fri, Jun 11, 2010 at 05:11, rhuij...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_wc/merge.c Fri Jun 11 09:11:14 2010 ... @@ -727,18 +726,16 @@ preserve_pre_merge_files(svn_skel_t **wo                                         target_abspath, result_pool));   *work_items =

Re: svn commit: r1382864 - /subversion/trunk/tools/server-side/svnpubsub/svnwcsub.py

2012-09-10 Thread Greg Stein
On Sep 10, 2012 10:19 AM, danie...@apache.org wrote: Author: danielsh Date: Mon Sep 10 14:18:51 2012 New Revision: 1382864 URL: http://svn.apache.org/viewvc?rev=1382864view=rev Log: [in tools/server-side/svnpubsub] Fix a bogus logging.critical(). Found by: joes * svnwcsub.py

Re: svn commit: r1295287 - /subversion/trunk/subversion/libsvn_delta/compat.c

2012-02-29 Thread Greg Stein
On Feb 29, 2012 4:28 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Wed, Feb 29, 2012 at 3:25 PM, hwri...@apache.org wrote: Author: hwright Date: Wed Feb 29 21:25:19 2012 New Revision: 1295287 URL: http://svn.apache.org/viewvc?rev=1295287view=rev Log: Ev2 shims: Improve

Re: svn commit: r1298548 - /subversion/site/publish/download/download.html

2012-03-08 Thread Greg Stein
Way ahead of you :-) r1298552 On Thu, Mar 8, 2012 at 15:09, Hyrum K Wright hyrum.wri...@wandisco.com wrote: Since much of this content is autogenerated from tools/dist/templates/download.ezt, you should probably update it, too. -Hyrum On Thu, Mar 8, 2012 at 2:02 PM,  gst...@apache.org

Re: svn commit: r1301511 - /subversion/trunk/Makefile.in

2012-03-16 Thread Greg Stein
We should get rid of most of these fine-grained targets. They add silly complexity. extraclean-swig-py vs extraclean-swig-pl. Really?! How about just: extraclean. Seriously. It is generally a bad idea to extraclean just a portion of the tree. You could throw away outputs from gen-make, autoconf,

Re: svn commit: r1327979 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_fs/fs-loader.c libsvn_repos/fs-wrap.c mod_dav_svn/repos.c

2012-04-19 Thread Greg Stein
On Apr 19, 2012 11:02 AM, phi...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_fs/fs-loader.c Thu Apr 19 15:02:17 2012 ... + if (kind == svn_node_dir) +{ + svn_error_clear(err); + *fs_type = apr_pstrdup(pool, SVN_FS_TYPE_BDB); + return

Re: svn commit: r1331652 - /subversion/trunk/subversion/libsvn_delta/compat.c

2012-04-30 Thread Greg Stein
On Apr 30, 2012 9:38 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: ... +/* Insert a new change for RELPATH, or return an existing one. */ +static struct change_node * +insert_change(const char *relpath, + apr_hash_t *changes) +{ + apr_pool_t *result_pool; +

Re: svn commit: r1032847 - /subversion/trunk/COMMITTERS

2010-11-08 Thread Greg Stein
-8] Tue Nov  9 05:38:04 2010 @@ -14,7 +14,7 @@ Blanket commit access:         kfogel   Karl Fogel kfo...@red-bean.com         gstein   Greg Stein gst...@gmail.com          brane   Branko Čibej br...@xbc.nu -           joe   Joe Orton j...@manyfish.co.uk +        jorton   Joe Orton j

Re: svn commit: r1103765 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h tests/libsvn_wc/db-test.c tests/libsvn_wc/op-depth-test.c

2011-05-17 Thread Greg Stein
On May 16, 2011 11:36 AM, Hyrum K Wright hy...@hyrumwright.org wrote: On Mon, May 16, 2011 at 3:24 PM, stef...@apache.org wrote: Author: stefan2 Date: Mon May 16 15:24:59 2011 New Revision: 1103765 URL: http://svn.apache.org/viewvc?rev=1103765view=rev Log: Finding the w/c base

Re: svn commit: r1496127 - /subversion/trunk/subversion/tests/cmdline/checkout_tests.py

2013-06-25 Thread Greg Stein
On Tue, Jun 25, 2013 at 6:54 PM, Daniel Shahaf danie...@elego.de wrote: Philip Martin wrote on Tue, Jun 25, 2013 at 10:08:38 +0100: Daniel Shahaf danie...@apache.org writes: - # note the current time to use it as peg revision date. - current_time = time.strftime(%Y-%m-%dT%H:%M:%S) +

Re: svn commit: r1497975 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_subr/config_file.c

2013-06-29 Thread Greg Stein
On Sat, Jun 29, 2013 at 3:05 PM, Ivan Zhakov i...@visualsvn.com wrote: On Saturday, June 29, 2013, wrote: Author: gstein Date: Sat Jun 29 02:00:07 2013 New Revision: 1497975 URL: http://svn.apache.org/r1497975 Log: Switch the config name and semantics to busted-proxy. For now, it

Re: svn commit: r1499747 - /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c

2013-07-05 Thread Greg Stein
On Thu, Jul 4, 2013 at 5:51 PM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: phi...@apache.org [mailto:phi...@apache.org] Sent: donderdag 4 juli 2013 15:22 To: commits@subversion.apache.org Subject: svn commit: r1499747 -

Re: svn commit: r1502401 - in /subversion/branches/tristate-chunked-request/subversion: include/svn_config.h libsvn_ra_serf/serf.c libsvn_ra_serf/util.c libsvn_subr/config_file.c

2013-07-11 Thread Greg Stein
On Thu, Jul 11, 2013 at 8:11 PM, bre...@apache.org wrote: Author: breser Date: Fri Jul 12 00:11:48 2013 New Revision: 1502401 URL: http://svn.apache.org/r1502401 Log: Reimplement the tristate http-chunked-requests config option on top of the latest trunk implementation of boolean

Re: svn commit: r1502440 - in /subversion/branches/1.8.x-tristate-chunked-request: ./ subversion/libsvn_ra_serf/serf.c subversion/libsvn_ra_serf/util.c subversion/libsvn_subr/config_file.c

2013-07-12 Thread Greg Stein
On Fri, Jul 12, 2013 at 2:53 AM, bre...@apache.org wrote: ... +++ subversion/branches/1.8.x-tristate-chunked-request/subversion/libsvn_ra_serf/serf.c Fri Jul 12 06:53:40 2013 ... @@ -293,12 +293,11 @@ load_config(svn_ra_serf__session_t *sess

Re: svn propchange: r871982 - svn:author

2009-11-20 Thread Greg Stein
I don't recall ANY discussion of rewriting history. I'm somewhat peeved. -g On Nov 20, 2009 5:40 PM, hwri...@apache.org wrote: Author: hwright Revision: 871982 Modified property: svn:author Modified: svn:author at Fri Nov 20 22:39:39 2009

Re: svn commit: r921716 - /subversion/trunk/subversion/libsvn_subr/mergeinfo.c

2010-03-11 Thread Greg Stein
On Thu, Mar 11, 2010 at 03:08, julianf...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_subr/mergeinfo.c Thu Mar 11 08:08:06 2010 ... @@ -1311,23 +1309,20 @@ svn_mergeinfo_intersect2(svn_mergeinfo_t   for (hi = apr_hash_first(apr_hash_pool_get(mergeinfo1), mergeinfo1);        

Re: RE: svn commit: r926814 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c update_editor.c workqueue.c

2010-03-23 Thread Greg Stein
Yup. Thanks. Saw this before heading to dinner, thinking it was due to new changes. Realized no about 15 minutes ago. Will fix ASAP. On Mar 23, 2010 9:12 PM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: gst...@apache.org [mailto:gst...@apache.org] Sent: dinsdag ...