Author: stefan2
Date: Tue Jan 6 16:36:20 2015
New Revision: 1649868
URL: http://svn.apache.org/r1649868
Log:
Get rid of a small non-static DAG function in FSX and merge it
with its sole caller.
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_dir_entries): Remove.
* subversion/libsvn_fs_x/dag.c
Author: stefan2
Date: Tue Jan 6 16:42:19 2015
New Revision: 1649870
URL: http://svn.apache.org/r1649870
Log:
Remove an unused POOL parameter and update code along the call stack.
* subversion/libsvn_fs_x/fs_x.c
(svn_fs_x__file_length): We don't need the POOL.
* subversion/libsvn_fs_x/f
Author: stefan2
Date: Tue Jan 6 16:45:03 2015
New Revision: 1649872
URL: http://svn.apache.org/r1649872
Log:
Function signatures in FSX should use consistent formatting with the result
type and each parameter on a separate line. Fix this for fs.c .
No functional change.
* subversion
Author: stefan2
Date: Fri Jan 9 14:19:35 2015
New Revision: 1650538
URL: http://svn.apache.org/r1650538
Log:
In FSX, a noderev's predecessor count is always known. There is no need
to handle "unknown" values.
This is a remnant of BDB carried over from FSFS. The situation in F
Author: stefan2
Date: Fri Jan 9 15:51:37 2015
New Revision: 1650580
URL: http://svn.apache.org/r1650580
Log:
Function signatures in FSX should use consistent formatting with the result
type and each parameter on a separate line.
Apply this rule to the remainder of FSX. No functional change
Author: stefan2
Date: Sat Jan 10 23:46:28 2015
New Revision: 1650834
URL: http://svn.apache.org/r1650834
Log:
Fix stringbuf insertion and replacement for the case that the source is
within the target string itself and contains NUL chars. Also, make the
test cases cover data containing NUL for
Author: stefan2
Date: Sat Jan 10 23:52:34 2015
New Revision: 1650835
URL: http://svn.apache.org/r1650835
Log:
* subversion/libsvn_subr/string.c
(svn_stringbuf_insert,
svn_stringbuf_replace): Get rid of the recursive call.
Suggested by: julianfoad
Modified:
subversion/trunk/subversion
Author: stefan2
Date: Sun Jan 11 00:10:13 2015
New Revision: 1650837
URL: http://svn.apache.org/r1650837
Log:
* STATUS: Nominate r1650834.
Modified:
subversion/branches/1.8.x/STATUS
Modified: subversion/branches/1.8.x/STATUS
URL:
http://svn.apache.org/viewvc/subversion/branches/1.8.x
Author: stefan2
Date: Sun Jan 11 00:26:08 2015
New Revision: 1650838
URL: http://svn.apache.org/r1650838
Log:
Add docstrings to a ton of functions in FSX/utils.h where they are missing
and correct a couple of others.
* subversion/libsvn_fs_x/util.h
(svn_fs_x__packed_base_rev): Correct the
Author: stefan2
Date: Sun Jan 11 00:48:58 2015
New Revision: 1650840
URL: http://svn.apache.org/r1650840
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 01:00:09 2015
New Revision: 1650842
URL: http://svn.apache.org/r1650842
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 01:09:52 2015
New Revision: 1650843
URL: http://svn.apache.org/r1650843
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Author: stefan2
Date: Sun Jan 11 01:14:40 2015
New Revision: 1650844
URL: http://svn.apache.org/r1650844
Log:
* subversion/libsvn_fs_x/index.c
(l2p_page_get_offset): POOL is actually a SCRATCH_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x/index.c
Modified: subversion/trunk
Author: stefan2
Date: Sun Jan 11 01:28:02 2015
New Revision: 1650849
URL: http://svn.apache.org/r1650849
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 01:32:12 2015
New Revision: 1650850
URL: http://svn.apache.org/r1650850
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Author: stefan2
Date: Sun Jan 11 01:57:45 2015
New Revision: 1650854
URL: http://svn.apache.org/r1650854
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 02:00:40 2015
New Revision: 1650855
URL: http://svn.apache.org/r1650855
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Author: stefan2
Date: Sun Jan 11 02:08:10 2015
New Revision: 1650856
URL: http://svn.apache.org/r1650856
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this fo
Author: stefan2
Date: Sun Jan 11 02:10:16 2015
New Revision: 1650857
URL: http://svn.apache.org/r1650857
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 02:35:22 2015
New Revision: 1650858
URL: http://svn.apache.org/r1650858
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Author: stefan2
Date: Sun Jan 11 02:37:11 2015
New Revision: 1650859
URL: http://svn.apache.org/r1650859
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Author: stefan2
Date: Sun Jan 11 02:38:26 2015
New Revision: 1650860
URL: http://svn.apache.org/r1650860
Log:
* subversion/libsvn_fs_x/temp_serializer.c
(serialize_dir): POOL is actually a SCRATCH_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x/temp_serializer.c
Modified
Author: stefan2
Date: Sun Jan 11 02:48:03 2015
New Revision: 1650861
URL: http://svn.apache.org/r1650861
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 03:01:41 2015
New Revision: 1650863
URL: http://svn.apache.org/r1650863
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do this for
Author: stefan2
Date: Sun Jan 11 20:22:30 2015
New Revision: 1650960
URL: http://svn.apache.org/r1650960
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Modified: subversion/trunk/subversion/libsvn_fs_x/transaction.h
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/transaction.h?rev=1650960&r1=1650959&r2=1650960&view=diff
==
--- subversion/trunk/su
Author: stefan2
Date: Sun Jan 11 20:35:33 2015
New Revision: 1650963
URL: http://svn.apache.org/r1650963
Log:
Continue migrating FSX to the two-pool paradigm. Many single-pool functions
don't allocate a return value, i.e. their pools can immediately be renamed
to SCRATCH_POOL. Do thi
Author: stefan2
Date: Sun Jan 11 20:39:37 2015
New Revision: 1650965
URL: http://svn.apache.org/r1650965
Log:
* subversion/libsvn_fs_x/fs.c
(x_freeze_body,
x_freeze_body2,
x_freeze): The POOL passed to "with lock" functions is a SCRATCH_POOL.
Modified:
subversion/trunk/
Author: stefan2
Date: Sun Jan 11 21:08:55 2015
New Revision: 1650970
URL: http://svn.apache.org/r1650970
Log:
* subversion/libsvn_fs_x/fs_id.c
(id_unparse): This POOL is exclusively used as a RESULT_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x/fs_id.c
Modified: subversion/trunk
Author: stefan2
Date: Tue Jan 13 00:03:45 2015
New Revision: 1651239
URL: http://svn.apache.org/r1651239
Log:
Gone through FSX/util.* and identified the functions that construct their
return value without the need of temporaries. Name their pool parameters
result_pool as per our two pool
Author: stefan2
Date: Tue Jan 13 00:25:20 2015
New Revision: 1651244
URL: http://svn.apache.org/r1651244
Log:
In FSX, the container object constructors don't create temporary data,
so their pool parameter shall be named result_pool.
* subversion/libsvn_fs_x/noder
Author: stefan2
Date: Tue Jan 13 00:54:15 2015
New Revision: 1651249
URL: http://svn.apache.org/r1651249
Log:
Some of the revprops code in FSX already uses the two-pool paradigm
but still calls the result pool simply "pool". Fix that.
* subversion/libsvn_fs_x/revprops.c
(par
Author: stefan2
Date: Tue Jan 13 01:07:39 2015
New Revision: 1651253
URL: http://svn.apache.org/r1651253
Log:
Continue migrating FSX to the two-pool paradigm. Some single-pool functions
don't allocate temporary data, i.e. their pools can immediately be renamed
to RESULT_POOL. Do this for
Author: stefan2
Date: Tue Jan 13 01:16:12 2015
New Revision: 1651255
URL: http://svn.apache.org/r1651255
Log:
In FSX, move path constructor function declarations from fs_x.h to util.h .
Their implementations are already in utils.c
* subversion/libsvn_fs_x/fs_x.h
(svn_fs_x__path_rev_absolute
Author: stefan2
Date: Tue Jan 13 01:18:33 2015
New Revision: 1651257
URL: http://svn.apache.org/r1651257
Log:
* subversion/libsvn_fs_x/fs_x.h
(svn_fs_x__ensure_revision_exists): Remove this unused function declaration.
There is no implementation.
Modified
Author: stefan2
Date: Tue Jan 13 01:21:37 2015
New Revision: 1651258
URL: http://svn.apache.org/r1651258
Log:
* subversion/libsvn_fs_x/id.c
(svn_fs_x__id_unparse): The POOL is a RESULT_POOL.
* subversion/libsvn_fs_x/id.h
(svn_fs_x__id_unparse): Make the header match the source.
Modified
Author: stefan2
Date: Tue Jan 13 01:24:19 2015
New Revision: 1651259
URL: http://svn.apache.org/r1651259
Log:
* subversion/libsvn_fs_x/hotcopy.c
(hotcopy_incremental_check_preconditions): Remove unused POOL parameter.
(svn_fs_x__hotcopy_prepare_target): Update caller.
Modified
Author: stefan2
Date: Tue Jan 13 01:26:57 2015
New Revision: 1651260
URL: http://svn.apache.org/r1651260
Log:
* subversion/libsvn_fs_x/low_level.c
(auto_escape_path,
auto_unescape_path): The POOL parameter is a pure RESULT_POOL.
Add missing docstrings.
Modified
Author: stefan2
Date: Tue Jan 13 01:40:37 2015
New Revision: 1651262
URL: http://svn.apache.org/r1651262
Log:
* subversion/libsvn_fs_x/index.c
(svn_fs_x__p2l_entry_dup): The POOL is a pure RESULT_POOL.
Simplify copy code.
* subversion/libsvn_fs_x/index.h
Author: stefan2
Date: Tue Jan 13 16:36:41 2015
New Revision: 1651401
URL: http://svn.apache.org/r1651401
Log:
* subversion/libsvn_fs_x/cached_data.c
(open_and_seek_revision,
open_and_seek_transaction,
open_and_seek_representation): Switch these internal functions to using
Author: stefan2
Date: Tue Jan 13 16:40:43 2015
New Revision: 1651402
URL: http://svn.apache.org/r1651402
Log:
Follow-up to r1651401: Remove redundant a function call.
This also fixes the build.
* subversion/libsvn_fs_x/cached_data.c
(get_node_revision_body): The REVISION_FILE has already been
Author: stefan2
Date: Wed Jan 14 01:09:09 2015
New Revision: 1651546
URL: http://svn.apache.org/r1651546
Log:
Make the next non-trivial function in FSX/cached_data.h comply to the
two pool paradigm. Although the signature does not change, getting
the pool usage right has a knock-on effect down
Author: stefan2
Date: Wed Jan 14 01:28:46 2015
New Revision: 1651548
URL: http://svn.apache.org/r1651548
Log:
Fix pool usage issues in FSX verification code.
* subversion/libsvn_fs_x/verify.c
(compare_p2l_to_l2p_index): Nested loops require seperate iterpools
Author: stefan2
Date: Wed Jan 14 01:32:05 2015
New Revision: 1651550
URL: http://svn.apache.org/r1651550
Log:
* subversion/libsvn_fs_x/util.c
(svn_fs_x__path_rev_shard,
svn_fs_x__path_revprops_shard): Use an itoa function that does not
allocate a temporary
Author: stefan2
Date: Wed Jan 14 16:37:32 2015
New Revision: 1651726
URL: http://svn.apache.org/r1651726
Log:
Fix the error formatting in svnserve's logger.
* subversion/svnserve/logger.c
(logger__log_error): Actually write the newline to the stream.
Modified:
subversion/trunk/subve
Author: stefan2
Date: Fri Jan 16 16:47:26 2015
New Revision: 1652451
URL: http://svn.apache.org/r1652451
Log:
Follow-up to r1652076: Fix same problem for L2P as well.
* subversion/libsvn_fs_fs/index.c
(svn_fs_fs__l2p_index_append): Be sure to use 64 bit offsets for the
Author: stefan2
Date: Fri Jan 16 16:48:04 2015
New Revision: 1652452
URL: http://svn.apache.org/r1652452
Log:
Remove a function declaration from FSX/dag.h that is not used outside dag.c .
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_delete_if_mutable): Remove from header.
* subversion
Author: stefan2
Date: Fri Jan 16 16:49:01 2015
New Revision: 1652453
URL: http://svn.apache.org/r1652453
Log:
Code formatting fixes. No functional change.
* subversion/libsvn_fs_x/fs_x.c
(verify_block_size): Remove superfluous line break.
* subversion/libsvn_fs_x/recovery.c
(recover_body
Author: stefan2
Date: Fri Jan 16 16:49:43 2015
New Revision: 1652455
URL: http://svn.apache.org/r1652455
Log:
* subversion/libsvn_fs_x/revprops.c
(parse_revprop): Use the SCRATCH_POOL where no result data is being
constructed.
Modified:
subversion/trunk/subversion
Author: stefan2
Date: Fri Jan 16 16:49:59 2015
New Revision: 1652456
URL: http://svn.apache.org/r1652456
Log:
Key / ID processing in FSX is much simpler these days. They are no longer
strings that need to be allocated.
* subversion/libsvn_fs_x/transaction.c
(get_and_increment_txn_key_baton
Author: stefan2
Date: Fri Jan 16 16:49:27 2015
New Revision: 1652454
URL: http://svn.apache.org/r1652454
Log:
Remove unused POOL parameters from static functions in FSX/lock.c.
* subversion/libsvn_fs_x/lock.c
(hash_fetch): Drop POOL parameter.
(read_digest_file): Update caller
Author: stefan2
Date: Fri Jan 16 16:50:35 2015
New Revision: 1652457
URL: http://svn.apache.org/r1652457
Log:
Most path constructors in FSX are glorified svn_dirent_join_many calls.
If it can be helped, we should not allocate temporary buffers. This will
allow us to stick with a single pool
Author: stefan2
Date: Fri Jan 16 17:14:22 2015
New Revision: 1652461
URL: http://svn.apache.org/r1652461
Log:
Follow-up to r1652457: Fix Windows build.
* subversion/libsvn_fs_x/util.c
(construct_txn_path): Use sizeof instead of strlen to determine an upper
limit to the
Author: stefan2
Date: Fri Jan 16 17:32:55 2015
New Revision: 1652469
URL: http://svn.apache.org/r1652469
Log:
Continue work on FSX's path constructors.
In this patch, get rid of the temporary buffers for files in sharded
directories.
* subversion/libsvn_fs_x/util.c
(construct_shard_sub
Author: stefan2
Date: Fri Jan 16 18:23:14 2015
New Revision: 1652477
URL: http://svn.apache.org/r1652477
Log:
Follow-up to r1652469: Fix the revision / revprop file name construction.
* subversion/libsvn_fs_x/util.c
(svn_fs_x__path_rev): The rev - not the shard - shall be the file name
Author: stefan2
Date: Fri Jan 16 18:23:27 2015
New Revision: 1652478
URL: http://svn.apache.org/r1652478
Log:
Fix an assertion triggered in FSX.
* subversion/libsvn_fs_x/recovery.c
(recover_body): Don't try to access packed revprops as non-packed.
Trying to construc
Author: stefan2
Date: Fri Jan 16 18:25:08 2015
New Revision: 1652479
URL: http://svn.apache.org/r1652479
Log:
* subversion/libsvn_fs_x/util.c
(svn_fs_x__path_rev_absolute): Toggle condition to avoid negation.
Modified:
subversion/trunk/subversion/libsvn_fs_x/util.c
Modified: subversion
Author: stefan2
Date: Fri Jan 16 18:32:12 2015
New Revision: 1652481
URL: http://svn.apache.org/r1652481
Log:
* subversion/libsvn_fs_x/util.c
(svn_fs_x__path_rev_shard,
svn_fs_x__path_revprops_shard): Simplify using the new path construction
utility
Author: stefan2
Date: Fri Jan 16 18:46:49 2015
New Revision: 1652488
URL: http://svn.apache.org/r1652488
Log:
Continue work on FSX's path constructors.
In this patch, get rid of the temporary buffers in the proto-rev file
path constructors.
* subversion/libsvn_fs_x/u
Author: stefan2
Date: Fri Jan 16 19:20:55 2015
New Revision: 1652496
URL: http://svn.apache.org/r1652496
Log:
Deal with the last set of path constructors in FSX. The temporary strings
they create cannot be eliminated reasonably, therefore swtich the functions
to using two pools and update the
Author: stefan2
Date: Fri Jan 16 19:25:45 2015
New Revision: 1652499
URL: http://svn.apache.org/r1652499
Log:
Fix a theoretical overflow issue with the path constructor buffers.
Those buffers are large enough to never overflow under correct usage.
However, we use strncpy to prevent overflow even
Author: stefan2
Date: Fri Jan 16 19:35:15 2015
New Revision: 1652502
URL: http://svn.apache.org/r1652502
Log:
Switch the last function in FSX/utils.* to using two-pool paradigm compliant
parameter names.
* subversion/libsvn_fs_x/util.c
(svn_fs_x__check_file_buffer_numeric): The POOL is a
Author: stefan2
Date: Fri Jan 16 19:36:48 2015
New Revision: 1652504
URL: http://svn.apache.org/r1652504
Log:
In FSX, structs shall have a "_t" suffix and a typedef for simplicity.
Fix a local struct that violates this.
* subversion/libsvn_fs_x/cached_data.c
(rep_read_baton):
Author: stefan2
Date: Fri Jan 16 19:41:29 2015
New Revision: 1652505
URL: http://svn.apache.org/r1652505
Log:
In FSX, structs shall have a "_t" suffix and a typedef for simplicity.
Fix this for another struct in cached_data that violates it.
* subversion/libsvn_fs_x/cac
Author: stefan2
Date: Fri Jan 16 19:56:00 2015
New Revision: 1652510
URL: http://svn.apache.org/r1652510
Log:
In FSX, typedef a bunch of structs that are already named correctly but are
missing a typedef. Remove the "struct " prefix everywhere they get used.
* subversion/libsvn_fs_x
Author: stefan2
Date: Fri Jan 16 20:21:28 2015
New Revision: 1652521
URL: http://svn.apache.org/r1652521
Log:
In FSX, structs shall have a "_t" suffix and a typedef for simplicity.
Fix this for the baton types that violate it in lock.c.
* subversion/libsvn_fs_x/lock.c
(walk_l
Author: stefan2
Date: Fri Jan 16 20:29:48 2015
New Revision: 1652522
URL: http://svn.apache.org/r1652522
Log:
In FSX, structs shall have a "_t" suffix and a typedef for simplicity.
Fix this for the baton types that violate it in transaction.c.
* subversion/libsvn_fs_x/tra
Author: stefan2
Date: Fri Jan 16 20:40:52 2015
New Revision: 1652524
URL: http://svn.apache.org/r1652524
Log:
In FSX, structs shall have a "_t" suffix and a typedef for simplicity.
Fix this for remaining baton structs that violate it in FSX.
* subversion/libsvn_f
Author: stefan2
Date: Sat Jan 17 11:21:00 2015
New Revision: 1652579
URL: http://svn.apache.org/r1652579
Log:
Rename a pool parameter.
* subversion/libsvn_fs_x/cached_data.c
(init_rep_state): This POOL is a pure RESULT_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x/cached_data.c
Author: stefan2
Date: Sat Jan 17 11:23:41 2015
New Revision: 1652580
URL: http://svn.apache.org/r1652580
Log:
* subversion/libsvn_fs_x/cached_data.c
(cache_windows): Fix pool usage. Within the loop, use the ITERPOOL.
The parameter is a SCRATCH_POOL.
Modified:
subversion
Author: stefan2
Date: Sat Jan 17 11:30:03 2015
New Revision: 1652581
URL: http://svn.apache.org/r1652581
Log:
In FSX/dag.c, switch make_entry() to the 2-pool paradigm.
Propagate that change along the call stack.
* subversion/libsvn_fs_x/dag.c
(make_entry): Use two pools now
Author: stefan2
Date: Sat Jan 17 11:53:02 2015
New Revision: 1652585
URL: http://svn.apache.org/r1652585
Log:
In FSX, switch svn_fs_x__dag_clone_child() to the 2-pool paradigm.
Propagate that change along the call stack.
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_clone_child): Change
Author: stefan2
Date: Sat Jan 17 12:09:55 2015
New Revision: 1652586
URL: http://svn.apache.org/r1652586
Log:
Switch the last function in FSX/rep-cache to using the 2-pool paradigm.
* subversion/libsvn_fs_x/rep-cache.h
(svn_fs_x__get_rep_reference): Switch declaration to the new paradigm
Author: stefan2
Date: Sat Jan 17 12:22:02 2015
New Revision: 1652590
URL: http://svn.apache.org/r1652590
Log:
In FSX, switch svn_fs_x__get_proplist() to the 2-pool paradigm.
Propagate that change along the call stack.
* subversion/libsvn_fs_x/cached_data.h
(svn_fs_x__get_proplist): Switch
Author: stefan2
Date: Sat Jan 17 12:27:43 2015
New Revision: 1652592
URL: http://svn.apache.org/r1652592
Log:
* subversion/libsvn_fs_x/cached_data.c
(skip_contents): Fix no-op typo.
Modified:
subversion/trunk/subversion/libsvn_fs_x/cached_data.c
Modified: subversion/trunk/subversion
Author: stefan2
Date: Sat Jan 17 12:27:57 2015
New Revision: 1652593
URL: http://svn.apache.org/r1652593
Log:
Sub-pools that have been introduced as a stand-in for a scratch pool that
is simply not provided by the FS API, shall be named SCRATCH_POOL.
* subversion/libsvn_fs_x/tree.c
Author: stefan2
Date: Sat Jan 17 20:25:48 2015
New Revision: 1652664
URL: http://svn.apache.org/r1652664
Log:
Make FSX revision roots lightweight objects.
The DAG node for the revision's root directory is easy to construct,
relatively large and rarely used. Therefore, don't store
Author: stefan2
Date: Sat Jan 17 20:33:25 2015
New Revision: 1652666
URL: http://svn.apache.org/r1652666
Log:
Since r1652664, the only caller of svn_fs_x__dag_revision_root uses
pre-checked revision numbers, we can simplify its code and the pool
parameter becomes a pure result pool.
* subversion
Author: stefan2
Date: Sat Jan 17 20:35:30 2015
New Revision: 1652667
URL: http://svn.apache.org/r1652667
Log:
Eliminate svn_fs_x__rev_get_root by merging it with its only remaining caller.
* subversion/libsvn_fs_x/cached_data.c
(svn_fs_x__rev_get_root): Remove.
* subversion/libsvn_fs_x
Author: stefan2
Date: Sat Jan 17 20:41:44 2015
New Revision: 1652669
URL: http://svn.apache.org/r1652669
Log:
Eliminate an intermediate allocation.
* subversion/libsvn_fs_x/tree.c
(make_txn_root): For this type of cache, ID is a mere debugging feature.
So, a more readily
Author: stefan2
Date: Sat Jan 17 20:42:56 2015
New Revision: 1652671
URL: http://svn.apache.org/r1652671
Log:
* subversion/libsvn_fs_x/tree.c
(make_root,
make_revision_root,
make_txn_root): The POOL parameter is a pure RESULT_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x
Author: stefan2
Date: Sat Jan 17 20:50:56 2015
New Revision: 1652673
URL: http://svn.apache.org/r1652673
Log:
* subversion/libsvn_fs_x/tree.c
(increment_mergeinfo_up_tree): As per our pool usage pattern, loops
shall use ITERPOOLs. Fit it here.
Modified
Author: stefan2
Date: Sat Jan 17 20:58:09 2015
New Revision: 1652675
URL: http://svn.apache.org/r1652675
Log:
* subversion/libsvn_fs_x/tree.c
(x_get_file_delta_stream): Actually use the SCRATCH_POOL.
Modified:
subversion/trunk/subversion/libsvn_fs_x/tree.c
Modified: subversion/trunk
Author: stefan2
Date: Sat Jan 17 20:58:41 2015
New Revision: 1652676
URL: http://svn.apache.org/r1652676
Log:
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_txn_root): Sync header with implementation.
Modified:
subversion/trunk/subversion/libsvn_fs_x/dag.h
Modified: subversion/trunk
Author: stefan2
Date: Sat Jan 17 21:03:52 2015
New Revision: 1652677
URL: http://svn.apache.org/r1652677
Log:
Switch svn_fs_x__dag_txn_base_root to the 2-pool paradigm.
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_txn_base_root): Switch signature to new paradigm.
* subversion/libsvn_fs_x
Author: stefan2
Date: Sat Jan 17 21:53:58 2015
New Revision: 1652680
URL: http://svn.apache.org/r1652680
Log:
* subversion/libsvn_fs_x/dag.c
(delete_if_mutable): svn_fs_x__dag_dir_entries can never return NULL,
so don't check for it.
Modified:
subversion/
Author: stefan2
Date: Sat Jan 17 21:54:11 2015
New Revision: 1652681
URL: http://svn.apache.org/r1652681
Log:
Tighten memory usage in FSX' svn_fs_dir_entries implementation.
* subversion/libsvn_fs_x/tree.c
(x_dir_entries): Introduce a SCRATCH_POOL and fetch the directory i
Author: stefan2
Date: Sat Jan 17 21:55:58 2015
New Revision: 1652682
URL: http://svn.apache.org/r1652682
Log:
* subversion/libsvn_fs_x/tree.c
(root_node,
verify_node): Code formatting fixes. No functional change.
Modified:
subversion/trunk/subversion/libsvn_fs_x/tree.c
Modified
Author: stefan2
Date: Sat Jan 17 22:01:03 2015
New Revision: 1652683
URL: http://svn.apache.org/r1652683
Log:
Switch svn_fs_x__dag_dir_entries to using the 2-pool paradigm.
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_dir_entries): Change the signature to the new paradigm.
* subversion
Author: stefan2
Date: Sat Jan 17 22:04:53 2015
New Revision: 1652685
URL: http://svn.apache.org/r1652685
Log:
Follow-up to r1652683: Fix build by updating forgotten callers.
* subversion/libsvn_fs_x/dag.c
(delete_if_mutable): Provide a scratch pool to svn_fs_x__dag_dir_entries.
* subversion
Author: stefan2
Date: Sat Jan 17 22:15:20 2015
New Revision: 1652686
URL: http://svn.apache.org/r1652686
Log:
svn_fs_x__get_contents only needs a single pool. Propagate up the call stack.
* subversion/libsvn_fs_x/cached_data.h
(svn_fs_x__get_contents): Sync declaration with its definition
Author: stefan2
Date: Sat Jan 17 22:37:51 2015
New Revision: 1652687
URL: http://svn.apache.org/r1652687
Log:
In svn_fs_x__dag_try_process_file_contents, bubble up pool naming from called
functions.
* subversion/libsvn_fs_x/dag.c
(svn_fs_x__dag_try_process_file_contents): POOL is actually a
Author: stefan2
Date: Sat Jan 17 22:52:17 2015
New Revision: 1652691
URL: http://svn.apache.org/r1652691
Log:
File node edit streams in FSX can be created without temporary objects.
Hence, its all RESULT_POOLs.
* subversion/libsvn_fs_x/transaction.c
(rep_write_get_baton): All allocations must
Author: stefan2
Date: Sat Jan 17 22:58:35 2015
New Revision: 1652692
URL: http://svn.apache.org/r1652692
Log:
Rename a misleadingly named SCRATCH_POOL struct member.
* subversion/libsvn_fs_x/transaction.c
(rep_write_baton_t): Rename our local pool to LOCAL_POOL.
(rep_write_cleanup
Author: stefan2
Date: Sat Jan 17 22:59:40 2015
New Revision: 1652693
URL: http://svn.apache.org/r1652693
Log:
* subversion/libsvn_fs_x/dag.h
(svn_fs_x__dag_get_edit_stream): Remove obsolete pool reference from
docstring. No functional change.
Modified
Author: stefan2
Date: Sat Jan 17 23:13:09 2015
New Revision: 1652695
URL: http://svn.apache.org/r1652695
Log:
Switch svn_fs_x__get_file_delta_stream to using two pools.
Propagate that change up the caller stack.
* subversion/libsvn_fs_x/cached_data.h
(svn_fs_x__get_file_delta_stream): Swith
Author: stefan2
Date: Sun Jan 18 15:36:05 2015
New Revision: 1652777
URL: http://svn.apache.org/r1652777
Log:
Fix pool naming for the last FSX/DAG function that is not a caching callback.
* subversion/libsvn_fs_x/dag.c
(svn_fs_x__dag_copy): We don't modify any of the incoming DAG
Author: stefan2
Date: Mon Jan 19 15:28:30 2015
New Revision: 1653030
URL: http://svn.apache.org/r1653030
Log:
* subversion/libsvn_subr/prefix_string.c
(svn_prefix_string__expand): Fix access violation caused buy insufficient
allocation.
Modified:
subversion
Author: stefan2
Revision: 1653030
Modified property: svn:log
Modified: svn:log at Mon Jan 19 15:32:30 2015
--
--- svn:log (original)
+++ svn:log Mon Jan 19 15:32:30 2015
@@ -1,3 +1,3 @@
* subversion/libsvn_subr
Author: stefan2
Date: Mon Jan 19 20:38:38 2015
New Revision: 1653113
URL: http://svn.apache.org/r1653113
Log:
Follow-up to r1650960: As it turns out, this function *will* sometimes
allocate memory and store it within the objects passed in.
* subversion/libsvn_fs_x/transaction.h
301 - 400 of 4871 matches
Mail list logo
