Re: svn commit: r1897133 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

2022-01-25 Thread Julian Foad
Julian Foad wrote: > I DO confirm > > XPASS: log_tests.py 47: log --use-merge-history --xml > > with RA-svn/serf on trunk. (That's today's trunk with your 'str/unicode/...' check line removed.)

Re: svn commit: r1897133 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

2022-01-25 Thread Julian Foad
On Jan 25 2022, at 1:15 pm, Julian Foad wrote: > Daniel Shahaf wrote: >> dsahlb...@apache.org wrote on Sun, 16 Jan 2022 19:19 +00:00: >>> Add a test for issue #4856, "invalid xml file produced by: svn log --xml >>> --use-merge-history". >>

Re: svn commit: r1897133 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

2022-01-25 Thread Julian Foad
Daniel Shahaf wrote: > dsahlb...@apache.org wrote on Sun, 16 Jan 2022 19:19 +00:00: >> Add a test for issue #4856, "invalid xml file produced by: svn log --xml >> --use-merge-history". > > The new test XFails for me over ra_local but XPasses over > svnserveautocheck and davautocheck. On the

Re: svn commit: r1874634 [3/3] - in /subversion/branches/decouple-shelving-cli/subversion: include/private/svn_client_shelf2.h libsvn_client/shelf2.c svn/shelf2-cmd.c svn/shelf2-cmd.h svn/svn.c tests/

2020-02-29 Thread Julian Foad
Daniel Shahaf wrote: > > This doesn't seem forward-compatible: if in 1.15 we add > SVN_EXPERIMENTAL_COMMANDS=foo, using that environment variable setting > on 1.14 (assuming the above branch is merged by 1.14) would disable > shelving. I'm aware that compatibility is a lesser concern for

Website 'staging' branch catch-up merges [was: svn commit: r1817775]

2017-12-13 Thread Julian Foad
Stefan wrote: On 11/12/2017 18:15, Daniel Shahaf wrote: julianf...@apache.org wrote on Mon, 11 Dec 2017 13:41 +: Modified: subversion/site/publish/docs/community-guide/releasing.part.html Could you backport this to staging/ so future changes to staging don't merge conflict when they

Re: svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h

2015-11-05 Thread Julian Foad
Bert Huijben wrote: >> Author: julianfoad >> URL: http://svn.apache.org/viewvc?rev=1712600=rev >> Log: >> * subversion/include/svn_fs.h >> (svn_fs_txns group): Remove an obsolete comment about transaction names. >> It described a naming scheme introduced in r865504 and removed in >>

Re: svn commit: r1492134 - /subversion/trunk/subversion/tests/cmdline/blame_tests.py

2013-06-12 Thread Julian Foad
Daniel Shahaf wrote: danie...@apache.org wrote on Wed, Jun 12, 2013 at 10:29:35 -: Author: danielsh Date: Wed Jun 12 10:29:34 2013 New Revision: 1492134 URL: http://svn.apache.org/r1492134 Log: Add an XFail test for 'svn blame -r 3:1' (where 3 1). Not filing an issue since

Re: svn commit: r1303316 - /subversion/trunk/subversion/tests/cmdline/svntest/sandbox.py

2012-03-26 Thread Julian Foad
Daniel Shahaf wrote: * subversion/tests/cmdline/svntest/sandbox.py   (Sandbox.get_tempname): Fix a bug: don't remove the directory before     allocating another filename in it. This seems to have broken export_tests.py 19 20: they fail if I run them twice without removing svn-test-work

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2012-03-06 Thread Julian Foad
Daniel Shahaf wrote: Daniel Shahaf wrote on Mon, Feb 06, 2012 at 18:20:28 +0200: Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100: On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote: This still strips whitespace around ='s in the value:     SVNHooksEnv name =

Re: svn commit: r1295287 - /subversion/trunk/subversion/libsvn_delta/compat.c

2012-03-01 Thread Julian Foad
Hyrum K Wright wrote: Current number of Ev2 test failures: 0 Yes, you read that correctly.  For those keeping score at home, after almost 6 months of work, the the testsuite now completely passes over ra_local with the Ev2 shims enabled. Fantastic! - Julian (ra_svn and ra_dav are a

Re: svn commit: r1293766 - /subversion/branches/1.7.x/STATUS

2012-02-27 Thread Julian Foad
stevek...@apache.org wrote on Sun, Feb 26, 2012 at 07:47:02 -: + * r1235831, r1236099 +  Tweak the parsing of the ssl-authority-files config option to make it +  easier for users to configure. +  Justification: +    Low impact change to help users. +  Notes: +    Both

Re: svn commit: r1230127 - /subversion/site/publish/mailing-lists.html

2012-01-11 Thread Julian Foad
Daniel Shahaf wrote: Log: * mailing-lists.html: use a non-breaking hyphen   pTo subscribe to the lists above, simply send email -  to emLISTNAME/em-subscr...@subversion.apache.org +  ! -- U+2011 NON-BREAKING HYPHEN.  TODO: used a named entity. -- +  to

Re: svn commit: r1160204 - WC-WC diff --summarize

2011-08-22 Thread Julian Foad
Reviewing my own commit ... On Mon, 2011-08-22 at 11:11 +, julianf...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=1160204view=rev Log: Extend 'svn diff --summarize' to support WC-WC diffs. Before this it only supported repo-repo diffs. [...] *

Re: svn commit: r1155044 - in /subversion/trunk/subversion/bindings/ctypes-python: csvn/repos.py csvn/wc.py test/localrepos.py test/remoterepos.py test/wc.py

2011-08-09 Thread Julian Foad
On Mon, 2011-08-08 at 21:44 +0300, Daniel Shahaf wrote: julianf...@apache.org wrote on Mon, Aug 08, 2011 at 18:32:08 -: +++ subversion/trunk/subversion/bindings/ctypes-python/test/remoterepos.py Mon Aug 8 18:32:07 2011 @@ -46,17 +46,24 @@ class RemoteRepositoryTestCase(unittest.

Re: svn commit: r1140861 - /subversion/trunk/subversion/svnadmin/main.c

2011-06-29 Thread Julian Foad
On Wed, 2011-06-29 at 02:16 +0300, Daniel Shahaf wrote: hwri...@apache.org wrote on Tue, Jun 28, 2011 at 21:47:06 -: Author: hwright Date: Tue Jun 28 21:47:06 2011 New Revision: 1140861 URL: http://svn.apache.org/viewvc?rev=1140861view=rev Log: * subversion/svnadmin/main.c

Re: svn commit: r1134219 - /subversion/trunk/configure.ac

2011-06-11 Thread Julian Foad
On Sat, 2011-06-11, Daniel Shahaf wrote: phi...@apache.org wrote on Fri, Jun 10, 2011 at 07:50:17 -: Author: philip Date: Fri Jun 10 07:50:17 2011 New Revision: 1134219 URL: http://svn.apache.org/viewvc?rev=1134219view=rev Log: * configure.ac: Don't replace svn_private_config.h

Re: svn commit: r1104124 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/deprecated.c libsvn_subr/io.c

2011-05-17 Thread Julian Foad
Not directly related to your change, but I notice the impl. allows the passed-in string to be null if not wanted. Maybe the doc string should promise that, otherwise why bother? - Julian On Tue, 2011-05-17 at 10:55 +, danie...@apache.org wrote: Author: danielsh Date: Tue May 17 10:55:51

Re: svn commit: r1102060 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

2011-05-12 Thread Julian Foad
Daniel Shahaf wrote: julianf...@apache.org wrote on Wed, May 11, 2011 at 20:11:52 -: Code simplification. * /home/julianfoad/src/subversion-d/subversion/libsvn_ra_serf/commit.c Wrong path, also in some other commits today. Thanks for telling me! I fixed this and three others from

Re: svn commit: r1100704 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-05-09 Thread Julian Foad
Hyrum K Wright wrote: On Sun, May 8, 2011 at 3:34 AM, rhuij...@apache.org wrote: -for (i = relpath_depth(local_relpath); i op_depth; --i) +for (i = (int)relpath_depth(local_relpath); i op_depth; --i) -for (i = relpath_depth(current_relpath); i op_depth; i--) +

Re: svn commit: r1091187 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/switch.c libsvn_client/update.c libsvn_wc/deprecated.c libsvn_wc/update_editor.c

2011-04-12 Thread Julian Foad
Hi Bert. A question about the server handles [depth] filtering flag... On Mon, 2011-04-11, rhuij...@apache.org wrote: Author: rhuijben Date: Mon Apr 11 19:58:27 2011 New Revision: 1091187 URL: http://svn.apache.org/viewvc?rev=1091187view=rev Log: Update the svn_wc_get_update_editor3()

Re: svn commit: r1072431 - /subversion/trunk/subversion/include/private/svn_debug.h

2011-02-21 Thread Julian Foad
* subversion/include/private/svn_debug.h (SVN_DBG): Add a docstring. [...] +/** Debug aid macro that prints the file:line of the call and printf-like + * arguments to the #SVN_DBG_OUTPUT stdio stream. Typical usage: + * + * pre + * SVN_DBG((path='%s' rev=%ld\n, dirent, revnum));

Re: svn commit: r1064200 - in /subversion/branches/uris-as-urls: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_ra/ subversion/libsvn_ra_local/ subversion/libsvn_ra_neon/ subversio

2011-01-28 Thread Julian Foad
On Thu, 2011-01-27, cmpil...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=1064200view=rev Log: On the 'uris-as-urls' branch: Begin ensuring that the relpaths returned from svn_url_* functions are URI-decoded. * BRANCH-README Update status. *

Re: svn commit: r1040663 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2010-12-01 Thread Julian Foad
Daniel Shahaf wrote: So we loop over the remaining sha1's and remove each of them... I wonder if there is room for further optimization here? e.g., does this prepare/reset the statement just once, or once per iteration? Each iteration of this loop prepares, uses and resets a SQL statement,

Re: svn commit: r1035894 - undefined reference to 'svn_fs_validate_mergeinfo'

2010-11-17 Thread Julian Foad
Since r1035894 I'm getting a link error on Linux (and so is Noorul): cd subversion/libsvn_fs_fs /usr/share/apr-1.0/build/libtool --tag=CC --silent --mode=link gcc -W[...] -D[...] -g -pthread -rpath /home/julianfoad/local/subversion-d/lib -Wl,--no-undefined -o libsvn_fs_fs-1.la caching.lo

Re: svn commit: r1035894 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_client/ subversion/libsvn_fs/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/

2010-11-17 Thread Julian Foad
Hi Paul. On Wed, 2010-11-17, pbu...@apache.org wrote: Log: Reintegrate the issue-3668-3669 branch. If you could insert a summary of this change here in the log message, that would be helpful. I see it's ... rather large. Modified: subversion/trunk/ (props changed)

Backport review - r1035992 in branches/1.6.x-r917523: ./ subversion/mod_dav_svn/mirror.c

2010-11-17 Thread Julian Foad
I've reviewed and tested this change. Here are the results. Executive summary: basically works in the simple case, but I have too many reservations to give a +1. The patch attempts to fix DAV mirroring when the Location directive value contains a space, such as Location /repo 1. For the

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-10 Thread Julian Foad
On Wed, 2010-11-10, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Nov 10 01:44:35 2010 New Revision: 1033320 URL: http://svn.apache.org/viewvc?rev=1033320view=rev Log: Fix issue #3622 (svn should exit with exit code 1 if updating externals fails). *

Re: svn commit: r1029240 - in /subversion/trunk: ./ subversion/tests/ subversion/tests/libsvn_wc/

2010-11-01 Thread Julian Foad
On Sun, 2010-10-31, danie...@apache.org wrote: Author: danielsh Date: Sun Oct 31 04:06:09 2010 New Revision: 1029240 URL: http://svn.apache.org/viewvc?rev=1029240view=rev Log: Avoid dragging libsvn_client as a dependency to libsvn_test, because that makes every C test file depend on

Re: svn commit: r1021431 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-10-11 Thread Julian Foad
On Mon, 2010-10-11, julianf...@apache.org wrote: Author: julianfoad Date: Mon Oct 11 17:10:35 2010 New Revision: 1021431 URL: http://svn.apache.org/viewvc?rev=1021431view=rev Log: * subversion/libsvn_wc/adm_ops.c (svn_wc_add4): Update a comment after r1021430. Please excuse this spate

Re: svn commit: r1004792 - /subversion/trunk/notes/wc-ng/nodes

2010-10-05 Thread Julian Foad
On Tue, 2010-10-05, e...@apache.org wrote: Author: ehu Date: Tue Oct 5 19:56:52 2010 New Revision: 1004792 URL: http://svn.apache.org/viewvc?rev=1004792view=rev Log: * notes/wc-ng/nodes: Add more explanation of how the table works. Excellent! We can much more easily agree and disagree

Re: svn commit: r1004792 - /subversion/trunk/notes/wc-ng/nodes

2010-10-05 Thread Julian Foad
Eric, I committed in r1004834 my other tweaks, comments and queries. - Julian

Re: svn commit: r1002271 - /subversion/trunk/subversion/include/svn_client.h

2010-10-04 Thread Julian Foad
On Tue, 2010-09-28, Daniel Shahaf wrote: julianf...@apache.org wrote on Tue, Sep 28, 2010 at 17:16:59 -: Author: julianfoad Date: Tue Sep 28 17:16:59 2010 New Revision: 1002271 URL: http://svn.apache.org/viewvc?rev=1002271view=rev Log: * subversion/include/svn_client.h

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
On Tue, 2010-09-07, s...@apache.org wrote: Author: stsp Date: Tue Sep 7 00:09:46 2010 New Revision: 993183 URL: http://svn.apache.org/viewvc?rev=993183view=rev Log: Introduce a new family of functions to parse numbers from strings. Looks useful. Thanks. The goal is to replace direct

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

2010-09-15 Thread Julian Foad
Also printf formatting type mismatches: subversion/libsvn_subr/svn_string.c: In function 'svn_cstring_strtoui64': subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long unsigned int', but argument 5 has type 'apr_uint64_t' subversion/libsvn_subr/svn_string.c:662: format '%lu'

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

2010-09-13 Thread Julian Foad
On Mon, 2010-09-13, s...@apache.org wrote: * subversion/libsvn_diff/parse-diff.c (svn_diff_parse_next_patch): When generating a reverse diff, do not swap the old and new filenames of the patch. The old filename in a unidiff is often useless (e.g. it contains a .orig extension), but the

Re: svn commit: r992042 - in /subversion/trunk/subversion: libsvn_client/merge.c tests/cmdline/merge_authz_tests.py tests/cmdline/merge_tests.py tests/cmdline/merge_tree_conflict_tests.py tests/cmdlin

2010-09-02 Thread Julian Foad
pbu...@apache.org wrote: Fix issue #2915 'Handle mergeinfo for subtrees missing due to removal by non-svn command'. With this change, if you attempt a merge-tracking aware merge to a WC which is missing subtrees due to an OS-level deletion, then an error is raised before any editor drives

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + * @since New in 1.7. + */ +svn_boolean_t +svn_error_has_cause(svn_error_t *err, apr_status_t apr_err); This looks like it could be a useful API. I would expect to

Re: svn commit: r983720 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/diff_tests.py

2010-08-10 Thread Julian Foad
On Mon, 2010-08-09, sbut...@apache.org wrote: Fix issue 2333 diff URL1 URL2 not reverse of diff URL2 URL1. When the repository reports a deleted directory, recursively walk the directory (in the repository) and report files as deleted. TODO: Handle non-infinite depth correctly. Review

Re: svn commit: r956941 - /subversion/trunk/subversion/libsvn_subr/io.c

2010-06-23 Thread Julian Foad
On Tue, 2010-06-22 at 23:18 +0300, Daniel Shahaf wrote: julianf...@apache.org wrote on Tue, 22 Jun 2010 at 19:18 -: @@ -3665,7 +3667,7 @@ temp_file_create(apr_file_t **new_file, #endif } -/* Wrapper for apr_file_name_get(). */ +/* Wrapper for apr_file_name_get(), passing out a

Re: svn commit: r948849 - notes/feedback/hwright-user-visits

2010-05-27 Thread Julian Foad
hwri...@apache.org wrote: * notes/feedback/hwright-user-visits: Add some additional comments sent to me by a user. That's good. Any chance of more details on the concerns of User 2? Particularly: * No zero-change commit support. -- supporting empty commits? what for? * Long option names

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Julian Foad
On Tue, 2010-05-04, hwri...@apache.org wrote: Author: hwright Date: Tue May 4 09:45:43 2010 New Revision: 940786 URL: http://svn.apache.org/viewvc?rev=940786view=rev Log: Add a callback to the public patch API, to allow consumers to collect information about the patch targets. This

Re: svn commit: r937452 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/status.c libsvn_wc/node.c libsvn_wc/questions.c

2010-04-23 Thread Julian Foad
subversion/libsvn_client/status.c:409: 'replaced' may be used uninitialized in this function - Julian On Fri, 2010-04-23, cmpil...@apache.org wrote: [...] + if (added) +{ + svn_boolean_t replaced; + + SVN_ERR(svn_wc__node_is_replaced(added,

Re: svn commit: r924797 - /subversion/trunk/subversion/libsvn_subr/stream.c

2010-03-18 Thread Julian Foad
On Thu, 2010-03-18, rhuij...@apache.org wrote: Author: rhuijben Date: Thu Mar 18 14:21:26 2010 New Revision: 924797 URL: http://svn.apache.org/viewvc?rev=924797view=rev Log: Extract the range handling from the common apr read codepath in the streams api, as there is no need to complicate

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

2010-03-17 Thread Julian Foad
On Thu, 2010-03-11, I (Julian Foad) wrote: Excellent, too. Just one nit: it looks like you intended to rename the argument wcprop_changes to props. Renamed in r924229. - Julian

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

2010-03-17 Thread Julian Foad
On Wed, 2010-03-17, C. Michael Pilato wrote: Julian Foad wrote: On Thu, 2010-03-11, I (Julian Foad) wrote: Excellent, too. Just one nit: it looks like you intended to rename the argument wcprop_changes to props. Renamed in r924229. Thanks. For the record, I hadn't ignored your

Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in /subversion/trunk/subversion: libsvn_client/cleanup.c tests/cmdline/upgrade_tests.py tests/cmdline/upgrade_tests_data/upgrade_with_ex

2010-03-15 Thread Julian Foad
On Fri, 2010-03-12, Daniel Näslund wrote: On Fri, Mar 12, 2010 at 06:15:27PM +, Philip Martin wrote: Daniel Näslund dan...@longitudo.com writes: Can this be committed? [[[ Follow up to r920118. * subversion/libsvn_client/cleanup.c (svn_client_upgrade): Use

Re: svn commit: r921503 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c deprecated.c wc.h

2010-03-11 Thread Julian Foad
On Wed, 2010-03-10, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Mar 10 18:28:10 2010 New Revision: 921503 URL: http://svn.apache.org/viewvc?rev=921503view=rev Log: Continue doing what it takes to get deprecated stuff into deprecated.c. * subversion/libsvn_wc/wc.h

Re: svn commit: r919992 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-03-10 Thread Julian Foad
On Sun, 2010-03-07, rhuij...@apache.org wrote: Author: rhuijben Date: Sun Mar 7 13:37:09 2010 New Revision: 919992 URL: http://svn.apache.org/viewvc?rev=919992view=rev Log: Replace the loggy_tweak_entry() function in the update editor by two more specific functions. One for updating

Re: svn commit: r920526 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-03-09 Thread Julian Foad
On Mon, 2010-03-08 at 21:34 +, rhuij...@apache.org wrote: Author: rhuijben Date: Mon Mar 8 21:34:38 2010 New Revision: 920526 URL: http://svn.apache.org/viewvc?rev=920526view=rev Log: * subversion/libsvn_wc/update_editor.c (install_added_props): Remove call to

Re: svn commit: r920118 - in /subversion/trunk/subversion: libsvn_client/cleanup.c tests/cmdline/upgrade_tests.py tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2

2010-03-09 Thread Julian Foad
On Sun, 2010-03-07, dan...@apache.org wrote: Author: dannas Date: Sun Mar 7 21:21:58 2010 New Revision: 920118 URL: http://svn.apache.org/viewvc?rev=920118view=rev Log: Fix issue #3483 - extend svn_client_upgrade() to include externals. I've done the externals upgrading after wc upgrade

Re: svn commit: r920875 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/commit.c libsvn_wc/adm_ops.c

2010-03-09 Thread Julian Foad
On Tue, 2010-03-09, phi...@apache.org wrote: Author: philip Date: Tue Mar 9 13:53:38 2010 New Revision: 920875 URL: http://svn.apache.org/viewvc?rev=920875view=rev Log: Remove some access batons from post-commit processing. Hi Philip. You could add SVN_DEPRECATED to

Re: svn commit: r920336 - in /subversion/trunk/subversion/libsvn_client: client.h commit.c commit_util.c copy.c

2010-03-09 Thread Julian Foad
On Mon, 2010-03-08, phi...@apache.org wrote: Author: philip Date: Mon Mar 8 14:35:42 2010 New Revision: 920336 URL: http://svn.apache.org/viewvc?rev=920336view=rev Log: Remove access baton from svn_client__harvest_committables. Explicitly use absolute paths in svn_client__copy_pair_t

Re: svn commit: r919413 - in /subversion/trunk/subversion/libsvn_wc: adm_files.c adm_files.h update_editor.c

2010-03-05 Thread Julian Foad
Author: julianfoad Date: Fri Mar 5 13:52:11 2010 New Revision: 919413 URL: http://svn.apache.org/viewvc?rev=919413view=rev Log: Unify the writing of new WC-1 text-base files in three different places in update_editor.c. As mentioned in my other email, I found a problem: still looks for

Re: svn commit: r916286 - in /subversion/trunk/subversion/mod_dav_svn: dav_svn.h mirror.c mod_dav_svn.c

2010-02-25 Thread Julian Foad
kame...@apache.org wrote: Author: kameshj Date: Thu Feb 25 13:40:22 2010 New Revision: 916286 Hi Kamesh. Some review comments below ... URL: http://svn.apache.org/viewvc?rev=916286view=rev Log: With the below apache configuration(See the trailing slash at the end of '/svn/'). Location

Re: svn commit: r916286 - in /subversion/trunk/subversion/mod_dav_svn: dav_svn.h mirror.c mod_dav_svn.c

2010-02-25 Thread Julian Foad
On Thu, 2010-02-25 at 20:45 +0530, Kamesh Jayachandran wrote: On 02/25/2010 08:29 PM, Julian Foad wrote: kame...@apache.org wrote: [...] -if (strcmp(uri.path, root_dir) == 0) { +if (uri.path) +canonicalized_uri = svn_dirent_canonicalize(uri.path, r-pool); Oops