Re: svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2022-01-11 Thread Stefan Sperling
On Tue, Jan 11, 2022 at 12:22:38AM -0500, Nathan Hartman wrote: > On Mon, Jan 10, 2022 at 6:44 AM wrote: > > > > Author: stsp > > Date: Mon Jan 10 11:44:46 2022 > > New Revision: 1896877 > > > > URL: http://svn.apache.org/viewvc?rev=1896877=rev > > Log: > > Fix misleading -r option documentation

Re: svn commit: r1892471 - in /subversion/trunk/subversion: libsvn_client/conflicts.c libsvn_wc/wc_db.c tests/cmdline/merge_tree_conflict_tests.py

2021-08-23 Thread Stefan Sperling
On Sat, Aug 21, 2021 at 09:38:56PM +0200, Daniel Sahlberg wrote: > > @@ -3028,12 +3028,12 @@ conflict_tree_get_details_local_missing( > >deleted_basename, > >conflict->pool); > >

Re: svn commit: r1886396 - in /subversion/site/publish: ./ doap.rdf docs/release-notes/release-history.html download.html

2021-02-16 Thread Stefan Sperling
On Tue, Feb 16, 2021 at 01:05:32PM +0100, Daniel Sahlberg wrote: > Den tis 16 feb. 2021 kl 11:34 skrev Stefan Sperling : > > On Mon, Feb 15, 2021 at 07:46:08PM +, Daniel Shahaf wrote: > > > The entity referred to by the tag wasn't created in 2021. So, > > > I

Re: svn commit: r1886396 - in /subversion/site/publish: ./ doap.rdf docs/release-notes/release-history.html download.html

2021-02-16 Thread Stefan Sperling
into the Incubator, or the date it > was > promoted to TLP. > > Thanks for RMing, > > Daniel > Thanks for checking. I think in both of these cases it would have helped to have more specific instructions for how to update these files in our release manager's manual of the community guide. Thanks, Stefan

Re: svn commit: r1886389 - in /subversion/site/publish: ./ index.html

2021-02-10 Thread Stefan Sperling
ng is now in order. Thank you! Stefan

Re: mailer.py py2/py3 change: non-UTF-8 environments (was: svn commit: r1884427 - in /subversion/trunk/tools/hook-scripts/mailer: mailer.py tests/mailer-t1.output tests/mailer-tweak.py)

2020-12-28 Thread Stefan Sperling
On Mon, Dec 21, 2020 at 07:15:53AM +, Daniel Shahaf wrote: > s...@apache.org wrote on Mon, 14 Dec 2020 16:57 -: > > URL: http://svn.apache.org/viewvc?rev=1884427=rev > > Log: > > Make mailer.py work properly with Python 3, and drop Python 2 support. > > > > Most of the changes deal with

Re: svn commit: r1882186 - in /subversion/trunk/subversion: libsvn_repos/authz.c tests/cmdline/svnauthz_tests.py tests/libsvn_repos/authz-test.c tests/libsvn_repos/repos-test.c

2020-10-06 Thread Stefan Sperling
On Sat, Oct 03, 2020 at 06:07:49AM +, Daniel Shahaf wrote: > Sounds like this change merits an entry in the 1.14 release notes (if > it's backported) or in the 1.15 release notes if it's not backported. > Would you please add a placeholder (just a section header or a ToC > link) or file a

Re: HACKING += release-lines.yaml? (was: svn commit: r1878162 - /subversion/trunk/tools/dist/release-lines.yaml)

2020-05-28 Thread Stefan Sperling
On Thu, May 28, 2020 at 03:03:40AM +, Daniel Shahaf wrote: > s...@apache.org wrote on Wed, 27 May 2020 14:34 -: > > Author: stsp > > Date: Wed May 27 14:34:18 2020 > > New Revision: 1878162 > > > > URL: http://svn.apache.org/viewvc?rev=1878162=rev > > Log: > > *

Re: svn commit: r1838746 - /subversion/site/staging/download.html

2018-08-25 Thread Stefan
On 25/08/2018 18:06, sebb AT ASF wrote: > On 25 August 2018 at 13:44, Stefan wrote: >> On 25/08/2018 14:37, Stefan wrote: >>> On 23/08/2018 20:01, s...@apache.org wrote: >>>> Author: sebb >>>> Date: Thu Aug 23 18:01:30 2018 >>>> New Revisio

Re: svn commit: r1839039 - /subversion/site/staging/download.html

2018-08-25 Thread Stefan
On Windows you can use the certutil command line tool, for instance. > Perhaps add the specific --option flags here? Or at least use > tags to get the monospaced font. Added more specific usage sample for cerutils (incl. the missing -tags) in r1839052. Regards, Stefan

Re: svn commit: r1838746 - /subversion/site/staging/download.html

2018-08-25 Thread Stefan
On 25/08/2018 14:37, Stefan wrote: > On 23/08/2018 20:01, s...@apache.org wrote: >> Author: sebb >> Date: Thu Aug 23 18:01:30 2018 >> New Revision: 1838746 >> >> URL: http://svn.apache.org/viewvc?rev=1838746=rev >> Log: >> SVN-4736 - fix gpg command &

Re: svn commit: r1838746 - /subversion/site/staging/download.html

2018-08-25 Thread Stefan
On 23/08/2018 20:01, s...@apache.org wrote: > Author: sebb > Date: Thu Aug 23 18:01:30 2018 > New Revision: 1838746 > > URL: http://svn.apache.org/viewvc?rev=1838746=rev > Log: > SVN-4736 - fix gpg command > > Modified: > subversion/site/staging/download.html > > Modified:

Re: svn commit: r1835191 - /subversion/site/publish/docs/community-guide/releasing.part.html

2018-07-09 Thread Stefan
se" and "to allow anybody planning > to test the release" is helpful. I suggest to pick one and drop the other :-) Done in r1835497 (incl. some more minor rephrasing). Regards, Stefan

Re: svn commit: r1822797 - in /subversion/site/publish: faq.html faq.ja.html faq.zh.html

2018-01-31 Thread Stefan
š„讨论。) > > 不管怎么样,如果你在2005å¹´11月15号的时候在Debian > GNU/Linux系统上面运行最新的testing发行版,然后遇到这个问题,那么解决方法就是,将libtool > 1.5.20的源代码使用标准的“./configure make > > Committed this by accident directly to publish (rather than staging). If anybody feels like this should be reverted/discussed/replace with something else, please reply. Since it's just a dead link correction, I didn't think it was worth reverting the accidental commit in this case. Regards, Stefan

Re: svn commit: r1819391 - /subversion/site/staging/docs/release-notes/1.10.html

2017-12-28 Thread Stefan
On 28/12/2017 22:37, Daniel Shahaf wrote: > Stefan wrote on Thu, Dec 28, 2017 at 18:19:12 +0100: >> On 28/12/2017 04:52, danie...@apache.org wrote: >>> Author: danielsh >>> Date: Thu Dec 28 03:52:02 2017 >>> New Revision: 1819391 >>> >>> URL

Re: svn commit: r1819391 - /subversion/site/staging/docs/release-notes/1.10.html

2017-12-28 Thread Stefan
ething we'd do. At the hackathon this was slightly touched too and was discussed that if we introduce shorter release cycles, we also should introduce LTS versions. Regards, Stefan smime.p7s Description: S/MIME Cryptographic Signature

Re: svn commit: r1818724 - /subversion/site/staging/faq.html

2017-12-26 Thread Stefan
On 20/12/2017 01:08, Daniel Shahaf wrote: > Stefan wrote on Tue, 19 Dec 2017 23:39 +0100: > [...] >> Since I never calculated the CVSS score for a Subversion vulnerability >> before, > If you're interested, you could go through the more recent advisories > (the security/

Re: svn commit: r1818724 - /subversion/site/staging/faq.html

2017-12-19 Thread Stefan
d on the system as only a Partial Confidentiality Impact, resulting in > -a lower score. > +hosted on the system as only a Low Confidentiality Impact, resulting in a > lower > +score. > > > > Originally I only intended to unbreak the links in the CVSSv2 section but then decided to update the documentation to CVSSv3 which we are using meanwhile. Since I never calculated the CVSS score for a Subversion vulnerability before, maybe someone familiar with the details could verify the information I changed are accurate? In principle I only replaced what was called "Complete" in CVSSv2 to "High" for CVSSv3 and "Partial" got changed to "Low". As far as the specification goes, this should be how we handle it for CVSSv3, right? Regards, Stefan

Re: svn commit: r1818496 - /subversion/site/staging/docs/release-notes/1.10.html

2017-12-17 Thread Stefan
was introduced in 1.6 (as I did). That's less likely to happen with danielsh's phrasing, since it points out that these line endings were (always) considered invalid. So to not just reply here without taking action, I went ahead and committed danielsh's suggested change in r1818517. Regards, Stefan

Re: svn commit: r1818343 - in /subversion/site/staging: faq.html faq.ja.html faq.zh.html

2017-12-15 Thread Stefan
£… > 成服务的形式。 > - > > > > > FTR: Two of the three links in these sections are dead and given that SVN 1.4 is way beyond it's end of life, I really don't see much purpose keeping that old information still in the FAQ section. It only bloats the page unnecessarily with information which is simply outdated. If anybody disagrees, please let me know. Regards, Stefan

Re: svn commit: r1818340 - in /subversion/site/staging: faq.html faq.ja.html faq.zh.html

2017-12-15 Thread Stefan
client capable of port forwarding > > > > > FTR: I got in touch with Robert O'Callahan (the author of TTSSH) and he stated/suggested to drop the link since nobody should be using TTSSH anymore (i.e. was discontinued). Hence, removed the link. Regards, Stefan

Re: svn commit: r1817718 - /subversion/site/staging/docs/index.html / Reinstate 1.6 API docu

2017-12-13 Thread Stefan
On 10/12/2017 17:23, Stefan wrote: > On 10/12/2017 17:11, Branko Čibej wrote: >> On 10.12.2017 17:00, Stefan wrote: >>> On 10/12/2017 16:54, luke1...@apache.org wrote: >>>> Author: luke1410 >>>> Date: Sun Dec 10 15:54:23 2017 >>>> New Revisio

Re: svn commit: r1817969 - /subversion/site/staging/docs/release-notes/1.3.html

2017-12-12 Thread Stefan
far as I can see JavaSVN no longer exists and therefore I couldn't find a replacement for the old link. Any objections/alternative suggestions? Regards, Stefan

Re: svn commit: r1817862 - /subversion/site/staging/docs/release-notes/1.4.html

2017-12-11 Thread Stefan
hapter of the Berkeley > DB > +Upgrade Guide for instructions on upgrading Berkeley DB environments. > > > > I'd appreciate if anybody more familiar with the BDB setup/instructions back around the 1.4 release could verify that the substitution for the old dead link is correct here rather than only relying on my google/DuckDuckGo-search skills. Regards, Stefan

Re: svn commit: r1817775 - /subversion/site/publish/docs/community-guide/releasing.part.html

2017-12-11 Thread Stefan
; merge conflict when they are published? Since I was working on the site right now, I took the liberty and quickly did it in r1817860. Regards, Stefan

Re: svn commit: r1817718 - /subversion/site/staging/docs/index.html / Reinstate 1.6 API docu

2017-12-10 Thread Stefan
On 10/12/2017 17:11, Branko Čibej wrote: > On 10.12.2017 17:00, Stefan wrote: >> On 10/12/2017 16:54, luke1...@apache.org wrote: >>> Author: luke1410 >>> Date: Sun Dec 10 15:54:23 2017 >>> New Revision: 1817718 >>> >>> URL: http://svn.apache.

Re: svn commit: r1817718 - /subversion/site/staging/docs/index.html / Reinstate 1.6 API docu

2017-12-10 Thread Stefan
g around (it should not cause any significant resources keeping them available, IMO). Note that I'd reinstate the old 1.6 docus directly on publish (rather than on staging) since this would be easier to do (i.e. reverting the corresponding changes from r1696552 which obviously were done on publish). Any objections and/or better ideas? Regards, Stefan

Re: svn commit: r1817713 - in /subversion/site/staging/docs/release-notes: 1.6.html 1.6.zh.html

2017-12-10 Thread Stefan
ing previous commit (r872853) is the one which previously was referred to as r32778 in the collabnet repository: https://svn.apache.org/viewvc?view=revision=872852 I'd still appreciate, if someone who happens to slightly remember which revision this release notes was linked against, could verify that the replacement link is correct (see: http://subversion-staging.apache.org/docs/release-notes/1.6.html ). Regards, Stefan

Re: svn commit: r1817146 - /subversion/site/staging/docs/release-notes/1.6.zh.html

2017-12-04 Thread Stefan
ing how to handle links where we can't determine a working replacement. For the Chinese 1.6 release notes I went with adding "XXX (dead link)" markers to at least point out that these are broken. This seems to be acceptable to me here, since the page contains a couple of other "XXX"-style TODO-/note-markers. I'm open for alternative ideas though (or do we have some defined style/handling for this I missed?). Regards, Stefan

Re: svn commit: r1817032 - in /subversion/site/staging/docs: index.html release-notes/1.8.html

2017-12-03 Thread Stefan
s however also changed the layout so the h3-sections are now indented. Initially I thought to resolve this, but after checking think it looks better that way. To see the change, compare these two pages [2/3]. Anybody against keeping this change? Also note that in order to use HTML 4.01 compliant ids, I did not go with #1.8 but rather #release-1.8, since in HTML 4.01 ids are not allowed to start with numbers. Regards, Stefan [1] http://subversion.apache.org/docs/release-notes/1.8.html (see link: "API users"). [2] http://subversion-staging.apache.org/docs/ [3] http://subversion.apache.org/docs/

Re: svn commit: r1816926 - /subversion/site/staging/docs/community-guide/mailing-lists.part.html

2017-12-01 Thread Stefan
zitieren/zitieren.php3*//on line //*2"*/ I could find a replacement which claims to be a local copy of the content which was available at the now broken linked page. Again I don't have any doubt that this is a correct capture of the original content (though it might not have been the latest version). Still, IMO this seems to be a reasonable replacement for the broken link, or does anybody think otherwise? Regards, Stefan **

Re: svn commit: r1816774 - /subversion/site/staging/mailing-lists.html

2017-11-30 Thread Stefan
On 01/12/2017 00:48, Daniel Shahaf wrote: > Stefan wrote on Thu, 30 Nov 2017 23:52 +0100: >> On 30/11/2017 23:47, luke1...@apache.org wrote: >>> Author: luke1410 >>> Date: Thu Nov 30 22:47:41 2017 >>> New Revision: 1816774 >>> >>> URL: http://s

Re: svn commit: r1816774 - /subversion/site/staging/mailing-lists.html

2017-11-30 Thread Stefan
ny archive of the subversion mailing lists anymore [4]. Hence I take it, we'd rather drop these no longer working links from our webpage. Regards, Stefan [1] https://en.wikipedia.org/wiki/Gmane [2] https://lars.ingebrigtsen.no/2016/07/28/the-end-of-gmane/ [3] https://lwn.net/Articles/695695/ [4] http://gmane.org/find.php?list=subversion

Re: svn commit: r1805627 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py merge_tree_conflict_tests.py stat_tests.py svntest/mergetrees.py tree_conflict_tests.py

2017-08-23 Thread Stefan Sperling
On Wed, Aug 23, 2017 at 04:09:55PM +, Daniel Shahaf wrote: > s...@apache.org wrote on Mon, 21 Aug 2017 12:49 +: > > Author: stsp > > Date: Mon Aug 21 12:49:42 2017 > > New Revision: 1805627 > > > > URL: http://svn.apache.org/viewvc?rev=1805627=rev > > Log: > > Follow-up to r1805620: Fix

Re: svn commit: r1805398 - in /subversion/site/publish/security: CVE-2017-9800-advisory.txt CVE-2017-9800-advisory.txt.asc

2017-08-18 Thread Stefan Sperling
On Fri, Aug 18, 2017 at 05:33:14PM +, Daniel Shahaf wrote: > s...@apache.org wrote on Fri, 18 Aug 2017 10:33 +: > > +++ subversion/site/publish/security/CVE-2017-9800-advisory.txt Fri Aug 18 > > 10:33:10 2017 > > @@ -80,24 +96,36 @@ Recommendations: > >the included patch. > > > >

Re: jira filter for 1.10.0-pending issues

2017-08-06 Thread Stefan
. If a change needs to be > made, please tell me. (Or commit it directly :-)) > > Thanks, > > Daniel FWIW: Reviewed the JIRA link and looks correct to me. Regards, Stefan

Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/tests/li

2017-07-26 Thread Stefan Sperling
On Wed, Jul 26, 2017 at 02:41:31PM +0300, Evgeny Kotkov wrote: > Stefan Sperling <s...@elego.de> writes: > > > Sounds like we're headed in a good direction :-) > > One particular thing that bothers me about using LZ4 as the new default > is that I think that a de

Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/tests/li

2017-07-26 Thread Stefan Sperling
On Wed, Jul 26, 2017 at 01:18:00PM +0300, Evgeny Kotkov wrote: > Stefan Sperling <s...@elego.de> writes: > > > Does mod_dav_svn really need an option for this? > > > > Can't lz4 (svndiff2) be negotiated as a mutual protocol capability of > > client

Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/ subversion/tests/li

2017-07-26 Thread Stefan Sperling
On Mon, Jul 24, 2017 at 07:19:09PM +0300, Evgeny Kotkov wrote: > However, there are a couple of difficulties with porting this approach to > mod_dav_svn, i.e., if we introduce the SVNCompression directive. There > are clients that don't use LZ4, so, presumably, this options would require >

Re: svn commit: r1794632 - /subversion/trunk/notes/sha1-advisory.txt

2017-05-10 Thread Stefan Sperling
On Wed, May 10, 2017 at 09:11:50AM +, Daniel Shahaf wrote: > > Summary: > > > > > > Subversion repositories can be corrupted by committing two files > > which have different content, yet produce the same SHA1 checksum. > > I don't think we should call this "corruption": the

Re: svn commit: r1782003 - /subversion/trunk/CHANGES

2017-02-07 Thread Stefan
On 2/7/2017 15:57, s...@apache.org wrote: > * FSX: Fix an initialization / life time issue with batch-fsync (r1781657) Didn't that issue get in post SVN 1.9 and hence is a noop-change in regards to the changelog for SVN 1.9.5 -> SVN 1.10? Regards, Stefan smime.p7s Description:

Re: svn commit: r1742826 - in /subversion/trunk: subversion/tests/cmdline/ subversion/tests/cmdline/svntest/ tools/client-side/ tools/server-side/svnpubsub/

2016-05-09 Thread Stefan Fuhrmann
found made it seem like there was no compatible way and suggested decimals. Anyway, using symbolic constants is certainly even better. -- Stefan^2.

Re: svn commit: r1740170 -/subversion/trunk/subversion/libsvn_client/conflicts.c

2016-04-21 Thread Stefan Sperling
On Thu, Apr 21, 2016 at 09:40:07AM +0200, Branko Čibej wrote: > It is wrong to use conflict->local_abspath to construct the relative > URL. Yes, it is. But where is the alleged code that does this? I don't see it. And I don't think I've written it.

Re: svn commit: r1740170 -/subversion/trunk/subversion/libsvn_client/conflicts.c

2016-04-21 Thread Stefan Sperling
On Wed, Apr 20, 2016 at 10:19:56PM +0200, Bert Huijben wrote: > The path calculation here 100% assumes that the working copy is always a > clean check out from ^/. This might be the case in our test suite, but in > almost every normal user scenario this isn’t the case. > > You can’t just

Re: svn commit: r1687906 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/resolved.c

2015-07-28 Thread Stefan Sperling
On Sat, Jun 27, 2015 at 09:08:29PM +, Bert Huijben wrote: Author: stsp Date: Sat Jun 27 10:35:42 2015 New Revision: 1687906 URL: http://svn.apache.org/r1687906 Log: Add a conflict walker to the new svn_client_conflict API. Contrary to our current libsvn_wc conflict

Re: svn commit: r1688511 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

2015-07-01 Thread Stefan Fuhrmann
the format file (should never happen, but ...) -- Stefan^2. *From:* Stefan Fuhrmann stef...@apache.org *Sent:* ‎Tuesday‎, ‎June‎ ‎30‎, ‎2015 ‎9‎:‎50‎ ‎PM *To:* commits@subversion.apache.org Author: stefan2 Date: Tue Jun 30 19:50:46 2015 New Revision: 1688511 URL: http://svn.apache.org/r1688511

Re: svn commit: r1685985 - in /subversion/branches/fsx-1.10/subversion: include/private/svn_mutex.h libsvn_fs_x/batch_fsync.c libsvn_fs_x/batch_fsync.h libsvn_fs_x/fs.c libsvn_subr/mutex.c tests/libsv

2015-06-18 Thread Stefan Fuhrmann
. -- Stefan^2.

Re: svn commit: r1678151 - in /subversion/trunk/subversion/libsvn_fs_fs: cached_data.c fs_fs.c recovery.c transaction.c

2015-05-11 Thread Stefan Sperling
On Thu, May 07, 2015 at 03:19:55PM +0200, Bert Huijben wrote: Your log message documents this change as 'This way, the hash parser's error message is preserved.', which is not what this change does. The docstring of svn_error_quick_wrap fooled me. I've reverted r1678151 and improved the

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

2015-04-19 Thread Stefan Sperling
On Sun, Apr 19, 2015 at 05:57:54PM +0200, Bert Huijben wrote: Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread? I could not find your patch in the thread with subject branching over mod_dav 2.4.6 is

Re: svn commit: r1673197 - in /subversion/trunk/subversion/libsvn_fs_fs: cached_data.h dag.c dag.h tree.c

2015-04-14 Thread Stefan Fuhrmann
? The intention has probably been to push the implementation further down the layering but that hasn't happened, yet. IMO, that is also not necessary / does not bring any extra benefit. So, I removed the declaration for now in r1673454. -- Stefan^2.

Making EXPANDED_SIZE reliable in FSFS [was: svn commit: r1673204 - /subversion/trunk/subversion/libsvn_fs_fs/dag.c]

2015-04-13 Thread Stefan Fuhrmann
. Thoughts? -- Stefan^2.

Re: svn commit: r1669743 - /subversion/trunk/subversion/libsvn_fs_fs/transaction.c

2015-03-29 Thread Stefan Fuhrmann
be. The condition as it stands now on /trunk should be minimal and correct. Thanks for the review! -- Stefan^2.

Re: svn commit: r1669769 - /subversion/branches/1.9.x/STATUS

2015-03-29 Thread Stefan Fuhrmann
://subversion.apache.org/docs/community-guide/releasing.html#release-stabilization . I think you can just move the doxygen fixes to the approved section. They're practically obvious fixes. Good point. That reduces noise for reviewers. I moved the docstring-only patches to approved now. -- Stefan^2.

Re: svn commit: r1654933 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

2015-01-27 Thread Stefan Fuhrmann
On Tue, Jan 27, 2015 at 11:19 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Good morning Stefan, stef...@apache.org wrote on Tue, Jan 27, 2015 at 01:48:08 -: + /* Redirect text rep to props rep. */ + rev_path = svn_fs_fs__path_rev_absolute(fs, rev, pool); + SVN_ERR

Re: svn commit: r1622946 - /subversion/trunk/subversion/libsvn_fs_fs/rev_file.c

2014-09-08 Thread Stefan Fuhrmann
in r1623368. -- Stefan^2.

Re: svn commit: r1619068 - in /subversion/trunk/subversion: include/ include/private/ libsvn_fs/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_svn/ libsvn_subr/ svnserve/ tests/ tests/libsv

2014-08-27 Thread Stefan Fuhrmann
do not see any reasons not to restore the 1.8 behavior here. Yes, we should revert and I did in r1620930. Thanks, Evgeny. -- Stefan^2.

Re: svn commit: r1568684 - in /subversion/trunk/subversion/libsvn_fs_x: cached_data.c changes.c fs_x.c id.c id.h index.c noderevs.c pack.c transaction.c tree.c verify.c

2014-08-26 Thread Stefan Fuhrmann
a typo, because the third condition is always false. Yep, it is. Fixed in r1619416. Thanks! -- Stefan^2.

Re: svn commit: r1618860 - in /subversion/trunk: build.conf subversion/svn-bench/ tools/client-side/svn-bench/

2014-08-19 Thread Stefan Fuhrmann
under this name in 1.8 :/ -- Stefan^2.

Re: svn commit: r1618024 - in /subversion/trunk/subversion: libsvn_client/merge.c libsvn_wc/tree_conflicts.c

2014-08-18 Thread Stefan Sperling
On Mon, Aug 18, 2014 at 02:33:38PM +0200, Bert Huijben wrote: -Original Message- From: s...@apache.org [mailto:s...@apache.org] Sent: donderdag 14 augustus 2014 21:23 To: commits@subversion.apache.org Subject: svn commit: r1618024 - in /subversion/trunk/subversion:

Re: svn commit: r1618643 - in /subversion/trunk/subversion:include/svn_wc.h libsvn_wc/info.c

2014-08-18 Thread Stefan Sperling
On Mon, Aug 18, 2014 at 06:40:16PM +0200, Bert Huijben wrote: Can you document how property conflicts are stored in this array. For the previous versions we have multiple ways to encode these. An info call is pretty performance critical for many gui clients so it shouldn't start creating

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-08-11 Thread Stefan Fuhrmann
On Fri, Jul 4, 2014 at 6:29 PM, Ivan Zhakov i...@visualsvn.com wrote: On 30 June 2014 14:19, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On Fri, Jun 27, 2014 at 12:55 PM, Ivan Zhakov i...@visualsvn.com wrote: On 26 June 2014 19:08, Stefan Fuhrmann stefan.fuhrm...@wandisco.com

Re: svn commit: r1589284 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.c hotcopy.c hotcopy.h

2014-08-06 Thread Stefan Fuhrmann
On Mon, Jul 28, 2014 at 2:27 AM, Evgeny Kotkov evgeny.kot...@visualsvn.com wrote: Hi Stefan, I recently stumbled upon this changeset and I had some time to review it. I think that the things should not be done this way. As I see it, this change breaks one fundamental aspect of the non

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-30 Thread Stefan Fuhrmann
On Fri, Jun 27, 2014 at 12:55 PM, Ivan Zhakov i...@visualsvn.com wrote: On 26 June 2014 19:08, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: Hi Ivan, I see three alternative ways to code that function 1. As hard coded string / byte sequence (current implementation). Cons

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-26 Thread Stefan Fuhrmann
On Thu, Jun 26, 2014 at 11:52 AM, Ivan Zhakov i...@visualsvn.com wrote: On 25 June 2014 22:11, Daniel Shahaf d...@daniel.shahaf.name wrote: Ivan Zhakov wrote on Wed, Jun 25, 2014 at 20:03:11 +0400: On 25 June 2014 19:54, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On Wed, Jun 25

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-26 Thread Stefan Sperling
On Thu, Jun 26, 2014 at 05:08:38PM +0200, Stefan Fuhrmann wrote: I see three alternative ways to code that function 1. As hard coded string / byte sequence (current implementation). Cons: * Hard to write, hard to review by just looking at it (applies to time until initial release only

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Stefan Fuhrmann
an apr_size_t* to an interface expecting an apr_size_t*. What am I missing? -- Stefan^2.

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 5:46 PM, Ivan Zhakov i...@visualsvn.com wrote: On 25 June 2014 19:24, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On Wed, Jun 25, 2014 at 4:57 PM, Ivan Zhakov i...@visualsvn.com wrote: On 21 June 2014 17:15, stef...@apache.org wrote: Author: stefan2

Re: svn commit: r1588651 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.c fs_fs.h

2014-04-20 Thread Stefan Fuhrmann
actually being cleared up. So, having a clear-able subpool can be a (usually minor) improvement. -- Stefan^2.

Re: svn commit: r1586947 - in /subversion/trunk/subversion/libsvn_fs_fs: dag.c dag.h tree.c

2014-04-14 Thread Stefan Fuhrmann
of figuring out why some operations e.g. scale better in Apache than svnserve. This is one of the things that came up. Now, both are faster with svnserve seeing a slightly larger improvement. -- Stefan^2.

Re: svn commit: r1581587 - /subversion/site/publish/docs/release-notes/1.9.html

2014-03-26 Thread Stefan Fuhrmann
and the other findings went into r1582124. -- Stefan^2.

Re: svn commit: r1577835 - /subversion/trunk/subversion/svn/svn.c

2014-03-15 Thread Stefan Sperling
On Sat, Mar 15, 2014 at 03:11:09PM +0100, Bert Huijben wrote: opt_allow_mixed_revisions, 'v'}, -{ { opt_force, N_(force deletions even if the contents doesn't match) } } +{ { opt_force, N_(force deletions even if deleted contents don't match) As far as I can tell it is

Re: svn commit: r1575525 - in /subversion/trunk/subversion: libsvn_client/export.c tests/cmdline/export_tests.py

2014-03-10 Thread Stefan Sperling
On Sat, Mar 08, 2014 at 08:53:39PM +, Bert Huijben wrote: This 'check via explicit target’ would also fix calling 'svn export’ directly on a file external, which is probably still broken after this patch. Thanks for fixing it in r1575915 :) I figured that a lazy fix of mine would make

Re: svn commit: r1575525 - in /subversion/trunk/subversion: libsvn_client/export.c tests/cmdline/export_tests.py

2014-03-10 Thread Stefan Sperling
On Mon, Mar 10, 2014 at 03:25:16PM +0100, Bert Huijben wrote: -Original Message- From: Stefan Sperling [mailto:s...@elego.de] Sent: maandag 10 maart 2014 14:54 To: Bert Huijben Cc: commits@subversion.apache.org; d...@subversion.apache.org Subject: Re: svn commit: r1575525

Re: svn commit: r1575428 - /subversion/trunk/subversion/libsvn_fs_fs/fs.h

2014-03-08 Thread Stefan Fuhrmann
On Sat, Mar 8, 2014 at 12:25 AM, Ben Reser b...@reser.org wrote: On 3/7/14, 3:11 PM, Stefan Fuhrmann wrote: Two comments: * The keys are being used one-way, i.e. any type input type will do *nod* I realize it's safe. But the problem is that we know we have a type that isn't stable

Re: svn commit: r1575428 - /subversion/trunk/subversion/libsvn_fs_fs/fs.h

2014-03-07 Thread Stefan Fuhrmann
the inconsistency. Two comments: * The keys are being used one-way, i.e. any type input type will do * Padding is horrible because it inserts sections of random data into a *hash* key. Valgrind might find these instances, if run on Windows. -- Stefan^2.

Re: svn commit: r1572105 - in /subversion/trunk/subversion: svn/auth-cmd.c svn/cl.h svn/svn.c tests/cmdline/getopt_tests_data/svn--help_stdout tests/cmdline/getopt_tests_data/svn_help_stdout

2014-02-27 Thread Stefan Sperling
On Wed, Feb 26, 2014 at 11:28:31PM +, Daniel Shahaf wrote: s...@apache.org wrote on Wed, Feb 26, 2014 at 15:48:06 -: Author: stsp Date: Wed Feb 26 15:48:06 2014 New Revision: 1572105 URL: http://svn.apache.org/r1572105 Log: Introduce 'svn auth', a subcommand for managing

Re: svn commit: r1570936 - /subversion/trunk/subversion/libsvn_client/blame.c

2014-02-23 Thread Stefan Fuhrmann
the fundamental shortcomings of blame nor do I intend to address them any time soon. I simply wanted to remove the behavioral dependency on FS implementation details. That's what this patch does and tests pass with FSX again. -- Stefan^2.

Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c

2014-01-20 Thread Stefan Fuhrmann
we don't have to remember to update this everytime? Doesn't help if we change the major, but the code already has that issue. I guess there was a following in r1547035 that would have made it SVN_VER_MINOR. Good point. Fixed in r1559869. -- Stefan^2.

Re: svn commit: r1558224 - in /subversion/trunk/subversion:libsvn_fs_fs/tree.c libsvn_fs_x/tree.c tests/libsvn_fs/fs-test.c

2014-01-14 Thread Stefan Fuhrmann
Hi Bert, We only accept incoming prop changes if there were no prop changes at the directory. -- Stefan^2. On Tue, Jan 14, 2014 at 11:39 PM, Bert Huijben b...@qqmail.nl wrote: How do we now check that property changes don't conflict? Before this patch we assumed that the client code would

Re: svn commit: r1555350 -/subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread Stefan Fuhrmann
function. -- Stefan^2. -- From: stef...@apache.org Sent: 4-1-2014 15:05 To: commits@subversion.apache.org Subject: svn commit: r1555350 -/subversion/trunk/subversion/libsvn_client/mtcc.c Author: stefan2 Date: Sat Jan 4 14:04:36 2014 New Revision: 1555350 URL

Re: svn commit: r1555350 -/subversion/trunk/subversion/libsvn_client/mtcc.c

2014-01-04 Thread Stefan Fuhrmann
* allocate the editor in the same pool as the ra layer (current code) which would not mean a extra memory consumption in the o.k. case. -- Stefan^2. On Sun, Jan 5, 2014 at 12:07 AM, Bert Huijben b...@qqmail.nl wrote: In the case of svnmucc the passed scratch pool is a subpool of the pool

Re: svn commit: r1554619 - in /subversion/trunk: subversion/include/ subversion/libsvn_client/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subversion/libsvn_ra/ subversion/libsvn_ra_serf/ subvers

2014-01-02 Thread Stefan Fuhrmann
-Ng work) What output parameters are you talking about? -- Stefan^2.

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-04 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 06:16:40PM -, phi...@apache.org wrote: Author: philip Date: Wed Dec 4 18:16:40 2013 New Revision: 1547866 URL: http://svn.apache.org/r1547866 Log: Fix issue 3437, rep-cache.db created with wrong permissions. * subversion/libsvn_fs_fs/rep-cache.c

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-04 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 07:36:57PM +0100, Stefan Sperling wrote: On Wed, Dec 04, 2013 at 06:16:40PM -, phi...@apache.org wrote: Author: philip Date: Wed Dec 4 18:16:40 2013 New Revision: 1547866 URL: http://svn.apache.org/r1547866 Log: Fix issue 3437, rep-cache.db created

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2013-12-04 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 06:38:05PM -, phi...@apache.org wrote: Author: philip Date: Wed Dec 4 18:38:04 2013 New Revision: 1547873 URL: http://svn.apache.org/r1547873 Log: Another part of issue 3437, rep-cache.db created with wrong permissions. * subversion/libsvn_subr/sqlite.c

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2013-12-04 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 07:53:40PM +0100, Stefan Sperling wrote: On Wed, Dec 04, 2013 at 06:38:05PM -, phi...@apache.org wrote: @@ -1314,6 +1314,12 @@ svn_sqlite__hotcopy(const char *src_path svn_sqlite__db_t *dst_db; sqlite3_backup *backup; int rc1, rc2

Re: svn commit: r1547460 - /subversion/trunk/subversion/tests/libsvn_repos/repos-test.c

2013-12-03 Thread Stefan Fuhrmann
. In particular, the test explicitly requests mergeinfo from that API. -- Stefan^2.

Re: svn commit: r1546114 - in /subversion/trunk: ./ subversion/libsvn_fs_x/ subversion/svnadmin/svnadmin.c subversion/tests/cmdline/svnadmin_tests.py subversion/tests/libsvn_fs_x/

2013-11-27 Thread Stefan Sperling
On Wed, Nov 27, 2013 at 10:38:02PM +0200, Daniel Shahaf wrote: s...@apache.org wrote on Wed, Nov 27, 2013 at 17:08:02 -: @@ -1696,15 +1741,63 @@ subcommand_verify(apr_getopt_t *os, void + /* Show the --keep-going error summary. */ + if (opt_state-keep_going

Re: svn commit: r1544716 - /subversion/trunk/subversion/libsvn_subr/config_file.c

2013-11-23 Thread Stefan Fuhrmann
for the review! -- Stefan^2

Re: svn commit: r1533392 - in /subversion/trunk/subversion: libsvn_client/list.c libsvn_ra_svn/client.c

2013-10-20 Thread Stefan Fuhrmann
On Fri, Oct 18, 2013 at 6:38 PM, C. Michael Pilato cmpil...@collab.netwrote: On 10/18/2013 12:20 PM, Stefan Fuhrmann wrote: On Fri, Oct 18, 2013 at 5:44 PM, Bert Huijben b...@qqmail.nl Then most likely there is a difference between implementation and documentation svn ls -R

Re: svn commit: r1533392 - in /subversion/trunk/subversion: libsvn_client/list.c libsvn_ra_svn/client.c

2013-10-18 Thread Stefan Fuhrmann
. As it turns out, the path gets combined above the RA layer in lib_client. I spent most of today figuring out why svn ls -R left my laptop idle (see r1533530), so I had exactly the use-case that you described. -- Stefan^2.

Re: svn commit: r1523465 - /subversion/trunk/subversion/svnserve/svnserve.c

2013-09-15 Thread Stefan Fuhrmann
at least release the used memory (and thate) when handing back the memory to the pool allocator? -- Stefan^2.

Re: svn commit: r1517472 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h update.c util.c

2013-08-26 Thread Stefan Sperling
On Mon, Aug 26, 2013 at 09:15:45AM -, i...@apache.org wrote: Author: ivan Date: Mon Aug 26 09:15:44 2013 New Revision: 1517472 URL: http://svn.apache.org/r1517472 Log: ra_serf: Remove DAV: headers from GET requests. This decrease outbound traffic during checkout/update by 45%. *

Re: svn commit: r1517472 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h update.c util.c

2013-08-26 Thread Stefan Sperling
On Mon, Aug 26, 2013 at 01:33:04PM +0400, Ivan Zhakov wrote: Done in r1517478. Thanks. But the comment still doesn't explain _why_ GET headers do not need the extra DAV headers. Issue #3255 doesn't mention GET requests anywhere. Can we explain the reason in the comment so that readers of the

Re: svn commit: r1515378 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c

2013-08-20 Thread Stefan Fuhrmann
svn_test_opts_t *op svn_stringbuf_t *rstring; svn_revnum_t i; - /* Bail (with success) on known-untestable scenarios */ - if ((strcmp(opts-fs_type, fsfs) != 0) - || (opts-server_minor_version (opts-server_minor_version 6))) -return SVN_NO_ERROR; - Stefan, With this change

Re: svn commit: r1512319 - /subversion/trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c

2013-08-11 Thread Stefan Fuhrmann
) != 0) + || (opts-server_minor_version (opts-server_minor_version 8))) s/8/9/ +return SVN_NO_ERROR; Fixed in several places with r1513012. Thanks for the review! -- Stefan^2.

Re: Log messages Re: svn commit: r1505729 - /subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs/cache d_data.c

2013-08-04 Thread Stefan Fuhrmann
into shared functions. -- Stefan^2,

Re: svn commit: r1506576 - in /subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs: fs.h fs_fs.c low_level.c temp_serializer.c transaction.c

2013-08-04 Thread Stefan Fuhrmann
'structure' has striken again. (Incidentally, trunk/subversion/libsvn_fs_x/structure is wrong --- it describes FSFS f6, not FSX.) I am aware that the binary structure of FSX is not defined, yet. I updated the file in r1510158. -- Stefan^2.

Re: svn commit: r1506576 - in /subversion/branches/fsfs-improvements/subversion/libsvn_fs_fs: fs.h fs_fs.c low_level.c temp_serializer.c transaction.c

2013-08-04 Thread Stefan Fuhrmann
number; +} uniquifier; } representation_t; A later commit moved this to node_revision_t I think; Which later commit? This struct has never been (intentionally) moved. -- Stefan^2. shouldn't the pointer in structure:471 be updated? (and I'm not sure if the statement in structure:555

Re: svn commit: r1506978 - in /subversion/branches/fsfs-improvements/subversion: libsvn_fs_fs/caching.c svnserve/svnserve.c

2013-08-04 Thread Stefan Fuhrmann
On Sun, Aug 4, 2013 at 9:18 AM, Daniel Shahaf danie...@elego.de wrote: Need to update mod_dav_svn.c:1176 as well Fixed in r1510166 with a minor addition. Thanks for the review! -- Stefan^2.

  1   2   >