On Tue, Jan 11, 2022 at 12:22:38AM -0500, Nathan Hartman wrote:
> On Mon, Jan 10, 2022 at 6:44 AM wrote:
> >
> > Author: stsp
> > Date: Mon Jan 10 11:44:46 2022
> > New Revision: 1896877
> >
> > URL: http://svn.apache.org/viewvc?rev=1896877&view=rev
> > Log:
> > Fix misleading -r option documentat
On Sat, Aug 21, 2021 at 09:38:56PM +0200, Daniel Sahlberg wrote:
> > @@ -3028,12 +3028,12 @@ conflict_tree_get_details_local_missing(
> >deleted_basename,
> >conflict->pool);
> >detai
On Tue, Feb 16, 2021 at 01:05:32PM +0100, Daniel Sahlberg wrote:
> Den tis 16 feb. 2021 kl 11:34 skrev Stefan Sperling :
> > On Mon, Feb 15, 2021 at 07:46:08PM +, Daniel Shahaf wrote:
> > > The entity referred to by the tag wasn't created in 2021. So,
> > > I
On Mon, Feb 15, 2021 at 07:46:08PM +, Daniel Shahaf wrote:
> s...@apache.org wrote on Wed, Feb 10, 2021 at 20:39:23 -:
> > Author: stsp
> > Date: Wed Feb 10 20:39:22 2021
> > New Revision: 1886396
> >
> > URL: http://svn.apache.org/viewvc?rev=1886396&view=rev
> > Log:
> > site/publish: Mer
On Wed, Feb 10, 2021 at 08:30:52PM +0100, Daniel Sahlberg wrote:
> *grabbing a commit in the pile*
>
> Is it intentional that the download page still links to 1.14.0 (and 1.10.6)?
>
> (I'm not familiar with the relase workflow and I realise this may be a soak
> for all mirrors to pick up the rela
On Mon, Dec 21, 2020 at 07:15:53AM +, Daniel Shahaf wrote:
> s...@apache.org wrote on Mon, 14 Dec 2020 16:57 -:
> > URL: http://svn.apache.org/viewvc?rev=1884427&view=rev
> > Log:
> > Make mailer.py work properly with Python 3, and drop Python 2 support.
> >
> > Most of the changes deal wi
On Sat, Oct 03, 2020 at 06:07:49AM +, Daniel Shahaf wrote:
> Sounds like this change merits an entry in the 1.14 release notes (if
> it's backported) or in the 1.15 release notes if it's not backported.
> Would you please add a placeholder (just a section header or a ToC
> link) or file a corre
On Thu, May 28, 2020 at 03:03:40AM +, Daniel Shahaf wrote:
> s...@apache.org wrote on Wed, 27 May 2020 14:34 -:
> > Author: stsp
> > Date: Wed May 27 14:34:18 2020
> > New Revision: 1878162
> >
> > URL: http://svn.apache.org/viewvc?rev=1878162&view=rev
> > Log:
> > * tools/dist/release-lin
On Wed, Aug 23, 2017 at 04:09:55PM +, Daniel Shahaf wrote:
> s...@apache.org wrote on Mon, 21 Aug 2017 12:49 +:
> > Author: stsp
> > Date: Mon Aug 21 12:49:42 2017
> > New Revision: 1805627
> >
> > URL: http://svn.apache.org/viewvc?rev=1805627&view=rev
> > Log:
> > Follow-up to r1805620: F
On Fri, Aug 18, 2017 at 05:33:14PM +, Daniel Shahaf wrote:
> s...@apache.org wrote on Fri, 18 Aug 2017 10:33 +:
> > +++ subversion/site/publish/security/CVE-2017-9800-advisory.txt Fri Aug 18
> > 10:33:10 2017
> > @@ -80,24 +96,36 @@ Recommendations:
> >the included patch.
> >
> >
On Wed, Jul 26, 2017 at 02:41:31PM +0300, Evgeny Kotkov wrote:
> Stefan Sperling writes:
>
> > Sounds like we're headed in a good direction :-)
>
> One particular thing that bothers me about using LZ4 as the new default
> is that I think that a decision like that go
On Wed, Jul 26, 2017 at 01:18:00PM +0300, Evgeny Kotkov wrote:
> Stefan Sperling writes:
>
> > Does mod_dav_svn really need an option for this?
> >
> > Can't lz4 (svndiff2) be negotiated as a mutual protocol capability of
> > client and server? Why won't a
On Mon, Jul 24, 2017 at 07:19:09PM +0300, Evgeny Kotkov wrote:
> However, there are a couple of difficulties with porting this approach to
> mod_dav_svn, i.e., if we introduce the SVNCompression directive. There
> are clients that don't use LZ4, so, presumably, this options would require
> specify
On Wed, May 10, 2017 at 09:11:50AM +, Daniel Shahaf wrote:
> > Summary:
> >
> >
> > Subversion repositories can be corrupted by committing two files
> > which have different content, yet produce the same SHA1 checksum.
>
> I don't think we should call this "corruption": the on-di
On Thu, Apr 21, 2016 at 09:40:07AM +0200, Branko Čibej wrote:
> It is wrong to use conflict->local_abspath to construct the relative
> URL.
Yes, it is.
But where is the alleged code that does this? I don't see it.
And I don't think I've written it.
On Wed, Apr 20, 2016 at 10:19:56PM +0200, Bert Huijben wrote:
> The path calculation here 100% assumes that the working copy is always a
> clean check out from ^/. This might be the case in our test suite, but in
> almost every normal user scenario this isn’t the case.
>
> You can’t just calcula
On Sat, Jun 27, 2015 at 09:08:29PM +, Bert Huijben wrote:
> > > Author: stsp
> > > Date: Sat Jun 27 10:35:42 2015
> > > New Revision: 1687906
> > >
> > > URL: http://svn.apache.org/r1687906
> > > Log:
> > > Add a conflict walker to the new svn_client_conflict API.
> > >
> > > Contrary to our
On Thu, May 07, 2015 at 03:19:55PM +0200, Bert Huijben wrote:
> Your log message documents this change as 'This way, the hash parser's error
> message is preserved.', which is not what this change does.
The docstring of svn_error_quick_wrap fooled me. I've reverted
r1678151 and improved the docst
On Sun, Apr 19, 2015 at 05:57:54PM +0200, Bert Huijben wrote:
> Why do you set the header if you can just set the parsed depth value even
> more locally as I did in my patch I sent as reply on the thread?
I could not find your patch in the thread with subject
"branching over mod_dav 2.4.6 is O(tr
On Mon, Aug 18, 2014 at 06:40:16PM +0200, Bert Huijben wrote:
> Can you document how property conflicts are stored in this array. For the
> previous versions we have multiple ways to encode these.
>
> An info call is pretty performance critical for many gui clients so it
> shouldn't start creati
On Mon, Aug 18, 2014 at 02:33:38PM +0200, Bert Huijben wrote:
> > -Original Message-
> > From: s...@apache.org [mailto:s...@apache.org]
> > Sent: donderdag 14 augustus 2014 21:23
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1618024 - in /subversion/trunk/subversion:
> > l
On Thu, Jun 26, 2014 at 05:08:38PM +0200, Stefan Fuhrmann wrote:
> I see three alternative ways to code that function
>
> 1. As hard coded string / byte sequence (current implementation).
> Cons:
> * Hard to write, hard to review by just looking at it (applies to time
> until initial release o
On Sat, Mar 15, 2014 at 03:11:09PM +0100, Bert Huijben wrote:
> > opt_allow_mixed_revisions, 'v'},
> > -{ { opt_force, N_("force deletions even if the contents doesn't
> > match") } }
> > +{ { opt_force, N_("force deletions even if deleted contents don't
> > match")
>
> As far as I
On Mon, Mar 10, 2014 at 03:25:16PM +0100, Bert Huijben wrote:
> > -Original Message-
> > From: Stefan Sperling [mailto:s...@elego.de]
> > Sent: maandag 10 maart 2014 14:54
> > To: Bert Huijben
> > Cc: commits@subversion.apache.org; d...@subversion.apache.o
On Sat, Mar 08, 2014 at 08:53:39PM +, Bert Huijben wrote:
> This 'check via explicit target’ would also fix calling 'svn export’ directly
> on a file external, which is probably still broken after this patch.
>
Thanks for fixing it in r1575915 :)
I figured that a lazy "fix" of mine would ma
On Wed, Feb 26, 2014 at 11:28:31PM +, Daniel Shahaf wrote:
> s...@apache.org wrote on Wed, Feb 26, 2014 at 15:48:06 -:
> > Author: stsp
> > Date: Wed Feb 26 15:48:06 2014
> > New Revision: 1572105
> >
> > URL: http://svn.apache.org/r1572105
> > Log:
> > Introduce 'svn auth', a subcommand f
On Wed, Dec 04, 2013 at 07:53:40PM +0100, Stefan Sperling wrote:
> On Wed, Dec 04, 2013 at 06:38:05PM -, phi...@apache.org wrote:
> > @@ -1314,6 +1314,12 @@ svn_sqlite__hotcopy(const char *src_path
> > svn_sqlite__db_t *dst_db;
> > sqlite3_backup *backup;
On Wed, Dec 04, 2013 at 06:38:05PM -, phi...@apache.org wrote:
> Author: philip
> Date: Wed Dec 4 18:38:04 2013
> New Revision: 1547873
>
> URL: http://svn.apache.org/r1547873
> Log:
> Another part of issue 3437, rep-cache.db created with wrong permissions.
>
> * subversion/libsvn_subr/sqlit
On Wed, Dec 04, 2013 at 07:36:57PM +0100, Stefan Sperling wrote:
> On Wed, Dec 04, 2013 at 06:16:40PM -, phi...@apache.org wrote:
> > Author: philip
> > Date: Wed Dec 4 18:16:40 2013
> > New Revision: 1547866
> >
> > URL: http://svn.apache.org/r1547866
On Wed, Dec 04, 2013 at 06:16:40PM -, phi...@apache.org wrote:
> Author: philip
> Date: Wed Dec 4 18:16:40 2013
> New Revision: 1547866
>
> URL: http://svn.apache.org/r1547866
> Log:
> Fix issue 3437, rep-cache.db created with wrong permissions.
>
> * subversion/libsvn_fs_fs/rep-cache.c
>
On Wed, Nov 27, 2013 at 10:38:02PM +0200, Daniel Shahaf wrote:
> s...@apache.org wrote on Wed, Nov 27, 2013 at 17:08:02 -:
> > @@ -1696,15 +1741,63 @@ subcommand_verify(apr_getopt_t *os, void
> > + /* Show the --keep-going error summary. */
> > + if (opt_state->keep_going && notify_baton.erro
On Mon, Aug 26, 2013 at 01:33:04PM +0400, Ivan Zhakov wrote:
> Done in r1517478.
Thanks. But the comment still doesn't explain _why_ GET headers
do not need the extra DAV headers. Issue #3255 doesn't mention
GET requests anywhere.
Can we explain the reason in the comment so that readers of the
co
On Mon, Aug 26, 2013 at 09:15:45AM -, i...@apache.org wrote:
> Author: ivan
> Date: Mon Aug 26 09:15:44 2013
> New Revision: 1517472
>
> URL: http://svn.apache.org/r1517472
> Log:
> ra_serf: Remove DAV: headers from GET requests. This decrease outbound
> traffic during checkout/update by 45%.
On Fri, Aug 09, 2013 at 02:19:33PM -0700, Bert Huijben wrote:
> If your scons is new enough it should handle rpath for you. It does
> handle rpath on other platforms.
It does not handle rpath for me. See this serf issue:
http://code.google.com/p/serf/issues/detail?id=118
On Sat, May 25, 2013 at 10:22:35AM +0100, Philip Martin wrote:
> Bert Huijben writes:
> > The diff command should never change the wc(no wclock, and no
> > db/pristine changes), so I really hope the problem that corrupts is
> > part of the merge on update, or we should check for another problem.
>
On Wed, Dec 19, 2012 at 08:18:44PM +0100, Bert Huijben wrote:
> > + /* If stdin is not a terminal and --force-interactive was not passed,
> > + * set --non-interactive. */
> > + if (!opt_state.force_interactive)
> > + opt_state.non_interactive = !svn_cmdline__stdin_isatty();
> > +
>
> Thi
On Wed, Dec 05, 2012 at 08:54:05PM -, l...@apache.org wrote:
> Author: lgo
> Date: Wed Dec 5 20:54:03 2012
> New Revision: 1417642
>
> URL: http://svn.apache.org/viewvc?rev=1417642&view=rev
> Log:
> Add a bulk-updates option to the global and per-server section in servers.
> This allows a use
On Tue, Sep 04, 2012 at 03:01:22PM -0400, Paul Burba wrote:
> I just noticed that this causes a segfault when updating with the quiet
> option:
>
> [[[
>
> C:\SVN\src-trunk>svn up
> Updating '.':
> At revision 1380738.
>
> C:\SVN\src-trunk>svn up -q
> This application has halted due to an unexp
On Tue, Jun 26, 2012 at 12:15:00AM +0200, Stephen Butler wrote:
>
> On Jun 25, 2012, at 23:25 , s...@apache.org wrote:
>
> > Author: stsp
> > Date: Mon Jun 25 21:25:47 2012
> > New Revision: 1353748
> >
> > URL: http://svn.apache.org/viewvc?rev=1353748&view=rev
> > Log:
> > Following up to r1353
On Sun, May 13, 2012 at 01:50:01PM +0200, Bert Huijben wrote:
> > -Original Message-
> > From: s...@apache.org [mailto:s...@apache.org]
> > Sent: zondag 13 mei 2012 13:07
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1337844 -
> > /subversion/trunk/subversion/libsvn_wc/con
On Thu, Apr 26, 2012 at 07:44:21AM +0300, Daniel Shahaf wrote:
> s...@apache.org wrote on Wed, Apr 25, 2012 at 21:38:08 -:
> > Author: stsp
> > Date: Wed Apr 25 21:38:08 2012
> > New Revision: 1330571
> > - else if (serr && serr->apr_err == SVN_ERR_REPOS_HOOK_FAILURE)
> > + else if (serr &&
On Thu, Apr 26, 2012 at 07:45:48AM +0300, Daniel Shahaf wrote:
> You need:
>
> else if (serr)
>/* do something */
That is there. It is just not visible in the context of the diff.
On Sat, Mar 24, 2012 at 07:18:41PM +0200, Daniel Shahaf wrote:
> s...@apache.org wrote on Thu, Mar 22, 2012 at 19:04:19 -:
> > Author: stsp
> > Date: Thu Mar 22 19:04:19 2012
> > New Revision: 1303987
> >
> > URL: http://svn.apache.org/viewvc?rev=1303987&view=rev
> > Log:
> > * tools/dist/dist
On Fri, Mar 09, 2012 at 07:23:41AM -0600, Hyrum K Wright wrote:
> Did you use the 'write-news' target of release.py to generate this
> template?
Yes I did.
> I thought that it would Do The Right Things, but apparently not...
Well, it got most things right :)
On Tue, Mar 06, 2012 at 12:39:27PM +, Julian Foad wrote:
> Daniel Shahaf wrote:
>
> > Daniel Shahaf wrote on Mon, Feb 06, 2012 at 18:20:28 +0200:
> >> Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100:
> >> > On Mon, Feb 06, 2012 at 05:5
On Mon, Feb 27, 2012 at 09:40:57AM +, Julian Foad wrote:
> stevek...@apache.org wrote on Sun, Feb 26, 2012 at 07:47:02 -:
>
> > + * r1235831, r1236099
> > + Tweak the parsing of the ssl-authority-files config option to make it
> > + easier for users to configure.
> > + Justificat
On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote:
> This still strips whitespace around ='s in the value:
> SVNHooksEnv "name = x = y"
> will result in
> setenv("name", "x=y", 1)
> whereas I believe it should result in
> setenv("name", "x = y", 1)
> (and, to be honest, I'd
On Fri, Feb 03, 2012 at 11:07:39AM +0200, Daniel Shahaf wrote:
> s...@apache.org wrote on Fri, Feb 03, 2012 at 01:02:08 -:
> > +static const char *
> > +SVNHooksEnv_cmd(cmd_parms *cmd, void *config, const char *arg1)
> > +{
> > + apr_array_header_t *var;
> > +
> > + var = svn_cstring_split(ar
On Thu, Feb 02, 2012 at 07:13:46AM -0600, Hyrum K Wright wrote:
> Bikeshed: since the fact that we are using diff is implied by the
> subcommand, would it be reasonable to use a more generic option name,
> such as '--ignore-props' instead of '--no-diff-properties'. It is
> shorter firstly, and sec
On Fri, Dec 23, 2011 at 11:25:37AM +0100, Stefan Sperling wrote:
> On Fri, Dec 23, 2011 at 10:40:59AM +0400, Konstantin Kolinko wrote:
> > I would say that URL and UUID should be enough.
>
> The repos_id is useful information for developers trying to help users
> with debugg
On Fri, Dec 23, 2011 at 04:10:07PM +0200, Daniel Shahaf wrote:
> On Fri, Dec 23, 2011, at 14:50, Stefan Sperling wrote:
> > On Fri, Dec 23, 2011 at 02:26:40PM +0200, Daniel Shahaf wrote:
> > > On Fri, Dec 23, 2011, at 13:01, Stefan Sperling wrote:
> > > > On Fri, De
On Fri, Dec 23, 2011 at 02:26:40PM +0200, Daniel Shahaf wrote:
> On Fri, Dec 23, 2011, at 13:01, Stefan Sperling wrote:
> > On Fri, Dec 23, 2011 at 01:48:18PM +0200, Daniel Shahaf wrote:
> > > s...@apache.org wrote on Fri, Dec 23, 2011 at 00:35:16 -:
> > > > +
On Fri, Dec 23, 2011 at 01:48:18PM +0200, Daniel Shahaf wrote:
> s...@apache.org wrote on Fri, Dec 23, 2011 at 00:35:16 -:
> > + An informative error message helps people more than an assert (which
> > + in case of TSVN can mean crashing the Windows Explorer).
>
> I thought the svn_err
On Fri, Dec 23, 2011 at 10:40:59AM +0400, Konstantin Kolinko wrote:
> 2011/12/23 Hyrum K Wright :
> > Yikes! I think this wins the prize for "longest function call".
> > Perhaps a helper function or at least some temporary variables would
> > be in order?
I look into that, sure.
> I would say t
On Sat, Nov 19, 2011 at 08:48:47PM +0200, Daniel Shahaf wrote:
> s...@apache.org wrote on Sat, Nov 19, 2011 at 18:34:53 -:
> > Author: stsp
> > Date: Sat Nov 19 18:34:52 2011
> > New Revision: 1204035
> >
> > URL: http://svn.apache.org/viewvc?rev=1204035&view=rev
> > Log:
> > On the moves-scan
On Fri, Nov 18, 2011 at 03:07:11PM +0100, Stefan Sperling wrote:
> On Fri, Nov 18, 2011 at 02:52:44PM +0100, Stefan Sperling wrote:
> > Suggestion (not tested);
> >
> > ap_log_error(APLOG_MARK, APLOG_WARNING, 0, NULL,
> >"mod_dav_
On Fri, Nov 18, 2011 at 02:52:44PM +0100, Stefan Sperling wrote:
> Suggestion (not tested);
>
> ap_log_error(APLOG_MARK, APLOG_WARNING, 0, NULL,
>"mod_dav_svn: nested Location '%s' inside "
>"SVNPath Loca
On Fri, Nov 18, 2011 at 01:37:24PM +, Philip Martin wrote:
> phi...@apache.org writes:
>
> > Author: philip
> > Date: Fri Nov 18 09:09:56 2011
> > New Revision: 1203546
>
> > Also, a nested Location inside an SVNPath Location is ambiguous so
> > prevent access and log the problem.
>
> > + i
On Mon, Aug 15, 2011 at 07:18:18AM -0500, Hyrum K Wright wrote:
> Do we do this other places in our code, or does this introduce a new pattern?
We do this in lots of places.
> It *does* introduce new "format not a string literal, argument types
> not checked" warnings at compile-time.
Those warn
On Thu, Jun 09, 2011 at 09:01:09PM +0200, Bert Huijben wrote:
>
>
> > -Original Message-
> > From: s...@apache.org [mailto:s...@apache.org]
> > Sent: donderdag 9 juni 2011 20:40
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1134032 -
> > /subversion/trunk/subversion/svns
On Mon, Feb 28, 2011 at 10:03:45AM +0530, Noorul Islam K M wrote:
> >> Pinging to get some attention to this thread.
> >
> > Hi Noorul,
> >
> > I can't evaluate this patch since I don't have a linux box.
> >
> $ make check MILESTONE_FILTER="(1.7.*)|(---)" MODE_FILTER=xfail
> TESTS=subversion/test
On Mon, Jun 06, 2011 at 12:09:50PM +0100, Julian Foad wrote:
> but I'm -0.9 on allowing more than one additional prefix:
>
> svn log -r rr123
> svn log -crr123
> etc.
>
> because no sensible use case including yours requires this. However, as
> it's been allowed for some time now and i
On Mon, Jun 06, 2011 at 10:17:01AM +0100, Julian Foad wrote:
> FWIW the original reasoning is in Karl's comment in parse_one_rev():
>
> /* Allow any number of 'r's to prefix a revision number, because
> that way if a script pastes svn output into another svn command
> (like "svn log -r
On Tue, Feb 22, 2011 at 12:18:36PM -0500, C. Michael Pilato wrote:
> On 02/22/2011 08:51 AM, s...@apache.org wrote:
> > Author: stsp
> > Date: Tue Feb 22 13:51:16 2011
> > New Revision: 1073325
>
> [...]
>
> > In some situations users might want to use a different configuration file
> > to config
On Thu, Sep 02, 2010 at 03:33:13PM -0400, Paul Burba wrote:
> On Thu, Sep 2, 2010 at 3:18 PM, Bert Huijben wrote:
> > $ python
> > ActivePython 2.6.1.1 (ActiveState Software Inc.) based on
> > Python 2.6.1 (r261:67515, Dec 5 2008, 13:58:38) [MSC v.1500 32 bit
> > (Intel)] on
> > win32
> > Type "
65 matches
Mail list logo
