Re: svn commit: r1825045 - /subversion/trunk/subversion/svn/svn.c

2018-03-24 Thread Daniel Shahaf
julianf...@apache.org wrote on Thu, 22 Feb 2018 11:02 +:
> +++ subversion/trunk/subversion/svn/svn.c Thu Feb 22 11:02:02 2018
> @@ -1831,7 +1831,7 @@ const svn_opt_subcommand_desc2_t svn_cl_
>   "\n"
>   "  To bring back a shelved change, use 'svn unshelve NAME'.\n"
>   "\n"
> - "  A shelved change is stored as a patch file, 
> .svn/shelves/NAME.patch\n"
> + "  Shelved changes are stored in /.svn/shelves/\n"

I noticed this line while reviewing the backport and wanted to ask, why
do we document the storage location publicly?  We don't generally
promise anything about the internal structure of .svn/ so this would
be a first.

Cheers,

Daniel

>   "\n"
>   "  The shelving feature is EXPERIMENTAL. This command is likely to 
> change\n"
>   "  in the next release, and there is no promise of backward 
> compatibility.\n"


svn commit: r1825045 - /subversion/trunk/subversion/svn/svn.c

2018-02-22 Thread julianfoad
Author: julianfoad
Date: Thu Feb 22 11:02:02 2018
New Revision: 1825045

URL: http://svn.apache.org/viewvc?rev=1825045=rev
Log:
Shelving: correct the help text for shelving v1 storage location.

The patch file names are encoded now, following r1821678.

(This code is #ifdef'd out.)

* subversion/svn/svn.c
  (svn_cl__cmd_table): Correct the note in v1 'shelve' usage.

Modified:
subversion/trunk/subversion/svn/svn.c

Modified: subversion/trunk/subversion/svn/svn.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/svn.c?rev=1825045=1825044=1825045=diff
==
--- subversion/trunk/subversion/svn/svn.c (original)
+++ subversion/trunk/subversion/svn/svn.c Thu Feb 22 11:02:02 2018
@@ -1831,7 +1831,7 @@ const svn_opt_subcommand_desc2_t svn_cl_
  "\n"
  "  To bring back a shelved change, use 'svn unshelve NAME'.\n"
  "\n"
- "  A shelved change is stored as a patch file, .svn/shelves/NAME.patch\n"
+ "  Shelved changes are stored in /.svn/shelves/\n"
  "\n"
  "  The shelving feature is EXPERIMENTAL. This command is likely to 
change\n"
  "  in the next release, and there is no promise of backward 
compatibility.\n"