svn commit: r1169837 - /subversion/trunk/subversion/libsvn_delta/compat.c

2011-09-12 Thread hwright
Author: hwright Date: Mon Sep 12 17:27:28 2011 New Revision: 1169837 URL: http://svn.apache.org/viewvc?rev=1169837view=rev Log: A couple of minor improvements to the Ev2-delta editor shim. * subversion/libsvn_delta/compat.c (complete_cb): Use svn_error_trace(). (abort_cb): Pass through to

Re: svn commit: r1169837 - /subversion/trunk/subversion/libsvn_delta/compat.c

2011-09-12 Thread Daniel Shahaf
hwri...@apache.org wrote on Mon, Sep 12, 2011 at 17:27:29 -: Author: hwright Date: Mon Sep 12 17:27:28 2011 New Revision: 1169837 URL: http://svn.apache.org/viewvc?rev=1169837view=rev Log: A couple of minor improvements to the Ev2-delta editor shim. *

Re: svn commit: r1169837 - /subversion/trunk/subversion/libsvn_delta/compat.c

2011-09-12 Thread Hyrum K Wright
On Mon, Sep 12, 2011 at 12:35 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: hwri...@apache.org wrote on Mon, Sep 12, 2011 at 17:27:29 -: Author: hwright Date: Mon Sep 12 17:27:28 2011 New Revision: 1169837 URL: http://svn.apache.org/viewvc?rev=1169837view=rev Log: A couple of minor

Re: svn commit: r1169837 - /subversion/trunk/subversion/libsvn_delta/compat.c

2011-09-12 Thread Daniel Shahaf
Look. You're just wrong. SVN_ERR() always implies svn_error_trace() regardless of SVN_ERR__TRACING, and there is no additional branch here in an optimized build (and last time you were introducing those changes someone demonstrated this via disassembly excerpts). So, if you want to reduce on