Safely remove unused API method
Project: http://git-wip-us.apache.org/repos/asf/syncope/repo Commit: http://git-wip-us.apache.org/repos/asf/syncope/commit/299db471 Tree: http://git-wip-us.apache.org/repos/asf/syncope/tree/299db471 Diff: http://git-wip-us.apache.org/repos/asf/syncope/diff/299db471 Branch: refs/heads/master Commit: 299db471b024ad54cadade8ce1db0a01b7d46dc3 Parents: cb6f0cf Author: Francesco Chicchiriccò <ilgro...@apache.org> Authored: Wed Sep 6 14:29:42 2017 +0200 Committer: Francesco Chicchiriccò <ilgro...@apache.org> Committed: Wed Sep 6 17:50:39 2017 +0200 ---------------------------------------------------------------------- .../syncope/core/persistence/api/dao/AnySearchDAO.java | 8 -------- .../core/persistence/jpa/dao/AbstractAnySearchDAO.java | 10 ---------- 2 files changed, 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/syncope/blob/299db471/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AnySearchDAO.java ---------------------------------------------------------------------- diff --git a/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AnySearchDAO.java b/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AnySearchDAO.java index fe5b572..18508ac 100644 --- a/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AnySearchDAO.java +++ b/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AnySearchDAO.java @@ -36,14 +36,6 @@ public interface AnySearchDAO extends DAO<Any<?>> { int count(Set<String> adminRealms, SearchCond searchCondition, AnyTypeKind kind); /** - * @param realmFullPath for use with {@link org.apache.syncope.core.persistence.api.dao.search.AssignableCond} - * @param kind any object - * @param <T> any - * @return the list of any objects matching the given search condition - */ - <T extends Any<?>> List<T> searchAssignable(String realmFullPath, AnyTypeKind kind); - - /** * @param searchCondition the search condition * @param kind any object * @param <T> any http://git-wip-us.apache.org/repos/asf/syncope/blob/299db471/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractAnySearchDAO.java ---------------------------------------------------------------------- diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractAnySearchDAO.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractAnySearchDAO.java index f20a765..6faeeab 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractAnySearchDAO.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractAnySearchDAO.java @@ -63,8 +63,6 @@ import org.apache.syncope.core.persistence.api.entity.anyobject.AnyObject; import org.apache.syncope.core.persistence.api.entity.group.Group; import org.apache.syncope.core.persistence.jpa.entity.JPAPlainSchema; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.transaction.annotation.Propagation; -import org.springframework.transaction.annotation.Transactional; import org.springframework.util.ReflectionUtils; public abstract class AbstractAnySearchDAO extends AbstractDAO<Any<?>> implements AnySearchDAO { @@ -90,14 +88,6 @@ public abstract class AbstractAnySearchDAO extends AbstractDAO<Any<?>> implement @Autowired protected AnyUtilsFactory anyUtilsFactory; - @Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = true) - @Override - public <T extends Any<?>> List<T> searchAssignable(final String realmFullPath, final AnyTypeKind kind) { - AssignableCond assignableCond = new AssignableCond(); - assignableCond.setRealmFullPath(realmFullPath); - return search(SearchCond.getLeafCond(assignableCond), kind); - } - protected SearchCond buildEffectiveCond(final SearchCond cond, final Set<String> dynRealmKeys) { List<SearchCond> effectiveConds = dynRealmKeys.stream().map(dynRealmKey -> { DynRealmCond dynRealmCond = new DynRealmCond();
