[jira] Created: (TAP5-1082) Integrate existing list: binding sample code
Integrate existing list: binding sample code Key: TAP5-1082 URL: https://issues.apache.org/jira/browse/TAP5-1082 Project: Tapestry 5 Issue Type: Improvement Affects Versions: 5.2.0 Reporter: Pierce Wetter http://wiki.apache.org/tapestry/Tapestry5HowToAddBindingPrefix list: is very useful. Seems like an obvious thing for inclusion. For the general purpose case of building complex structures, yaml: would be possible, let me know if you want a sample implementation. Pierce -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r927985 - in /tapestry/tapestry5/trunk: tapestry-hibernate-core/src/main/java/org/apache/tapestry5/internal/hibernate/ tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibern
Author: hlship Date: Fri Mar 26 17:44:14 2010 New Revision: 927985 URL: http://svn.apache.org/viewvc?rev=927985view=rev Log: TAP5-1079: Fix some package access problems for reloadable services (which were breaking the test suite) Modified: tapestry/tapestry5/trunk/tapestry-hibernate-core/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateCoreMessages.java tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateMessages.java tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/PersistedEntity.java Modified: tapestry/tapestry5/trunk/tapestry-hibernate-core/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateCoreMessages.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-hibernate-core/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateCoreMessages.java?rev=927985r1=927984r2=927985view=diff == --- tapestry/tapestry5/trunk/tapestry-hibernate-core/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateCoreMessages.java (original) +++ tapestry/tapestry5/trunk/tapestry-hibernate-core/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateCoreMessages.java Fri Mar 26 17:44:14 2010 @@ -1,10 +1,10 @@ -// Copyright 2008 The Apache Software Foundation +// Copyright 2008, 2010 The Apache Software Foundation // // Licensed under the Apache License, Version 2.0 (the License); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // -// http://www.apache.org/licenses/LICENSE-2.0 +// http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an AS IS BASIS, @@ -24,17 +24,17 @@ public class HibernateCoreMessages { private static final Messages MESSAGES = MessagesImpl.forClass(HibernateCoreMessages.class); -static String configurationImmutable() +public static String configurationImmutable() { return MESSAGES.get(configuration-immutable); } -static String startupTiming(long toConfigure, long overall) +public static String startupTiming(long toConfigure, long overall) { return MESSAGES.format(startup-timing, toConfigure, overall); } -static String entityCatalog(Collection entityNames) +public static String entityCatalog(Collection entityNames) { return MESSAGES.format(entity-catalog, InternalUtils.joinSorted(entityNames)); } Modified: tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateMessages.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateMessages.java?rev=927985r1=927984r2=927985view=diff == --- tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateMessages.java (original) +++ tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/HibernateMessages.java Fri Mar 26 17:44:14 2010 @@ -1,4 +1,4 @@ -// Copyright 2007, 2008 The Apache Software Foundation +// Copyright 2007, 2008, 2010 The Apache Software Foundation // // Licensed under the Apache License, Version 2.0 (the License); // you may not use this file except in compliance with the License. @@ -17,21 +17,21 @@ package org.apache.tapestry5.internal.hi import org.apache.tapestry5.ioc.Messages; import org.apache.tapestry5.ioc.internal.util.MessagesImpl; -class HibernateMessages +public class HibernateMessages { private static final Messages MESSAGES = MessagesImpl.forClass(HibernateMessages.class); -static String sessionPersistedEntityLoadFailure(String entityName, Object id, Throwable cause) +public static String sessionPersistedEntityLoadFailure(String entityName, Object id, Throwable cause) { return MESSAGES.format(session-persisted-entity-load-failure, entityName, id, cause); } -static String entityNotAttached(Object entity) +public static String entityNotAttached(Object entity) { return MESSAGES.format(entity-not-attached, entity); } -static String commitTransactionInterceptor(String serviceId, Class serviceInterface) +public static String commitTransactionInterceptor(String serviceId, Class serviceInterface) { return MESSAGES.format(commit-transaction-interceptor, serviceId, serviceInterface.getName()); } Modified: tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/internal/hibernate/PersistedEntity.java URL:
[jira] Closed: (TAP5-1082) Integrate existing list: binding sample code
[ https://issues.apache.org/jira/browse/TAP5-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo closed TAP5-1082. --- Resolution: Invalid The prop binding already supports lists: [property1, methodCall()]. See http://tapestry.apache.org/tapestry5.1/guide/propexp.html. Please post suggestions in the mailing list before posting them here. ;) Integrate existing list: binding sample code Key: TAP5-1082 URL: https://issues.apache.org/jira/browse/TAP5-1082 Project: Tapestry 5 Issue Type: Improvement Affects Versions: 5.2.0 Reporter: Pierce Wetter http://wiki.apache.org/tapestry/Tapestry5HowToAddBindingPrefix list: is very useful. Seems like an obvious thing for inclusion. For the general purpose case of building complex structures, yaml: would be possible, let me know if you want a sample implementation. Pierce -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-1083) When using a radio button as a trigger on a form fragment, the button no longer selects (because the DOM click event is aborted)
When using a radio button as a trigger on a form fragment, the button no longer selects (because the DOM click event is aborted) Key: TAP5-1083 URL: https://issues.apache.org/jira/browse/TAP5-1083 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.2.0 Reporter: Howard M. Lewis Ship I believe this is an unwanted side-effect. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r928041 - in /tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test: Jetty7Runner.java SeleniumLauncher.java
Author: uli Date: Fri Mar 26 20:19:23 2010 New Revision: 928041 URL: http://svn.apache.org/viewvc?rev=928041view=rev Log: fix some mistakes. Modified: tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/Jetty7Runner.java tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumLauncher.java Modified: tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/Jetty7Runner.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/Jetty7Runner.java?rev=928041r1=928040r2=928041view=diff == --- tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/Jetty7Runner.java (original) +++ tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/Jetty7Runner.java Fri Mar 26 20:19:23 2010 @@ -50,20 +50,22 @@ public class Jetty7Runner webapp.setWar(expandedPath); // SSL support - -SslSelectChannelConnector sslConnector = new SslSelectChannelConnector(); - -sslConnector.setPort(sslPort); - File keystoreFile = new File(TapestryTestConstants.MODULE_BASE_DIR, src/test/conf/keystore); - -sslConnector.setKeystore(keystoreFile.getPath()); - -sslConnector.setPassword(tapestry); - -sslConnector.setKeyPassword(tapestry); - -jettyServer.addConnector(sslConnector); + +if (keystoreFile.exists()) +{ +SslSelectChannelConnector sslConnector = new SslSelectChannelConnector(); + +sslConnector.setPort(sslPort); + +sslConnector.setKeystore(keystoreFile.getPath()); + +sslConnector.setPassword(tapestry); + +sslConnector.setKeyPassword(tapestry); + +jettyServer.addConnector(sslConnector); +} jettyServer.setHandler(webapp); Modified: tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumLauncher.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumLauncher.java?rev=928041r1=928040r2=928041view=diff == --- tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumLauncher.java (original) +++ tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumLauncher.java Fri Mar 26 20:19:23 2010 @@ -177,7 +177,8 @@ public class SeleniumLauncher File ffProfileTemplate = new File(TapestryTestConstants.MODULE_BASE_DIR, src/test/conf/ff_profile_template); - seleniumServer.getConfiguration().setFirefoxProfileTemplate(ffProfileTemplate); +if(ffProfileTemplate.isDirectory()) + seleniumServer.getConfiguration().setFirefoxProfileTemplate(ffProfileTemplate); seleniumServer.start();
[jira] Assigned: (TAP5-940) Zone should fire a heart beat event
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-940: - Assignee: Howard M. Lewis Ship Zone should fire a heart beat event --- Key: TAP5-940 URL: https://issues.apache.org/jira/browse/TAP5-940 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: mindhawk Assignee: Howard M. Lewis Ship Priority: Minor If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-688) Show information while zone is updated
[ https://issues.apache.org/jira/browse/TAP5-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-688. - Resolution: Duplicate Assignee: Howard M. Lewis Ship This overlaps TAP-682 which will incude new events for this purpose. Show information while zone is updated -- Key: TAP5-688 URL: https://issues.apache.org/jira/browse/TAP5-688 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.1.0.5 Reporter: Martin Lauenroth Assignee: Howard M. Lewis Ship If the zone update request takes a while the user gets no feedback and so he clicks again and again -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-521) Support for adding parameters to event links with javascript
[ https://issues.apache.org/jira/browse/TAP5-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-521. - Resolution: Invalid Assignee: Howard M. Lewis Ship Starting in 5.2.0, there's new client-side options for Zones to send arbitrary parameters as part of the request, and a @QueryParameter annotation that can be used on the server side to get that same information. Support for adding parameters to event links with javascript Key: TAP5-521 URL: https://issues.apache.org/jira/browse/TAP5-521 Project: Tapestry 5 Issue Type: New Feature Components: tapestry-core Affects Versions: 5.0.18 Reporter: Inge Solvoll Assignee: Howard M. Lewis Ship Priority: Minor A Tapestry.js hook into the parameters of event and action links would be very useful in order to create more powerful client side controls. As of now, I'm using a function created by equanda that performs string transformations on a generated link. It works, but it would be so much cleaner and safer with a built-in function looking something like this: Tapestry.addEventLinkContextValue(link, value) { link = link + '/' + value; } This is of course a simplified example that probably wouldn't work... :) Here are some use cases to make it clearer why I want this feature: 1. A dropdown that updates a zone through its onchange event, pushing the selected value into the context of the trigger link. 2. A textfield that works like an autocompleter on a connected zone. Same pattern, the entered text is pushed into the context of the trigger link. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-1084) Zones that initially render inside a Form should support updates within the Form
Zones that initially render inside a Form should support updates within the Form Key: TAP5-1084 URL: https://issues.apache.org/jira/browse/TAP5-1084 Project: Tapestry 5 Issue Type: New Feature Components: tapestry-core Affects Versions: 5.2, 5.1 Reporter: Howard M. Lewis Ship This kind of mechanism is already present for FormInjector and AjaxFormLoop; it's just a matter of making it global for all Zones automatically. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1030) RegistryImpl.autobuild() does not inject resources into constructor parameters
[ https://issues.apache.org/jira/browse/TAP5-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-1030: -- Assignee: Howard M. Lewis Ship RegistryImpl.autobuild() does not inject resources into constructor parameters -- Key: TAP5-1030 URL: https://issues.apache.org/jira/browse/TAP5-1030 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Leonard Lu Assignee: Howard M. Lewis Ship The Javadoc for ObjectLocator.autobuild() states that it Autobuilds a class by finding the public constructor with the most parameters. Services and resources will be injected into the parameters of the constructor. However, this seems to only be true for the ServiceResourcesImpl implementation of the interface, which is aware of the following resources (code from 5.1.0.5, AbstractServiceCreator, line 63): injectionResources.put(String.class, serviceId); injectionResources.put(ObjectLocator.class, resources); injectionResources.put(ServiceResources.class, resources); injectionResources.put(Logger.class, logger); injectionResources.put(Class.class, resources.getServiceInterface()); injectionResources.put(OperationTracker.class, resources.getTracker()); On the other hand, RegistryImpl is only aware of the OperationTracker resource (RegistryImpl line 841) resourcesMap.put(OperationTracker.class, tracker); Specifically, one cannot call registry.autobuild() on any class that has a Logger resource in its constructor. If this is the intended behavior than the ObjectLocator javadoc should be updated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1030) Injecting a Logger into a non-service object, created as part of constructing a service configuration, should work but doesn't
[ https://issues.apache.org/jira/browse/TAP5-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1030: --- Summary: Injecting a Logger into a non-service object, created as part of constructing a service configuration, should work but doesn't (was: RegistryImpl.autobuild() does not inject resources into constructor parameters) Did a little digging and found out that java.util.logging.Logger, not org.slf4j.Logger, was being set up for injection! Injecting a Logger into a non-service object, created as part of constructing a service configuration, should work but doesn't -- Key: TAP5-1030 URL: https://issues.apache.org/jira/browse/TAP5-1030 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Leonard Lu Assignee: Howard M. Lewis Ship The Javadoc for ObjectLocator.autobuild() states that it Autobuilds a class by finding the public constructor with the most parameters. Services and resources will be injected into the parameters of the constructor. However, this seems to only be true for the ServiceResourcesImpl implementation of the interface, which is aware of the following resources (code from 5.1.0.5, AbstractServiceCreator, line 63): injectionResources.put(String.class, serviceId); injectionResources.put(ObjectLocator.class, resources); injectionResources.put(ServiceResources.class, resources); injectionResources.put(Logger.class, logger); injectionResources.put(Class.class, resources.getServiceInterface()); injectionResources.put(OperationTracker.class, resources.getTracker()); On the other hand, RegistryImpl is only aware of the OperationTracker resource (RegistryImpl line 841) resourcesMap.put(OperationTracker.class, tracker); Specifically, one cannot call registry.autobuild() on any class that has a Logger resource in its constructor. If this is the intended behavior than the ObjectLocator javadoc should be updated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r928116 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/internal/services/ajax/ main/java/org/apache/tapestry5/internal/services/javascript/ main/java/org/
Author: hlship Date: Sat Mar 27 01:24:11 2010 New Revision: 928116 URL: http://svn.apache.org/viewvc?rev=928116view=rev Log: TAP5-940: Refactor internal.services.javascript to internal.services.ajax Added: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/JavascriptSupportImpl.java (contents, props changed) - copied, changed from r928115, tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavascriptSupportImpl.java tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ajax/ tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ajax/JavaScriptSupportImplTest.java (contents, props changed) - copied, changed from r928115, tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/javascript/JavaScriptSupportImplTest.java Removed: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavascriptSupportImpl.java tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/javascript/JavaScriptSupportImplTest.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java tapestry/tapestry5/trunk/tapestry-core/src/test/conf/testng.xml Copied: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/JavascriptSupportImpl.java (from r928115, tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavascriptSupportImpl.java) URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/JavascriptSupportImpl.java?p2=tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/JavascriptSupportImpl.javap1=tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavascriptSupportImpl.javar1=928115r2=928116rev=928116view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/JavascriptSupportImpl.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/JavascriptSupportImpl.java Sat Mar 27 01:24:11 2010 @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package org.apache.tapestry5.internal.services.javascript; +package org.apache.tapestry5.internal.services.ajax; import java.util.Map; Propchange: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/JavascriptSupportImpl.java -- svn:eol-style = native Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=928116r1=928115r2=928116view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Sat Mar 27 01:24:11 2010 @@ -73,7 +73,7 @@ import org.apache.tapestry5.internal.ren import org.apache.tapestry5.internal.renderers.ObjectArrayRenderer; import org.apache.tapestry5.internal.renderers.RequestRenderer; import org.apache.tapestry5.internal.services.*; -import org.apache.tapestry5.internal.services.javascript.JavascriptSupportImpl; +import org.apache.tapestry5.internal.services.ajax.JavascriptSupportImpl; import org.apache.tapestry5.internal.services.messages.PropertiesFileParserImpl; import org.apache.tapestry5.internal.transform.*; import org.apache.tapestry5.internal.translator.NumericTranslator; Modified: tapestry/tapestry5/trunk/tapestry-core/src/test/conf/testng.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/conf/testng.xml?rev=928116r1=928115r2=928116view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/test/conf/testng.xml (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/test/conf/testng.xml Sat Mar 27 01:24:11 2010 @@ -45,7 +45,7 @@ package name=org.apache.tapestry5.internal.transform/ package
svn commit: r928115 - in /tapestry/tapestry5/trunk/tapestry-ioc/src: main/java/org/apache/tapestry5/ioc/ main/java/org/apache/tapestry5/ioc/internal/ test/java/org/apache/tapestry5/ioc/
Author: hlship Date: Sat Mar 27 01:24:07 2010 New Revision: 928115 URL: http://svn.apache.org/viewvc?rev=928115view=rev Log: TAP5-1050: Injecting a Logger into a non-service object, created as part of constructing a service configuration, should work but doesn't Added: tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/IndirectResources.java (with props) tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/InjectionCheck.java (with props) tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/InjectionCheckImpl.java (with props) tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/InjectionCheckModule.java (with props) Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/AbstractServiceCreator.java tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ContributionDefImpl.java tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/IntegrationTest.java Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java?rev=928115r1=928114r2=928115view=diff == --- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java (original) +++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/ObjectLocator.java Sat Mar 27 01:24:07 2010 @@ -83,9 +83,12 @@ public interface ObjectLocator T T getObject(ClassT objectType, AnnotationProvider annotationProvider); /** - * Autobuilds a class by finding the public constructor with the most parameters. Services and - * resources will be - * injected into the parameters of the constructor and private field marked with the {...@link Inject} annotation. + * Autobuilds a class by finding the public constructor with the most parameters. Services and other resources or + * dependencies will be injected into the parameters of the constructor and private field marked with the + * {...@link Inject} annotation. There are two cases: constructing a service implementation, and constructing + * an arbitrary object. In the former case, many emservice resources/em are also available for injection, not + * just dependencies or objects provided via + * {...@link MasterObjectProvider#provide(Class, AnnotationProvider, ObjectLocator, boolean)}. * * @param T * @param clazz @@ -98,10 +101,8 @@ public interface ObjectLocator T T autobuild(ClassT clazz); /** - * Autobuilds a class by finding the public constructor with the most parameters. Services and - * resources will be - * injected into the parameters of the constructor and private field marked with the {...@link Inject} annotation. This - * version tracks the operation using {...@link OperationTracker#invoke(String, Invokable)}. + * Preferred version of {...@link #autobuild(Class)} that tracks the operation using + * {...@link OperationTracker#invoke(String, Invokable)}. * * @param T * @param description @@ -133,6 +134,7 @@ public interface ObjectLocator * @param implementationClass *a concrete class that implements the interface * @return a proxy + * @see #autobuild(Class) */ T T proxy(ClassT interfaceClass, Class? extends T implementationClass); } Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/AbstractServiceCreator.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/AbstractServiceCreator.java?rev=928115r1=928114r2=928115view=diff == --- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/AbstractServiceCreator.java (original) +++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/AbstractServiceCreator.java Sat Mar 27 01:24:07 2010 @@ -69,7 +69,7 @@ public abstract class AbstractServiceCre } /** - * Returns a map (based on parameterDefaults) that includes (possibly) an additional mapping containing the + * Returns a map (based on injectionResources) that includes (possibly) an additional mapping containing the * collected configuration data. This involves scanning the parameters and generic types. */ protected final InjectionResources createInjectionResources() @@ -115,9 +115,11 @@ public abstract class
svn commit: r928118 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
Author: hlship Date: Sat Mar 27 01:24:17 2010 New Revision: 928118 URL: http://svn.apache.org/viewvc?rev=928118view=rev Log: TAP5-940: Expose Environmental Hearthbeat as an injectable service Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=928118r1=928117r2=928118view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Sat Mar 27 01:24:17 2010 @@ -85,7 +85,6 @@ import org.apache.tapestry5.internal.uti import org.apache.tapestry5.internal.validator.ValidatorMacroImpl; import org.apache.tapestry5.ioc.*; import org.apache.tapestry5.ioc.annotations.*; -import org.apache.tapestry5.ioc.internal.services.UpdateListenerHubImpl; import org.apache.tapestry5.ioc.internal.util.CollectionFactory; import org.apache.tapestry5.ioc.internal.util.IdAllocator; import org.apache.tapestry5.ioc.services.*; @@ -2862,4 +2861,13 @@ public final class TapestryModule } } +/** + * Exposes the Environmental {...@link Heartbeat} as an injective service. + * + * @since 5.2.0 + */ +public Heartbeat buildHeartbeat() +{ +return environmentalBuilder.build(Heartbeat.class); +} }
[jira] Created: (TAP5-1085) The ExceptionReporter should be configured to mark more of the Tapestry generated classes (used for method field access and method advice) as hidden by default
The ExceptionReporter should be configured to mark more of the Tapestry generated classes (used for method field access and method advice) as hidden by default - Key: TAP5-1085 URL: https://issues.apache.org/jira/browse/TAP5-1085 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.0 Reporter: Howard M. Lewis Ship Priority: Minor The point of the hidden is to make it appear as if only the user's classes exist, not all the proxies and other intermediaries. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-940) Zone should fire a heart beat event
[ https://issues.apache.org/jira/browse/TAP5-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-940. - Resolution: Fixed Fix Version/s: 5.2.0 There was already a Heartbeat in place for the partial page render Zone should fire a heart beat event --- Key: TAP5-940 URL: https://issues.apache.org/jira/browse/TAP5-940 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: mindhawk Assignee: Howard M. Lewis Ship Priority: Minor Fix For: 5.2.0 If there is not a component in Zone fire a heart beat event, the forced attributes would not return to the client, although the page would fire this event at the end. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1030) Injecting a Logger into a non-service object, created as part of constructing a service configuration, should work but doesn't
[ https://issues.apache.org/jira/browse/TAP5-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1030. -- Resolution: Fixed Fix Version/s: 5.2.0 Oops, I think some of the commits listed TAP5-1050! Injecting a Logger into a non-service object, created as part of constructing a service configuration, should work but doesn't -- Key: TAP5-1030 URL: https://issues.apache.org/jira/browse/TAP5-1030 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Leonard Lu Assignee: Howard M. Lewis Ship Fix For: 5.2.0 The Javadoc for ObjectLocator.autobuild() states that it Autobuilds a class by finding the public constructor with the most parameters. Services and resources will be injected into the parameters of the constructor. However, this seems to only be true for the ServiceResourcesImpl implementation of the interface, which is aware of the following resources (code from 5.1.0.5, AbstractServiceCreator, line 63): injectionResources.put(String.class, serviceId); injectionResources.put(ObjectLocator.class, resources); injectionResources.put(ServiceResources.class, resources); injectionResources.put(Logger.class, logger); injectionResources.put(Class.class, resources.getServiceInterface()); injectionResources.put(OperationTracker.class, resources.getTracker()); On the other hand, RegistryImpl is only aware of the OperationTracker resource (RegistryImpl line 841) resourcesMap.put(OperationTracker.class, tracker); Specifically, one cannot call registry.autobuild() on any class that has a Logger resource in its constructor. If this is the intended behavior than the ObjectLocator javadoc should be updated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r928122 - /tapestry/tapestry-site/trunk/pom.xml
Author: andyhot Date: Sat Mar 27 02:15:53 2010 New Revision: 928122 URL: http://svn.apache.org/viewvc?rev=928122view=rev Log: info on CI Modified: tapestry/tapestry-site/trunk/pom.xml Modified: tapestry/tapestry-site/trunk/pom.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry-site/trunk/pom.xml?rev=928122r1=928121r2=928122view=diff == --- tapestry/tapestry-site/trunk/pom.xml (original) +++ tapestry/tapestry-site/trunk/pom.xml Sat Mar 27 02:15:53 2010 @@ -38,6 +38,17 @@ urlhttp://svn.apache.org/viewvc/tapestry//url /scm +ciManagement +systemhudson/system +urlhttp://hudson.zones.apache.org/hudson/view/Tapestry//url +notifiers +notifier +typemail/type +addressd...@tapestry.apache.org/address +/notifier +/notifiers +/ciManagement + build plugins plugin