Repository: tez Updated Branches: refs/heads/master 6632903bb -> b421e4f61
TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables (sree) Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/b421e4f6 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/b421e4f6 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/b421e4f6 Branch: refs/heads/master Commit: b421e4f612a923e8e5082cea103d5c1ada7c4e2b Parents: 6632903 Author: Sreenath Somarajapuram <s...@apache.org> Authored: Thu Oct 15 18:19:53 2015 +0530 Committer: Sreenath Somarajapuram <s...@apache.org> Committed: Thu Oct 15 18:19:53 2015 +0530 ---------------------------------------------------------------------- CHANGES.txt | 2 ++ .../app/scripts/mixins/column-selector-mixin.js | 36 ++++++++++---------- 2 files changed, 20 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/b421e4f6/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 7c2f030..b833f81 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -6,6 +6,7 @@ Release 0.8.2: Unreleased INCOMPATIBLE CHANGES ALL CHANGES: + TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables TEZ-2887. Tez build failure due to missing dependency in pom files. TEZ-1692. Reduce code duplication between TezMapredSplitsGrouper and TezMapreduceSplitsGrouper. @@ -213,6 +214,7 @@ Release 0.7.1: Unreleased INCOMPATIBLE CHANGES ALL CHANGES + TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables TEZ-2885. Remove counter logs from AMWebController. TEZ-2887. Tez build failure due to missing dependency in pom files. TEZ-2096. TEZ-UI : Add link to view AM log of finished & running apps http://git-wip-us.apache.org/repos/asf/tez/blob/b421e4f6/tez-ui/src/main/webapp/app/scripts/mixins/column-selector-mixin.js ---------------------------------------------------------------------- diff --git a/tez-ui/src/main/webapp/app/scripts/mixins/column-selector-mixin.js b/tez-ui/src/main/webapp/app/scripts/mixins/column-selector-mixin.js index 22e131d..34f2731 100644 --- a/tez-ui/src/main/webapp/app/scripts/mixins/column-selector-mixin.js +++ b/tez-ui/src/main/webapp/app/scripts/mixins/column-selector-mixin.js @@ -51,13 +51,13 @@ App.ColumnSelectorMixin = Em.Mixin.create({ visibleColumnIds = JSON.parse(localStorage.getItem(this._storeKey)); }catch(e){} - if(!visibleColumnIds) { - visibleColumnIds = {}; + visibleColumnIds = visibleColumnIds || {}; - this.get('defaultColumnConfigs').forEach(function (config) { + this.get('defaultColumnConfigs').forEach(function (config) { + if(visibleColumnIds[config.id] != false) { visibleColumnIds[config.id] = true; - }); - } + } + }); this._super(); this.set('visibleColumnIds', visibleColumnIds); @@ -122,19 +122,19 @@ App.ColumnSelectorMixin = Em.Mixin.create({ }, selectionChange: function () { - var visibleColumnIds = this.get('selectOptions').reduce(function (obj, option) { - if(option.get('selected')) { - obj[option.get('id')] = true; - } - return obj; - }, {}), - selectionToSave = this.get('selectOptions').reduce(function (obj, option) { - var id = option.id; - if(!id.match('_INPUT_') && !id.match('_OUTPUT_') && visibleColumnIds[id]) { - obj[id] = true; - } - return obj; - }, {}); + var visibleColumnIds = {}, + selectionToSave = {}; + + this.get('selectOptions').forEach(function (option) { + var isSelected = option.get('selected'), + id = option.get('id'), + groupName = id.split('/')[0]; + + visibleColumnIds[id] = isSelected; + if(!groupName.match('_INPUT_') && !groupName.match('_OUTPUT_')) { + selectionToSave[id] = isSelected; + } + }); if(isObjectsDifferent(visibleColumnIds, this.get('visibleColumnIds'))) { try {
