Repository: thrift Updated Branches: refs/heads/master bf9b6970b -> 847fae938
THRIFT-3959: document that the go simple server is not simple Client: go Patch: JodeZer <jeffery1...@hotmail.com> This closes #1213 Project: http://git-wip-us.apache.org/repos/asf/thrift/repo Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/847fae93 Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/847fae93 Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/847fae93 Branch: refs/heads/master Commit: 847fae9388048aa9e09d5ed042e34f5452638248 Parents: bf9b697 Author: James E. King, III <jk...@apache.org> Authored: Wed Mar 22 15:17:30 2017 -0400 Committer: James E. King, III <jk...@apache.org> Committed: Wed Mar 22 15:17:30 2017 -0400 ---------------------------------------------------------------------- lib/go/thrift/simple_server.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/thrift/blob/847fae93/lib/go/thrift/simple_server.go ---------------------------------------------------------------------- diff --git a/lib/go/thrift/simple_server.go b/lib/go/thrift/simple_server.go index 4097c4a..5d05c5b 100644 --- a/lib/go/thrift/simple_server.go +++ b/lib/go/thrift/simple_server.go @@ -25,7 +25,11 @@ import ( "sync" ) -// Simple, non-concurrent server for testing. +/* + * This is not a typical TSimpleServer as it is not blocked after accept a socket. + * It is more like a TThreadedServer that can handle different connections in different goroutines. + * This will work if golang user implements a conn-pool like thing in client side. + */ type TSimpleServer struct { quit chan struct{}