[GitHub] [tinkerpop] humbleengineer commented on pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

humbleengineer commented on pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293#issuecomment-642154171 > Do you mind squashing the "TINKERPOP-2264" to one commit and all your "docker" related ones to another? > > Other than that, this looks good - VOTE +1 Do

[GitHub] [tinkerpop] spmallette commented on pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

spmallette commented on pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293#issuecomment-642110333 Do you mind squashing the "TINKERPOP-2264" to one commit and all your "docker" related ones to another? Other than that, this looks good - VOTE +1

[GitHub] [tinkerpop] jorgebay opened a new pull request #1294: TINKERPOP-2377 .NET GLV: Check for null earlier

jorgebay opened a new pull request #1294: URL: https://github.com/apache/tinkerpop/pull/1294 https://issues.apache.org/jira/browse/TINKERPOP-2377 I think this addresses the issue. This is an automated message from the

[tinkerpop] 01/01: TINKERPOP-2377 .NET GLV: Check for null earlier

This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a commit to branch TINKERPOP-2377 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit c7a552739f12102a32689e6828b215871d29f010 Author: Jorge Bay Gondra AuthorDate: Wed Jun 10 15:49:19 2020 +0200

[tinkerpop] branch TINKERPOP-2377 created (now c7a5527)

This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a change to branch TINKERPOP-2377 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at c7a5527 TINKERPOP-2377 .NET GLV: Check for null earlier This branch includes the following new commits:

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

spmallette commented on a change in pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293#discussion_r438109277 ## File path: docker/gremlin-server.sh ## @@ -57,7 +57,7 @@ echo "Using Gremlin Server $GREMLIN_SERVER_VERSION" sed -e "s/GREMLIN_SERVER_VERSION\$/$

[GitHub] [tinkerpop] humbleengineer commented on a change in pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

humbleengineer commented on a change in pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293#discussion_r438074087 ## File path: docker/gremlin-server.sh ## @@ -57,7 +57,7 @@ echo "Using Gremlin Server $GREMLIN_SERVER_VERSION" sed -e "s/GREMLIN_SERVER_VERSION

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

spmallette commented on a change in pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293#discussion_r438046045 ## File path: docker/gremlin-server.sh ## @@ -57,7 +57,7 @@ echo "Using Gremlin Server $GREMLIN_SERVER_VERSION" sed -e "s/GREMLIN_SERVER_VERSION\$/$

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

spmallette commented on a change in pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293#discussion_r438045632 ## File path: gremlin-python/pom.xml ## @@ -311,7 +311,7 @@ limitations under the License.

[GitHub] [tinkerpop] humbleengineer opened a new pull request #1293: TINKERPOP-2264 update gremlin-python tests to be timezone/system-independent, related minor Docker changes

humbleengineer opened a new pull request #1293: URL: https://github.com/apache/tinkerpop/pull/1293 The datetime conversion tests didn't pass when running on a Mac in London, so they've been updated to use `calendar.timegm` just like the code under test was in the [original PR for TINKERPO